vrr/open5gs
2
0
Fork 0
mirror of https://github.com/open5gs/open5gs.git synced 2026-05-04 06:10:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[SBI] crash when enum is unknown (#2622)

Browse source 
j
The crash is caused by ogs_assert(data) in listEntry_create(void *data).
Reason for the failing assertion is that in

OpenAPI_subscription_data_t *OpenAPI_subscription_data_parseFromJSON(
        cJSON *subscription_dataJSON)

in line 501 of file subscription_data.c the event string is transformed
into an integer/enum value, which in case of an unknown event is 0.

Steps to reproduce:

1. Deploy NRF
2. Run curl --http2-prior-knowledge --header "Content-Type: application/json" --data '{"nfStatusNotificationUri": "test@example.com", "reqNotifEvents": ["unknown"], "subscriptionId": "12345"}' "http://<NRF_IP>:<NRF_PORT>/nnrf-nfm/v1/subscriptions"
This commit is contained in:
Sukchan Lee 2023-09-24 09:54:53 +09:00
parent 317d9bf846
commit 0abfb204ea
72 changed files with 854 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

16
lib/sbi/openapi/model/qos_monitoring_data.c
View file

@ -231,11 +231,17 @@ OpenAPI_qos_monitoring_data_t *OpenAPI_qos_monitoring_data_parseFromJSON(cJSON *
req_qos_mon_paramsList = OpenAPI_list_create();
cJSON_ArrayForEach(req_qos_mon_params_local, req_qos_mon_params) {
OpenAPI_requested_qos_monitoring_parameter_e localEnum = OpenAPI_requested_qos_monitoring_parameter_NULL;
if (!cJSON_IsString(req_qos_mon_params_local)) {
ogs_error("OpenAPI_qos_monitoring_data_parseFromJSON() failed [req_qos_mon_params]");
goto end;
}
OpenAPI_list_add(req_qos_mon_paramsList, (void *)OpenAPI_requested_qos_monitoring_parameter_FromString(req_qos_mon_params_local->valuestring));
localEnum = OpenAPI_requested_qos_monitoring_parameter_FromString(req_qos_mon_params_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_requested_qos_monitoring_parameter_FromString(req_qos_mon_params_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(req_qos_mon_paramsList, (void *)localEnum);
}
rep_freqs = cJSON_GetObjectItemCaseSensitive(qos_monitoring_dataJSON, "repFreqs");
@ -252,11 +258,17 @@ OpenAPI_qos_monitoring_data_t *OpenAPI_qos_monitoring_data_parseFromJSON(cJSON *
rep_freqsList = OpenAPI_list_create();
cJSON_ArrayForEach(rep_freqs_local, rep_freqs) {
OpenAPI_reporting_frequency_e localEnum = OpenAPI_reporting_frequency_NULL;
if (!cJSON_IsString(rep_freqs_local)) {
ogs_error("OpenAPI_qos_monitoring_data_parseFromJSON() failed [rep_freqs]");
goto end;
}
OpenAPI_list_add(rep_freqsList, (void *)OpenAPI_reporting_frequency_FromString(rep_freqs_local->valuestring));
localEnum = OpenAPI_reporting_frequency_FromString(rep_freqs_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_reporting_frequency_FromString(rep_freqs_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(rep_freqsList, (void *)localEnum);
}
rep_thresh_dl = cJSON_GetObjectItemCaseSensitive(qos_monitoring_dataJSON, "repThreshDl");