vrr/open5gs
2
0
Fork 0
mirror of https://github.com/open5gs/open5gs.git synced 2026-05-04 06:10:11 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

[SBI] crash when enum is unknown (#2622)

Browse source 
j
The crash is caused by ogs_assert(data) in listEntry_create(void *data).
Reason for the failing assertion is that in

OpenAPI_subscription_data_t *OpenAPI_subscription_data_parseFromJSON(
        cJSON *subscription_dataJSON)

in line 501 of file subscription_data.c the event string is transformed
into an integer/enum value, which in case of an unknown event is 0.

Steps to reproduce:

1. Deploy NRF
2. Run curl --http2-prior-knowledge --header "Content-Type: application/json" --data '{"nfStatusNotificationUri": "test@example.com", "reqNotifEvents": ["unknown"], "subscriptionId": "12345"}' "http://<NRF_IP>:<NRF_PORT>/nnrf-nfm/v1/subscriptions"
This commit is contained in:
Sukchan Lee 2023-09-24 09:54:53 +09:00
parent 317d9bf846
commit 0abfb204ea
72 changed files with 854 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

40
lib/sbi/openapi/model/immediate_mdt_conf.c
View file

@ -361,11 +361,17 @@ OpenAPI_immediate_mdt_conf_t *OpenAPI_immediate_mdt_conf_parseFromJSON(cJSON *im
measurement_lte_listList = OpenAPI_list_create();
cJSON_ArrayForEach(measurement_lte_list_local, measurement_lte_list) {
OpenAPI_measurement_lte_for_mdt_e localEnum = OpenAPI_measurement_lte_for_mdt_NULL;
if (!cJSON_IsString(measurement_lte_list_local)) {
ogs_error("OpenAPI_immediate_mdt_conf_parseFromJSON() failed [measurement_lte_list]");
goto end;
}
OpenAPI_list_add(measurement_lte_listList, (void *)OpenAPI_measurement_lte_for_mdt_FromString(measurement_lte_list_local->valuestring));
localEnum = OpenAPI_measurement_lte_for_mdt_FromString(measurement_lte_list_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_measurement_lte_for_mdt_FromString(measurement_lte_list_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(measurement_lte_listList, (void *)localEnum);
}
}
@ -380,11 +386,17 @@ OpenAPI_immediate_mdt_conf_t *OpenAPI_immediate_mdt_conf_parseFromJSON(cJSON *im
measurement_nr_listList = OpenAPI_list_create();
cJSON_ArrayForEach(measurement_nr_list_local, measurement_nr_list) {
OpenAPI_measurement_nr_for_mdt_e localEnum = OpenAPI_measurement_nr_for_mdt_NULL;
if (!cJSON_IsString(measurement_nr_list_local)) {
ogs_error("OpenAPI_immediate_mdt_conf_parseFromJSON() failed [measurement_nr_list]");
goto end;
}
OpenAPI_list_add(measurement_nr_listList, (void *)OpenAPI_measurement_nr_for_mdt_FromString(measurement_nr_list_local->valuestring));
localEnum = OpenAPI_measurement_nr_for_mdt_FromString(measurement_nr_list_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_measurement_nr_for_mdt_FromString(measurement_nr_list_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(measurement_nr_listList, (void *)localEnum);
}
}
@ -399,11 +411,17 @@ OpenAPI_immediate_mdt_conf_t *OpenAPI_immediate_mdt_conf_parseFromJSON(cJSON *im
reporting_trigger_listList = OpenAPI_list_create();
cJSON_ArrayForEach(reporting_trigger_list_local, reporting_trigger_list) {
OpenAPI_reporting_trigger_e localEnum = OpenAPI_reporting_trigger_NULL;
if (!cJSON_IsString(reporting_trigger_list_local)) {
ogs_error("OpenAPI_immediate_mdt_conf_parseFromJSON() failed [reporting_trigger_list]");
goto end;
}
OpenAPI_list_add(reporting_trigger_listList, (void *)OpenAPI_reporting_trigger_FromString(reporting_trigger_list_local->valuestring));
localEnum = OpenAPI_reporting_trigger_FromString(reporting_trigger_list_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_reporting_trigger_FromString(reporting_trigger_list_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(reporting_trigger_listList, (void *)localEnum);
}
}
@ -522,11 +540,17 @@ OpenAPI_immediate_mdt_conf_t *OpenAPI_immediate_mdt_conf_parseFromJSON(cJSON *im
add_positioning_method_listList = OpenAPI_list_create();
cJSON_ArrayForEach(add_positioning_method_list_local, add_positioning_method_list) {
OpenAPI_positioning_method_mdt_e localEnum = OpenAPI_positioning_method_mdt_NULL;
if (!cJSON_IsString(add_positioning_method_list_local)) {
ogs_error("OpenAPI_immediate_mdt_conf_parseFromJSON() failed [add_positioning_method_list]");
goto end;
}
OpenAPI_list_add(add_positioning_method_listList, (void *)OpenAPI_positioning_method_mdt_FromString(add_positioning_method_list_local->valuestring));
localEnum = OpenAPI_positioning_method_mdt_FromString(add_positioning_method_list_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_positioning_method_mdt_FromString(add_positioning_method_list_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(add_positioning_method_listList, (void *)localEnum);
}
}
@ -565,11 +589,17 @@ OpenAPI_immediate_mdt_conf_t *OpenAPI_immediate_mdt_conf_parseFromJSON(cJSON *im
sensor_measurement_listList = OpenAPI_list_create();
cJSON_ArrayForEach(sensor_measurement_list_local, sensor_measurement_list) {
OpenAPI_sensor_measurement_e localEnum = OpenAPI_sensor_measurement_NULL;
if (!cJSON_IsString(sensor_measurement_list_local)) {
ogs_error("OpenAPI_immediate_mdt_conf_parseFromJSON() failed [sensor_measurement_list]");
goto end;
}
OpenAPI_list_add(sensor_measurement_listList, (void *)OpenAPI_sensor_measurement_FromString(sensor_measurement_list_local->valuestring));
localEnum = OpenAPI_sensor_measurement_FromString(sensor_measurement_list_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_sensor_measurement_FromString(sensor_measurement_list_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(sensor_measurement_listList, (void *)localEnum);
}
}