vrr/open5gs
2
0
Fork 0
mirror of https://github.com/open5gs/open5gs.git synced 2026-05-02 05:10:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

[SBI] crash when enum is unknown (#2622)

Browse source 
j
The crash is caused by ogs_assert(data) in listEntry_create(void *data).
Reason for the failing assertion is that in

OpenAPI_subscription_data_t *OpenAPI_subscription_data_parseFromJSON(
        cJSON *subscription_dataJSON)

in line 501 of file subscription_data.c the event string is transformed
into an integer/enum value, which in case of an unknown event is 0.

Steps to reproduce:

1. Deploy NRF
2. Run curl --http2-prior-knowledge --header "Content-Type: application/json" --data '{"nfStatusNotificationUri": "test@example.com", "reqNotifEvents": ["unknown"], "subscriptionId": "12345"}' "http://<NRF_IP>:<NRF_PORT>/nnrf-nfm/v1/subscriptions"
This commit is contained in:
Sukchan Lee 2023-09-24 09:54:53 +09:00
parent 317d9bf846
commit 0abfb204ea
72 changed files with 854 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

16
lib/sbi/openapi/model/events_subsc_req_data_rm.c
View file

@ -243,11 +243,17 @@ OpenAPI_events_subsc_req_data_rm_t *OpenAPI_events_subsc_req_data_rm_parseFromJS
req_qos_mon_paramsList = OpenAPI_list_create();
cJSON_ArrayForEach(req_qos_mon_params_local, req_qos_mon_params) {
OpenAPI_requested_qos_monitoring_parameter_e localEnum = OpenAPI_requested_qos_monitoring_parameter_NULL;
if (!cJSON_IsString(req_qos_mon_params_local)) {
ogs_error("OpenAPI_events_subsc_req_data_rm_parseFromJSON() failed [req_qos_mon_params]");
goto end;
}
OpenAPI_list_add(req_qos_mon_paramsList, (void *)OpenAPI_requested_qos_monitoring_parameter_FromString(req_qos_mon_params_local->valuestring));
localEnum = OpenAPI_requested_qos_monitoring_parameter_FromString(req_qos_mon_params_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_requested_qos_monitoring_parameter_FromString(req_qos_mon_params_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(req_qos_mon_paramsList, (void *)localEnum);
}
}
@ -271,11 +277,17 @@ OpenAPI_events_subsc_req_data_rm_t *OpenAPI_events_subsc_req_data_rm_parseFromJS
req_anisList = OpenAPI_list_create();
cJSON_ArrayForEach(req_anis_local, req_anis) {
OpenAPI_required_access_info_e localEnum = OpenAPI_required_access_info_NULL;
if (!cJSON_IsString(req_anis_local)) {
ogs_error("OpenAPI_events_subsc_req_data_rm_parseFromJSON() failed [req_anis]");
goto end;
}
OpenAPI_list_add(req_anisList, (void *)OpenAPI_required_access_info_FromString(req_anis_local->valuestring));
localEnum = OpenAPI_required_access_info_FromString(req_anis_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_required_access_info_FromString(req_anis_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(req_anisList, (void *)localEnum);
}
}