vrr/open5gs
2
0
Fork 0
mirror of https://github.com/open5gs/open5gs.git synced 2026-05-02 05:10:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

[SBI] crash when enum is unknown (#2622)

Browse source 
j
The crash is caused by ogs_assert(data) in listEntry_create(void *data).
Reason for the failing assertion is that in

OpenAPI_subscription_data_t *OpenAPI_subscription_data_parseFromJSON(
        cJSON *subscription_dataJSON)

in line 501 of file subscription_data.c the event string is transformed
into an integer/enum value, which in case of an unknown event is 0.

Steps to reproduce:

1. Deploy NRF
2. Run curl --http2-prior-knowledge --header "Content-Type: application/json" --data '{"nfStatusNotificationUri": "test@example.com", "reqNotifEvents": ["unknown"], "subscriptionId": "12345"}' "http://<NRF_IP>:<NRF_PORT>/nnrf-nfm/v1/subscriptions"
This commit is contained in:
Sukchan Lee 2023-09-24 09:54:53 +09:00
parent 317d9bf846
commit 0abfb204ea
72 changed files with 854 additions and 122 deletions
Download patch file Download diff file Expand all files Collapse all files

40
lib/sbi/openapi/model/access_and_mobility_subscription_data.c
View file

@ -1142,11 +1142,17 @@ OpenAPI_access_and_mobility_subscription_data_t *OpenAPI_access_and_mobility_sub
rat_restrictionsList = OpenAPI_list_create();
cJSON_ArrayForEach(rat_restrictions_local, rat_restrictions) {
OpenAPI_rat_type_e localEnum = OpenAPI_rat_type_NULL;
if (!cJSON_IsString(rat_restrictions_local)) {
ogs_error("OpenAPI_access_and_mobility_subscription_data_parseFromJSON() failed [rat_restrictions]");
goto end;
}
OpenAPI_list_add(rat_restrictionsList, (void *)OpenAPI_rat_type_FromString(rat_restrictions_local->valuestring));
localEnum = OpenAPI_rat_type_FromString(rat_restrictions_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_rat_type_FromString(rat_restrictions_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(rat_restrictionsList, (void *)localEnum);
}
}
@ -1194,11 +1200,17 @@ OpenAPI_access_and_mobility_subscription_data_t *OpenAPI_access_and_mobility_sub
core_network_type_restrictionsList = OpenAPI_list_create();
cJSON_ArrayForEach(core_network_type_restrictions_local, core_network_type_restrictions) {
OpenAPI_core_network_type_e localEnum = OpenAPI_core_network_type_NULL;
if (!cJSON_IsString(core_network_type_restrictions_local)) {
ogs_error("OpenAPI_access_and_mobility_subscription_data_parseFromJSON() failed [core_network_type_restrictions]");
goto end;
}
OpenAPI_list_add(core_network_type_restrictionsList, (void *)OpenAPI_core_network_type_FromString(core_network_type_restrictions_local->valuestring));
localEnum = OpenAPI_core_network_type_FromString(core_network_type_restrictions_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_core_network_type_FromString(core_network_type_restrictions_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(core_network_type_restrictionsList, (void *)localEnum);
}
}
@ -1286,11 +1298,17 @@ OpenAPI_access_and_mobility_subscription_data_t *OpenAPI_access_and_mobility_sub
sor_update_indicator_listList = OpenAPI_list_create();
cJSON_ArrayForEach(sor_update_indicator_list_local, sor_update_indicator_list) {
OpenAPI_sor_update_indicator_e localEnum = OpenAPI_sor_update_indicator_NULL;
if (!cJSON_IsString(sor_update_indicator_list_local)) {
ogs_error("OpenAPI_access_and_mobility_subscription_data_parseFromJSON() failed [sor_update_indicator_list]");
goto end;
}
OpenAPI_list_add(sor_update_indicator_listList, (void *)OpenAPI_sor_update_indicator_FromString(sor_update_indicator_list_local->valuestring));
localEnum = OpenAPI_sor_update_indicator_FromString(sor_update_indicator_list_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_sor_update_indicator_FromString(sor_update_indicator_list_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(sor_update_indicator_listList, (void *)localEnum);
}
}
@ -1491,11 +1509,17 @@ OpenAPI_access_and_mobility_subscription_data_t *OpenAPI_access_and_mobility_sub
primary_rat_restrictionsList = OpenAPI_list_create();
cJSON_ArrayForEach(primary_rat_restrictions_local, primary_rat_restrictions) {
OpenAPI_rat_type_e localEnum = OpenAPI_rat_type_NULL;
if (!cJSON_IsString(primary_rat_restrictions_local)) {
ogs_error("OpenAPI_access_and_mobility_subscription_data_parseFromJSON() failed [primary_rat_restrictions]");
goto end;
}
OpenAPI_list_add(primary_rat_restrictionsList, (void *)OpenAPI_rat_type_FromString(primary_rat_restrictions_local->valuestring));
localEnum = OpenAPI_rat_type_FromString(primary_rat_restrictions_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_rat_type_FromString(primary_rat_restrictions_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(primary_rat_restrictionsList, (void *)localEnum);
}
}
@ -1510,11 +1534,17 @@ OpenAPI_access_and_mobility_subscription_data_t *OpenAPI_access_and_mobility_sub
secondary_rat_restrictionsList = OpenAPI_list_create();
cJSON_ArrayForEach(secondary_rat_restrictions_local, secondary_rat_restrictions) {
OpenAPI_rat_type_e localEnum = OpenAPI_rat_type_NULL;
if (!cJSON_IsString(secondary_rat_restrictions_local)) {
ogs_error("OpenAPI_access_and_mobility_subscription_data_parseFromJSON() failed [secondary_rat_restrictions]");
goto end;
}
OpenAPI_list_add(secondary_rat_restrictionsList, (void *)OpenAPI_rat_type_FromString(secondary_rat_restrictions_local->valuestring));
localEnum = OpenAPI_rat_type_FromString(secondary_rat_restrictions_local->valuestring);
if (!localEnum) {
ogs_error("OpenAPI_rat_type_FromString(secondary_rat_restrictions_local->valuestring) failed");
goto end;
}
OpenAPI_list_add(secondary_rat_restrictionsList, (void *)localEnum);
}
}