mirror of
https://github.com/lfnovo/open-notebook.git
synced 2026-08-14 19:43:51 +00:00
30c7e2a63e
Some checks are pending
Development Build / extract-version (push) Waiting to run
Development Build / changes (push) Waiting to run
Development Build / build-regular (push) Blocked by required conditions
Development Build / build-single (push) Blocked by required conditions
Development Build / summary (push) Blocked by required conditions
Tests / Frontend Tests (push) Waiting to run
Tests / Frontend Lint (push) Waiting to run
Tests / Frontend Build (push) Waiting to run
Tests / Backend Tests (push) Waiting to run
Tests / Backend Lint (push) Waiting to run
Tests / Backend Typecheck (push) Waiting to run
The episode profile "Max output tokens" field (#991) confused users: nothing explained what it controls, and whether it was a per-conversation, per-turn, or per-call limit. An empty field also showed "Must be a positive integer" — a scary error on an optional field — because a transient/empty number-input state produced NaN, which slipped past the nullable() guard into the positive() rule. - Add help text (all 14 locales) stating it caps output tokens per generation step — the outline and the full transcript, not a per-turn or conversation limit — and that blank uses the built-in defaults (3000 outline / 5000 transcript, from podcast-creator). - Add a placeholder ("Leave blank for defaults") so the empty field reads as intentionally optional rather than unfilled. - Map empty and NaN inputs to null in setValueAs, so an empty or half-typed value reads as "unset" and never trips the positive-integer rule. Genuinely invalid entries (0, negatives, decimals) still error. Field stays an optional override — no behavior change to generation. Verified in the browser: help renders, placeholder shows, empty field has no error, zero console errors. Frontend lint/test/build green. |
||
|---|---|---|
| .. | ||
| public | ||
| src | ||
| test-results | ||
| .gitignore | ||
| AGENTS.md | ||
| CLAUDE.md | ||
| components.json | ||
| eslint.config.mjs | ||
| next.config.ts | ||
| package-lock.json | ||
| package.json | ||
| postcss.config.mjs | ||
| start-server.js | ||
| tsconfig.json | ||
| vitest.config.ts | ||