mirror of
https://github.com/lfnovo/open-notebook.git
synced 2026-04-28 19:40:50 +00:00
* feat: replace provider config with credential-based system (#477) Introduce a new credential management system replacing the old ProviderConfig singleton and standalone Models page. Each credential stores encrypted API keys and provider-specific configuration with full CRUD support via a unified settings UI. Backend: - Add Credential domain model with encrypted API key storage - Add credentials API router (CRUD, discovery, registration, testing) - Add encryption utilities for secure key storage - Add key_provider for DB-first env-var fallback provisioning - Add connection tester and model discovery services - Integrate ModelManager with credential-based config - Add provider name normalization for Esperanto compatibility - Add database migrations 11-12 for credential schema Frontend: - Rewrite settings/api-keys page with credential management UI - Add model discovery dialog with search and custom model support - Add compact default model assignments (primary/advanced layout) - Add inline model testing and credential connection testing - Add env-var migration banner - Update navigation to unified settings page - Remove standalone models page and old settings components i18n: - Update all 7 locale files with credential and model management keys Closes #477 Co-Authored-By: JFMD <git@jfmd.us> Co-Authored-By: OraCatQAQ <570768706@qq.com> * fix: address PR #540 review comments - Fix docs referencing removed Models page - Fix error-handler returning raw messages instead of i18n keys - Fix auth.py misleading docstring and missing no-password guard - Fix connection_tester using wrong env var for openai_compatible - Add provision_provider_keys before model discovery/sync - Update CLAUDE.md to reflect credential-based system - Fix missing closing brace in api-keys page useEffect * fix: add logging to credential migration and surface errors in UI - Add comprehensive logging to migrate-from-env and migrate-from-provider-config endpoints (start, per-provider progress, success/failure with stack traces, final summary) - Fix frontend migration hooks ignoring errors array from response - Show error toast when migration fails instead of "nothing to migrate" - Invalidate status/envStatus queries after migration so banner updates * docs: update CLAUDE.md files for credential system Replace stale ProviderConfig and /api-keys/ references across 8 CLAUDE.md files to reflect the new Credential-based system from PR #540. * docs: update user documentation for credential-based system Replace env var API key instructions with Settings UI credential workflow across all user-facing documentation. The new flow is: set OPEN_NOTEBOOK_ENCRYPTION_KEY → start services → add credential in Settings UI → test → discover models → register. - Rewrite ai-providers.md, api-configuration.md, environment-reference.md - Update all quick-start guides and installation docs - Update ollama.md, openai-compatible.md, local-tts/stt networking sections - Update reverse-proxy.md, development-setup.md, security.md - Fix broken links to non-existent docs/deployment/ paths - Add credentials endpoints to api-reference.md - Move all API key env vars to deprecated/legacy sections * chore: bump version to 1.7.0-rc1 Release candidate for credential-based provider management system. * fix: initialize provider before try block in test_credential Prevents UnboundLocalError when Credential.get() throws (e.g., invalid credential_id) before provider is assigned. * fix: reorder down migration to drop index before table Removes duplicate REMOVE FIELD statement and reorders so the index is dropped before the table, preventing rollback failures. * refactor: simplify encryption key to always derive via SHA-256 Remove the dual code path in _ensure_fernet_key() that detected native Fernet keys. Since the credential system is new, always deriving via SHA-256 removes unnecessary complexity. Also removes the generate_key() function and Fernet.generate_key() references from docs. * fix: correct mock patch targets in embedding tests and URL validation Fix embedding tests patching wrong module path for model_manager (was targeting open_notebook.utils.embedding.model_manager but it's imported locally from open_notebook.ai.models). Also fix URL validation to allow unresolvable hostnames since they may be valid in the deployment environment (e.g., Azure endpoints, internal DNS). * feat: add global setup banner for encryption and migration status Show a persistent banner in AppShell when encryption key is missing (red) or env var API keys can be migrated (amber), so users see these prompts on every page instead of only on Settings > API Keys. Includes a docs link for the encryption banner and i18n support across all 7 locales. * docs: several improvements to docker-compose e env examples * Update README.md Co-authored-by: cubic-dev-ai[bot] <191113872+cubic-dev-ai[bot]@users.noreply.github.com> * docs: fix env var format in README and update model setup instructions Align the encryption key snippet in README Step 2 with the list format used in the compose file. Replace deprecated "Settings → Models" instructions with credential-based Discover Models flow. * fix: address credential system review issues - Fix SSRF bypass via IPv4-mapped IPv6 addresses (::ffff:169.254.x.x) - Fix TTS connection test missing config parameter - Add Azure-specific model discovery using api-key auth header - Add Vertex static model list for credential-based discovery - Fix PROVIDER_DISCOVERY_FUNCTIONS incorrect azure/vertex mapping - Extract business logic to api/credentials_service.py (service layer) - Move credential Pydantic schemas to api/models.py - Update tests to use new service imports and ValueError assertions * fix: sanitize error responses and migrate key_provider to Credential - Replace raw exception messages in all credential router 500 responses with generic error strings (internal details logged server-side only) - Refactor key_provider.py to use Credential.get_by_provider() instead of deprecated ProviderConfig.get_instance() - Remove unused functions (get_provider_configs, get_default_api_key, get_provider_config) that were dead code --------- Co-authored-by: JFMD <git@jfmd.us> Co-authored-by: OraCatQAQ <570768706@qq.com>
198 lines
6.1 KiB
Python
198 lines
6.1 KiB
Python
"""
|
|
Field-level encryption for sensitive data using API keys.
|
|
|
|
This module provides encryption/decryption for API keys stored in the database.
|
|
Fernet uses AES-128-CBC with HMAC-SHA256 for authenticated encryption.
|
|
|
|
OPEN_NOTEBOOK_ENCRYPTION_KEY accepts **any string**. A Fernet key is derived
|
|
from it via SHA-256, so users can set a simple passphrase like
|
|
``OPEN_NOTEBOOK_ENCRYPTION_KEY=my-secret`` and it will work.
|
|
|
|
Usage:
|
|
# Encrypt before storing
|
|
encrypted = encrypt_value(api_key)
|
|
|
|
# Decrypt when reading
|
|
decrypted = decrypt_value(encrypted)
|
|
"""
|
|
|
|
import base64
|
|
import hashlib
|
|
import os
|
|
from pathlib import Path
|
|
from typing import Optional
|
|
|
|
from cryptography.fernet import Fernet, InvalidToken
|
|
from loguru import logger
|
|
|
|
|
|
def get_secret_from_env(var_name: str) -> Optional[str]:
|
|
"""
|
|
Get a secret from environment, supporting Docker secrets pattern.
|
|
|
|
Checks for VAR_FILE first (Docker secrets), then falls back to VAR.
|
|
|
|
Args:
|
|
var_name: Base name of the environment variable (e.g., "OPEN_NOTEBOOK_ENCRYPTION_KEY")
|
|
|
|
Returns:
|
|
The secret value, or None if not configured.
|
|
"""
|
|
# Check for _FILE variant first (Docker secrets)
|
|
file_path = os.environ.get(f"{var_name}_FILE")
|
|
if file_path:
|
|
try:
|
|
path = Path(file_path)
|
|
if path.exists() and path.is_file():
|
|
secret = path.read_text().strip()
|
|
if secret:
|
|
logger.debug(f"Loaded {var_name} from file: {file_path}")
|
|
return secret
|
|
else:
|
|
logger.warning(f"{var_name}_FILE points to empty file: {file_path}")
|
|
else:
|
|
logger.warning(f"{var_name}_FILE path does not exist: {file_path}")
|
|
except Exception as e:
|
|
logger.error(f"Failed to read {var_name} from file {file_path}: {e}")
|
|
|
|
# Fall back to direct environment variable
|
|
return os.environ.get(var_name)
|
|
|
|
|
|
def _get_or_create_encryption_key() -> str:
|
|
"""
|
|
Get encryption key from environment, requires explicit configuration.
|
|
|
|
Priority:
|
|
1. OPEN_NOTEBOOK_ENCRYPTION_KEY_FILE (Docker secrets)
|
|
2. OPEN_NOTEBOOK_ENCRYPTION_KEY (environment variable)
|
|
|
|
For production deployments, you MUST set OPEN_NOTEBOOK_ENCRYPTION_KEY explicitly!
|
|
|
|
Returns:
|
|
Encryption key string.
|
|
|
|
Raises:
|
|
ValueError: If no encryption key is configured.
|
|
"""
|
|
# First check environment/Docker secrets
|
|
key = get_secret_from_env("OPEN_NOTEBOOK_ENCRYPTION_KEY")
|
|
if key:
|
|
return key
|
|
|
|
raise ValueError(
|
|
"OPEN_NOTEBOOK_ENCRYPTION_KEY is not set. "
|
|
"Set this environment variable to any secret string to enable "
|
|
"encrypted storage of API keys in the database."
|
|
)
|
|
|
|
|
|
# Lazy-loaded encryption key: initialized on first use, not at import time.
|
|
# This prevents the entire app from crashing if the key is not yet configured
|
|
# when other modules import from this file.
|
|
_ENCRYPTION_KEY: Optional[str] = None
|
|
|
|
|
|
def _get_encryption_key() -> str:
|
|
"""Get the encryption key, initializing lazily on first call."""
|
|
global _ENCRYPTION_KEY
|
|
if _ENCRYPTION_KEY is None:
|
|
_ENCRYPTION_KEY = _get_or_create_encryption_key()
|
|
return _ENCRYPTION_KEY
|
|
|
|
|
|
def _ensure_fernet_key(key: str) -> str:
|
|
"""
|
|
Derive a valid Fernet key from an arbitrary string via SHA-256.
|
|
|
|
Any string is accepted as input. The key is derived by hashing it with
|
|
SHA-256 and encoding the result as URL-safe base64.
|
|
"""
|
|
derived = hashlib.sha256(key.encode()).digest()
|
|
return base64.urlsafe_b64encode(derived).decode()
|
|
|
|
|
|
def get_fernet() -> Fernet:
|
|
"""
|
|
Get Fernet instance with the configured encryption key.
|
|
|
|
Returns:
|
|
Fernet instance.
|
|
|
|
Raises:
|
|
ValueError: If encryption key is not configured.
|
|
"""
|
|
return Fernet(_ensure_fernet_key(_get_encryption_key()).encode())
|
|
|
|
|
|
def encrypt_value(value: str) -> str:
|
|
"""
|
|
Encrypt a string value using Fernet symmetric encryption.
|
|
|
|
Args:
|
|
value: The plain text string to encrypt.
|
|
|
|
Returns:
|
|
Base64-encoded encrypted string.
|
|
|
|
Raises:
|
|
ValueError: If encryption is not configured.
|
|
"""
|
|
fernet = get_fernet()
|
|
return fernet.encrypt(value.encode()).decode()
|
|
|
|
|
|
def looks_like_fernet_token(s: str) -> bool:
|
|
"""
|
|
Check if string looks like a Fernet encrypted token.
|
|
|
|
Fernet tokens are versioned (1 byte) + timestamp (8 bytes) + IV (16 bytes)
|
|
+ ciphertext (variable, multiple of 16 with PKCS7 padding) + HMAC (32 bytes).
|
|
Minimum decoded size is 73 bytes (1+8+16+16+32) for the smallest payload.
|
|
"""
|
|
if len(s) < 100: # Base64 of 73 bytes = ~100 chars minimum
|
|
return False
|
|
try:
|
|
decoded = base64.urlsafe_b64decode(s)
|
|
# Fernet: version(1) + timestamp(8) + IV(16) + ciphertext(>=16) + HMAC(32)
|
|
# Minimum 73 bytes, ciphertext must be multiple of 16 (AES block size)
|
|
if len(decoded) < 73:
|
|
return False
|
|
ciphertext_len = len(decoded) - 1 - 8 - 16 - 32
|
|
return ciphertext_len > 0 and ciphertext_len % 16 == 0
|
|
except Exception:
|
|
return False
|
|
|
|
|
|
def decrypt_value(value: str) -> str:
|
|
"""
|
|
Decrypt a Fernet-encrypted string value.
|
|
|
|
Handles graceful fallback for legacy unencrypted data.
|
|
|
|
Args:
|
|
value: The encrypted string (or plain text for legacy data).
|
|
|
|
Returns:
|
|
Decrypted plain text string, or original value if not encrypted.
|
|
|
|
Raises:
|
|
ValueError: If encryption is not configured or if decryption fails
|
|
for what appears to be encrypted data (wrong key).
|
|
"""
|
|
fernet = get_fernet()
|
|
|
|
try:
|
|
return fernet.decrypt(value.encode()).decode()
|
|
except InvalidToken:
|
|
if looks_like_fernet_token(value):
|
|
# Looks like encrypted data but failed to decrypt - likely wrong key
|
|
raise ValueError(
|
|
"Decryption failed: data appears to be encrypted but key is incorrect. "
|
|
"Check OPEN_NOTEBOOK_ENCRYPTION_KEY configuration."
|
|
)
|
|
# Not a valid token - treat as legacy plaintext
|
|
return value
|
|
except Exception as e:
|
|
logger.error(f"Decryption failed: {e}")
|
|
raise ValueError(f"Decryption failed: {str(e)}")
|