mirror of
https://github.com/lfnovo/open-notebook.git
synced 2026-05-03 05:40:36 +00:00
* feat(i18n): complete 100% internationalization and fix Next.js 15 compatibility
* feat(i18n): complete 100% internationalization coverage
* chore(test): finalize component tests and project cleanup
* test(logic): add unit tests for useModalManager hook
* fix(test): resolve timeout in AppSidebar tests by mocking TooltipProvider
* feat(i18n): comprehensive i18n audit, fixes for hardcoded strings, and complete zh-TW support
* fix(i18n): resolve TypeScript warnings and improve translation hook stability
- Remove unused useTranslation import from ConnectionGuard
- Add ref-based checking state to prevent dependency cycles
- Fix useTranslation hook to return empty string for undefined translations
- Add comment for backward compatibility on ExtractedReference interface
- Ensure .replace() string methods work safely with nested translation keys
* feat(i18n): complete internationalization implementation with Docker deployment
- Add LanguageLoadingOverlay component for smooth language transitions
- Update all translation files (en-US, zh-CN, zh-TW) with improved terminology
- Optimize Docker configuration for better performance
- Update version check and config handling for i18n support
- Fix route handling for language-specific content
- Add comprehensive task documentation
* fix(i18n): resolve localization errors, duplicates, and type issues
* chore(i18n): finalize 100% internationalization coverage
* chore(test): supplement i18n test cases and cleanup redundant files
* fix(test): resolve lint type errors and finalize delivery documents
* feat(i18n): finalize full internationalization and zh-TW localization
* fix(frontend): add missing devDependency and fix build tsconfig
* feat(ui): enhance sidebar hover effects with better visual feedback
* fix(frontend): resolve accessibility, i18n, and lint issues
- fix: add missing id, name, autocomplete attributes to dialog inputs
- fix: add aria labels and DialogDescription for accessibility
- fix: resolve uncontrolled component warning in SettingsForm
- fix: correct duplicate 'Traditional Chinese' label in zh-TW locale
- feat: add i18n support for podcast template names
- chore: fix lint errors in Dialogs
* fix: address all 21 PR feedback items from cubic-dev-ai bot
Configuration:
- Remove ignoreDuringBuilds flags from next.config.ts
Testing:
- Fix AppSidebar.test.tsx regex pattern and add missing assertion
Logic:
- Fix ConnectionGuard.tsx re-entry prevention logic
Internationalization (I18n) - Translations:
- Add missing keys: notebooks.archived, common.note/insight, accessibility keys
- Add specific keys: sources.allSourcesDescShort, transformations.selectModel
- Add singular/plural keys: podcasts.usedByCount_one/other, common.note/notes
- Add common.created/updated with {time} placeholder
Internationalization (I18n) - Usage:
- SourcesPage: use allSourcesDescShort instead of string splitting
- TransformationPlayground: use navigation.transformation and selectModel
- CommandPalette: use dedicated keys instead of string concatenation
- GeneratePodcastDialog: fix zh-TW date locale handling
- NotebookHeader: correctly interpolate {time} placeholder
- TransformationCard: use common.description instead of undefined key
- ChatPanel/SpeakerProfilesPanel: implement proper pluralization
- SystemInfo: correctly interpolate {version} placeholder
- LanguageLoadingOverlay: use t.common.loading instead of hardcoded string
- MessageActions: use specific error key cannotSaveNoteNoNotebook
Other:
- Fix SessionManager.tsx exhaustive-deps warning
* fix: remove duplicate locale keys and add missing zh-CN translations
- en-US: remove duplicate loading key (line 59) and addNew key (sources)
- zh-CN: remove duplicate common keys (loading, note, insight, newSource, newNotebook, newPodcast)
- zh-CN: remove duplicate accessibility.searchNotebooks key
- zh-CN: remove duplicate sources.addNew key
- zh-CN: remove duplicate navigation.transformation key
- zh-CN: add missing usedByCount_one and usedByCount_other keys in podcasts
- zh-TW: remove duplicate common keys (loading, note, insight, newSource, newNotebook, newPodcast)
- zh-TW: remove duplicate accessibility.searchNotebooks key
- zh-TW: remove duplicate sources.addNew key
* docs: remove info.md
* fix: remove duplicate notebook keys and unused ts-expect-error
- zh-CN: remove duplicate notebooks keys (archived, archive, unarchive, deleteNotebook, deleteNotebookDesc)
- zh-TW: remove duplicate notebooks keys (archived, archive, unarchive, deleteNotebook, deleteNotebookDesc)
- GeneratePodcastDialog: remove unused @ts-expect-error directive
* fix(a11y): fix unassociated labels in search page
- Replace <Label> with role='group' + aria-labelledby for search type section
- Replace <Label> with role='group' + aria-labelledby for search in section
- Follows WAI-ARIA best practices for labeling form field groups
* fix(a11y): fix unassociated labels across multiple components
- search/page.tsx: use role='group' + aria-labelledby for search type and search in sections
- RebuildEmbeddings.tsx: use role='group' + aria-labelledby for include checkboxes
- TransformationPlayground.tsx: replace Label with span for non-form output label
* chore: revert to npm stack and ensure i18n compatibility
* chore: polish zh-TW translations for better idiomatic usage
* fix: resolve linter errors (ruff import sort, mypy config duplicate)
* style: apply ruff formatting
* fix: finalize upstream compliance (Dockerfile.single, i18n hooks, docker-compose)
* style: polish strings, fix timeout cleanup, and improve test mocks
* fix: use relative imports in test setup to resolve IDE path errors
* perf(docker): optimize build speed by removing apt-get upgrade and build tools
- Remove apt-get upgrade from both builder and runtime stages (saves 10-15 min each)
- Remove gcc/g++/make/git from builder (uv downloads pre-built wheels)
- Add --no-install-recommends to minimize package footprint
- Keep npm mirror (npmmirror.com) for faster frontend deps
- Add npm registry config for reliable China network access
Also includes:
- fix(a11y): add missing labels and aria attributes to form fields
- fix(i18n): add 2s safety timeout to LanguageLoadingOverlay
- fix(i18n): add robustness checks to use-translation proxy
Build time reduced from 2+ hours to ~34 minutes (~70% improvement)
* fix(a11y): resolve 16 form field accessibility warnings in notebook and podcast pages
* fix(a11y): resolve 4 button and 1 select field accessibility warnings in models page
* fix(a11y): resolve redundant attributes and residual warnings in transformations and podcast forms
* fix(i18n): deep fix for language switch hang using proxy protection and safer access
* fix(a11y): add name attributes to ModelSelector, TransformationPlayground, and SourceDetailContent
* fix: add missing Label import to SourceDetailContent
* fix(i18n): use native react-i18next in LanguageLoadingOverlay to prevent hang during language switch
* fix(i18n): rewrite use-translation Proxy with strict depth limit and expanded blocked props to prevent language switch hang
* fix: add type assertion to fix TypeScript comparison error
* fix(i18n): disable useSuspense to prevent thread hang during language resource loading
* fix(i18n): add infinite loop detection circuit breaker to useTranslation hook
* fix(i18n): update traditional chinese label to native script in en-US
* feat: add new localization strings for notebook and note management.
* fix: resolve config priority, docker build deps, and ui glitches
* refactor: improve ui details and test coverage based on feedback
* refactor: improve ui details (version check/lang toggle) and test coverage
* fix: polish language matching and test cleanup
* fix(test): update mocks to resolve timeouts and proxy errors
* fix(frontend): restore tsconfig.json structure and enable IDE support for tests
* fix: address PR review findings and resolve CI OIDC failure
* fix: merge exception headers in custom handler
* fix: comprehensive PR review remediations and async performance fixes
* refactor: address all PR #371 review feedback
- Docker: consolidate SURREAL_URL to docker.env, add single-container override
- Security: restore apt-get upgrade in Dockerfile and Dockerfile.single
- Create centralized getDateLocale helper (lib/utils/date-locale.ts)
- Refactor 7 files to use getDateLocale helper
- Revert config/route.ts to origin/main version
- Move test files to co-located pattern (3 files)
- Remove local useTranslation mock from ConfirmDialog.test.tsx
- Simplify use-version-check to single useEffect pattern
- Fix test import paths after moving to co-located pattern
* fix: add jest-dom types for test files
* fix: address remaining review issues
- Add apt-get upgrade -y to Dockerfile.single backend-builder stage
- Refactor ChatColumn.test.tsx: use 'as unknown as ReturnType<typeof hook>' instead of 'as any'
- Use toBeInTheDocument() assertions instead of toBeDefined()
155 lines
5.1 KiB
Python
155 lines
5.1 KiB
Python
"""
|
|
Unit tests for the open_notebook.graphs module.
|
|
|
|
This test suite focuses on testing graph structures, tools, and validation
|
|
without heavy mocking of the actual processing logic.
|
|
"""
|
|
|
|
from datetime import datetime
|
|
|
|
import pytest
|
|
|
|
from open_notebook.graphs.prompt import PatternChainState, graph
|
|
from open_notebook.graphs.tools import get_current_timestamp
|
|
from open_notebook.graphs.transformation import (
|
|
TransformationState,
|
|
run_transformation,
|
|
)
|
|
from open_notebook.graphs.transformation import (
|
|
graph as transformation_graph,
|
|
)
|
|
|
|
# ============================================================================
|
|
# TEST SUITE 1: Graph Tools
|
|
# ============================================================================
|
|
|
|
|
|
class TestGraphTools:
|
|
"""Test suite for graph tool definitions."""
|
|
|
|
def test_get_current_timestamp_format(self):
|
|
"""Test timestamp tool returns correct format."""
|
|
timestamp = get_current_timestamp.func()
|
|
|
|
assert isinstance(timestamp, str)
|
|
assert len(timestamp) == 14 # YYYYMMDDHHmmss format
|
|
assert timestamp.isdigit()
|
|
|
|
def test_get_current_timestamp_validity(self):
|
|
"""Test timestamp represents valid datetime."""
|
|
timestamp = get_current_timestamp.func()
|
|
|
|
# Parse it back to datetime to verify validity
|
|
year = int(timestamp[0:4])
|
|
month = int(timestamp[4:6])
|
|
day = int(timestamp[6:8])
|
|
hour = int(timestamp[8:10])
|
|
minute = int(timestamp[10:12])
|
|
second = int(timestamp[12:14])
|
|
|
|
# Should be valid date components
|
|
assert 2020 <= year <= 2100
|
|
assert 1 <= month <= 12
|
|
assert 1 <= day <= 31
|
|
assert 0 <= hour <= 23
|
|
assert 0 <= minute <= 59
|
|
assert 0 <= second <= 59
|
|
|
|
# Should parse as datetime
|
|
dt = datetime.strptime(timestamp, "%Y%m%d%H%M%S")
|
|
assert isinstance(dt, datetime)
|
|
|
|
def test_get_current_timestamp_is_tool(self):
|
|
"""Test that function is properly decorated as a tool."""
|
|
# Check it has tool attributes
|
|
assert hasattr(get_current_timestamp, "name")
|
|
assert hasattr(get_current_timestamp, "description")
|
|
|
|
|
|
# ============================================================================
|
|
# TEST SUITE 2: Prompt Graph State
|
|
# ============================================================================
|
|
|
|
|
|
class TestPromptGraph:
|
|
"""Test suite for prompt pattern chain graph."""
|
|
|
|
def test_pattern_chain_state_structure(self):
|
|
"""Test PatternChainState structure and fields."""
|
|
state = PatternChainState(
|
|
prompt="Test prompt", parser=None, input_text="Test input", output=""
|
|
)
|
|
|
|
assert state["prompt"] == "Test prompt"
|
|
assert state["parser"] is None
|
|
assert state["input_text"] == "Test input"
|
|
assert state["output"] == ""
|
|
|
|
def test_prompt_graph_compilation(self):
|
|
"""Test that prompt graph compiles correctly."""
|
|
assert graph is not None
|
|
|
|
# Graph should have the expected structure
|
|
assert hasattr(graph, "invoke")
|
|
assert hasattr(graph, "ainvoke")
|
|
|
|
|
|
# ============================================================================
|
|
# TEST SUITE 3: Transformation Graph
|
|
# ============================================================================
|
|
|
|
|
|
class TestTransformationGraph:
|
|
"""Test suite for transformation graph workflows."""
|
|
|
|
def test_transformation_state_structure(self):
|
|
"""Test TransformationState structure and fields."""
|
|
from unittest.mock import MagicMock
|
|
|
|
from open_notebook.domain.notebook import Source
|
|
from open_notebook.domain.transformation import Transformation
|
|
|
|
mock_source = MagicMock(spec=Source)
|
|
mock_transformation = MagicMock(spec=Transformation)
|
|
|
|
state = TransformationState(
|
|
input_text="Test text",
|
|
source=mock_source,
|
|
transformation=mock_transformation,
|
|
output="",
|
|
)
|
|
|
|
assert state["input_text"] == "Test text"
|
|
assert state["source"] == mock_source
|
|
assert state["transformation"] == mock_transformation
|
|
assert state["output"] == ""
|
|
|
|
@pytest.mark.asyncio
|
|
async def test_run_transformation_assertion_no_content(self):
|
|
"""Test transformation raises assertion with no content."""
|
|
from unittest.mock import MagicMock
|
|
|
|
from open_notebook.domain.transformation import Transformation
|
|
|
|
mock_transformation = MagicMock(spec=Transformation)
|
|
|
|
state = {
|
|
"input_text": None,
|
|
"transformation": mock_transformation,
|
|
"source": None,
|
|
}
|
|
|
|
config = {"configurable": {"model_id": None}}
|
|
|
|
with pytest.raises(AssertionError, match="No content to transform"):
|
|
await run_transformation(state, config)
|
|
|
|
def test_transformation_graph_compilation(self):
|
|
"""Test that transformation graph compiles correctly."""
|
|
assert transformation_graph is not None
|
|
assert hasattr(transformation_graph, "invoke")
|
|
assert hasattr(transformation_graph, "ainvoke")
|
|
|
|
|
|
if __name__ == "__main__":
|
|
pytest.main([__file__, "-v"])
|