mirror of
https://github.com/lfnovo/open-notebook.git
synced 2026-08-04 05:12:52 +00:00
3bfa6d728e
Some checks are pending
Development Build / summary (push) Blocked by required conditions
Development Build / extract-version (push) Waiting to run
Development Build / changes (push) Waiting to run
Development Build / build-regular (push) Blocked by required conditions
Development Build / build-single (push) Blocked by required conditions
Tests / Backend Tests (push) Waiting to run
Tests / Backend Lint (push) Waiting to run
Tests / Backend Typecheck (push) Waiting to run
Tests / Frontend Tests (push) Waiting to run
Tests / Frontend Lint (push) Waiting to run
Tests / Frontend Build (push) Waiting to run
Surface content-core 2.x's docling_formulas (formula extraction) and docling_vision (image/chart vision) enrichment flags in Settings → Content Processing, mirroring the existing OCR toggle. Both default off and are gated on Docling availability in the UI. The settings persist via GET/PUT /api/settings and are threaded into content-core extraction alongside docling_ocr. Migration 23 backfills the new fields on the existing content_settings record. Labels and help are translated across all 14 locales. Closes #1131
109 lines
4.4 KiB
Python
109 lines
4.4 KiB
Python
from fastapi import APIRouter, HTTPException
|
|
from loguru import logger
|
|
|
|
from api.models import SettingsResponse, SettingsUpdate
|
|
from open_notebook.domain.content_settings import ContentSettings
|
|
from open_notebook.exceptions import (
|
|
InvalidInputError,
|
|
OpenNotebookError,
|
|
)
|
|
|
|
router = APIRouter()
|
|
|
|
|
|
@router.get("/settings", response_model=SettingsResponse)
|
|
async def get_settings():
|
|
"""Get all application settings."""
|
|
try:
|
|
settings: ContentSettings = await ContentSettings.get_instance() # type: ignore[assignment]
|
|
|
|
return SettingsResponse(
|
|
default_content_processing_engine_doc=settings.default_content_processing_engine_doc,
|
|
default_content_processing_engine_url=settings.default_content_processing_engine_url,
|
|
default_embedding_option=settings.default_embedding_option,
|
|
auto_delete_files=settings.auto_delete_files,
|
|
docling_ocr=settings.docling_ocr,
|
|
docling_formulas=settings.docling_formulas,
|
|
docling_vision=settings.docling_vision,
|
|
youtube_preferred_languages=settings.youtube_preferred_languages,
|
|
)
|
|
except HTTPException:
|
|
raise
|
|
except OpenNotebookError:
|
|
raise
|
|
except Exception as e:
|
|
logger.error(f"Error fetching settings: {str(e)}")
|
|
raise HTTPException(
|
|
status_code=500, detail="Error fetching settings"
|
|
)
|
|
|
|
|
|
@router.put("/settings", response_model=SettingsResponse)
|
|
async def update_settings(settings_update: SettingsUpdate):
|
|
"""Update application settings."""
|
|
try:
|
|
settings: ContentSettings = await ContentSettings.get_instance() # type: ignore[assignment]
|
|
|
|
# Update only provided fields
|
|
if settings_update.default_content_processing_engine_doc is not None:
|
|
# Cast to proper literal type
|
|
from typing import Literal, cast
|
|
|
|
settings.default_content_processing_engine_doc = cast(
|
|
Literal["auto", "docling", "simple"],
|
|
settings_update.default_content_processing_engine_doc,
|
|
)
|
|
if settings_update.default_content_processing_engine_url is not None:
|
|
from typing import Literal, cast
|
|
|
|
settings.default_content_processing_engine_url = cast(
|
|
Literal["auto", "firecrawl", "jina", "crawl4ai", "simple"],
|
|
settings_update.default_content_processing_engine_url,
|
|
)
|
|
if settings_update.default_embedding_option is not None:
|
|
from typing import Literal, cast
|
|
|
|
settings.default_embedding_option = cast(
|
|
Literal["ask", "always", "never"],
|
|
settings_update.default_embedding_option,
|
|
)
|
|
if settings_update.auto_delete_files is not None:
|
|
from typing import Literal, cast
|
|
|
|
settings.auto_delete_files = cast(
|
|
Literal["yes", "no"], settings_update.auto_delete_files
|
|
)
|
|
if settings_update.docling_ocr is not None:
|
|
settings.docling_ocr = settings_update.docling_ocr
|
|
if settings_update.docling_formulas is not None:
|
|
settings.docling_formulas = settings_update.docling_formulas
|
|
if settings_update.docling_vision is not None:
|
|
settings.docling_vision = settings_update.docling_vision
|
|
if settings_update.youtube_preferred_languages is not None:
|
|
settings.youtube_preferred_languages = (
|
|
settings_update.youtube_preferred_languages
|
|
)
|
|
|
|
await settings.update()
|
|
|
|
return SettingsResponse(
|
|
default_content_processing_engine_doc=settings.default_content_processing_engine_doc,
|
|
default_content_processing_engine_url=settings.default_content_processing_engine_url,
|
|
default_embedding_option=settings.default_embedding_option,
|
|
auto_delete_files=settings.auto_delete_files,
|
|
docling_ocr=settings.docling_ocr,
|
|
docling_formulas=settings.docling_formulas,
|
|
docling_vision=settings.docling_vision,
|
|
youtube_preferred_languages=settings.youtube_preferred_languages,
|
|
)
|
|
except HTTPException:
|
|
raise
|
|
except InvalidInputError as e:
|
|
raise HTTPException(status_code=400, detail=str(e))
|
|
except OpenNotebookError:
|
|
raise
|
|
except Exception as e:
|
|
logger.error(f"Error updating settings: {str(e)}")
|
|
raise HTTPException(
|
|
status_code=500, detail="Error updating settings"
|
|
)
|