6 commits

Author	SHA1	Message	Date
orihatav	d0bbe4a921	fix: handle tiktoken network errors in offline environments (issue #264) ... In air-gapped / offline Docker deployments, tiktoken.get_encoding() tries to download the encoding file from openaipublic.blob.core.windows.net. When that request fails it raises a URLError / OSError — not an ImportError — so the previous except clause silently missed it and the crash surfaced in the UI. Widened `except ImportError` to `except Exception` so all failures — "not installed" and "network unreachable" — fall through to the word-count fallback (words × 1.3). Added a loguru WARNING so operators can see when the fallback is active. TIKTOKEN_CACHE_DIR now reads from the environment with a blank-safe fallback (`or` guard prevents os.makedirs("") on empty env var). This lets Docker images redirect the cache to a path outside /app/data/ so user-data volume mounts cannot shadow the pre-baked encoding. Both images now pre-download the o200k_base encoding during the builder stage (internet is available at build time) and copy it into the runtime image at /app/tiktoken-cache. ENV TIKTOKEN_CACHE_DIR=/app/tiktoken-cache is set in the runtime stage so no network call is ever needed at runtime. Added test_token_count_network_error_fallback in tests/test_utils.py: patches tiktoken.get_encoding with a URLError and asserts token_count() returns a positive int instead of raising. Fixes #264 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>	2026-03-10 19:45:14 -05:00
Luis Novo	d8006ff5cb	feat: content-type aware chunking and unified embedding (#444) ... * feat: content-type aware chunking and unified embedding - Add chunking.py with HTML, Markdown, and plain text detection - Add embedding.py with mean pooling for large content - Create dedicated commands: embed_note, embed_insight, embed_source - Use fire-and-forget pattern for embedding via submit_command() - Refactor rebuild_embeddings_command to delegate to individual commands - Remove legacy commands and needs_embedding() methods - Reduce chunk size to 1500 chars for Ollama compatibility - Update CLAUDE.md documentation for new architecture Fixes #350, #142 * fix: address code review issues - Note.save() now returns command_id for tracking embedding jobs - Add length check after generate_embeddings() to fail fast on mismatch - Add numpy as explicit dependency (was transitive) - Remove hardcoded chunk sizes from docstrings * docs: address code review comments - Rename "SYNC PATH" to "DOMAIN MODEL PATH" in embedding router - Add test_chunking.py and test_embedding.py to Testing Strategy - Clarify auto-embedding behavior for each domain model * fix: clean thinking tags from prompt graph output Adds clean_thinking_content() to prompt.py to handle extended thinking models that return <think>...</think> tags. This fixes empty titles when saving notes from chat. * chore: remove local docker-compose from git * fix(frontend): handle null parent_id in search results Add defensive check for null parent_id in search results to prevent "Cannot read properties of null (reading 'split')" error. This can happen with orphaned records in the database. * fix: cascade delete embeddings and insights when source is deleted When deleting a Source, now also deletes associated: - source_embedding records - source_insight records This prevents orphaned records that cause null parent_id errors in vector search results. * fix: add cleanup for orphan embedding/insight records in migration 10 Deletes source_embedding and source_insight records where the linked source no longer exists (source.id = NONE). * chore: bump esperanto to 2.16 Increases ctx_num for Ollama models to accommodate larger notebook context windows. See: https://github.com/lfnovo/esperanto/pull/69	2026-01-21 23:49:08 -03:00
MisonL	67dd85c928	Feat/localization tests docker (#371) ... * feat(i18n): complete 100% internationalization and fix Next.js 15 compatibility * feat(i18n): complete 100% internationalization coverage * chore(test): finalize component tests and project cleanup * test(logic): add unit tests for useModalManager hook * fix(test): resolve timeout in AppSidebar tests by mocking TooltipProvider * feat(i18n): comprehensive i18n audit, fixes for hardcoded strings, and complete zh-TW support * fix(i18n): resolve TypeScript warnings and improve translation hook stability - Remove unused useTranslation import from ConnectionGuard - Add ref-based checking state to prevent dependency cycles - Fix useTranslation hook to return empty string for undefined translations - Add comment for backward compatibility on ExtractedReference interface - Ensure .replace() string methods work safely with nested translation keys * feat(i18n): complete internationalization implementation with Docker deployment - Add LanguageLoadingOverlay component for smooth language transitions - Update all translation files (en-US, zh-CN, zh-TW) with improved terminology - Optimize Docker configuration for better performance - Update version check and config handling for i18n support - Fix route handling for language-specific content - Add comprehensive task documentation * fix(i18n): resolve localization errors, duplicates, and type issues * chore(i18n): finalize 100% internationalization coverage * chore(test): supplement i18n test cases and cleanup redundant files * fix(test): resolve lint type errors and finalize delivery documents * feat(i18n): finalize full internationalization and zh-TW localization * fix(frontend): add missing devDependency and fix build tsconfig * feat(ui): enhance sidebar hover effects with better visual feedback * fix(frontend): resolve accessibility, i18n, and lint issues - fix: add missing id, name, autocomplete attributes to dialog inputs - fix: add aria labels and DialogDescription for accessibility - fix: resolve uncontrolled component warning in SettingsForm - fix: correct duplicate 'Traditional Chinese' label in zh-TW locale - feat: add i18n support for podcast template names - chore: fix lint errors in Dialogs * fix: address all 21 PR feedback items from cubic-dev-ai bot Configuration: - Remove ignoreDuringBuilds flags from next.config.ts Testing: - Fix AppSidebar.test.tsx regex pattern and add missing assertion Logic: - Fix ConnectionGuard.tsx re-entry prevention logic Internationalization (I18n) - Translations: - Add missing keys: notebooks.archived, common.note/insight, accessibility keys - Add specific keys: sources.allSourcesDescShort, transformations.selectModel - Add singular/plural keys: podcasts.usedByCount_one/other, common.note/notes - Add common.created/updated with {time} placeholder Internationalization (I18n) - Usage: - SourcesPage: use allSourcesDescShort instead of string splitting - TransformationPlayground: use navigation.transformation and selectModel - CommandPalette: use dedicated keys instead of string concatenation - GeneratePodcastDialog: fix zh-TW date locale handling - NotebookHeader: correctly interpolate {time} placeholder - TransformationCard: use common.description instead of undefined key - ChatPanel/SpeakerProfilesPanel: implement proper pluralization - SystemInfo: correctly interpolate {version} placeholder - LanguageLoadingOverlay: use t.common.loading instead of hardcoded string - MessageActions: use specific error key cannotSaveNoteNoNotebook Other: - Fix SessionManager.tsx exhaustive-deps warning * fix: remove duplicate locale keys and add missing zh-CN translations - en-US: remove duplicate loading key (line 59) and addNew key (sources) - zh-CN: remove duplicate common keys (loading, note, insight, newSource, newNotebook, newPodcast) - zh-CN: remove duplicate accessibility.searchNotebooks key - zh-CN: remove duplicate sources.addNew key - zh-CN: remove duplicate navigation.transformation key - zh-CN: add missing usedByCount_one and usedByCount_other keys in podcasts - zh-TW: remove duplicate common keys (loading, note, insight, newSource, newNotebook, newPodcast) - zh-TW: remove duplicate accessibility.searchNotebooks key - zh-TW: remove duplicate sources.addNew key * docs: remove info.md * fix: remove duplicate notebook keys and unused ts-expect-error - zh-CN: remove duplicate notebooks keys (archived, archive, unarchive, deleteNotebook, deleteNotebookDesc) - zh-TW: remove duplicate notebooks keys (archived, archive, unarchive, deleteNotebook, deleteNotebookDesc) - GeneratePodcastDialog: remove unused @ts-expect-error directive * fix(a11y): fix unassociated labels in search page - Replace <Label> with role='group' + aria-labelledby for search type section - Replace <Label> with role='group' + aria-labelledby for search in section - Follows WAI-ARIA best practices for labeling form field groups * fix(a11y): fix unassociated labels across multiple components - search/page.tsx: use role='group' + aria-labelledby for search type and search in sections - RebuildEmbeddings.tsx: use role='group' + aria-labelledby for include checkboxes - TransformationPlayground.tsx: replace Label with span for non-form output label * chore: revert to npm stack and ensure i18n compatibility * chore: polish zh-TW translations for better idiomatic usage * fix: resolve linter errors (ruff import sort, mypy config duplicate) * style: apply ruff formatting * fix: finalize upstream compliance (Dockerfile.single, i18n hooks, docker-compose) * style: polish strings, fix timeout cleanup, and improve test mocks * fix: use relative imports in test setup to resolve IDE path errors * perf(docker): optimize build speed by removing apt-get upgrade and build tools - Remove apt-get upgrade from both builder and runtime stages (saves 10-15 min each) - Remove gcc/g++/make/git from builder (uv downloads pre-built wheels) - Add --no-install-recommends to minimize package footprint - Keep npm mirror (npmmirror.com) for faster frontend deps - Add npm registry config for reliable China network access Also includes: - fix(a11y): add missing labels and aria attributes to form fields - fix(i18n): add 2s safety timeout to LanguageLoadingOverlay - fix(i18n): add robustness checks to use-translation proxy Build time reduced from 2+ hours to ~34 minutes (~70% improvement) * fix(a11y): resolve 16 form field accessibility warnings in notebook and podcast pages * fix(a11y): resolve 4 button and 1 select field accessibility warnings in models page * fix(a11y): resolve redundant attributes and residual warnings in transformations and podcast forms * fix(i18n): deep fix for language switch hang using proxy protection and safer access * fix(a11y): add name attributes to ModelSelector, TransformationPlayground, and SourceDetailContent * fix: add missing Label import to SourceDetailContent * fix(i18n): use native react-i18next in LanguageLoadingOverlay to prevent hang during language switch * fix(i18n): rewrite use-translation Proxy with strict depth limit and expanded blocked props to prevent language switch hang * fix: add type assertion to fix TypeScript comparison error * fix(i18n): disable useSuspense to prevent thread hang during language resource loading * fix(i18n): add infinite loop detection circuit breaker to useTranslation hook * fix(i18n): update traditional chinese label to native script in en-US * feat: add new localization strings for notebook and note management. * fix: resolve config priority, docker build deps, and ui glitches * refactor: improve ui details and test coverage based on feedback * refactor: improve ui details (version check/lang toggle) and test coverage * fix: polish language matching and test cleanup * fix(test): update mocks to resolve timeouts and proxy errors * fix(frontend): restore tsconfig.json structure and enable IDE support for tests * fix: address PR review findings and resolve CI OIDC failure * fix: merge exception headers in custom handler * fix: comprehensive PR review remediations and async performance fixes * refactor: address all PR #371 review feedback - Docker: consolidate SURREAL_URL to docker.env, add single-container override - Security: restore apt-get upgrade in Dockerfile and Dockerfile.single - Create centralized getDateLocale helper (lib/utils/date-locale.ts) - Refactor 7 files to use getDateLocale helper - Revert config/route.ts to origin/main version - Move test files to co-located pattern (3 files) - Remove local useTranslation mock from ConfirmDialog.test.tsx - Simplify use-version-check to single useEffect pattern - Fix test import paths after moving to co-located pattern * fix: add jest-dom types for test files * fix: address remaining review issues - Add apt-get upgrade -y to Dockerfile.single backend-builder stage - Refactor ChatColumn.test.tsx: use 'as unknown as ReturnType<typeof hook>' instead of 'as any' - Use toBeInTheDocument() assertions instead of toBeDefined()	2026-01-15 13:51:05 -03:00
Justin Florentine	855e730577	fix: preserve AIMessage metadata when cleaning thinking content ... Use model_copy() instead of creating new AIMessage to preserve response_metadata, id, usage_metadata, etc. Also adds test coverage for malformed thinking tags pattern. Addresses PR #333 feedback from lfnovo and cubic-dev-ai. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>	2025-12-19 20:08:12 -05:00
Luis Novo	9bdfd99f1b	feat: simplify reverse proxy configuration with Next.js rewrites (#213) ... * feat: simplify reverse proxy configuration with Next.js rewrites Add Next.js API rewrites to proxy /api/* requests internally from port 8502 to the FastAPI backend on port 5055. This eliminates the need for complex reverse proxy configurations with multiple upstreams and location blocks. Changes: - Add rewrites to next.config.ts proxying /api/* to INTERNAL_API_URL - Introduce INTERNAL_API_URL env var (defaults to http://localhost:5055) - Update supervisord configs to pass INTERNAL_API_URL to Next.js - Document INTERNAL_API_URL in .env.example with usage examples - Add simplified reverse proxy examples for nginx, Traefik, Caddy, Coolify - Update README architecture diagram to show internal proxying - Add explanatory comments to _config route handler Benefits: - Reduces reverse proxy config from 12 lines to 3 (75% reduction) - Single-port deployment (8502 only) for 95% of use cases - Zero breaking changes - backward compatible with existing setups - Zero performance overhead (validated through testing) - Preserves proxy headers (X-Forwarded-*) for rate limiting/SSL Resolves: #179 Related: OSS-321 * fix: rename _config to config to fix production routing CRITICAL BUG FIX: The /_config endpoint has never worked in production builds because Next.js treats folders starting with underscore as "private folders" and excludes them from routing entirely. This endpoint is critical for: - Providing API_URL to the browser at runtime - Enabling zero-config deployments with auto-detection - Supporting reverse proxy scenarios where API URL differs from frontend URL Changes: - Rename frontend/src/app/_config/ → frontend/src/app/config/ - Update client code references (/_config → /config) - Update documentation with correct endpoint path - Bump version to 1.1.0 (minor version for new rewrites feature + bug fix) Impact: - Runtime configuration now works in production builds - /config returns {"apiUrl":"http://localhost:5055"} correctly - Auto-detection for reverse proxy deployments now functional Related: #179, OSS-321 * fix: resolve React hook exhaustive-deps warning in AddExistingSourceDialog Wrap performSearch function in useCallback to properly memoize it and satisfy React Hook exhaustive-deps rule. This prevents unnecessary re-renders and ensures the useEffect dependency array is correctly specified. Changes: - Import useCallback from React - Wrap performSearch with useCallback([debouncedSearchQuery, allSources]) - Add performSearch to useEffect dependency array * final fixes	2025-10-24 11:24:14 -03:00
Luis Novo	18b4dfdb77	Claude/add initial tests 011 cukte9g4 qwj hjw7 g3ny rf (#190) ... * test: add comprehensive unit tests for domain module Add 24 comprehensive unit tests covering the open_notebook.domain module: **ObjectModel Base (5 tests)** - Create and update operations with timestamps - Get by ID with class resolution - Delete validation - Relationship creation **RecordModel Singleton (3 tests)** - Singleton pattern behavior - Async database loading - Update persistence **ModelManager (3 tests)** - Singleton pattern - Model instance caching - Default model retrieval **Notebook Domain (3 tests)** - Name validation (empty/whitespace) - Source relationship queries - Archived flag defaults **Source Domain (3 tests)** - Text vectorization and chunking - Insight validation and creation - RecordID command field parsing **Note Domain (2 tests)** - Content validation - Embedding configuration **Podcast Domain (2 tests)** - Speaker profile validation - Episode profile segment validation **Additional Tests (3 tests)** - ChatSession relationships - Transformation creation - ContentSettings defaults All tests use proper mocking to avoid database dependencies and validate both business logic and error handling. Tests follow pytest best practices with async support, fixtures, and comprehensive assertions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * test: add comprehensive tests for utils and graphs modules Add 56 new unit tests covering utils and graphs modules: **Utils Module Tests (36 tests)** Text Utilities (13 tests): - Text splitting with various chunk sizes - ASCII and non-printable character removal - Thinking tag parsing and cleaning (single/multiple tags) - Edge cases (empty strings, invalid input, large content) Token Utilities (4 tests): - Token counting with tiktoken - Cost calculation - Fallback behavior when tiktoken unavailable Version Utilities (7 tests): - Semantic version comparison (equal, less, greater, prerelease) - Installed package version retrieval - GitHub version fetching with URL validation Context Builder (12 tests): - ContextItem and ContextConfig creation - Builder initialization with various parameters - Priority sorting and deduplication - Token-based truncation - Response formatting - Source and notebook context building - Convenience functions **Graphs Module Tests (20 tests)** Model Provisioning (4 tests): - Default model selection - Large context model triggering (>105k tokens) - Specific model ID selection - Kwargs pass-through Tools (3 tests): - Current timestamp format validation - Timestamp validity checking - Tool decoration verification Prompt Graph (5 tests): - PatternChainState structure - Model calling with/without parser - Graph compilation and execution Transformation Graph (8 tests): - TransformationState structure - Transformation with source objects - Transformation with direct input text - Thinking content cleaning - Content validation - Graph compilation and execution - Default prompt integration All tests use proper mocking to avoid external dependencies (network, database) and validate both success paths and error handling. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * improve tests --------- Co-authored-by: Claude <noreply@anthropic.com>	2025-10-21 16:54:59 -03:00