open-code-review/internal
chethanuk c973e581ec
Some checks are pending
CI / test (push) Waiting to run
fix(tool): resolve file_read paths against git top-level in monorepos (#309)
* fix(tool): resolve file_read paths against git top-level in monorepos

ocr review from a monorepo subdirectory failed with "file not found" (#287):
git reports diff and `git show HEAD:<path>` paths relative to the repo root,
but RepoDir was scoped to the invocation subdirectory, producing a double
prefix. resolveWorkingDir now anchors RepoDir at `git rev-parse
--show-toplevel` on the review path (requireGit=true); scan keeps the CWD so
its `git ls-files` walk stays scoped.

The top-level lookup uses a stdout-only git helper so stderr notices can't
pollute the path, and fails loudly if --show-toplevel errors or is empty
(e.g. a bare repo) instead of silently reusing the subdirectory. Adds
regression tests for the subdir hoist, the scan-path scoping, git-show
resolution of root-relative paths, and the bare-repo failure.

* docs(rules): document repo-root rule.json resolution in monorepos

Since #287 anchored RepoDir at the git top-level, ocr review from a
monorepo subdirectory loads the repo-root .opencodereview/rule.json
rather than a subdir-local one. Call out this user-visible behavior at
loadProjectRule so the scope change isn't a surprise (review feedback).
2026-07-07 20:06:28 +08:00
..
agent fix(agent): recover from panics in per-file review and comment-pool goroutines (#171) (#182) 2026-07-01 23:23:12 +08:00
config fix(tool): resolve file_read paths against git top-level in monorepos (#309) 2026-07-07 20:06:28 +08:00
diff test(diff): add tests for gitignore pattern matching and mode getters 2026-07-01 14:27:07 +08:00
gitcmd test: expand unit test coverage for agent, llm, llmloop, and tool packages 2026-06-26 23:09:11 +08:00
llm fix(tui): persist official-tab models and refine saved secret hint (#260) 2026-07-06 20:38:39 +08:00
llmloop fix(agent): recover from panics in per-file review and comment-pool goroutines (#171) (#182) 2026-07-01 23:23:12 +08:00
mcp feat: add standard MCP tool support (#212) 2026-07-01 19:10:16 +08:00
model feat(review): add structured category and severity to findings (#311) 2026-07-07 13:08:41 +08:00
pathutil test: improve coverage for template and pathutil packages 2026-06-27 00:22:30 +08:00
release fix(build): improve Windows support based on PR #13 review feedback 2026-06-02 22:37:27 +08:00
scan fix(session): isolate test sessions to test-sessions subdirectory 2026-06-30 13:23:21 +08:00
session fix(session): isolate test sessions to test-sessions subdirectory 2026-06-30 13:23:21 +08:00
stdout test: add unit tests for output_helpers, config, model, stdout, and telemetry packages 2026-06-26 23:26:49 +08:00
suggestdiff test: add unit tests for pure logic functions across 6 packages 2026-06-26 22:41:35 +08:00
telemetry fix(telemetry): support http:// scheme in otlp_endpoint for insecure gRPC (#280) 2026-07-03 11:26:03 +08:00
tool fix(tool): resolve file_read paths against git top-level in monorepos (#309) 2026-07-07 20:06:28 +08:00
viewer feat(viewer): make human readable token usage for session (#278) 2026-07-03 12:01:46 +08:00