vrr/open-code-review
2
0
Fork 0
mirror of https://github.com/alibaba/open-code-review.git synced 2026-08-21 06:34:29 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

refactor(agent): rename file_metadata_table to file_list

Browse source 
The placeholder renders a plain one-per-line list, not a table.
The old name misleadingly suggests markdown table formatting.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
kite 2026-08-10 19:53:09 +08:00
parent 3370be62e6
commit bb54dbefce
3 changed files with 8 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

6
internal/agent/grouping.go
View file

@ -64,11 +64,11 @@ func callGroupingLLM(ctx context.Context, diffs []model.Diff, client llm.LLMClie
}
}()
table := buildFileMetadataTable(diffs)
fileList := buildFileList(diffs)
messages := make([]llm.Message, 0, len(task.Messages))
for _, m := range task.Messages {
content := strings.ReplaceAll(m.Content, "{{file_metadata_table}}", table)
content := strings.ReplaceAll(m.Content, "{{file_list}}", fileList)
messages = append(messages, llm.NewTextMessage(m.Role, content))
}
@ -92,7 +92,7 @@ func callGroupingLLM(ctx context.Context, diffs []model.Diff, client llm.LLMClie
return groups, usage, err
}
func buildFileMetadataTable(diffs []model.Diff) string {
func buildFileList(diffs []model.Diff) string {
var sb strings.Builder
for _, d := range diffs {
status := "MODIFIED"

8
internal/agent/grouping_test.go
View file

@ -236,7 +236,7 @@ func TestGroupDiffs_LLMError_Fallback(t *testing.T) {
client := &fakeGroupingClient{err: fmt.Errorf("connection refused")}
tpl := template.Template{
GroupingTask: &template.LlmConversation{
Messages: []template.ChatMessage{{Role: "user", Content: "{{file_metadata_table}}"}},
Messages: []template.ChatMessage{{Role: "user", Content: "{{file_list}}"}},
},
}
result := groupDiffs(context.Background(), diffs, client, "fake", tpl, 0)
@ -252,7 +252,7 @@ func TestGroupDiffs_LLMSuccess(t *testing.T) {
}
tpl := template.Template{
GroupingTask: &template.LlmConversation{
Messages: []template.ChatMessage{{Role: "user", Content: "{{file_metadata_table}}"}},
Messages: []template.ChatMessage{{Role: "user", Content: "{{file_list}}"}},
},
}
result := groupDiffs(context.Background(), diffs, client, "fake", tpl, 0)
@ -271,7 +271,7 @@ func TestCallGroupingLLM_EmptyResponse(t *testing.T) {
diffs := []model.Diff{{NewPath: "a.go"}}
client := &fakeGroupingClient{response: ""}
task := &template.LlmConversation{
Messages: []template.ChatMessage{{Role: "user", Content: "{{file_metadata_table}}"}},
Messages: []template.ChatMessage{{Role: "user", Content: "{{file_list}}"}},
}
_, _, err := callGroupingLLM(context.Background(), diffs, client, "fake", task)
if err == nil {
@ -284,7 +284,7 @@ func TestBuildFileMetadataTable(t *testing.T) {
{NewPath: "a.go", IsNew: true, Insertions: 10, Deletions: 0},
{NewPath: "b.go", IsDeleted: true, Insertions: 0, Deletions: 5},
}
table := buildFileMetadataTable(diffs)
table := buildFileList(diffs)
if !contains(table, "ADDED") || !contains(table, "DELETED") {
t.Errorf("table missing status:\n%s", table)
}

2
internal/config/template/prompts/grouping_task_user.md
View file

@ -1,6 +1,6 @@
Group the following changed files:
{{file_metadata_table}}
{{file_list}}
Respond with a JSON array:
[{"label": "short theme description", "files": ["path1", "path2"]}]