vrr/open-code-review
2
0
Fork 0
mirror of https://github.com/alibaba/open-code-review.git synced 2026-07-10 01:39:12 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(rules): align test expectations with English rule docs and isolate global config

Browse source 
Rule doc files were translated from Chinese to English but tests still
expected Chinese substrings. Also added HOME isolation to prevent the
user's ~/.opencodereview/rule.json from interfering with system-default
rule assertions.
This commit is contained in:
kite 2026-06-06 17:22:07 +08:00
parent 7d75c3a9d3
commit aa86d9fa60
1 changed files with 14 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

26
internal/config/rules/system_rules_test.go
View file

@ -57,23 +57,23 @@ func TestResolve_DefaultRules(t *testing.T) {
path string
wantSubstr string // substring that should appear in the matched rule
}{
{"src/main/java/com/example/foo.java", "逻辑错误识别"},
{"foo.java", "逻辑错误识别"},
{"src/main/resources/mapper/usermapper.xml", "SQL逻辑错误识别"},
{"src/main/resources/dao/userdao.xml", "SQL逻辑错误识别"},
{"src/main/java/com/example/foo.java", "Logic Error Detection"},
{"foo.java", "Logic Error Detection"},
{"src/main/resources/mapper/usermapper.xml", "SQL Logic Error Detection"},
{"src/main/resources/dao/userdao.xml", "SQL Logic Error Detection"},
{"pom.xml", "snapshot"},
{"submodule/pom.xml", "snapshot"},
{"src/main/resources/application.properties", "配置错误识别"},
{"src/main/resources/application.properties", "Configuration Error Detection"},
{"frontend/package.json", "latest"},
{"config/app.yaml", "yaml-key"},
{"deploy/values.yml", "yaml-key"},
{"src/components/app.tsx", "React"},
{"lib/utils.ts", "TypeScript"},
{"app.kt", "空安全"},
{"src/main/handler.cpp", "智能指针"},
{"app.kt", "Null Safety"},
{"src/main/handler.cpp", "Smart Pointer"},
{"driver.c", "malloc"},
{"pages/Index.ets", "状态装饰器"},
{"components/Button.ets", "状态装饰器"},
{"pages/Index.ets", "State Decorator"},
{"components/Button.ets", "State Decorator"},
{"entry/src/main/module.json5", "json-key"},
{"entry/oh-package.json5", "json-key"},
}
@ -180,13 +180,14 @@ func truncate(s string, maxLen int) string {
}
func TestNewResolver_DefaultOnly(t *testing.T) {
t.Setenv("HOME", t.TempDir())
resolver, _, err := NewResolver(t.TempDir(), "")
if err != nil {
t.Fatalf("NewResolver: %v", err)
}
got := resolver.Resolve("src/main.java")
if !strings.Contains(got, "逻辑错误识别") {
if !strings.Contains(got, "Logic Error Detection") {
t.Errorf("expected system default java rule, got %q", truncate(got, 80))
}
}
@ -204,6 +205,7 @@ func TestNewResolver_ProjectFileMissing(t *testing.T) {
}
func TestNewResolver_ProjectRuleHighestPriority(t *testing.T) {
t.Setenv("HOME", t.TempDir())
dir := t.TempDir()
ocrDir := filepath.Join(dir, ".opencodereview")
if err := os.MkdirAll(ocrDir, 0o755); err != nil {
@ -224,7 +226,7 @@ func TestNewResolver_ProjectRuleHighestPriority(t *testing.T) {
want string
}{
{"force-api/src/foo.java", "project-java-rule"},
{"other/src/bar.java", "逻辑错误识别"},
{"other/src/bar.java", "Logic Error Detection"},
}
for _, tt := range tests {
t.Run(tt.path, func(t *testing.T) {
@ -559,7 +561,7 @@ func TestResolveDetail_SystemPatternMatch(t *testing.T) {
if detail.Pattern != "**/*.java" {
t.Errorf("expected pattern '**/*.java', got %q", detail.Pattern)
}
if !strings.Contains(detail.Rule, "逻辑错误识别") {
if !strings.Contains(detail.Rule, "Logic Error Detection") {
t.Errorf("expected java rule, got %q", truncate(detail.Rule, 80))
}
}