vrr/open-code-review
2
0
Fork 0
mirror of https://github.com/alibaba/open-code-review.git synced 2026-07-09 17:28:58 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix: correct auth_header test to expect rejection of unsupported values

Browse source 
NormalizeAuthHeader only accepts "x-api-key" and "authorization". The
test was incorrectly expecting custom headers to be accepted and trimmed.
This commit is contained in:
kite 2026-06-09 22:24:16 +08:00
parent dd0ebd905e
commit 7fcb9db6a3
1 changed files with 3 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

10
cmd/opencodereview/config_cmd_test.go
View file

@ -14,14 +14,10 @@ func TestSetConfigValueAuthHeaderNormalizesKnownValues(t *testing.T) {
}
}
func TestSetConfigValueAuthHeaderTrimsCustomHeader(t *testing.T) {
func TestSetConfigValueAuthHeaderRejectsCustomHeader(t *testing.T) {
cfg := &Config{}
if err := setConfigValue(cfg, "llm.auth_header", " X-Custom-Auth "); err != nil {
t.Fatalf("setConfigValue: %v", err)
}
if cfg.Llm.AuthHeader != "X-Custom-Auth" {
t.Errorf("AuthHeader = %q, want %q", cfg.Llm.AuthHeader, "X-Custom-Auth")
if err := setConfigValue(cfg, "llm.auth_header", " X-Custom-Auth "); err == nil {
t.Fatal("expected error for unsupported auth_header, got nil")
}
}