From 4d7895db979e9dfd272b5e33e074f60cd99d966a Mon Sep 17 00:00:00 2001 From: kite Date: Sat, 22 Aug 2026 19:40:49 +0800 Subject: [PATCH] feat(config): raise MAX_TOOL_REQUEST_TIMES to 100, minMaxTools to 50 Grouped file review needs more tool call rounds than single-file mode since one RunPerFile call now serves multiple files. Raise the default from 30 to 100 and the user-configurable minimum from 10 to 50. --- cmd/opencodereview/flags_test.go | 6 +++--- cmd/opencodereview/shared_flags.go | 2 +- internal/config/template/task_template.json | 2 +- internal/config/template/template_test.go | 4 ++-- 4 files changed, 7 insertions(+), 7 deletions(-) diff --git a/cmd/opencodereview/flags_test.go b/cmd/opencodereview/flags_test.go index 3a9a4db..cf13d43 100644 --- a/cmd/opencodereview/flags_test.go +++ b/cmd/opencodereview/flags_test.go @@ -80,12 +80,12 @@ func TestParseReviewFlags_NegativeMaxTools(t *testing.T) { } func TestParseReviewFlags_MaxToolsBelowMin(t *testing.T) { - opts, err := parseReviewFlags([]string{"--max-tools", "5"}) + opts, err := parseReviewFlags([]string{"--max-tools", "30"}) if err != nil { t.Fatalf("unexpected error: %v", err) } - if opts.maxTools != 10 { - t.Errorf("maxTools = %d, want 10 (clamped to min)", opts.maxTools) + if opts.maxTools != 50 { + t.Errorf("maxTools = %d, want 50 (clamped to min)", opts.maxTools) } } diff --git a/cmd/opencodereview/shared_flags.go b/cmd/opencodereview/shared_flags.go index fd58242..047a4b0 100644 --- a/cmd/opencodereview/shared_flags.go +++ b/cmd/opencodereview/shared_flags.go @@ -112,7 +112,7 @@ func validateReviewOptions(opts *reviewOptions) error { if err := validateAudience(opts.audience); err != nil { return err } - const minMaxTools = 10 + const minMaxTools = 50 if opts.maxTools < 0 { return fmt.Errorf("--max-tools must be a non-negative integer (0 means use template default)") } diff --git a/internal/config/template/task_template.json b/internal/config/template/task_template.json index 897db9d..4d8bccc 100644 --- a/internal/config/template/task_template.json +++ b/internal/config/template/task_template.json @@ -35,7 +35,7 @@ { "role": "user", "prompt_file": "grouping_task_user.md" } ] }, - "MAX_TOOL_REQUEST_TIMES": 30, + "MAX_TOOL_REQUEST_TIMES": 100, "PLAN_MODE_LINE_THRESHOLD": 50, "MAX_REVIEW_ROUNDS": 2, "MAX_TOKENS": 58888 diff --git a/internal/config/template/template_test.go b/internal/config/template/template_test.go index e251fa6..e56ccaf 100644 --- a/internal/config/template/template_test.go +++ b/internal/config/template/template_test.go @@ -99,8 +99,8 @@ func TestLoadDefault_FieldsPopulated(t *testing.T) { if tpl.MaxTokens != 58888 { t.Errorf("MaxTokens = %d, want 58888", tpl.MaxTokens) } - if tpl.MaxToolRequestTimes != 30 { - t.Errorf("MaxToolRequestTimes = %d, want 30", tpl.MaxToolRequestTimes) + if tpl.MaxToolRequestTimes != 100 { + t.Errorf("MaxToolRequestTimes = %d, want 100", tpl.MaxToolRequestTimes) } if tpl.PlanModeLineThreshold != 50 { t.Errorf("PlanModeLineThreshold = %d, want 50", tpl.PlanModeLineThreshold)