From 0a7d14e453e93631e32336d42d3da34466bda4a8 Mon Sep 17 00:00:00 2001 From: kite Date: Mon, 15 Jun 2026 15:32:53 +0800 Subject: [PATCH] fix: remove duplicate kimi provider and fix test locale Remove the duplicate kimi provider entry introduced by overlapping PRs (#130 and #134). Keep the Kimi Moonshot API entry with MOONSHOT_API_KEY. Set LC_ALL=C in Makefile test target to ensure git outputs English messages regardless of system locale. --- Makefile | 2 +- internal/llm/providers.go | 12 ------------ internal/llm/providers_test.go | 2 +- 3 files changed, 2 insertions(+), 14 deletions(-) diff --git a/Makefile b/Makefile index ae5df94..4ce0451 100644 --- a/Makefile +++ b/Makefile @@ -30,7 +30,7 @@ build: $(GO) build -ldflags "$(LD_FLAGS)" -o $(DIST_DIR)/$(BINARY_NAME) ./cmd/opencodereview test: - $(GO) test -v -race -count=1 ./... + LC_ALL=C $(GO) test -v -race -count=1 ./... clean: rm -rf $(DIST_DIR) diff --git a/internal/llm/providers.go b/internal/llm/providers.go index 86e532e..6f9bc77 100644 --- a/internal/llm/providers.go +++ b/internal/llm/providers.go @@ -130,18 +130,6 @@ var registry = []Provider{ "MiniMax-M2.5-highspeed", }, }, - { - Name: "kimi", - DisplayName: "Kimi API", - Protocol: "openai", - BaseURL: "https://api.moonshot.cn/v1", - EnvVar: "KIMI_API_KEY", - Models: []string{ - "kimi-k2.5", - "kimi-k2.6", - "kimi-k2.7-code", - }, - }, } var registryMap map[string]Provider diff --git a/internal/llm/providers_test.go b/internal/llm/providers_test.go index a813caa..d10d4e1 100644 --- a/internal/llm/providers_test.go +++ b/internal/llm/providers_test.go @@ -40,7 +40,7 @@ func TestListProviders_Order(t *testing.T) { if len(providers) < 3 { t.Fatalf("expected at least 3 providers, got %d", len(providers)) } - expected := []string{"anthropic", "dashscope", "deepseek", "kimi", "mimo", "minimax", "openai", "z-ai"} + expected := []string{"anthropic", "dashscope", "deepseek", "kimi", "mimo", "minimax", "openai", "volcengine", "z-ai"} if len(providers) != len(expected) { t.Fatalf("expected %d providers, got %d", len(expected), len(providers)) }