vrr/ntopng
2
0
Fork 0
mirror of https://github.com/ntop/ntopng.git synced 2026-08-31 18:04:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3
ntopng/include
History
Ivan Nardi 5fcb49ce2f
Initial fixes for e2e REST test flakiness (#10814) 
Root causes, found while debugging non-reproducible e2e test failures
(tests/e2e/rest):

1. PcapInterface.cpp: the pre-script hot-reload wait used a fixed
   `sleep(housekeeping_frequency * 2)` after running the pre script,
   guessing that checks/host-checks/alert-exclusions reload would be
   applied in time. Replaced with a poll on the actual reload-pending
   flags (now exposed via `isFlowChecksReloadPending()` /
   `isHostChecksReloadPending()` / `isAlertExclusionsReloadPending()`),
   bounded by a generous timeout. Returns immediately when no reload
   was requested.

2. Ntop.cpp checkShutdownWhenDone(): the runtime/post test scripts
   were preceded by fixed `sleep()` calls hoping pending
   alert notifications had been dequeued/dispatched. Replaced with
   `waitRecipientsQueuesDrained()`, which polls `recipients_are_empty()`
   (requiring two consecutive empty reads to close the dequeue-vs-
   persist window) instead of guessing a duration.

3. checkShutdownWhenDone() gated pcap-interface completion on
   `read_from_pcap_dump_done()` (packets fully read) instead of
   `pcap_dump_processing_done()` (packets read AND flow-end housekeeping
   - which runs flow-end checks - fully executed). For pcaps with
   little other flow activity this let the runtime/post scripts and
   shutdown proceed before the last flows had actually been checked,
   silently dropping alerts.

4. Hardened `flowChecksReloadInProgress` / `hostChecksReloadInProgress` /
   `alertExclusionsReloadInProgress` to `std::atomic<bool>`: they are
   written from an HTTP-handler Lua VM thread, read from the poller
   thread, and cleared from the main thread.

There are still some issues with a a few tests, likely depending
on runtime script timing.
2026-08-24 15:16:39 +02:00
..
flow_alerts Code format 2026-03-15 10:50:50 +01:00
flow_checks Fixes blacklisted country alert not working with view interfaces (#10183) 2026-04-07 10:07:06 +00:00
host_alerts Implemented VPN detection alert (#10344) 2026-05-12 12:47:02 +02:00
host_checks Code format 2026-03-15 10:50:50 +01:00
ActiveHostWalkerInfo.h Update (c) 2026-01-02 09:11:30 +01:00
AddressResolution.h Code format 2026-03-15 10:50:50 +01:00
AddressTree.h Add option to disable address tree lock if not required 2026-04-16 16:12:50 +02:00
AggregatedFlowsStats.h Added Location and Site filters to flows aggregated by host (#10708) 2026-08-06 15:06:07 +02:00
Alert.h Update (c) 2026-01-02 09:11:30 +01:00
AlertableEntity.h Code format 2026-03-15 10:50:50 +01:00
AlertCounter.h Code format 2026-03-15 10:50:50 +01:00
AlertFifoItem.h Rename labels to tags to avoid confusion as labels was too common. (note: tag filters are now flowfilters) 2026-05-12 11:43:07 +02:00
AlertFifoQueue.h Code format 2026-03-15 10:50:50 +01:00
AlertsQueue.h Code format 2026-03-15 10:50:50 +01:00
ASNConfiguration.h Code format 2026-03-15 10:50:50 +01:00
ASNStats.h Reworked SNMO interface roles in flows 2026-08-14 12:46:26 +02:00
AutonomousSystem.h Typo 2026-07-29 23:39:21 +02:00
AutonomousSystemHash.h Code format 2026-03-15 10:50:50 +01:00
BehaviouralCounter.h Code format 2026-03-15 10:50:50 +01:00
BGPPrefixListener.h Improved BGP listerner integration 2026-05-21 23:55:07 +02:00
Bitmap.h Store labels in historical flows and show them in the flow list 2026-04-28 12:51:24 +02:00
Bitmap64.h Store labels in historical flows and show them in the flow list 2026-04-28 12:51:24 +02:00
Bitmap128.h Update (c) 2026-01-02 09:11:30 +01:00
Bitmap4096.h Update (c) 2026-01-02 09:11:30 +01:00
Bitmask.h Code format 2026-03-15 10:50:50 +01:00
BlacklistStats.h Code format 2026-03-15 10:50:50 +01:00
BlacklistUsageStats.h Code format 2026-03-15 10:50:50 +01:00
Bloom.h Code format 2026-03-15 10:50:50 +01:00
BroadcastDomains.h Code format 2026-03-15 10:50:50 +01:00
Cardinality.h Code format 2026-03-15 10:50:50 +01:00
CategoryCounter.h Code format 2026-03-15 10:50:50 +01:00
Check.h Code format 2026-03-15 10:50:50 +01:00
ChecksLoader.h Update (c) 2026-01-02 09:11:30 +01:00
CHTimeseriesExporter.h Rework clickhouse timeseries dump queue (use C++ struct rather than strings, native CH block insert, increase batch size) 2026-07-23 17:24:33 +02:00
CHTSPoint.h Add ifid and ntopng_instance_name to CH timeseries table. Add ifid migration from tags for old data. 2026-08-11 15:59:46 +02:00
CHTSPointFifoQueue.h Rework clickhouse timeseries dump queue (use C++ struct rather than strings, native CH block insert, increase batch size) 2026-07-23 17:24:33 +02:00
Condvar.h Code format 2026-03-15 10:50:50 +01:00
ContainerStats.h Update (c) 2026-01-02 09:11:30 +01:00
ContinuousPing.h Code format 2026-03-15 10:50:50 +01:00
ContinuousPingStats.h Code format 2026-03-15 10:50:50 +01:00
CountriesHash.h Code format 2026-03-15 10:50:50 +01:00
Country.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
DB.h Rework clickhouse timeseries dump queue (use C++ struct rather than strings, native CH block insert, increase batch size) 2026-07-23 17:24:33 +02:00
DESCounter.h Code format 2026-03-15 10:50:50 +01:00
DnsStats.h Code format 2026-03-15 10:50:50 +01:00
DoHDoTStats.h Code format 2026-03-15 10:50:50 +01:00
DSCPStats.h Code format 2026-03-15 10:50:50 +01:00
DummyInterface.h Update (c) 2026-01-02 09:11:30 +01:00
ElasticSearch.h Code format 2026-03-15 10:50:50 +01:00
EthStats.h Code format 2026-03-15 10:50:50 +01:00
FifoQueue.h Code format 2026-03-15 10:50:50 +01:00
FifoSerializerQueue.h Update (c) 2026-01-02 09:11:30 +01:00
Fingerprint.h Code format 2026-03-15 10:50:50 +01:00
Flow.h Add application latency column consistent with network latency 2026-08-21 10:17:31 +02:00
flow_alerts_includes.h Implementation of the SlowDoS alert structure (#9962) 2026-01-17 10:57:31 +01:00
flow_checks_includes.h Implementation of the SlowDoS alert structure (#9962) 2026-01-17 10:57:31 +01:00
FlowAlert.h Code format 2026-03-15 10:50:50 +01:00
FlowAlertsLoader.h Update (c) 2026-01-02 09:11:30 +01:00
FlowCheck.h Code format 2026-03-15 10:50:50 +01:00
FlowChecksExecutor.h Code format 2026-03-15 10:50:50 +01:00
FlowChecksLoader.h Code format 2026-03-15 10:50:50 +01:00
FlowDB.h Code format 2026-03-15 10:50:50 +01:00
FlowGrouper.h Code format 2026-03-15 10:50:50 +01:00
FlowHash.h Code format 2026-03-15 10:50:50 +01:00
FlowRiskAlerts.h Update (c) 2026-01-02 09:11:30 +01:00
FlowsHostInfo.h Code format 2026-03-15 10:50:50 +01:00
FlowStats.h Added flow risk filter 2026-07-27 19:46:39 +02:00
FlowTrafficStats.h Code format 2026-03-15 10:50:50 +01:00
FrequentStringItems.h Update (c) 2026-01-02 09:11:30 +01:00
GenericHash.h Code format 2026-03-15 10:50:50 +01:00
GenericHashEntry.h Code format 2026-03-15 10:50:50 +01:00
GenericTrafficElement.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
Geolocation.h Add AS information to the database from geoip/as.csv when available. Cache the information on redis. Use RIPE service as last resort. 2026-06-09 10:36:54 +02:00
Host.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
host_alerts_includes.h Implemented VPN detection alert (#10344) 2026-05-12 12:47:02 +02:00
host_checks_includes.h Implemented VPN detection alert (#10344) 2026-05-12 12:47:02 +02:00
HostAlert.h Code format 2026-03-15 10:50:50 +01:00
HostAlertableEntity.h Code format 2026-03-15 10:50:50 +01:00
HostCheck.h Code format 2026-03-15 10:50:50 +01:00
HostChecksExecutor.h Code format 2026-03-15 10:50:50 +01:00
HostChecksLoader.h Update (c) 2026-01-02 09:11:30 +01:00
HostChecksStatus.h Code format 2026-03-15 10:50:50 +01:00
HostDetails.h Code format 2026-03-15 10:50:50 +01:00
HostHash.h Code format 2026-03-15 10:50:50 +01:00
HostPools.h Code format 2026-03-15 10:50:50 +01:00
HostPoolStats.h Code format 2026-03-15 10:50:50 +01:00
HostsPorts.h Code format 2026-03-15 10:50:50 +01:00
HostsPortsAnalysis.h Code format 2026-03-15 10:50:50 +01:00
HostStats.h Added local traffic timeseries 2026-07-25 15:43:37 +02:00
HTTPserver.h Code format 2026-03-15 10:50:50 +01:00
HTTPstats.h Code format 2026-03-15 10:50:50 +01:00
ICMPinfo.h Code format 2026-03-15 10:50:50 +01:00
ICMPstats.h Code format 2026-03-15 10:50:50 +01:00
IEC104Stats.h Code format 2026-03-15 10:50:50 +01:00
InfluxDBTimeseriesExporter.h Code format 2026-03-15 10:50:50 +01:00
InMemorySQLiteDB.h Code format 2026-03-15 10:50:50 +01:00
InterarrivalStats.h Code format 2026-03-15 10:50:50 +01:00
InterfaceMemberAlertableEntity.h Code format 2026-03-15 10:50:50 +01:00
InterfaceStatsHash.h Code format 2026-03-15 10:50:50 +01:00
IpAddress.h Added ability to set IPv6 addresses as IPv4 when the IP is IPv4-over-IPv6 2026-08-11 15:04:15 +02:00
JobQueue.h Code format 2026-03-15 10:50:50 +01:00
L4Stats.h Removed dead code 2025-10-03 07:21:52 +02:00
ListeningPorts.h Code format 2026-03-15 10:50:50 +01:00
LocalHost.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
LocalHostStats.h Added local traffic timeseries 2026-07-25 15:43:37 +02:00
LocalTrafficStats.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
LuaEngine.h Fix per interface periodic activitis stats (ThreadedActivity::lua was ignoring the selected interface). Add script path to the context to know which script is actually running. 2026-08-12 09:17:39 +02:00
LuaEngineFunctions.h Update (c) 2026-01-02 09:11:30 +01:00
Mac.h Fixed Unexpected Gateway check (#10561) 2026-07-14 09:42:48 +02:00
MacHash.h Update (c) 2026-01-02 09:11:30 +01:00
MacManufacturers.h Code format 2026-03-15 10:50:50 +01:00
MacStats.h Code format 2026-03-15 10:50:50 +01:00
MDNS.h Code format 2026-03-15 10:50:50 +01:00
MostVisitedList.h Code format 2026-03-15 10:50:50 +01:00
Mutex.h Code format 2026-03-15 10:50:50 +01:00
nDPIStats.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
NetworkDiscovery.h Code format 2026-03-15 10:50:50 +01:00
NetworkInterface.h Reworked ACLs 2026-08-06 16:23:16 +02:00
NetworkInterfaceAlertableEntity.h Code format 2026-03-15 10:50:50 +01:00
NetworkStats.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
nProbeStats.h Changes for implementing full IPv6 Support in Flow Exporters (#10325) 2026-05-06 00:28:22 +02:00
Ntop.h Initial fixes for e2e REST test flakiness (#10814) 2026-08-24 15:16:39 +02:00
ntop_defines.h Force ZMQ encryption on fresh installations. Add a toasts to warn the user. 2026-08-20 11:38:59 +02:00
ntop_flow.h Changed modbus, s7comm and profinet mapping 2026-06-19 08:35:12 +00:00
ntop_includes.h Improved sist stats 2026-08-06 23:27:20 +02:00
ntop_typedefs.h Added cacheing updates variable for GUI 2026-08-12 09:57:19 +00:00
ntop_win32.h Win changes 2026-06-21 11:08:30 +02:00
NtopGlobals.h Code format 2026-03-15 10:50:50 +01:00
NtopngLuaContext.h Implemented ntop.forceHTTPSsecure() 2026-08-14 15:58:32 +02:00
ObservationPoint.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
ObservationPointHash.h Update (c) 2026-01-02 09:11:30 +01:00
ObservationPointIdTrafficStats.h Update (c) 2026-01-02 09:11:30 +01:00
OtherAlertableEntity.h Code format 2026-03-15 10:50:50 +01:00
PacketDumper.h Code format 2026-03-15 10:50:50 +01:00
PacketDumperGeneric.h Update (c) 2026-01-02 09:11:30 +01:00
PacketDumperTuntap.h Code format 2026-03-15 10:50:50 +01:00
PacketStats.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
Paginator.h Fixes exporter interface index filter not working 2026-08-11 11:12:52 +00:00
ParsedeBPF.h Code format 2026-03-15 10:50:50 +01:00
ParsedFlow.h Reworked next_hop/exporter_ip (#10714) 2026-08-09 13:21:13 +02:00
ParsedFlowCore.h Reworked flow exporters implementation 2026-08-10 21:26:17 +02:00
ParserInterface.h Reworked SNMO interface roles in flows 2026-08-14 12:46:26 +02:00
PartializableFlowTrafficStats.h Code format 2026-03-15 10:50:50 +01:00
PcapInterface.h Experimental host code 2026-05-03 20:05:41 +02:00
PeerStats.h Update (c) 2026-01-02 09:11:30 +01:00
PeriodicActivities.h Implemented oneshot callback that run forever sicne boot 2026-07-15 21:20:14 +02:00
PeriodicScript.h Code format 2026-03-15 10:50:50 +01:00
PF_RINGInterface.h Code format 2026-03-15 10:50:50 +01:00
Ping.h Code format 2026-03-15 10:50:50 +01:00
PortDetails.h Code format 2026-03-15 10:50:50 +01:00
Prefs.h Add pref for CH ts queue/batch size 2026-08-10 16:40:54 +02:00
ProtoCounter.h Code format 2026-03-15 10:50:50 +01:00
ProtoStats.h Code format 2026-03-15 10:50:50 +01:00
QueuedThreadData.h Code format 2026-03-15 10:50:50 +01:00
Radius.h Code format 2026-03-15 10:50:50 +01:00
RecipientQueue.h Rename labels to tags to avoid confusion as labels was too common. (note: tag filters are now flowfilters) 2026-05-12 11:43:07 +02:00
Recipients.h Rename labels to tags to avoid confusion as labels was too common. (note: tag filters are now flowfilters) 2026-05-12 11:43:07 +02:00
Redis.h Replaced static with dynamic memory with lpop/rpop 2026-08-16 23:25:21 +02:00
RedisStub.h Fixed prototype 2026-08-17 21:45:35 +02:00
RemoteHost.h Code format 2026-03-15 10:50:50 +01:00
RoundTripStats.h Code format 2026-03-15 10:50:50 +01:00
RRDTimeseriesExporter.h Code format 2026-03-15 10:50:50 +01:00
RwLock.h Code format 2026-03-15 10:50:50 +01:00
Score.h Update (c) 2026-01-02 09:11:30 +01:00
ScoreCounter.h Code format 2026-03-15 10:50:50 +01:00
ScoreStats.h Code format 2026-03-15 10:50:50 +01:00
ServerConfiguration.h Code format 2026-03-15 10:50:50 +01:00
ServerPortsBitmap.h Code format 2026-03-15 10:50:50 +01:00
sFlowPktInterface.h Code format 2026-03-15 10:50:50 +01:00
SNMP.h Code format 2026-03-15 10:50:50 +01:00
SNMPSession.h Update (c) 2026-01-02 09:11:30 +01:00
SPSCQueue.h Code format 2026-03-15 10:50:50 +01:00
SQLiteDB.h Code format 2026-03-15 10:50:50 +01:00
SQLiteStoreManager.h Mark override 2026-03-26 18:45:28 +01:00
StatsManager.h Code format 2026-03-15 10:50:50 +01:00
StringFifoQueue.h Code format 2026-03-15 10:50:50 +01:00
SyslogCollectorInterface.h Code format 2026-03-15 10:50:50 +01:00
SyslogDump.h Code format 2026-03-15 10:50:50 +01:00
SyslogLuaEngine.h Code format 2026-03-15 10:50:50 +01:00
SyslogParserInterface.h Add support for RFC 5424 format (fix #10679) 2026-08-03 16:24:29 +02:00
SyslogStats.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
TagsConfiguration.h Rename labels to tags to avoid confusion as labels was too common. (note: tag filters are now flowfilters) 2026-05-12 11:43:07 +02:00
TcpFlowStats.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
TcpPacketStats.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
ThreadedActivity.h Fix per interface periodic activitis stats (ThreadedActivity::lua was ignoring the selected interface). Add script path to the context to know which script is actually running. 2026-08-12 09:17:39 +02:00
ThreadedActivityStats.h Fixed usge stats: TS written and SNMP devices polled 2026-07-17 19:23:42 +02:00
ThreadPool.h Code format 2026-03-15 10:50:50 +01:00
ThroughputStats.h Code format 2026-03-15 10:50:50 +01:00
TimelineExtract.h Code format 2026-03-15 10:50:50 +01:00
TimeseriesExporter.h Rework clickhouse timeseries dump queue (use C++ struct rather than strings, native CH block insert, increase batch size) 2026-07-23 17:24:33 +02:00
Trace.h Add TLS support for Redis (#10287) 2026-04-20 10:02:41 +02:00
TrafficCounter.h Code format 2026-03-15 10:50:50 +01:00
TrafficStats.h Cleanup unused serialize() methods 2026-08-05 11:13:11 +02:00
UintBitmap.h Code format 2026-03-15 10:50:50 +01:00
UsedPorts.h Code format 2026-03-15 10:50:50 +01:00
UserActivityStats.h Update (c) 2026-01-02 09:11:30 +01:00
Utils.h Changes for handling inscure TLS 2026-08-11 19:22:57 +02:00
ViewScoreStats.h Code format 2026-03-15 10:50:50 +01:00
VirtualHost.h Code format 2026-03-15 10:50:50 +01:00
VirtualHostHash.h Code format 2026-03-15 10:50:50 +01:00
VLAN.h Type fixes (16 -> 32 bit) 2026-03-16 12:40:56 +01:00
VLANAddressTree.h Change VLANAddressTree to use 64-bit values (same as AddressTree) 2026-04-17 12:31:34 +02:00
VLANHash.h Update (c) 2026-01-02 09:11:30 +01:00
ZCCollectorInterface.h Code format 2026-03-15 10:50:50 +01:00
ZMQCollectorInterface.h ZMQ improvements 2026-07-04 00:51:45 +02:00
ZMQParserInterface.h ZMQ improvements 2026-07-04 00:51:45 +02:00
ZMQPublisher.h Code format 2026-03-15 10:50:50 +01:00
ZMQUtils.h Code format 2026-03-15 10:50:50 +01:00