Commit graph

3722 commits

Author SHA1 Message Date
emanuele-f
d21681592a Update counters each minute and other changes 2016-08-16 01:39:41 +02:00
Luca Deri
d85555296f Minor code cleanup 2016-08-15 11:52:07 +02:00
Simone Mainardi
12f24a87b4 Implements stateful alerts in C and sqlite 2016-08-11 19:56:49 +02:00
Simone Mainardi
781b3d4988 Improves y-axis labels in community historical graphs
fixes #682
2016-08-11 11:42:22 +02:00
Luca Deri
a3d36634e3 Code cleanup 2016-08-10 15:53:39 +02:00
Luca Deri
cc78c4f37e Various script fixes 2016-08-10 15:06:17 +02:00
Simone Mainardi
9cf1866e2f Fixes an error in community mode (due to NetworkInterfaceView removal)
WARNING: Script failure [/Users/simone/code/ntopng/scripts/lua/iface_hosts_list.lua][/Users/simone/code/ntopng/scripts/lua/modules/lua_utils.lua:164: attempt to get length of local 'h' (a nil value)]
2016-08-10 14:58:09 +02:00
Luca Deri
34dee98540 Fixed top talkers hosts 2016-08-10 13:00:52 +02:00
Simone Mainardi
116ffda7c8 Additional fixes after removal of NetworkInterfaceView 2016-08-10 12:23:14 +02:00
Simone Mainardi
12aa4c7399 Fixes after removal of the NetworkInterfaceView code 2016-08-10 11:21:08 +02:00
Luca
fdf1384081 Fixes after merge 2016-08-10 09:46:05 +02:00
Luca
bcadcf033f Removed view interface (work in progress will be reintroduced after cleanup) 2016-08-10 09:37:10 +02:00
Simone Mainardi
431b0d96ed Implements a function to obtain suppressed alerts redis keys 2016-08-09 19:17:42 +02:00
Simone Mainardi
b9b22593f4 Removes a debug table print 2016-08-09 18:26:32 +02:00
Simone Mainardi
0b1f12f928 Improves jsonencode function 2016-08-09 18:17:39 +02:00
Simone Mainardi
52abb7659a Handles per-interface alerts via the AlertsManager
This commit moves the global ntopng-wide alerts to
interfaces' AlertsManager s
2016-08-09 16:47:36 +02:00
Simone Mainardi
246c58c1ac Implements stateful threshold host alerts 2016-08-08 16:53:45 +02:00
Simone Mainardi
42b588be48 Adds the new lua alerts API 2016-08-05 19:12:57 +02:00
Simone Mainardi
199b418037 Implements db-based new generation alerts with lua API (wip) 2016-08-05 19:11:34 +02:00
Simone Mainardi
770bc4c6fc Security Fix: users enumeration
A user reported us

"""
I would like to report a possible security issue in ntopng.

When connected with a regular, unprivileged user, it is possible to force-navigate to the URL: http://192.168.2.176:3000/lua/admin/validate_new_user.lua?user=<anyuser>&networks=0.0.0.0/0,::/0
Due to this, it is possible to replace <anyuser> with a list of users and enumerate the users that exist in the system.
"""

This commit fixes the issue
2016-08-05 17:53:34 +02:00
Luca Deri
89d6fa301a Added minimal json encoding function
Modified bash path in ntopng-add-user.sh
2016-08-05 11:03:56 +02:00
Luca Deri
45e0c01377 Fix for #672 2016-08-03 15:05:38 +02:00
valentina
982881b1e2 Changes and rework for SIP and RTP protocol. 2016-08-01 23:54:03 +02:00
Simone Mainardi
f1d3dbb455 Stateful host alerts now 'require' a lua API
This commit is a companion of professional version commit

commit 2b6e5358a71179a728edc0a8e591ffb883d626ab
Date:   Mon Aug 1 22:07:37 2016 +0200

    Refactors stateful host alerts to provide an API
2016-08-01 22:08:34 +02:00
Simone Mainardi
e674c73a2e Simplifies the API for stateful host alerts 2016-08-01 18:22:43 +02:00
valentina
d9b565e44b Other changes for SIP protocol. 2016-07-31 18:59:31 +02:00
valentina
4ad4fe04bd changes for SIP protocol. 2016-07-31 09:46:14 +02:00
Simone Mainardi
845250f5a0 Reworks thresholds alerts management to allow function override
Functions will be overridden in the professional version
2016-07-29 19:44:18 +02:00
Simone Mainardi
64e98766e7 Minor fix to improve robustness of alerts re arming 2016-07-28 16:01:05 +02:00
Simone Mainardi
2ec5c8e798 Replaces sub with gsub for string substitution 2016-07-28 15:48:41 +02:00
Simone Mainardi
a31225e2ab Sets vlan 0 to implicit for nagios alerts
This is to ensure backward compatibility with previous
nagios alert format.
2016-07-28 15:45:11 +02:00
Simone Mainardi
85c5beb545 Implements alerts on a per-interface per-vlan basis
Interfaces were handled globally before this commit. Now
alerts can be configured per-interface. So for example alerts
for the same host 193.168.2.1 can be handled differently on multiple interfaces.

Old alerts configured should be automatically migrated thanks to script startup.lua

This commits also paves the way to introduce stateful alerts in the professional version
2016-07-27 22:10:17 +02:00
Simone Mainardi
374d41387a Implements a lua table slicing facility 2016-07-26 20:07:10 +02:00
Simone Mainardi
106ba35d2c Removes redundant calls in alerts 2016-07-26 20:06:45 +02:00
Simone Mainardi
0de66219d0 Sets flow vlan to DOT1Q if no inner vlan is detected
If no {SRC,DST}_VLAN field is set, then the outer vlan values
found in Q-in-Q DOT1Q_{SRC,DST}_VLAN are used (if set) to populate
flow vlan.

Fixes #650
2016-07-24 14:26:08 +02:00
Simone Mainardi
f3bff5d2aa Minor change
This change is propaedeutic to Professional commit:

commit 1e1d453a1e96cc4394a0b94a7efe0b5857b1b1eb
Author: Simone Mainardi <simonemainardi@gmail.com>
Date:   Mon Jul 18 20:04:53 2016 +0200

    Improves the usability of historical charts
2016-07-18 20:05:40 +02:00
Simone Mainardi
57c4d74733 Changes to improve behavior consistency with current implementation 2016-07-18 10:55:15 +02:00
Simone Mainardi
cd5f3dbfd6 Merge branch 'log-preferences' of https://github.com/mathieufrh/ntopng into mathieufrh-log-preferences 2016-07-18 10:31:13 +02:00
Mathieu
46330a0fdd Check for cmdl trace level option 2016-07-15 14:42:11 +02:00
Simone Mainardi
7a8878a886 Adds bidirectional flags in host_get_json TCP flows
An excerpt of the json returned is:

{"srv.ip":"a.b.c.d","cli.port":50559,"srv.port":443,
"cli2srv.tcp_flags":{"SYN":1,"RST":0,"PSH":1,"FIN":0,"URG":0,"ACK":1},"cli2srv.throughput_bps":0,"bytes":2869,"srv2cli.throughput_bps":0,"cli2srv.throughput_pps":0,
"srv2cli.tcp_flags":{"SYN":1,"RST":0,"PSH":1,"FIN":0,"URG":0,"ACK":1},"tcp_established":true,"srv2cli.throughput_pps":0,"cli.ip":"192.168.2.130","proto.ndpi_id":126,"proto.ndpi":"SSL.Google"},
2016-07-14 12:44:55 +02:00
Mathieu
2dc31415b5 Add log preferences 2016-07-13 18:16:36 +02:00
Simone Mainardi
0515516952 Adds the Observation Period in historical Breadcrumbs 2016-07-13 17:58:40 +02:00
Simone Mainardi
926a57f658 Executes db explorer queires automatically on user click
Clicking on flow details (e.g., protocol or src or dst)
automatically redirects the user to the db explorer page
and preserves selection details (pro version).
2016-07-12 17:02:14 +02:00
Luca Deri
c25a9a632d Fixed SNMP wrapping bug
Added ability to graph flow-devices port I/O
2016-07-12 15:51:26 +02:00
Luca
c85fa80ddd Removed hard-coded number now a #define
Preliminary work for the enterprise edition
2016-07-09 09:58:13 +02:00
Simone Mainardi
2c693cb0c1 Adds the ability to set a custom Google Maps API key
Users can now generate a custom Google Maps API key and
set it via ntopng Preferences page.

Addresses #646
2016-07-06 11:46:37 +02:00
Simone Mainardi
a51994cfec Implements asynchronous database schema updates
Database updates are now performed asynchronously.
The web server starts but notifies the user with a
'please wait' message until the updates are completed.
2016-07-04 19:37:44 +02:00
Luca Deri
ef62c85bc7 Implemented host deviceIP/port binding 2016-07-04 00:04:32 +02:00
Luca Deri
5791d5a262 Improved SNMP support 2016-07-03 13:06:34 +02:00
valentina
4c6adfdb49 Changed for SIP flows 2016-07-01 23:33:35 +02:00