Commit graph

42 commits

Author SHA1 Message Date
Luca Deri
444a12e0e8 Win fixes 2018-07-17 00:58:05 +02:00
Luca Deri
65e2302e86 Compilation fixes 2018-04-16 17:27:31 +02:00
Simone Mainardi
5050bcfd04 Fixes param socketcall.recvfrom points to uninitialised byte(s)
Fixes

==19665== Thread 23:
==19665== Syscall param socketcall.recvfrom(fromlen_in) points to uninitialised byte(s)
==19665==    at 0x5CB7B03: ??? (in /usr/lib64/libpthread-2.17.so)
==19665==    by 0x447762: NetworkDiscovery::discover(lua_State*, unsigned int) (NetworkDiscovery.cpp:598)
==19665==    by 0x492E1D: ntop_discover_iface_hosts(lua_State*) (Lua.cpp:2472)
==19665==    by 0x555B66: lj_BC_FUNCC (in /home/simone/ntopng/ntopng)
==19665==    by 0x54501C: lua_pcall (in /home/simone/ntopng/ntopng)
==19665==    by 0x4E5024: LuaHandler::luaL_dofileM(bool) (LuaHandler.cpp:34)
==19665==    by 0x4A0367: __ntop_lua_handlefile(lua_State*, char*, bool) (Lua.cpp:6959)
==19665==    by 0x4A11ED: Lua::run_script(char*, NetworkInterface*) (Lua.cpp:7638)
==19665==    by 0x4A8050: ThreadedActivity::runScript(char*, NetworkInterface*) (ThreadedActivity.cpp:162)
==19665==    by 0x4A7F5B: ThreadedActivity::runScript() (ThreadedActivity.cpp:130)
==19665==    by 0x4A81BD: ThreadedActivity::uSecDiffPeriodicActivityBody() (ThreadedActivity.cpp:190)
==19665==    by 0x4A7E7A: ThreadedActivity::activityBody() (ThreadedActivity.cpp:107)
==19665==  Address 0x26c617ac is on thread 23's stack
==19665==  in frame #1, created by NetworkDiscovery::discover(lua_State*, unsigned int) (NetworkDiscovery.cpp:518)
==19665==  Uninitialised value was created by a stack allocation
==19665==    at 0x4474EE: NetworkDiscovery::discover(lua_State*, unsigned int) (NetworkDiscovery.cpp:518)
==19665==
==19665== Syscall param socketcall.recvfrom(fromlen_out) points to uninitialised byte(s)
==19665==    at 0x5CB7B03: ??? (in /usr/lib64/libpthread-2.17.so)
==19665==    by 0x447762: NetworkDiscovery::discover(lua_State*, unsigned int) (NetworkDiscovery.cpp:598)
==19665==    by 0x492E1D: ntop_discover_iface_hosts(lua_State*) (Lua.cpp:2472)
==19665==    by 0x555B66: lj_BC_FUNCC (in /home/simone/ntopng/ntopng)
==19665==    by 0x54501C: lua_pcall (in /home/simone/ntopng/ntopng)
==19665==    by 0x4E5024: LuaHandler::luaL_dofileM(bool) (LuaHandler.cpp:34)
==19665==    by 0x4A0367: __ntop_lua_handlefile(lua_State*, char*, bool) (Lua.cpp:6959)
==19665==    by 0x4A11ED: Lua::run_script(char*, NetworkInterface*) (Lua.cpp:7638)
==19665==    by 0x4A8050: ThreadedActivity::runScript(char*, NetworkInterface*) (ThreadedActivity.cpp:162)
==19665==    by 0x4A7F5B: ThreadedActivity::runScript() (ThreadedActivity.cpp:130)
==19665==    by 0x4A81BD: ThreadedActivity::uSecDiffPeriodicActivityBody() (ThreadedActivity.cpp:190)
==19665==    by 0x4A7E7A: ThreadedActivity::activityBody() (ThreadedActivity.cpp:107)
==19665==  Address 0x26c617ac is on thread 23's stack
==19665==  in frame #1, created by NetworkDiscovery::discover(lua_State*, unsigned int) (NetworkDiscovery.cpp:518)
==19665==  Uninitialised value was created by a stack allocation
==19665==    at 0x4474EE: NetworkDiscovery::discover(lua_State*, unsigned int) (NetworkDiscovery.cpp:518)
2018-04-16 16:16:35 +02:00
Luca Deri
0d61694162 Merge branch 'dev' of https://github.com/ntop/ntopng into dev 2018-04-14 09:41:44 +02:00
Luca Deri
2f0b410261 Added errno check 2018-04-14 09:41:33 +02:00
Luca Deri
a0337edb5f Added break in case of MDNS discovery error 2018-04-14 09:40:42 +02:00
Luca Deri
1adcc909ed Improved discovery with SSH scan 2018-04-07 00:18:52 +02:00
Luca Deri
caf83f1ad0 ARP fixes 2018-03-22 23:31:24 +01:00
Luca Deri
f0c936c368 Updated (C) to 2018 2018-03-22 21:59:42 +01:00
emanuele-f
60f3753e12 Fix network discovery on nedge 2018-03-08 17:28:02 +01:00
emanuele-f
01f815ab65 Revert "Using immediate mode for network discovery also for non-arm systems to prevent blocking"
This reverts commit 7828f4dc23 for keeping compatibility with older pcap versions.
2018-02-10 11:41:32 +01:00
emanuele-f
7828f4dc23 Using immediate mode for network discovery also for non-arm systems to prevent blocking 2018-02-09 19:34:02 +01:00
emanuele-f
691a509222 Fix network discovery on ARM devices.
We set the pcap immediate mode to avoid blocking on the pcap_next calls.
In fact, by default pcap packet buffering is enabled so timeouts are not honored and we may end up waiting several seconds before receiving a packet.
2018-01-31 17:20:37 +00:00
emanuele-f
6ebdcc33d6 Fix crashes on network discovery when capabilities are not available 2018-01-31 14:09:53 +00:00
Luca Deri
b33c55856e Discovery fixes 2017-12-03 12:18:39 +01:00
Luca Deri
67aab07180 Reworked discovery code 2017-12-03 11:56:09 +01:00
Luca Deri
659e52ff47 Win fixes 2017-12-02 10:38:56 +01:00
Luca Deri
ae49d7b929 Discovery changes due to missing Win pcap_get_selectable_fd() 2017-12-02 10:09:25 +01:00
Luca Deri
2c2740e0d3 Win fixes 2017-12-02 09:50:27 +01:00
Luca Deri
9018ca5e40 Changes for discoverable interfaces 2017-09-15 19:54:48 +02:00
Luca Deri
20b665f0b6 Fixed for executing network discovery when ntopng moved to nobody (Linux only) 2017-09-15 19:24:23 +02:00
Luca Deri
c74abf4eb0 Network discovery:
- Removed redundancies between C and Lua
- Discovery is now enabled at interface creation (if supported by the device).
2017-08-16 09:07:28 +02:00
Luca Deri
93d96d1faa Improved device detection
Fixed invalid 0.0.0.0 and 255.255.255.255 scan bug
2017-08-13 13:45:02 +02:00
Luca Deri
f99eaf5c86 Implemented NetBIOS name query 2017-08-11 10:52:50 +02:00
Luca
810d6557fb Improved SSDP parsing 2017-08-10 19:24:54 +02:00
Luca Deri
7654a6a033 Discovery improvements 2017-08-10 08:10:25 +02:00
Luca Deri
406671d188 Updated EtherOUI 2017-08-09 17:56:19 +02:00
Luca Deri
0f678dcda9 Debian 9 fix 2017-08-09 16:55:35 +02:00
Luca Deri
39a7dcc20e Discovery update 2017-08-08 12:42:13 +02:00
Luca Deri
c5eca39162 Added MDNS response dissection 2017-08-08 10:10:16 +02:00
Luca Deri
bfd35989b7 Implemented MDNS resolver 2017-08-07 12:12:17 +02:00
Luca Deri
b25c49398a Implemented unicast MDNS request (work in progress) 2017-08-06 09:33:02 +02:00
Luca Deri
81066d6370 Warnings fix 2017-08-06 08:15:03 +02:00
Luca Deri
34de282cc4 MDNS multicast discovery (work in progress) 2017-08-05 19:40:23 +02:00
Luca Deri
ee5446c5c9 ARP scan is now repeating the scan loop 2017-08-04 12:33:03 +02:00
Luca Deri
a72419f65a MDNS support (work in progress) 2017-08-04 12:21:41 +02:00
Luca Deri
bce4665e79 Implemented ARP scan for discovering hosts 2017-08-04 01:05:46 +02:00
Luca Deri
f22807f0be Implemented L2 support for netfilter interfaces
Fixed warnings
2017-07-31 00:08:40 +02:00
Luca Deri
48c37e5424 Improvements on SSDP network discovery 2017-06-30 00:37:38 +02:00
Luca
bf0f7f68b1 Implemented initia; Lua discovery call
Dissected SSDP location header and reported in host info page
2017-06-18 15:25:18 -04:00
Luca
9178a951d6 Disabled ethtool from interfaces such as wlan and vibr
If ntopng is started withou -i, vibr interfaces are not taken into account
2017-06-15 07:12:19 -04:00
Luca Deri
0301f506e7 Scaffolding code for implementing device discovery 2017-06-13 23:35:56 +02:00