Pro: you can easily detect if you have errors in your code base.
Cons: the CI might fail for unrelated errors, i.e. for errors unrelated
to the code you are trying to push/commit/merge. And that *will* happen a
lot, especially just after this PR has been merged, because there are
lots of errors right now.
Memory leak detection is still disabled.
This is the behavior that we have on nDPI too.
* Create formatter CI
This step in the CI pipeline is responsible for enforcing the coding style to the cpp code.
* Update formatter.yml
* Give writing permission to the code formatter action
* Add the workflow-dispatch event trigger
* Add first sketch of coding style
* Run build CI only after the formatter
* Disable include sorting on the formatter
* Fix formatter CI
* Fix code formatter in pull requests
* Fix code formatter CI
Commit the changes made by the formatter only when pushing to a remote branch. When dealing with pull requests the CI fails if the code is not properly formatted and does not commit the changes
* Remove formatter CI from PR
* Enable Build CI in PR