Commit graph

166 commits

Author SHA1 Message Date
MatteoBiscosi
7d264efe7b Removed wrong assignement 2021-06-25 10:59:13 +02:00
MatteoBiscosi
6c9b183819 Fixed chart label wrongly formatted (#5552) 2021-06-25 10:57:01 +02:00
Simone Mainardi
0f5340e1a3 (C) update 2021-05-31 12:39:02 +02:00
Simone Mainardi
d45ab54934 Harmonizes scores for Lua-triggered alerts
Addresses #5315
2021-05-12 12:56:12 +02:00
Simone Mainardi
bbe6a3de37 Changes set_severity to set_score 2021-05-05 09:59:04 +02:00
Simone Mainardi
c7082a4647 Implements new alerts database and drilldown
alert store skeleton

Alert database type changes

Implement alert store for host alerts. All alert store skeletons.

Fix class method access

Enable tracing

Implements simple queries for host alerts

Implement flow alert store

Fixes escaping of INSERT queries

Flow alerts database schema fixes

Adds escaping for alert JSON in flows and hosts

Implements queries .select() for alerts store

Adds limit and offset to perform paginated queries

Adds new REST getter for flow alerts

Name changes alert_severity to severity, alert_json to json

Fixes alert message not shown

Implement active monitoring alerts store

Implements sort of queries in the new dataabase

Changes alert_type to alert_id

Implement mac alerts store

Fixes flow alert messages

Implement system alerts store

Implement snmp alert store

Add missing items to the flow alerts

Add missing items to the host alerts

Add missing items to the mac alerts

Implements COUNT aplerts api

Add device_name to snmp alerts

add flow alerts templates

updated gitignore

fix for missing order field

add families defined in `alert_store_schema.sql`

Reworks and simplifies alert store subclasses

Implements REST API to fetch alert timeseries

Fixes date in flow REST api

Host alert json fix

Add get/host/alert/list.lua

Move alert/list.lua to alert/past/list.lua

Add alert/past/list.lua for all alert families

Add entity_id to system table to identify the alert type based on <alert_id, entity_id>

Add missing field

Implements facilities to query engaged alerts via REST

Handle both historical and past alerts in alert/list.lua

Fix count

Update params of select_historical

Implement method to add family-specific filters

Add alert/ts.lua for all alert families

Implements facilities and REST endpoints to delete alerts

Implements ordering of alert queries

Fix add_order_by group_by

Rest API tests update

Tests output update

Remove debug trace

Use alert_id instead of type. Add more flow alert info.

Update http lint

Format obsolete tlv version alerts. Add more host info.

Add row_id to list of alerts

Fix selection of engaged alerts

Add test for mac alerts (bcast domains)

Removes attempt to format alerts as flow alerts

Fixes interface selection for active monitoring

Update test output with rest changes

Add more fields to be ignores

Set alert count to 1 for the time being

add bar timeseries chart

add apexcharts

improvements on timeseries bar chart

registered chart callbakcs

working on alert page

fix for date format

Fixes acrive monitoring REST API

Fixes alignment of grouped alert data

Additional fix for alert histogram

remove useless if

formatting alerts page

fixes on flows alert stats table

rename local networks to device

format host pagie in alert_stats

add tag support for hosts and flow

implemented single delete action

add release modal

Fixes format of threshold cross interface alerts

Fixes wrong increase of dropped alerts

Implements exclusion list for invalid dns queries

Reworks exclusions lists for hosts and flows

Addresses #5212
Addresses #5113

Adds host alert keys in host callbacks definitions

Adds alert ids to flow callbacks

fix for not working button (#5215)

Fixes reported timeseries name

removed any additional button inside chart's toolbar (#5200)

Add tables for interfaces, networks, users to the schema. Skeleton alert_store classes

fixed broken range picker layout in firefox (#5199)

Alert insert fixes

Add more info to network alerts

Add rest endpoint for interface, network, user alerts

Fix endpoint selection in alerts_stats

Unifies columns between engaged and past alerts

Fixes Missing mandatory 'alert_granularity'

Minor fixes for missing alert_severity

Fixes arithmetic on a nil value (field 'last_seen')

Fixes get/system/alert/list.lua

use tstamp for column names (#5221)

Implements host alert formatter

Add alerts_store format_record_common

Use common format_record for am, system alerts

Use common format_record for all alerts

Fixes formatting of alerts of all types

Fixes nil in function 'hostinfo2label'

fixes on disable modal

add pages for network, user and interface endpoint (#5224)

Set alert_entity in all classes

Unifies influxdb alerts into system alerts

Addresses #5224

Unifies process alerts into system alerts

Addresses #5224

Cleanup unused periodicActivityEntity

Unifies category lists alerts into system alerts

Addresses #5224

Aligns new alert enums

Addresses #5224

Fixes alert page links

Fixes insertion of interface alerts

Implement filters for Host alerts

Fixes active monitoring alerts not triggering

Implement filters on flow alerts

Fixes for internal alerts timestamp and subtype

implements disable for the alerts

formatted alert disable label

Add address and device type to mac alert records

fix for delete alert toggle

Fix access to entity_val in alert_unexpected_new_device

add mac address and device type inside table

Fixes for new alert fields not handled

Fixes alert_definitions to handle new fields

Add ip/port to snmp alert records

Implements deletion of stored flow alerts

Add alert_name to all alert records via rest. Fix duration.

fixes for snmp tab

Implements delete of past host alerts

Add name to snmp alert records

fixes on system tab

Fix Date column

fixes link

Update menu

Fixes bad argument #3 to 'format' in snmp alerts

updated interface link

new alerts url for host (#5228)

Fixes sort of engaged alert

Minor cleanup

Fixes data returned for local network alerts

Fix duration for one shot. Note.

Fix duration override

Fixes interface selection for system alerts

Move host alert page

fixes for local network tab

Minor fix

Fix engaged host alerts

fixes on user tab

Fix alert_user_activity message
2021-04-26 19:41:34 +02:00
Matteo Biscosi
101c53336e Migrates alerts to an object-oriented implementation 2020-12-23 11:46:26 +01:00
DasSkelett
14d89c3fdb
Fix nil check in isCompatibleVersion() (#4841)
While playing around with the timeseries feature I got the following exception when trying to use Telegraf's `inputs.influxdb_listener` as proxy to a Prometheus database.
```
...opng/scripts/lua/modules/timeseries/drivers/influxdb.lua:1643: attempt to index a nil value (local 'current')
```

`current` is likely supposed to be checked for nil earlier together with `required`, but instead of `current` the line is checking `version`, which isn't used anymore afterwards though.

So this commit changes the check from `version == nil` to `current == nil`.

Since then I've discovered that proxying Prometheus via Telegraf's `influxdb_listener` doesn't work anyways since ntopng also tries to read from it, but that's a different story.
2020-12-16 17:52:28 +01:00
Simone Mainardi
b3dc39c641 Refactors alert_severities into an independend Lua module 2020-11-30 15:28:17 +01:00
gabryon99
77d5fd9706 fixed regex for influxdb version 2020-06-23 09:44:52 +02:00
gabryon99
efe75bd55a add snmp3 username 2020-06-23 09:00:55 +02:00
emanuele-f
610e632234 Add comments/remove table.clone when not needed 2020-05-21 11:10:47 +02:00
Simone Mainardi
c41309f21e Fixes InfluxDB version check when headers are manipulated by HAProxy
Fixes #3964
2020-05-20 13:02:28 +02:00
Simone Mainardi
0f2ce04912 Fixes InfluxDB retention policies not updated upon retention changes
Fixes #3922
2020-05-13 14:25:46 +02:00
Simone Mainardi
290175b16f Refactors alrt builders into creators
Refactors builders into creators: calls
2020-04-27 15:53:56 +02:00
emanuele-f
00c5e9f909 Add ability to report resolved IP address for unreachable hosts 2020-04-27 15:46:03 +02:00
emanuele-f
2648ae372f Rename measure in metric for active monitoring ts
Closes #3837
2020-04-27 14:36:30 +02:00
emanuele-f
345b202975 Split 95th percentile by direction 2020-04-24 18:24:57 +02:00
Simone Mainardi
2739aac076 Implements alert builders for each alert definition
[AlertsK] Implements alert consts builder

[AlertsK] alert_threshold_cross.lua

[AlertsK] too_many_drops.lua

[AlertsK] alert_test_failed.lua

[AlertsK] alert_flows_flood.lua alert_tcp_syn_flood.lua lert_tcp_syn_scan.lua

[AlertsK] alert_snmp_topology_changed.lua

[AlertsK] snmp_device_reset.lua

[AlertsK] alert_slow_periodic_activity.lua

[AlertsK] alert_port_status_change.lua

[AlertsK] alert_port_status_change.lua

[AlertsK] alert_port_load_threshold_exceeded.lua

[AlertsK] alert_port_errors.lua

[AlertsK] alert_port_duplexstatus_change.lua

[AlertsK] alert_periodic_activity_not_executed.lua

[AlertsK] alert_misbehaving_flows_ratio.lua

[AlertsK] alert_influxdb_error.lua

[AlertsK] alert_influxdb_dropped_points.lua

[AlertsK] alert_dropped_alerts.lua

[AlertsK] alert_am_threshold_cross.lua

[AlertsK] alert_broadcast_domain_too_large.lua

[AlertsK] alert_device_connection.lua

[AlertsK] alert_device_connection.lua

[AlertsK] alert_host_pool_connection.lua alert_host_pool_disconnection.lua

[AlertsK] alert_ghost_network.lua

[AlertsK] alert_ip_outsite_dhcp_range.lua

[AlertsK] alert_list_download_failed.lua

[AlertsK] alert_login_failed.lua

[AlertsK] alert_mac_ip_association_change.lua

[AlertsK] alert_slow_purge.lua

[AlertsK] alert_request_reply_ratio.lua

[AlertsK] alert_quota_exceeded.lua

[AlertsK] alert_process_notification.lua

[AlertsK] alert_nfq_flushed.lua

[AlertsK] alert_misconfigured_app.lua alert_new_device.lua

[AlertsK] alert_influxdb_export_failure.lua

[AlertsK] alert_unresponsive_device.lua

[AlertsK] alert_user_activity.lua

[AlertsK] alert_user_script_calls_drops.lua

[AlertsK] minor fix
2020-04-24 15:35:44 +02:00
Simone Mainardi
a0612895fe Implements slow rrd checks and updates in C 2020-02-19 19:28:07 +01:00
Simone Mainardi
a7ea7f76ed Implements detection of slow timeseries append 2020-02-19 18:45:36 +01:00
Simone Mainardi
0e64fd94d6 Implements deadlines for periodic and user scripts 2020-02-18 18:44:41 +01:00
Simone Mainardi
00158e8bc2 Implements error handling in line protocol generation 2020-02-16 14:30:08 +01:00
Simone Mainardi
dacaa7e3db Migrates font-awesome 5 fa to fas 2019-12-18 11:50:02 +01:00
emanuele-f
e28d0ec755 Reduce the 1d aggregation visualization interface when 1h is disabled 2019-12-18 11:44:04 +01:00
emanuele-f
262fc931f6 Disable InfluxDB 1h data rollup to reduce db pressure 2019-12-18 11:31:31 +01:00
emanuele-f
d86d58a80d Make InfluxDB query timeout configurable 2019-11-29 12:10:59 +01:00
emanuele-f
2a04c8fe35 Log influxdb queries in redis 2019-11-26 13:54:52 +01:00
emanuele-f
478c97b743 Inhibit some influxdb queries when the database does not respond
This reduces the gui loading time when such event occurs
2019-11-25 15:39:21 +01:00
emanuele-f
1fd65ac44c Flow user scripts enhancements
- Add title label in hash table utilization gauges
- List Hash Tables charts and Periodic Activities charts in a single page
- Replace Periodic Activities max duration column with time utilization percentage
- Add api to add a straight line in the charts
- Show max duration time as a straight line in Periodic Activities charts
- Move dropped flow calls charts to the Peridic Activities page
- Fix expert view number of calls 0
- Fix interface/host/network trigger alert label
- Move chart icon to separate column in redis and influxdb pages
- Fix interface menu selection in Hash Tables and Periodic Activities
- Highlight issues with a warning triangle in Hash Tables and Periodic Activities
- Fix some page navigation issues with extra_params
- Fix wrong schema graph options passed to nv_graph_utils
2019-11-20 20:09:45 +01:00
emanuele-f
4628ad3bcd Fix invalid upsampling due to missing points in composed charts 2019-11-14 20:03:43 +01:00
emanuele-f
8747af5f2b Reduce max queue length 2019-10-24 17:00:03 +02:00
emanuele-f
3882e2f26d Fix invalid failed exports key 2019-10-24 16:34:06 +02:00
emanuele-f
0d04eb2d5c Stop writing points if InfluxDB export is failing.
The dropped points are accounted and shown in the gui. Dropped points alert are generated as usual.

Fixes #2998
2019-10-24 16:09:01 +02:00
emanuele-f
10aa5542f8 Rework alertEntity functions to avoid modules circular dependencies
Fixes #2975
2019-10-23 13:01:57 +02:00
Simone Mainardi
002f1e7176 InfluxDB writes are now done with second precision
Implements #2935
2019-10-14 09:44:15 +02:00
Simone Mainardi
aa652145d0 Unifies flows, timeseries and top-talkers data retention
Implements #2897
2019-10-07 16:35:32 +02:00
Simone Mainardi
039034435b Prevents InfluxDB export retries on missing timeseries files
Fixes #2873
2019-09-27 10:18:25 +02:00
emanuele-f
907b260ece Fix for missing "other" series 2019-09-20 18:49:28 +02:00
emanuele-f
acac611c29 Add missing tags in last-timestamp check 2019-09-16 20:19:08 +02:00
emanuele-f
d29bb578c0 Add last-timestamp check to avoid adding invalid 0 points in the charts
The issue occurred in InfluxDB due to a delay between buffering and actual export.
This possible addresses #2853
2019-09-16 20:04:30 +02:00
emanuele-f
1d248331f6 Implement optimized exists query in InfluxDB
This avoids returning too much results when using standard listSeries
2019-09-05 16:02:20 +02:00
Simone Mainardi
3a5de882fe Fixes lua nil-call exception upon InfluxDB errors
Fixes
WARNING: Script failure [/home/simone/ntopng/scripts/callbacks/system/timeseries.lua][/home/simone/ntopng/scripts/lua/modules/alerts_api.lua:223: attempt to call a nil value (global 'alertEntity')]
2019-08-16 20:48:11 +02:00
emanuele-f
c183a577be Alerts API cleanup and JSON migration 2019-07-29 15:17:22 +02:00
Simone Mainardi
e28bb2ae96 Implements InfluxDB overall health checks 2019-07-04 12:49:39 +02:00
Simone Mainardi
5187a36d37 Implements flags to detect recent InfluxDB export failures and dropped points 2019-07-04 11:38:10 +02:00
emanuele-f
47e5d87e44 Show InfluxDB setup errors in the header
Fixes #2702
2019-07-03 16:59:29 +02:00
emanuele-f
0957bef845 Fix InfluxDB error with partial reply during setup
Fixes #2703
2019-07-03 14:30:14 +02:00
Simone Mainardi
9f3bb73ddc Keeps InfluxDB export stats since startup 2019-07-02 18:42:09 +02:00
Simone Mainardi
0e3de3efe6 Fixes InfluxDB memory calculation
Fixes #2694
2019-07-01 18:44:48 +02:00