Commit graph

237 commits

Author SHA1 Message Date
Simone Mainardi
b3be99e97b Fixes number of flows in ajax requests 2016-05-24 12:17:43 +02:00
Simone Mainardi
e12c703464 Implements IN_BYTES / OUT_BYTES for historical protocols 2016-05-24 11:57:12 +02:00
Simone Mainardi
9953cc2328 Implements IN_BYTES/OUT_BYTES in historical data
MySQL schema change has been implemented together with
new historical talkers.
TODO: historical protocols.
2016-05-24 11:08:11 +02:00
valentina
5d2f1f4c03 Rework Preference Panes 2016-05-23 23:07:52 +02:00
Luca Deri
58e48e4529 Improved flow status detection 2016-05-16 19:13:55 +02:00
Luca
5ff9db9dd5 Improved detection of flow status 2016-05-16 18:54:08 +02:00
Simone Mainardi
46a1edd046 Sets host symbolic names in mutual exclusion
This is to guarantee that symbolic names are left
in a consistent state after possible lua calls.

TODO: check: should get_name be mutex-protected?

Also fixes an issue with minute top talkers:

11/May/2016 11:06:21 [Lua.cpp:4617] WARNING: Script failure [/usr/share/ntopng/scripts/callbacks/minute.lua][/usr/share/ntopng/scripts/lua/modules/top_talkers.lua:215: attempt to concatenate field 'name' (a nil value)]
11/May/2016 11:09:22 [Lua.cpp:4617] WARNING: Script failure [/usr/share/ntopng/scripts/callbacks/minute.lua][/usr/share/ntopng/scripts/lua/modules/top_talkers.lua:185: attempt to concatenate field 'name' (a nil value)]
2016-05-12 00:26:02 +02:00
Simone Mainardi
b29869c053 Makes the historical perPage results persistent
Implements #515
2016-05-10 18:27:56 +02:00
Luca Deri
4acb2b0e81 Minor cosmetic fixes 2016-05-07 00:20:55 +02:00
Simone Mainardi
9ce96af916 Prevents localstats to be overwritten in interfaces aggregation
Fixes #552
2016-05-06 11:02:44 +02:00
Simone Mainardi
926dfe283b Improves minute top statistics calculations
Minute top statistics were affected by issues when
processing local hosts that were serialized and
deserialized back.

This commit fixes this issue.
2016-04-29 13:36:26 +02:00
Simone Mainardi
92f2a33c75 Prevents attempts to perform op. on a nil values (Fixes #525) 2016-04-22 10:20:15 +02:00
Simone Mainardi
283737cddd Improves the responsiveness of historical pages
Tables with ipv4 and ipv6 flows are loaded dynamically
only when the used clicks on the corresponding tab
2016-04-20 12:38:34 +02:00
Luca
2fb0e863fe Fixed inter-arrival time in flows
Updated (C)
2016-04-19 11:06:39 +02:00
Luca
bc6a018415 Enhanced alerts: added alarm status on/off/permanent to handle in the future for counting pending issues 2016-04-19 10:51:53 +02:00
Luca Deri
7a34bd7891 Added checks for #497 2016-04-15 22:11:50 +02:00
Simone Mainardi
d46a5b8b5e Refactors historical labels and code to improve readability 2016-04-15 17:05:28 +02:00
Simone Mainardi
12679976dc Adds a flow inspector to the historical top applications 2016-04-14 17:56:07 +02:00
Simone Mainardi
3c0022197e Adds a flow inspector to the historical top talkers 2016-04-14 15:24:38 +02:00
Simone Mainardi
66513dc093 fixes a MySQL query error on unknown field 2016-04-14 11:04:24 +02:00
Simone Mainardi
fd4057a270 Improves historical talkers/protocols drill down 2016-04-13 18:13:59 +02:00
Simone Mainardi
05c1209310 Pops-up a window to download flows (and prevents page changes to be lost) 2016-04-13 15:51:23 +02:00
Simone Mainardi
7b1e38cc6e Checks whether local packet dump is enabled via Lua
Fixes #487
2016-04-12 18:26:32 +02:00
Simone Mainardi
0ca318ac4d Implements VLAN statistics
Comuptes VLAN statistics and store data to RRD files.
2016-04-12 18:01:05 +02:00
Luca Deri
8b150132d2 Added interface TCP stats 2016-04-11 00:02:37 +02:00
Simone Mainardi
53fdd4f36b Specifies Interface in the top talkers minute stats table 2016-04-08 17:30:30 +02:00
Simone Mainardi
fdaf16a7ef Implements bi-directional HTTP reqs/resps rates 2016-04-08 15:52:56 +02:00
Luca Deri
c68b0d3959 Merge pull request #471 from simonemainardi/dev
Fixes issues when sorting flows
2016-04-06 01:32:21 +02:00
Simone Mainardi
18e8e57db5 Adds ports, l4 and l7 protocols to pcap and flows download 2016-04-04 19:57:22 +02:00
Simone Mainardi
90ffa1eb10 Removes a debug print 2016-04-04 19:40:55 +02:00
Simone Mainardi
870a08a568 Adds ports, l4 and l7 protocols to historical talkers drill-down 2016-04-04 19:38:57 +02:00
Simone Mainardi
ba5b7a08f7 Extendends direction breakdown for l7 protocols 2016-04-04 16:44:32 +02:00
Simone Mainardi
7f983c3b14 Adds direction breakdown for historical top talkers 2016-04-04 16:01:17 +02:00
Simone Mainardi
27d9f37016 Fixes issues when sorting flows
Todo: check also host sort that may be affected as well

Fixes #464
2016-04-02 18:11:42 +02:00
Luca Deri
ef6fdebf63 Fixes in MySQl batch 2016-03-26 22:00:56 +01:00
valentina
149cdb18c6 Some fixes for ntopng and nbox integration 2016-03-26 17:52:25 +01:00
Simone Mainardi
2754c2dfa1 Stores integer interface ids into MySQL
Interface flows are now stored using integer interface ids rather
than interface names. This speeds up queries.
A migration code has also been introduced so that old MySQL table
format is migrated and old data does not get lost.

This also fixes #460
2016-03-25 19:58:00 +01:00
Luca
c3d2ecc749 Implemented flow packets interarrival stats 2016-03-23 23:22:58 +01:00
Luca Deri
0c0b671e0f Improved top sites 2016-03-22 14:56:03 +01:00
Simone Mainardi
6ce3ae37ee Fixes an 'expected string, got nil'
Fixes
[Lua.cpp:76] ERROR: ntop_get_file_dir_exists : expected string, got nil
2016-03-21 20:41:16 +01:00
valentina
c973a28752 Added management of latitude and longitude parameters (SRC_IP_LONG, SRC_IP_LAT, DST_IP_LONG and DST_IP_LAT) 2016-03-20 21:06:49 +01:00
Luca Deri
924939c8f2 Added fix for catching MySQL errors 2016-03-19 15:04:18 +01:00
Simone Mainardi
d89cde0409 Handles interface alerts with ids
The Interface Alerts toggle button was not working. This
commit fixes this bug as well.
2016-03-16 19:53:13 +01:00
Simone Mainardi
6c5f665a73 Fixes local networks aggregation functions
Local networks are aggregated on the basis of their string representation
rather than their id which may change between ntopng restarts.
2016-03-11 18:30:42 +01:00
Simone Mainardi
97c45aef96 Handles netowrk interfaces with integer ids
To prevent possible issues with special characters like /,
interface have been handled in the web UI via integer ids
2016-03-10 17:45:27 +01:00
Luca
8f0f8fc1cf Added logic to detect flows with low goodput (e.g. originated by tools like https://github.com/shekyan/slowhttptest) 2016-03-08 19:18:28 +01:00
valentina
51e679821e Fixed some fields of SIP protocol 2016-03-05 11:41:46 +01:00
Luca Deri
ba38b2c13b Fix for #424 2016-03-02 09:13:50 +01:00
Simone Mainardi
c3f96646c5 Adds contextual 'download flows' and 'extract pcap' buttons
Download flows and extract pcap buttons are now available in
the Pro edition. These buttons are shown at the bottom of the
historical pages (e.g., flows, talkers, and protocols) and
make requests that keep into account filters specified by the user
2016-03-02 00:06:44 +01:00
Simone Mainardi
f97ee78d42 Minor flow_utils.lua fixes
Fixes for:
02/Mar/2016 00:02:41 [Lua.cpp:4815] WARNING: Script failure [/Users/simone/code/ntopng/scripts/lua/host_stats.lua][error loading module 'flow_utils' from file '/Users/simone/code/ntopng/scripts/lua/modules/flow_utils.lua':
	    ...rs/simone/code/ntopng/scripts/lua/modules/flow_utils.lua:1089: syntax error near '=']

02/Mar/2016 00:01:47 [Lua.cpp:4815] WARNING: Script failure [/Users/simone/code/ntopng/scripts/lua/host_stats.lua][error loading module 'flow_utils' from file '/Users/simone/code/ntopng/scripts/lua/modules/flow_utils.lua':
	    ...rs/simone/code/ntopng/scripts/lua/modules/flow_utils.lua:1072: ')' expected near '_1']
2016-03-02 00:03:38 +01:00