Migrates alerts to an object-oriented implementation

scripts/lua/modules/alert_definitions/alert_misconfigured_app.lua

@@ -2,32 +2,50 @@
 -- (C) 2019-20 - ntop.org
 --
 
+-- ##############################################
+
 local alert_keys = require "alert_keys"
 
--- #######################################################
+-- Import the classes library.
+local classes = require "classes"
+-- Make sure to import the Superclass!
+local alert = require "alert"
+
+-- ##############################################
+
+local alert_misconfigured_app = classes.class(alert)
+
+-- ##############################################
+
+alert_misconfigured_app.meta = {
+  alert_key = alert_keys.ntopng.alert_misconfigured_app,
+  i18n_title = "alerts_dashboard.misconfigured_app",
+  icon = "fas fa-cog",
+}
+
+-- ##############################################
 
 -- @brief Prepare an alert table used to generate the alert
--- @param alert_severity A severity as defined in `alert_severities`
--- @param alert_granularity A granularity as defined in `alert_consts.alerts_granularities`
--- @param alert_subtype A string with the subtype of the alert
+-- @param one_param The first alert param
+-- @param another_param The second alert param
 -- @return A table with the alert built
-local function createMisconfiguredApp(alert_severity, alert_granularity, alert_subtype)
-   local built = {
-      alert_severity = alert_severity,
-      alert_subtype = alert_subtype,
-      alert_granularity = alert_granularity,
-      alert_type_params = {
-      },
-   }
+function alert_misconfigured_app:init()
+   -- Call the paren constructor
+   self.super:init()
 
-   return built
+   self.alert_type_params = {}
 end
 
 -- #######################################################
 
-local function formatMisconfiguredApp(ifid, alert, threshold_info)
+-- @brief Format an alert into a human-readable string
+-- @param ifid The integer interface id of the generated alert
+-- @param alert The alert description table, including alert data such as the generating entity, timestamp, granularity, type
+-- @param alert_type_params Table `alert_type_params` as built in the `:init` method
+-- @return A human-readable string
+function alert_misconfigured_app.format(ifid, alert, alert_type_params)
   local alert_severities = require "alert_severities"
-local alert_consts = require("alert_consts")
+  local alert_consts = require("alert_consts")
   local entity = alert_consts.formatAlertEntity(ifid, alert_consts.alertEntityRaw(alert["alert_entity"]), alert["alert_entity_val"])
 
   if alert.alert_subtype == "too_many_flows" then
@@ -41,10 +59,4 @@ end
 
 -- #######################################################
 
-return {
-  alert_key = alert_keys.ntopng.alert_misconfigured_app,
-  i18n_title = "alerts_dashboard.misconfigured_app",
-  icon = "fas fa-cog",
-  i18n_description = formatMisconfiguredApp,
-  creator = createMisconfiguredApp,
-}
+return alert_misconfigured_app