vrr/ntopng
2
0
Fork 0
mirror of https://github.com/ntop/ntopng.git synced 2026-04-29 15:39:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Fixes misleading application selection in flow report

Browse source 
Fixes #4660
This commit is contained in:
Simone Mainardi 2020-11-02 17:21:35 +01:00
parent 34c9ea53b1
commit f3de7a9a4e
1 changed files with 21 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

29
scripts/lua/modules/flow_utils.lua
View file

@ -1797,15 +1797,28 @@ function printActiveFlowsDropdown(base_url, page_params, ifstats, flowstats, is_
print(getPageUrl(base_url, application_filter_params))
print('">'..i18n("flows_page.all_proto")..'</a></li>')
for key, value in pairsByKeys(flowstats["ndpi"], asc) do
local class_active = ''
if(key == page_params.application) then
class_active = 'active'
end
print('<li><a class="dropdown-item '..class_active..'" href="')
application_filter_params["application"] = key
if not isEmptyString(page_params["application"]) then
-- An application has been explicitly selected from the dropdown
-- so only that application is shown as dropdown a dropdown item.
-- The application will also include all sub-applications, e.g., DNS
-- will include DNS.Google, DNS.Facebook and so on.
print('<li><a class="dropdown-item active href="')
application_filter_params["application"] = page_params["application"]
print(getPageUrl(base_url, application_filter_params))
print('">'..key..'</a></li>')
print('">'..page_params["application"]..'</a></li>')
else
-- No application selected in the dropdown. Show all the available applications
-- as reported in flowstats
for key, value in pairsByKeys(flowstats["ndpi"], asc) do
local class_active = ''
if(key == page_params.application) then
class_active = 'active'
end
print('<li><a class="dropdown-item '..class_active..'" href="')
application_filter_params["application"] = key
print(getPageUrl(base_url, application_filter_params))
print('">'..key..'</a></li>')
end
end
print("</ul> </div>'")