vrr/ntopng
2
0
Fork 0
mirror of https://github.com/ntop/ntopng.git synced 2026-05-08 06:24:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Implements counters for export dropped flows (wip)

Browse source 
ntopng optionally exports flows to MySQL or ES. This change
keeps track of possible drops (e.g., due to a slow mysql server)
and shows them to the user.
This commit is contained in:
Simone Mainardi 2016-08-26 19:27:46 +02:00
parent be37fe7595
commit e8707bcaa9
10 changed files with 77 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

17
src/MySQLDB.cpp
View file

@ -57,6 +57,8 @@ void* MySQLDB::queryLoop() {
mysql_close(&mysql_alt);
if(!connectToDB(&mysql_alt, true))
return(NULL);
} else {
mysqlExportedFlows++;
}
} else
sleep(1);
@ -386,6 +388,8 @@ bool MySQLDB::createDBSchema() {
/* ******************************************* */
MySQLDB::MySQLDB(NetworkInterface *_iface) : DB(_iface) {
mysqlDroppedFlowsQueueTooLong = 0;
mysqlExportedFlows = 0;
connectToDB(&mysql, false);
}
@ -533,7 +537,18 @@ bool MySQLDB::dumpFlow(time_t when, bool partial_dump, Flow *f, char *json) {
}
free(json_buf);
ntop->getRedis()->lpush(CONST_SQL_QUEUE, sql, CONST_MAX_MYSQL_QUEUE_LEN);
if (ntop->getRedis()->llen(CONST_SQL_QUEUE) < CONST_MAX_MYSQL_QUEUE_LEN) {
/* We know that we should have locked before evaluating the condition
above as another thread, via the lpush below, can invalidate the condition.
However, we prefer to avoid an additional lock as the lpush guarantees
that no more than CONST_MAX_MYSQL_QUEUE_LEN will ever be in the queue.
The drawback is that the counter mysqlDroppedFlowsQueueTooLong
is not guaranteed to be 100% accurate but we can tolerate this.
*/
ntop->getRedis()->lpush(CONST_SQL_QUEUE, sql, CONST_MAX_MYSQL_QUEUE_LEN);
} else {
mysqlDroppedFlowsQueueTooLong++;
}
return(true);
}