vrr/ntopng
2
0
Fork 0
mirror of https://github.com/ntop/ntopng.git synced 2026-05-01 00:19:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

REST endpoints now return specific HTTP codes on failure (fix #4278)

Browse source
This commit is contained in:
Alfredo Cardigliano 2020-08-20 11:45:17 +02:00
parent 745b3b52d3
commit ba2e44ddc6
37 changed files with 141 additions and 228 deletions
Download patch file Download diff file Expand all files Collapse all files

13
scripts/lua/rest/v1/get/host/custom_data.lua
View file

@ -17,8 +17,6 @@ local rest_utils = require("rest_utils")
-- NOTE: in case of invalid login, no error is returned but redirected to login
--
sendHTTPHeader('application/json')
local rc = rest_utils.consts.success.ok
local res = {}
local field_aliases = {}
@ -26,9 +24,8 @@ local field_aliases = {}
local ifid = _GET["ifid"]
local fields = _GET["field_alias"]
if isEmptyString(ifid) then
print(rest_utils.rc(rest_utils.consts.err.invalid_interface))
rest_utils.answer(rest_utils.consts.err.invalid_interface)
return
end
@ -49,7 +46,7 @@ else
--
-- Invalid field alias...
if isEmptyString(fields) then
print(rest_utils.rc(rest_utils.consts.err.invalid_args))
rest_utils.answer(rest_utils.consts.err.invalid_args)
return
end
--
@ -76,7 +73,7 @@ if ((hostparam ~= nil) or (not isEmptyString(hostparam))) then
local host_info = url2hostinfo(_GET)
local host = interface.getHostInfo(host_info["host"], host_info["vlan"])
if not host then
print(rest_utils.rc(rest_utils.consts.err.not_found))
rest_utils.answer(rest_utils.consts.err.not_found)
return
else
--
@ -98,7 +95,7 @@ if ((hostparam ~= nil) or (not isEmptyString(hostparam))) then
end
end
tracker.log("get_host_custom_data_json", {ifid, host_info["host"], host_info["vlan"], field_aliases})
print(rest_utils.rc(rc, res))
rest_utils.answer(rc, res)
return
end
else
@ -126,6 +123,6 @@ else
end
end
tracker.log("get_host_custom_data_json", {ifid, "All Hosts", field_aliases})
print(rest_utils.rc(rc, res))
rest_utils.answer(rc, res)
return
end