vrr/ntopng
2
0
Fork 0
mirror of https://github.com/ntop/ntopng.git synced 2026-05-02 00:40:10 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Improve rest/v1/edit/ntopng/user.lua endpoint

Browse source
This commit is contained in:
Alfredo Cardigliano 2020-08-17 16:46:53 +02:00
parent bfa14d5690
commit b65154289e
4 changed files with 116 additions and 35 deletions
Download patch file Download diff file Expand all files Collapse all files

112
scripts/lua/rest/v1/edit/ntopng/user.lua
View file

@ -12,7 +12,7 @@ local rest_utils = require("rest_utils")
--
-- Edit a ntopng user
-- Example: curl -u admin:admin -d '{"username": "mario", "user_role": "unprivileged", "allowed_interface": "", "allowed_networks": "0.0.0.0/0,::/0", "user_language": "en"}' http://localhost:3000/lua/rest/v1/edit/ntopng/user.lua
-- Example: curl -u admin:admin -d '{"username": "mario", "full_name": "Mario Rossi", "user_role": "unprivileged", "allowed_interface": "", "allowed_networks": "0.0.0.0/0,::/0", "user_language": "en"}' http://localhost:3000/lua/rest/v1/edit/ntopng/user.lua
--
-- NOTE: in case of invalid login, no error is returned but redirected to login
--
@ -23,69 +23,111 @@ local rc = rest_utils.consts_ok
local res = {}
if not haveAdminPrivileges() then
print(rest_utils.rc(rest_utils.consts_not_granted, res))
return
print(rest_utils.rc(rest_utils.consts_not_granted, res))
return
end
local username = _POST["username"]
local full_name = _POST["full_name"]
local host_role = _POST["user_role"]
local host_pool_id = _POST["host_pool_id"]
local networks = _POST["allowed_networks"]
local allowed_interface = _POST["allowed_interface"]
local language = _POST["user_language"]
local allow_pcap_download = _POST["allow_pcap_download"]
local password = _POST["password"]
local confirm_password = _POST["confirm_password"]
if username == nil or (host_role == nil and networks == nil and allowed_interface == nil
and allow_pcap_download == nil and language == nil) then
print(rest_utils.rc(rest_utils.consts_invalid_args, res))
return
if username == nil then
print(rest_utils.rc(rest_utils.consts_invalid_args, res))
return
end
if host_role == nil and
networks == nil and
allowed_interface == nil and
allow_pcap_download == nil and
language == nil and
full_name == nil and
(password == nil or confirm_password == nil) and
host_pool_id == nil then
print(rest_utils.rc(rest_utils.consts_invalid_args, res))
return
end
username = string.lower(username)
local all_users = ntop.getUsers()
if(all_users[username] == nil) then
-- User doesn't exist
print(rest_utils.rc(rest_utils.consts_user_does_not_exist, res))
return
-- User doesn't exist
print(rest_utils.rc(rest_utils.consts_user_does_not_exist, res))
return
end
if(full_name ~= nil) then
if(not ntop.changeUserFullName(username, full_name)) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
return
end
end
if(host_role ~= nil) then
if(not ntop.changeUserRole(username, host_role)) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
return
end
if(not ntop.changeUserRole(username, host_role)) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
return
end
end
if(networks ~= nil) then
if(not ntop.changeAllowedNets(username, networks)) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
return
end
if(not ntop.changeAllowedNets(username, networks)) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
return
end
end
if(host_pool_id ~= nil) then
if(not ntop.changeUserHostPool(username, host_pool_id)) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
return
end
end
if(allowed_interface ~= nil) then
if(not ntop.changeAllowedIfname(username, getInterfaceName(allowed_interface))) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
return
end
if(not ntop.changeAllowedIfname(username, getInterfaceName(allowed_interface))) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
return
end
end
if (allow_pcap_download ~= nil) then
local allow_pcap_download_enabled = false
if(tonumber(allow_pcap_download) == 1) then
allow_pcap_download_enabled = true;
end
if(not ntop.changeUserPermission(username, allow_pcap_download_enabled)) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
return
end
if(allow_pcap_download ~= nil) then
local allow_pcap_download_enabled = false
if(tonumber(allow_pcap_download) == 1) then
allow_pcap_download_enabled = true;
end
if(not ntop.changeUserPermission(username, allow_pcap_download_enabled)) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
return
end
end
if(language ~= nil) then
if(not ntop.changeUserLanguage(username, language)) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
return
end
if(not ntop.changeUserLanguage(username, language)) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
return
end
end
if(password ~= nil and confirm_password ~= nil) then
-- Note: the old password is not required here as the admin is doing the request
if(password ~= confirm_password) then
print(rest_utils.rc(rest_utils.consts_password_mismatch, res))
return
end
if(ntop.resetUserPassword(_SESSION["user"], username, "", password)) then
print(rest_utils.rc(rest_utils.consts_edit_user_failed, res))
end
end
print(rest_utils.rc(rc, res))