vrr/ntopng
2
0
Fork 0
mirror of https://github.com/ntop/ntopng.git synced 2026-05-05 10:41:34 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

Fixes IP reassignment code that is now per-interface

Browse source 
Implements #5038
This commit is contained in:
Simone Mainardi 2021-02-26 11:21:04 +01:00
parent db0633fc9f
commit 76006d6250
6 changed files with 87 additions and 25 deletions
Download patch file Download diff file Expand all files Collapse all files

54
scripts/plugins/alerts/network/ip_reassignment/user_scripts/interface/ip_reassignment.lua
View file

@ -1,12 +1,17 @@
--
-- (C) 2019-21 - ntop.org
--
local dirs = ntop.getDirs()
package.path = dirs.installdir .. "/scripts/lua/modules/?.lua;" .. package.path
package.path = dirs.installdir .. "/scripts/lua/modules/pools/?.lua;" .. package.path
local user_scripts = require("user_scripts")
local interface_pools = require "interface_pools"
-- #################################################################
local IP_REASSIGNMENT_KEY = "ntopng.prefs.ifid_" .. interface.getId() .. ".ip_reassignment_alerts"
-- Used to remember when the preferences are reloaded
local IP_REASSIGNMENT_PREF_UPDATED = "ntopng.cache.ip_reassignment_pref_updated"
-- #################################################################
@ -38,29 +43,58 @@ local script = {
-- #################################################################
function script.onLoad(hook, hook_config)
if hook_config and hook_config.enabled then
ntop.setPref(IP_REASSIGNMENT_KEY, "1")
function script.setup()
local pref_updated = ntop.getCache(IP_REASSIGNMENT_PREF_UPDATED)
-- If in-memory settings for interfaces have not yet been updated...
if pref_updated ~= "1" then
-- Fetch the configsets
local configsets = user_scripts.getConfigsets()
-- Instance of local network pools to get assigned members
local pools_instance = interface_pools:create()
-- For each interface, get its pool configuration, and check whether this script is enabled or not
for ifid, _ in pairs(interface.getIfNames()) do
-- Retrieve the confset_id (possibly) associated to this interface
local confset_id = pools_instance:get_configset_id(string.format("%d", ifid))
local iface_config = user_scripts.getConfigById(configsets, confset_id, "interface")
local conf = user_scripts.getTargetHookConfig(iface_config, "ip_reassignment", "min")
local enabled = conf and conf.enabled
-- Set the in-memory pref for the interface
interface.updateIPReassignment(tonumber(ifid), enabled)
end
-- Don't redo this code, unless a script.on<Something> event marks the configuration as changed
ntop.setCache(IP_REASSIGNMENT_PREF_UPDATED, "1")
end
return true
end
-- #################################################################
function script.onUnload(hook, hook_config)
ntop.delCache(IP_REASSIGNMENT_KEY)
function script.onLoad(hook, hook_config, configset_id)
ntop.delCache(IP_REASSIGNMENT_PREF_UPDATED)
end
-- #################################################################
function script.onEnable(hook, hook_config)
ntop.setPref(IP_REASSIGNMENT_KEY, "1")
function script.onUnload(hook, hook_config, configset_id)
ntop.delCache(IP_REASSIGNMENT_PREF_UPDATED)
end
-- #################################################################
function script.onDisable(hook, hook_config)
ntop.delCache(IP_REASSIGNMENT_KEY)
function script.onEnable(hook, hook_config, configset_id)
ntop.delCache(IP_REASSIGNMENT_PREF_UPDATED)
end
-- #################################################################
function script.onDisable(hook, hook_config, configset_id)
ntop.delCache(IP_REASSIGNMENT_PREF_UPDATED)
end
-- #################################################################