vrr/ntopng
2
0
Fork 0
mirror of https://github.com/ntop/ntopng.git synced 2026-04-30 07:59:35 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

Implements flags to detect recent InfluxDB export failures and dropped points

Browse source
This commit is contained in:
Simone Mainardi 2019-07-04 11:38:10 +02:00
parent 0748ef191d
commit 5187a36d37
1 changed files with 34 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

34
scripts/lua/modules/timeseries/drivers/influxdb.lua
View file

@ -705,9 +705,19 @@ end
-- ##############################################
local INFLUX_KEY_PREFIX = "ntopng.cache.influxdb."
-- Keys to identify redis hash caches to keep stats counters
-- such as dropped and exported points
local INFLUX_KEY_DROPPED_POINTS = INFLUX_KEY_PREFIX.."dropped_points"
local INFLUX_KEY_EXPORTED_POINTS = INFLUX_KEY_PREFIX.."exported_points"
local INFLUX_KEY_EXPORTS = INFLUX_KEY_PREFIX.."exports"
local INFLUX_KEY_FAILED_EXPORTS = INFLUX_KEY_PREFIX.."failed_exports"
-- Use this flag as TTL-based redis keys to check wether the health
-- of influxdb is OK.
local INFLUX_FLAGS_TIMEOUT = 60 -- keep the issue for 60 seconds
local INFLUX_FLAG_DROPPING_POINTS = INFLUX_KEY_PREFIX.."flag_dropping_points"
local INFLUX_FLAG_FAILING_EXPORTS = INFLUX_KEY_PREFIX.."flag_failing_exports"
-- ##############################################
@ -721,6 +731,7 @@ end
-- ##############################################
local function inc_dropped_points(ifid, num_points)
ntop.setCache(INFLUX_FLAG_DROPPING_POINTS, "", INFLUX_FLAGS_TIMEOUT)
inc_val(INFLUX_KEY_DROPPED_POINTS, ifid, num_points)
end
@ -738,10 +749,20 @@ end
-- ##############################################
local function inc_failed_exports(ifid)
ntop.setCache(INFLUX_FLAG_FAILING_EXPORTS, "", INFLUX_FLAGS_TIMEOUT)
inc_val(INFLUX_KEY_FAILED_EXPORTS, ifid, 1)
end
-- ##############################################
local function del_all_vals()
ntop.delCache(INFLUX_KEY_DROPPED_POINTS)
ntop.delCache(INFLUX_KEY_EXPORTED_POINTS)
ntop.delCache(INFLUX_KEY_EXPORTS)
ntop.delCache(INFLUX_KEY_FAILED_EXPORTS)
ntop.delCache(INFLUX_FLAG_DROPPING_POINTS)
ntop.delCache(INFLUX_KEY_FAILED_EXPORTS)
end
-- ##############################################
@ -775,6 +796,8 @@ end
-- ##############################################
-- When we giveup for a certain exportable, that is, when we are not
-- going to try and export it again, we call this function
local function dropExportable(exportable)
inc_dropped_points(exportable["ifid"], exportable["num_points"])
deleteExportableFile(exportable)
@ -804,6 +827,8 @@ end
-- ##############################################
-- Call this function when an exportable has been sent to InfluxDB
-- with success
local function exportableSuccess(exportable)
inc_exported_points(exportable["ifid"], exportable["num_points"])
inc_exports(exportable["ifid"])
@ -812,6 +837,14 @@ end
-- ##############################################
-- Call this function when the export has failed but it is going
-- to be tried again
local function exportableFailure(exportable)
inc_failed_exports(exportable["ifid"])
end
-- ##############################################
function driver:_performExport(exportable)
local time_key = "ntopng.cache.influxdb_export_time_" .. self.db .. "_" .. exportable["ifid"]
local prev_t = tonumber(ntop.getCache(time_key)) or 0
@ -907,6 +940,7 @@ function driver:export(deadline)
ntop.lremCache(INFLUX_EXPORT_QUEUE, cur_export)
else
-- export FAILED, retry next time
exportableFailure(exportable)
end
end