Additional lateral movement alert fixes

This commit is contained in:
Simone Mainardi 2020-10-12 10:03:23 +02:00
parent c6f799ac16
commit 291538b323

View file

@ -11,9 +11,12 @@ local json = require("dkjson")
-- @brief Prepare an alert table used to generate the alert
-- @param alert_severity A severity as defined in `alert_consts.alert_severities`
-- @param alert_granularity A granularity as defined in `alert_consts.alerts_granularities`
-- @param last_error A string with the lastest influxdb error
-- @param last_error A table containing the last lateral movement error, e.g.,
-- {"event":"create","shost":"192.168.2.153","dhost":"224.0.0.68","dport":1968,"vlan_id":0,"l4":17,"l7":0,"first_seen":1602488355,"last_seen":1602488355,"num_uses":1}
-- @return A table with the alert built
local function createLateralMovementError(alert_severity, alert_granularity, last_error)
-- Create a subtype, to avoid merging multiple lateral movement alerts together
local alert_subtype = last_error.shost .. "/" .. last_error.dhost .. "/" .. last_error.dport .. "/" .. last_error.l4 .. "/" .. last_error.l7
local threshold_type = {
alert_severity = alert_severity,
alert_subtype = alert_subtype,
@ -29,28 +32,21 @@ end
-- #######################################################
local function formatLateralMovementErrorMessage(ifid, alert, status)
local msg = json.decode(status.error_msg)
local vlan_id = alert.vlan_id or 0
local client = ip2label(msg.shost, vlan_id)
local server = ip2label(msg.dhost, vlan_id)
local msg = status.error_msg
local vlan_id = msg.vlan_id or 0
local client = {host = msg.shost, vlan = vlan_id}
local server = {host = msg.dhost, vlan = vlan_id}
local rsp = format_utils.formatEpoch(msg.timestamp)..": " ..
"<A HREF=\""..hostinfo2detailsurl(client) .."\">".. msg.shost .."</A>"..
local rsp = "<A HREF=\""..hostinfo2detailsurl(client) .."\">".. hostinfo2label(client) .."</A>"..
" <i class=\"fas fa-exchange-alt fa-lg\" aria-hidden=\"true\" data-original-title=\"\" title=\"\"></i>" ..
"<A HREF=\""..hostinfo2detailsurl(server) .."\">".. msg.dhost .."</A>"..
" [Port: "..msg.dport.."]"
if(vlan_id ~= 0) then
rsp = rsp .. "[VLAN Id: " .. msg.info .. "]"
end
"<A HREF=\""..hostinfo2detailsurl(server) .."\">".. hostinfo2label(server) .."</A>"..
" ["..i18n("port")..": "..msg.dport.."]"
rsp = rsp .. "[L7: "..msg.l7.."]"
if(msg.info ~= "") then
rsp = rsp .. "["..i18n("application")..": "..interface.getnDPIProtoName(msg.l7).."]"
if not isEmptyString(msg.info) then
rsp = rsp .. "[" .. msg.info .. "]"
end
-- tprint(rsp)
return(rsp)
end
@ -60,6 +56,6 @@ return {
alert_key = alert_keys.ntopng.alert_lateral_movement,
i18n_title = "alerts_dashboard.lateral_movement",
i18n_description = formatLateralMovementErrorMessage,
icon = "fas fa-subway",
icon = "fas fa-arrows-alt-h",
creator = createLateralMovementError,
}