mirror of
https://github.com/navidrome/navidrome.git
synced 2026-07-09 17:18:45 +00:00
Some checks are pending
Pipeline: Test, Lint, Build / Test Go code (push) Waiting to run
Pipeline: Test, Lint, Build / Package/Release (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Get version info (push) Waiting to run
Pipeline: Test, Lint, Build / Lint Go code (push) Waiting to run
Pipeline: Test, Lint, Build / Test Go code (Windows) (push) Waiting to run
Pipeline: Test, Lint, Build / Test JS code (push) Waiting to run
Pipeline: Test, Lint, Build / Lint i18n files (push) Waiting to run
Pipeline: Test, Lint, Build / Check Docker configuration (push) Waiting to run
Pipeline: Test, Lint, Build / Build (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-1 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-2 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-3 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-4 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-5 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Upload Linux PKG (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-6 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-7 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-8 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-9 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-10 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Push to GHCR (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Push to Docker Hub (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Cleanup digest artifacts (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build Windows installers (push) Blocked by required conditions
* feat(plugins): export ReadPackageManifest and ValidatePackage for off-disk inspection * test(plugins): cover ValidatePackage cross-field validation branch * feat(cmd): add 'plugin list' command * refactor(cmd): drop premature pluginManager interface until first use * feat(cmd): add 'plugin enable' and 'plugin disable' commands * feat(cmd): add 'plugin edit' for config and permission updates * test(cmd): cover plugin edit aborting on config validation failure * feat(cmd): add 'plugin info' and 'plugin validate' (installed id or .ndp file) * test(cmd): unit-test formatManifestInfo nil-guard and json branches * feat(cmd): add 'plugin rescan' command * feat(cmd): enrich plugin info text output and re-validate config on validate * fix(cmd): omit zero-value timestamps in plugin info text output * fix(cmd): give plugin list and info separate format flag vars A shared package-global bound to both commands' --format flag caused the later init() registration (info, default "text") to clobber the earlier one (list, default "table"), so 'plugin list' with no -f failed with 'invalid output format "text"'. Split into pluginListFormat / pluginInfoFormat and add a regression test on the registered defaults. * fix(plugins): address code-review findings on plugin CLI - edit: read-modify-write merge so flipping one permission flag no longer wipes unspecified fields (matches the native API); reject non-JSON --users/--libraries values. - info: return an error on unknown --format (was silently text); include sha256 in off-disk JSON output; align the text columns. - move declaredPermissions onto plugins.Permissions.DeclaredNames() as the single source of truth; drop ValidatePackage's redundant Validate call. - readConfigFile: pass ctx to log.Fatal; copy flag globals before taking their address; trim comments that restated the code. * refactor(plugins): export ReadManifest/ComputeFileSHA256, drop thin CLI wrappers Remove the ReadPackageManifest/ComputeFileSHA256/ValidatePackage wrappers in favor of exporting the underlying readManifest->ReadManifest and computeFileSHA256->ComputeFileSHA256 directly. ValidatePackage was identical to ReadPackageManifest (readManifest already validates via ParseManifest), so the CLI's validate path now calls ReadManifest too. * test(plugins): consolidate ReadManifest specs and move ComputeFileSHA256 tests Merge the two ReadManifest Describe blocks into one, and move the ComputeFileSHA256 tests out of package_test.go into a new manager_sync_test.go (where the function now lives), deduping the overlapping hash specs. * test(plugins): use createTestPackage everywhere, drop writeNDP helper The schema-invalid and cross-field ReadManifest specs now build packages with createTestPackage (typed Manifest) instead of the raw-JSON writeNDP helper, so there is a single package-building helper. Also trims the gratuitous 1MB wasm buffer in the read-only spec to a few bytes. * test(plugins): drop duplicate missing-manifest spec from ReadManifest The openPackage block already covers the missing-manifest.json error path (shared zip-walk code); ReadManifest's identical copy added no distinct coverage. * test(plugins): fix misleading ReadManifest spec name and drop unused wasm bytes The spec was named 'should read only the manifest without loading wasm' but ReadManifest returns only (*Manifest, error) — it cannot assert whether wasm was loaded. Rename to what it actually verifies (manifest parses from a package that also contains a wasm entry) and pass nil wasm bytes, since the contents are never observed. * fix(cmd): address PR review feedback on plugin CLI - edit --users/--libraries now accept both comma-separated and JSON-array input (CSV is converted to the JSON the manager stores); help text documents both. - Permissions.DeclaredNames() derives names by reflecting over the generated struct's json tags instead of a hand-maintained list, so new permission types are picked up automatically. - isPackagePath checks only the .ndp suffix, so a mistyped package path yields a precise 'no such file' error instead of falling back to a misleading 'Plugin not found'. - Restore a ReadManifest test for the missing-manifest.json error path (it has its own branch, separate from openPackage). * docs(cmd): trim verbose comments to the why * fix(cmd): setting an explicit users/libraries list clears the all-* flag Per Codex review: with allUsers/allLibraries true, 'plugin edit --users <list>' preserved the all-* flag so the allow-list was silently ignored, and the mutually-exclusive flags meant it couldn't be corrected in one command. An explicit list now implies all-*=false.
234 lines
7.3 KiB
Go
234 lines
7.3 KiB
Go
package plugins
|
|
|
|
import (
|
|
"context"
|
|
"crypto/sha256"
|
|
"encoding/hex"
|
|
"encoding/json"
|
|
"fmt"
|
|
"io"
|
|
"os"
|
|
"path/filepath"
|
|
"strings"
|
|
"time"
|
|
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
"github.com/navidrome/navidrome/model/request"
|
|
"github.com/navidrome/navidrome/server/events"
|
|
)
|
|
|
|
// PluginMetadata holds the extracted information from a plugin file
|
|
// without fully initializing the plugin.
|
|
type PluginMetadata struct {
|
|
Manifest *Manifest
|
|
SHA256 string
|
|
}
|
|
|
|
// adminContext returns a context with admin privileges for DB operations.
|
|
func adminContext(ctx context.Context) context.Context {
|
|
return request.WithUser(ctx, model.User{IsAdmin: true})
|
|
}
|
|
|
|
// marshalManifest marshals a manifest to JSON string, returning empty string on error.
|
|
func marshalManifest(m *Manifest) string {
|
|
b, _ := json.Marshal(m)
|
|
return string(b)
|
|
}
|
|
|
|
// ComputeFileSHA256 computes the SHA-256 hash of a file without loading it into memory.
|
|
// This is used for quick change detection before full plugin compilation.
|
|
func ComputeFileSHA256(path string) (string, error) {
|
|
f, err := os.Open(path)
|
|
if err != nil {
|
|
return "", err
|
|
}
|
|
defer f.Close()
|
|
|
|
h := sha256.New()
|
|
if _, err := io.Copy(h, f); err != nil {
|
|
return "", err
|
|
}
|
|
return hex.EncodeToString(h.Sum(nil)), nil
|
|
}
|
|
|
|
// addPluginToDB adds a new plugin to the database as disabled.
|
|
func (m *Manager) addPluginToDB(ctx context.Context, repo model.PluginRepository, name, path string, metadata *PluginMetadata) error {
|
|
now := time.Now()
|
|
newPlugin := &model.Plugin{
|
|
ID: name,
|
|
Path: path,
|
|
Manifest: marshalManifest(metadata.Manifest),
|
|
SHA256: metadata.SHA256,
|
|
Enabled: false,
|
|
CreatedAt: now,
|
|
UpdatedAt: now,
|
|
}
|
|
if err := repo.Put(newPlugin); err != nil {
|
|
return fmt.Errorf("adding plugin to DB: %w", err)
|
|
}
|
|
log.Info(ctx, "Discovered new plugin", "plugin", name)
|
|
m.sendPluginRefreshEvent(ctx, events.Any)
|
|
return nil
|
|
}
|
|
|
|
// updatePluginInDB updates an existing plugin in the database after a file change.
|
|
// If the plugin was enabled, it will be unloaded and disabled.
|
|
func (m *Manager) updatePluginInDB(ctx context.Context, repo model.PluginRepository, dbPlugin *model.Plugin, path string, metadata *PluginMetadata) error {
|
|
wasEnabled := dbPlugin.Enabled
|
|
if wasEnabled {
|
|
if err := m.unloadPlugin(dbPlugin.ID); err != nil {
|
|
log.Debug(ctx, "Plugin not loaded during change", "plugin", dbPlugin.ID, err)
|
|
}
|
|
}
|
|
dbPlugin.Path = path
|
|
dbPlugin.Manifest = marshalManifest(metadata.Manifest)
|
|
dbPlugin.SHA256 = metadata.SHA256
|
|
dbPlugin.Enabled = false
|
|
dbPlugin.LastError = ""
|
|
dbPlugin.UpdatedAt = time.Now()
|
|
if err := repo.Put(dbPlugin); err != nil {
|
|
return fmt.Errorf("updating plugin in DB: %w", err)
|
|
}
|
|
log.Info(ctx, "Plugin file changed", "plugin", dbPlugin.ID, "wasEnabled", wasEnabled)
|
|
m.sendPluginRefreshEvent(ctx, dbPlugin.ID)
|
|
return nil
|
|
}
|
|
|
|
// removePluginFromDB removes a plugin from the database.
|
|
// If the plugin was enabled, it will be unloaded first.
|
|
func (m *Manager) removePluginFromDB(ctx context.Context, repo model.PluginRepository, dbPlugin *model.Plugin) error {
|
|
pluginID := dbPlugin.ID
|
|
if dbPlugin.Enabled {
|
|
if err := m.unloadPlugin(pluginID); err != nil {
|
|
log.Debug(ctx, "Plugin not loaded during removal", "plugin", pluginID, err)
|
|
}
|
|
}
|
|
if err := repo.Delete(pluginID); err != nil {
|
|
return fmt.Errorf("deleting plugin from DB: %w", err)
|
|
}
|
|
log.Info(ctx, "Plugin removed", "plugin", pluginID)
|
|
m.sendPluginRefreshEvent(ctx, events.Any)
|
|
return nil
|
|
}
|
|
|
|
// syncPlugins scans the plugins folder and synchronizes with the database.
|
|
// It handles new, changed, and removed plugins by comparing SHA-256 hashes.
|
|
// - New plugins are added to DB as disabled
|
|
// - Changed plugins are updated in DB and disabled if they were enabled
|
|
// - Removed plugins are deleted from DB (after unloading if enabled)
|
|
func (m *Manager) syncPlugins(ctx context.Context, folder string) error {
|
|
if m.ds == nil {
|
|
return fmt.Errorf("datastore not configured")
|
|
}
|
|
|
|
adminCtx := adminContext(ctx)
|
|
|
|
// Read current plugins from folder
|
|
entries, err := os.ReadDir(folder)
|
|
if err != nil {
|
|
if os.IsNotExist(err) {
|
|
log.Debug(ctx, "Plugins folder does not exist", "folder", folder)
|
|
return nil
|
|
}
|
|
return fmt.Errorf("reading plugins folder: %w", err)
|
|
}
|
|
|
|
// Build map of files in folder
|
|
filesOnDisk := make(map[string]string) // name -> path
|
|
for _, entry := range entries {
|
|
if entry.IsDir() || !strings.HasSuffix(entry.Name(), PackageExtension) {
|
|
log.Trace(ctx, "Skipping non-plugin entry", "name", entry.Name(), "isDir", entry.IsDir())
|
|
continue
|
|
}
|
|
name := strings.TrimSuffix(entry.Name(), PackageExtension)
|
|
filesOnDisk[name] = filepath.Join(folder, entry.Name())
|
|
}
|
|
log.Debug(ctx, "Plugin sync: scanned folder", "folder", folder, "entriesTotal", len(entries), "pluginsFound", len(filesOnDisk))
|
|
|
|
// Get all plugins from DB
|
|
repo := m.ds.Plugin(adminCtx)
|
|
dbPlugins, err := repo.GetAll()
|
|
if err != nil {
|
|
return fmt.Errorf("reading plugins from DB: %w", err)
|
|
}
|
|
pluginsInDB := make(map[string]*model.Plugin)
|
|
for i := range dbPlugins {
|
|
pluginsInDB[dbPlugins[i].ID] = &dbPlugins[i]
|
|
}
|
|
log.Debug(ctx, "Plugin sync: current DB state", "pluginsInDB", len(pluginsInDB))
|
|
|
|
now := time.Now()
|
|
|
|
// Process files on disk
|
|
for name, path := range filesOnDisk {
|
|
dbPlugin, exists := pluginsInDB[name]
|
|
|
|
// Compute SHA256 first (lightweight operation) to check if plugin changed
|
|
sha256Hash, err := ComputeFileSHA256(path)
|
|
if err != nil {
|
|
log.Error(ctx, "Failed to compute SHA256 for plugin", "plugin", name, "path", path, err)
|
|
continue
|
|
}
|
|
|
|
// If plugin exists in DB with same hash, skip full manifest extraction
|
|
if exists && dbPlugin.SHA256 == sha256Hash {
|
|
// Plugin unchanged - just update path in case folder moved
|
|
if dbPlugin.Path != path {
|
|
dbPlugin.Path = path
|
|
dbPlugin.UpdatedAt = now
|
|
if err := repo.Put(dbPlugin); err != nil {
|
|
log.Error(ctx, "Failed to update plugin path in DB", "plugin", name, err)
|
|
}
|
|
}
|
|
delete(pluginsInDB, name)
|
|
continue
|
|
}
|
|
|
|
// Plugin is new or changed - need full manifest extraction
|
|
metadata, err := m.extractManifest(path)
|
|
if err != nil {
|
|
log.Error(ctx, "Failed to extract manifest from plugin", "plugin", name, "path", path, err)
|
|
// Store error in DB if plugin exists
|
|
if exists {
|
|
dbPlugin.LastError = err.Error()
|
|
dbPlugin.UpdatedAt = now
|
|
if dbPlugin.Enabled {
|
|
// Unload broken plugin
|
|
if unloadErr := m.unloadPlugin(name); unloadErr != nil {
|
|
log.Debug(ctx, "Plugin not loaded", "plugin", name)
|
|
}
|
|
dbPlugin.Enabled = false
|
|
}
|
|
if putErr := repo.Put(dbPlugin); putErr != nil {
|
|
log.Error(ctx, "Failed to update plugin in DB", "plugin", name, err)
|
|
}
|
|
}
|
|
delete(pluginsInDB, name)
|
|
continue
|
|
}
|
|
|
|
if !exists {
|
|
// New plugin - add to DB as disabled
|
|
if err := m.addPluginToDB(ctx, repo, name, path, metadata); err != nil {
|
|
log.Error(ctx, "Failed to add plugin to DB", "plugin", name, err)
|
|
}
|
|
} else {
|
|
// Plugin changed - update DB
|
|
if err := m.updatePluginInDB(ctx, repo, dbPlugin, path, metadata); err != nil {
|
|
log.Error(ctx, "Failed to update plugin in DB", "plugin", name, err)
|
|
}
|
|
}
|
|
// Mark as processed
|
|
delete(pluginsInDB, name)
|
|
}
|
|
|
|
// Remove plugins no longer on disk
|
|
for _, dbPlugin := range pluginsInDB {
|
|
if err := m.removePluginFromDB(ctx, repo, dbPlugin); err != nil {
|
|
log.Error(ctx, "Failed to delete plugin from DB", "plugin", dbPlugin.ID, err)
|
|
}
|
|
}
|
|
|
|
return nil
|
|
}
|