mirror of
https://github.com/navidrome/navidrome.git
synced 2026-04-28 11:29:38 +00:00
Some checks are pending
Pipeline: Test, Lint, Build / Lint i18n files (push) Waiting to run
Pipeline: Test, Lint, Build / Check Docker configuration (push) Waiting to run
Pipeline: Test, Lint, Build / Test JS code (push) Waiting to run
Pipeline: Test, Lint, Build / Get version info (push) Waiting to run
Pipeline: Test, Lint, Build / Lint Go code (push) Waiting to run
Pipeline: Test, Lint, Build / Test Go code (push) Waiting to run
Pipeline: Test, Lint, Build / Build (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-1 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-2 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-3 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-4 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-5 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-6 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-7 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-8 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-9 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build-10 (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Push to GHCR (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Push to Docker Hub (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Cleanup digest artifacts (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Build Windows installers (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Package/Release (push) Blocked by required conditions
Pipeline: Test, Lint, Build / Upload Linux PKG (push) Blocked by required conditions
* build: add sqlite_fts5 build tag to enable FTS5 support
* feat: add SearchBackend config option (default: fts)
* feat: add buildFTS5Query for safe FTS5 query preprocessing
* feat: add FTS5 search backend with config toggle, refactor legacy search
- Add searchExprFunc type and getSearchExpr() for backend selection
- Rename fullTextExpr to legacySearchExpr
- Add ftsSearchExpr using FTS5 MATCH subquery
- Update fullTextFilter in sql_restful.go to use configured backend
* feat: add FTS5 migration with virtual tables, triggers, and search_participants
Creates FTS5 virtual tables for media_file, album, and artist with
unicode61 tokenizer and diacritic folding. Adds search_participants
column, populates from JSON, and sets up INSERT/UPDATE/DELETE triggers.
* feat: populate search_participants in PostMapArgs for FTS5 indexing
* test: add FTS5 search integration tests
* fix: exclude FTS5 virtual tables from e2e DB restore
The restoreDB function iterates all tables in sqlite_master and
runs DELETE + INSERT to reset state. FTS5 contentless virtual tables
cannot be directly deleted from. Since triggers handle FTS5 sync
automatically, simply skip tables matching *_fts and *_fts_* patterns.
* build: add compile-time guard for sqlite_fts5 build tag
Same pattern as netgo: compilation fails with a clear error if
the sqlite_fts5 build tag is missing.
* build: add sqlite_fts5 tag to reflex dev server config
* build: extract GO_BUILD_TAGS variable in Makefile to avoid duplication
* fix: strip leading * from FTS5 queries to prevent "unknown special query" error
* feat: auto-append prefix wildcard to FTS5 search tokens for broader matching
Every plain search token now gets a trailing * appended (e.g., "love" becomes
"love*"), so searching for "love" also matches "lovelace", "lovely", etc.
Quoted phrases are preserved as exact matches without wildcards. Results are
ordered alphabetically by name/title, so shorter exact matches naturally
appear first.
* fix: clarify comments about FTS5 operator neutralization
The comments said "strip" but the code lowercases operators to
neutralize them (FTS5 operators are case-sensitive). Updated comments
to accurately describe the behavior.
* fix: use fmt.Sprintf for FTS5 phrase placeholders
The previous encoding used rune('0'+index) which silently breaks with
10+ quoted phrases. Use fmt.Sprintf for arbitrary index support.
* fix: validate and normalize SearchBackend config option
Normalize the value to lowercase and fall back to "fts" with a log
warning for unrecognized values. This prevents silent misconfiguration
from typos like "FTS", "Legacy", or "fts5".
* refactor: improve documentation for build tags and FTS5 requirements
Signed-off-by: Deluan <deluan@navidrome.org>
* refactor: convert FTS5 query and search backend normalization tests to DescribeTable format
Signed-off-by: Deluan <deluan@navidrome.org>
* fix: add sqlite_fts5 build tag to golangci configuration
Signed-off-by: Deluan <deluan@navidrome.org>
* feat: add UISearchDebounceMs configuration option and update related components
Signed-off-by: Deluan <deluan@navidrome.org>
* fix: fall back to legacy search when SearchFullString is enabled
FTS5 is token-based and cannot match substrings within words, so
getSearchExpr now returns legacySearchExpr when SearchFullString
is true, regardless of SearchBackend setting.
* fix: add sqlite_fts5 build tag to CI pipeline and Dockerfile
* fix: add WHEN clauses to FTS5 AFTER UPDATE triggers
Added WHEN clauses to the media_file_fts_au, album_fts_au, and
artist_fts_au triggers so they only fire when FTS-indexed columns
actually change. Previously, every row update (e.g., play count, rating,
starred status) triggered an unnecessary delete+insert cycle in the FTS
shadow tables. The WHEN clauses use IS NOT for NULL-safe comparison of
each indexed column, avoiding FTS index churn for non-indexed updates.
* feat: add SearchBackend configuration option to data and insights components
Signed-off-by: Deluan <deluan@navidrome.org>
* fix: enhance input sanitization for FTS5 by stripping additional punctuation and special characters
Signed-off-by: Deluan <deluan@navidrome.org>
* feat: add search_normalized column for punctuated name search (R.E.M., AC/DC)
Add index-time normalization and query-time single-letter collapsing to
fix FTS5 search for punctuated names. A new search_normalized column
stores concatenated forms of punctuated words (e.g., "R.E.M." → "REM",
"AC/DC" → "ACDC") and is indexed in FTS5 tables. At query time, runs of
consecutive single letters (from dot-stripping) are collapsed into OR
expressions like ("R E M" OR REM*) to match both the original tokens and
the normalized form. This enables searching by "R.E.M.", "REM", "AC/DC",
"ACDC", "A-ha", or "Aha" and finding the correct results.
* refactor: simplify isSingleUnicodeLetter to avoid []rune allocation
Use utf8.DecodeRuneInString to check for a single Unicode letter
instead of converting the entire string to a []rune slice.
* feat: define ftsSearchColumns for flexible FTS5 search column inclusion
Signed-off-by: Deluan <deluan@navidrome.org>
* feat: update collapseSingleLetterRuns to return quoted phrases for abbreviations
Signed-off-by: Deluan <deluan@navidrome.org>
* feat: implement extractPunctuatedWords to handle artist/album names with embedded punctuation
Signed-off-by: Deluan <deluan@navidrome.org>
* feat: implement extractPunctuatedWords to handle artist/album names with embedded punctuation
Signed-off-by: Deluan <deluan@navidrome.org>
* refactor: punctuated word handling to improve processing of artist/album names
Signed-off-by: Deluan <deluan@navidrome.org>
* feat: add CJK support for search queries with LIKE filters
Signed-off-by: Deluan <deluan@navidrome.org>
* feat: enhance FTS5 search by adding album version support and CJK handling
Signed-off-by: Deluan <deluan@navidrome.org>
* refactor: search configuration to use structured options
Signed-off-by: Deluan <deluan@navidrome.org>
* feat: enhance search functionality to support punctuation-only queries and update related tests
Signed-off-by: Deluan <deluan@navidrome.org>
---------
Signed-off-by: Deluan <deluan@navidrome.org>
181 lines
4.5 KiB
Go
181 lines
4.5 KiB
Go
package persistence
|
|
|
|
import (
|
|
"cmp"
|
|
"context"
|
|
"fmt"
|
|
"reflect"
|
|
"strings"
|
|
"sync"
|
|
|
|
. "github.com/Masterminds/squirrel"
|
|
"github.com/deluan/rest"
|
|
"github.com/fatih/structs"
|
|
"github.com/navidrome/navidrome/log"
|
|
"github.com/navidrome/navidrome/model"
|
|
)
|
|
|
|
type filterFunc = func(field string, value any) Sqlizer
|
|
|
|
func (r *sqlRepository) parseRestFilters(ctx context.Context, options rest.QueryOptions) Sqlizer {
|
|
if len(options.Filters) == 0 {
|
|
return nil
|
|
}
|
|
filters := And{}
|
|
for f, v := range options.Filters {
|
|
// Ignore filters with empty values
|
|
if v == "" {
|
|
continue
|
|
}
|
|
// Look for a custom filter function
|
|
f = strings.ToLower(f)
|
|
if ff, ok := r.filterMappings[f]; ok {
|
|
if filter := ff(f, v); filter != nil {
|
|
filters = append(filters, filter)
|
|
}
|
|
continue
|
|
}
|
|
// Ignore invalid filters (not based on a field or filter function)
|
|
if r.isFieldWhiteListed != nil && !r.isFieldWhiteListed(f) {
|
|
log.Warn(ctx, "Ignoring filter not whitelisted", "filter", f, "table", r.tableName)
|
|
continue
|
|
}
|
|
// For fields ending in "id", use an exact match
|
|
if strings.HasSuffix(f, "id") {
|
|
filters = append(filters, eqFilter(f, v))
|
|
continue
|
|
}
|
|
// Default to a "starts with" filter
|
|
filters = append(filters, startsWithFilter(f, v))
|
|
}
|
|
return filters
|
|
}
|
|
|
|
func (r *sqlRepository) parseRestOptions(ctx context.Context, options ...rest.QueryOptions) model.QueryOptions {
|
|
qo := model.QueryOptions{}
|
|
if len(options) > 0 {
|
|
qo.Sort, qo.Order = r.sanitizeSort(options[0].Sort, options[0].Order)
|
|
qo.Max = options[0].Max
|
|
qo.Offset = options[0].Offset
|
|
if seed, ok := options[0].Filters["seed"].(string); ok {
|
|
qo.Seed = seed
|
|
delete(options[0].Filters, "seed")
|
|
}
|
|
qo.Filters = r.parseRestFilters(ctx, options[0])
|
|
}
|
|
return qo
|
|
}
|
|
|
|
func (r sqlRepository) sanitizeSort(sort, order string) (string, string) {
|
|
if sort != "" {
|
|
sort = toSnakeCase(sort)
|
|
if mapped, ok := r.sortMappings[sort]; ok {
|
|
sort = mapped
|
|
} else {
|
|
if !r.isFieldWhiteListed(sort) {
|
|
log.Warn(r.ctx, "Ignoring sort not whitelisted", "sort", sort, "table", r.tableName)
|
|
sort = ""
|
|
}
|
|
}
|
|
}
|
|
if order != "" {
|
|
order = strings.ToLower(order)
|
|
if order != "desc" {
|
|
order = "asc"
|
|
}
|
|
}
|
|
return sort, order
|
|
}
|
|
|
|
func eqFilter(field string, value any) Sqlizer {
|
|
return Eq{field: value}
|
|
}
|
|
|
|
func startsWithFilter(field string, value any) Sqlizer {
|
|
return Like{field: fmt.Sprintf("%s%%", value)}
|
|
}
|
|
|
|
func containsFilter(field string) func(string, any) Sqlizer {
|
|
return func(_ string, value any) Sqlizer {
|
|
return Like{field: fmt.Sprintf("%%%s%%", value)}
|
|
}
|
|
}
|
|
|
|
func booleanFilter(field string, value any) Sqlizer {
|
|
v := strings.ToLower(value.(string))
|
|
return Eq{field: v == "true"}
|
|
}
|
|
|
|
func fullTextFilter(tableName string, mbidFields ...string) func(string, any) Sqlizer {
|
|
return func(field string, value any) Sqlizer {
|
|
v := strings.ToLower(value.(string))
|
|
searchExpr := getSearchExpr()
|
|
cond := cmp.Or(
|
|
mbidExpr(tableName, v, mbidFields...),
|
|
searchExpr(tableName, v),
|
|
)
|
|
return cond
|
|
}
|
|
}
|
|
|
|
func substringFilter(field string, value any) Sqlizer {
|
|
parts := strings.Fields(value.(string))
|
|
filters := And{}
|
|
for _, part := range parts {
|
|
filters = append(filters, Like{field: "%" + part + "%"})
|
|
}
|
|
return filters
|
|
}
|
|
|
|
func idFilter(tableName string) func(string, any) Sqlizer {
|
|
return func(field string, value any) Sqlizer { return Eq{tableName + ".id": value} }
|
|
}
|
|
|
|
func invalidFilter(ctx context.Context) func(string, any) Sqlizer {
|
|
return func(field string, value any) Sqlizer {
|
|
log.Warn(ctx, "Invalid filter", "fieldName", field, "value", value)
|
|
return Eq{"1": "0"}
|
|
}
|
|
}
|
|
|
|
var (
|
|
whiteList = map[string]map[string]struct{}{}
|
|
mutex sync.RWMutex
|
|
)
|
|
|
|
func registerModelWhiteList(instance any) fieldWhiteListedFunc {
|
|
name := reflect.TypeOf(instance).String()
|
|
registerFieldWhiteList(name, instance)
|
|
return getFieldWhiteListedFunc(name)
|
|
}
|
|
|
|
func registerFieldWhiteList(name string, instance any) {
|
|
mutex.Lock()
|
|
defer mutex.Unlock()
|
|
if whiteList[name] != nil {
|
|
return
|
|
}
|
|
m := structs.Map(instance)
|
|
whiteList[name] = map[string]struct{}{}
|
|
for k := range m {
|
|
whiteList[name][toSnakeCase(k)] = struct{}{}
|
|
}
|
|
ma := structs.Map(model.Annotations{})
|
|
for k := range ma {
|
|
whiteList[name][toSnakeCase(k)] = struct{}{}
|
|
}
|
|
}
|
|
|
|
type fieldWhiteListedFunc func(field string) bool
|
|
|
|
func getFieldWhiteListedFunc(tableName string) fieldWhiteListedFunc {
|
|
return func(field string) bool {
|
|
mutex.RLock()
|
|
defer mutex.RUnlock()
|
|
if _, ok := whiteList[tableName]; !ok {
|
|
return false
|
|
}
|
|
_, ok := whiteList[tableName][field]
|
|
return ok
|
|
}
|
|
}
|