mirror of
https://github.com/navidrome/navidrome.git
synced 2026-08-05 14:20:23 +00:00
810b14ed57
* fix(plugins): confine plugin filesystem mounts to their root A plugin granted read-write filesystem access could escape its mount by creating a relative symlink inside it and then writing through that link, reaching any path the server process can write, including navidrome.db. wazero resolves guest paths by concatenating them onto the host root. Its WASI layer validates every path argument except the symlink target, which path_symlink forwards unvalidated by design, and fs.ValidPath splits on "/" only, so on Windows a "..\" path escapes the mount as well. Mounts now go through a jailedFS wrapper that denies symlink creation and rejects any path that is not filepath.IsLocal. That requires bypassing extism's AllowedPaths, which discards any FSConfig passed alongside it, so the mounts are built directly and applied per instance instead. Following symlinks that already exist in a mount is unchanged: music libraries rely on it, and read-only mounts already reject creating new ones. * test(plugins): guard against setting extism AllowedPaths Extracts the extism manifest construction so a test can assert AllowedPaths is never set. Setting it makes extism build its own FSConfig and discard the jailed mounts, silently restoring the symlink escape. Verified by simulating the regression: with AllowedPaths populated for plugins holding the filesystem permission, the new spec fails, as do two of the end-to-end sandbox specs. |
||
|---|---|---|
| .. | ||
| partial-metadata-agent | ||
| test-artwork | ||
| test-cache-plugin | ||
| test-config | ||
| test-kvstore | ||
| test-library | ||
| test-lyrics | ||
| test-matcher | ||
| test-metadata-agent | ||
| test-scheduler | ||
| test-scrobbler | ||
| test-sonic-similarity | ||
| test-subsonicapi-plugin | ||
| test-taskqueue | ||
| test-users | ||
| test-websocket | ||
| Makefile | ||