vrr/navidrome
2
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-04-26 10:30:46 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 4

test(stream): replace time.Sleep with Eventually assertion in throttle test

Browse source
This commit is contained in:
Deluan 2026-03-25 08:35:32 -04:00
parent 6fe2b76ac1
commit c1f12d148d
1 changed files with 15 additions and 20 deletions
Download patch file Download diff file Expand all files Collapse all files

35
core/stream/throttle_test.go
View file

@ -16,10 +16,10 @@ var _ = Describe("TranscodingThrottle", func() {
Describe("Acquire/Release", func() {
It("allows up to maxConcurrent acquires", func() {
t := newTranscodingThrottle(2, 10, time.Second)
Expect(t.Acquire(context.Background())).To(Succeed())
Expect(t.Acquire(context.Background())).To(Succeed())
Expect(t.Acquire(GinkgoT().Context())).To(Succeed())
Expect(t.Acquire(GinkgoT().Context())).To(Succeed())
// Third should block, so test it doesn't return immediately
ctx, cancel := context.WithTimeout(context.Background(), 50*time.Millisecond)
ctx, cancel := context.WithTimeout(GinkgoT().Context(), 50*time.Millisecond)
defer cancel()
err := t.Acquire(ctx)
Expect(err).To(MatchError(ErrTranscodingBusy))
@ -27,30 +27,26 @@ var _ = Describe("TranscodingThrottle", func() {
It("releases a slot and allows new acquire", func() {
t := newTranscodingThrottle(1, 10, time.Second)
Expect(t.Acquire(context.Background())).To(Succeed())
Expect(t.Acquire(GinkgoT().Context())).To(Succeed())
t.Release()
Expect(t.Acquire(context.Background())).To(Succeed())
Expect(t.Acquire(GinkgoT().Context())).To(Succeed())
})
It("returns ErrTranscodingBusy when backlog limit is reached", func() {
t := newTranscodingThrottle(1, 2, 5*time.Second)
// Fill the slot
Expect(t.Acquire(context.Background())).To(Succeed())
Expect(t.Acquire(GinkgoT().Context())).To(Succeed())
// Fill the backlog (2 waiters) — they block in goroutines
var wg sync.WaitGroup
for i := 0; i < 2; i++ {
wg.Add(1)
go func() {
defer wg.Done()
_ = t.Acquire(context.Background())
}()
wg.Go(func() { _ = t.Acquire(GinkgoT().Context()) })
}
// Give goroutines time to enter backlog
time.Sleep(50 * time.Millisecond)
// Wait until both goroutines are in the backlog
Eventually(func() int64 { return t.backlog.Load() }).Should(BeNumerically(">=", 2))
// Third waiter should be rejected immediately (backlog full)
err := t.Acquire(context.Background())
err := t.Acquire(GinkgoT().Context())
Expect(err).To(MatchError(ErrTranscodingBusy))
// Clean up: release all
@ -62,15 +58,14 @@ var _ = Describe("TranscodingThrottle", func() {
It("returns ErrTranscodingBusy when timeout expires", func() {
t := newTranscodingThrottle(1, 10, 50*time.Millisecond)
Expect(t.Acquire(context.Background())).To(Succeed())
err := t.Acquire(context.Background())
Expect(err).To(MatchError(ErrTranscodingBusy))
Expect(t.Acquire(GinkgoT().Context())).To(Succeed())
Expect(t.Acquire(GinkgoT().Context())).To(MatchError(ErrTranscodingBusy))
})
It("respects context cancellation", func() {
t := newTranscodingThrottle(1, 10, 5*time.Second)
Expect(t.Acquire(context.Background())).To(Succeed())
ctx, cancel := context.WithCancel(context.Background())
Expect(t.Acquire(GinkgoT().Context())).To(Succeed())
ctx, cancel := context.WithCancel(GinkgoT().Context())
cancel()
err := t.Acquire(ctx)
Expect(err).To(MatchError(ErrTranscodingBusy))
@ -79,7 +74,7 @@ var _ = Describe("TranscodingThrottle", func() {
It("is disabled when maxConcurrent is 0", func() {
t := newTranscodingThrottle(0, 10, time.Second)
for i := 0; i < 100; i++ {
Expect(t.Acquire(context.Background())).To(Succeed())
Expect(t.Acquire(GinkgoT().Context())).To(Succeed())
}
})
})