vrr/navidrome
2
0
Fork 0
mirror of https://github.com/navidrome/navidrome.git synced 2026-04-28 03:19:38 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

fix(plugins): silence plugin warnings and folder creation when plugins disabled (#4297)

Browse source 
* fix(plugins): silence repeated “Plugin not found” spam for inactive Spotify/Last.fm plugins

Navidrome was emitting a warning when the optional Spotify or
Last.fm agents weren’t enabled, filling the journal with entries like:

    level=warning msg="Plugin not found" capability=MetadataAgent name=spotify

Fixed by completely disable the plugin system when Plugins.Enabled = false.

Signed-off-by: Deluan <deluan@navidrome.org>

* style: update test description for clarity

Signed-off-by: Deluan <deluan@navidrome.org>

* fix: ensure plugin folder is created only if plugins are enabled

Signed-off-by: Deluan <deluan@navidrome.org>

---------

Signed-off-by: Deluan <deluan@navidrome.org>
This commit is contained in:
Deluan Quintão 2025-07-02 13:17:59 -04:00 • committed by GitHub
parent 82f490d066
commit a3d1a9dbe5
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
18 changed files with 102 additions and 64 deletions
Download patch file Download diff file Expand all files Collapse all files

4
plugins/manager_test.go
View file

@ -12,7 +12,7 @@ import (
)
var _ = Describe("Plugin Manager", func() {
var mgr *Manager
var mgr *managerImpl
var ctx context.Context
BeforeEach(func() {
@ -76,7 +76,7 @@ var _ = Describe("Plugin Manager", func() {
Describe("ScanPlugins", func() {
var tempPluginsDir string
var m *Manager
var m *managerImpl
BeforeEach(func() {
tempPluginsDir, _ = os.MkdirTemp("", "navidrome-plugins-test-*")