From 1bbafbd5d2dbe3ef355dced52025c9a3640cd581 Mon Sep 17 00:00:00 2001 From: Ivan Nardi Date: Tue, 18 Nov 2025 19:35:10 +0000 Subject: [PATCH] Build system: Apply warning flags consistently to performance tests MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Ensure that performance test tools are compiled with project warning flags (NDPI_CFLAGS) for consistent code quality standards across the codebase. Previously, tests/performance/Makefile.in compiled tools (gcrypt-int, gcrypt-gnu, substringsearch, strnstr, geo, patriciasearch) with only user-provided CFLAGS, missing the project's warning flags (-W, -Wall, -Wno-address-of-packed-member). 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude --- tests/performance/Makefile.in | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/tests/performance/Makefile.in b/tests/performance/Makefile.in index ff4831bbb..b4d2c0f1b 100644 --- a/tests/performance/Makefile.in +++ b/tests/performance/Makefile.in @@ -17,19 +17,19 @@ all: $(TESTS) tools: $(TOOLS) gcrypt-int: $(srcdir)/gcrypt.c Makefile $(GEN_HEADERS) - $(CC) $(INC) @CFLAGS@ $(srcdir)/gcrypt.c -o $@ + $(CC) $(INC) @NDPI_CFLAGS@ @CFLAGS@ $(srcdir)/gcrypt.c -o $@ gcrypt-gnu: $(srcdir)/gcrypt.c Makefile $(GEN_HEADERS) - $(CC) $(INC) @CFLAGS@ -DHAVE_LIBGCRYPT $(srcdir)/gcrypt.c -o $@ -lgcrypt + $(CC) $(INC) @NDPI_CFLAGS@ @CFLAGS@ -DHAVE_LIBGCRYPT $(srcdir)/gcrypt.c -o $@ -lgcrypt substringsearch: $(srcdir)/substringsearch.c Makefile $(GEN_HEADERS) - $(CC) $(INC) @CFLAGS@ $(srcdir)/substringsearch.c -o substringsearch $(LIB) + $(CC) $(INC) @NDPI_CFLAGS@ @CFLAGS@ $(srcdir)/substringsearch.c -o substringsearch $(LIB) strnstr: $(srcdir)/strnstr.cpp Makefile $(GEN_HEADERS) - $(CXX) $(INC) @CFLAGS@ $(srcdir)/strnstr.cpp -o strnstr + $(CXX) $(INC) @NDPI_CFLAGS@ @CFLAGS@ $(srcdir)/strnstr.cpp -o strnstr geo: $(srcdir)/geo.c Makefile $(GEN_HEADERS) - $(CC) $(INC) @CFLAGS@ $(srcdir)/geo.c -o geo $(LIB) + $(CC) $(INC) @NDPI_CFLAGS@ @CFLAGS@ $(srcdir)/geo.c -o geo $(LIB) substring_test: substringsearch top-1m.csv ./substringsearch @@ -43,7 +43,7 @@ geo_test: geo # patriciasearch: $(srcdir)/patriciasearch.c Makefile $(GEN_HEADERS) - $(CC) $(INC) @CFLAGS@ $(srcdir)/patriciasearch.c -o patriciasearch $(LIB) + $(CC) $(INC) @NDPI_CFLAGS@ @CFLAGS@ $(srcdir)/patriciasearch.c -o patriciasearch $(LIB) patricia_test: patriciasearch blacklist-ip.txt ./patriciasearch