vrr/multi-scrobbler
2
0
Fork 0
mirror of https://github.com/FoxxMD/multi-scrobbler.git synced 2026-10-19 15:26:33 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

fix(lz): Only use original artist_name in naive play if no artists credits were extracted

Browse source 
Prevents single artist string with joiner slipping through uniqueNormalizedStrArr filter on artists
This commit is contained in:
FoxxMD 2026-10-13 13:54:36 +00:00
parent 1380097efd
commit c792ed3d44
2 changed files with 31 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

5
src/backend/common/vendor/ListenbrainzApiClient.ts vendored
View file

@ -656,7 +656,6 @@ export const listenToNaivePlay = (listen: ListenResponse): PlayObject => {
if(artist_names.length > 0) {
artists = artist_names;
} else if(typeof artist_name === 'string') {
artists = [artist_name];
// since we aren't using MB mappings we should be conservative and assume artist string with & are proper names (not joiner)
const parsedArtists = parseCredits(artist_name, [',', '/', '\\']);
@ -673,6 +672,10 @@ export const listenToNaivePlay = (listen: ListenResponse): PlayObject => {
normalTrackName = parsedTrackArtists.primary;
artists = artists.concat(parsedTrackArtists.secondary ?? [])
}
if(artists.length === 0) {
// fallback to original artist_name string if we weren't able to parse anything from artists/track credits
artists.push(artist_name);
}
artists = uniqueNormalizedStrArr(artists);
}

27
src/backend/tests/listenbrainz/listenbrainz.test.ts
View file

@ -25,6 +25,7 @@ import incorrectMultiArtistsTrackName from './incorrectlyMapped/multiArtistsInTr
import veryWrong from './incorrectlyMapped/veryWrong.json' with { type: "json" };
import { generatePlay } from "../../../core/tests/utils/PlayTestUtils.ts";
import { nameToCredit, creditsToNames, namesToCredits } from "../../../core/MusicMetadata.ts";
import { playStateFromRequest } from "../../sources/EndpointListenbrainzSource.ts";
interface LZTestFixture {
data: ListenResponse
@ -371,6 +372,32 @@ describe('Listenbrainz Endpoint Behavior', function() {
});
it('does not include artist_name if artists were extracted from string', function() {
const payload = {
"listened_at": 1791895981,
"track_metadata": {
"artist_name": "Alohaii feat. Rachie",
"track_name": "Heart Of Glass",
"release_name": "SUMMERTIDE",
"additional_info": {
"artist_mbids": [
"a611433b-c2bb-4ba2-be28-775a079e93c6",
"745a0c93-a487-4650-ab05-07c4eb9234a2"
],
"release_mbid": "560db4c2-5af5-4ef0-a9e0-b56fca3d8bea",
"release_group_mbid": "e5a74679-1883-45cb-b776-8b7aee879760",
"recording_mbid": "3d4a73ff-3956-4d6b-b423-b1c079775dcf",
"duration_ms": 217433,
"track_mbid": "c3fda34b-31e1-4e9a-af76-85e3dd08b09f",
"tracknumber": 4
}
}
}
const state = playStateFromRequest({listen_type: 'single', payload: [payload]});
expect(state[0].play.data.artists?.some(x => x.name === 'Alohaii')).is.true;
expect(state[0].play.data.artists?.some(x => x.name === 'Rachie')).is.true;
})
});