vrr/learn-claude-code
2
0
Fork 0
mirror of https://github.com/shareAI-lab/learn-claude-code.git synced 2026-05-21 02:29:23 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 2

seed .env first and pin Python via .python-version + pyenv

Browse source 
- Move .env seeding to step 1 so users can start editing while deps install.
- Add .python-version (3.11); setup.sh resolves pyenv's matching interpreter
  automatically, so no manual 'pyenv shell' needed.
- Falls back to \$PYTHON_BIN/python3 when pyenv isn't installed.
- Capture pyenv output into a variable before grep -q to avoid SIGPIPE
  (exit 141) under set -o pipefail.
This commit is contained in:
Fred Liang 2026-04-29 14:23:48 -07:00
parent 4bde3d3b64
commit 70d95119f3
2 changed files with 68 additions and 43 deletions
Download patch file Download diff file Expand all files Collapse all files

1
.python-version Normal file
View file

@ -0,0 +1 @@
3.11

110
setup.sh
View file

@ -1,7 +1,7 @@
#!/usr/bin/env bash
# Dev environment bootstrap for learn-claude-code.
# Creates a local .venv, installs requirements.txt, and seeds .env from
# .env.example. Safe to re-run -- existing venv and .env are preserved.
# Seeds .env, pins Python via .python-version (pyenv), creates a local .venv,
# and installs requirements.txt. Safe to re-run -- existing files are preserved.
set -euo pipefail
@ -9,7 +9,6 @@ REPO_ROOT="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
cd "$REPO_ROOT"
VENV_DIR="${VENV_DIR:-.venv}"
PYTHON_BIN="${PYTHON_BIN:-python3}"
MIN_PY_MAJOR=3
MIN_PY_MINOR=10
@ -17,46 +16,7 @@ say() { printf '\033[36m==>\033[0m %s\n' "$*"; }
warn() { printf '\033[33m[warn]\033[0m %s\n' "$*" >&2; }
die() { printf '\033[31m[error]\033[0m %s\n' "$*" >&2; exit 1; }
# 1. Check Python
if ! command -v "$PYTHON_BIN" >/dev/null 2>&1; then
die "'$PYTHON_BIN' not found. Install Python ${MIN_PY_MAJOR}.${MIN_PY_MINOR}+ or set PYTHON_BIN."
fi
PY_VERSION="$("$PYTHON_BIN" -c 'import sys; print("%d.%d" % sys.version_info[:2])')"
say "Using $PYTHON_BIN ($PY_VERSION)"
"$PYTHON_BIN" - <<PY || die "Python ${MIN_PY_MAJOR}.${MIN_PY_MINOR}+ required (found $PY_VERSION)."
import sys
sys.exit(0 if sys.version_info >= (${MIN_PY_MAJOR}, ${MIN_PY_MINOR}) else 1)
PY
# 2. Create venv
if [ ! -d "$VENV_DIR" ]; then
say "Creating virtualenv at $VENV_DIR"
"$PYTHON_BIN" -m venv "$VENV_DIR"
else
say "Reusing virtualenv at $VENV_DIR"
fi
# shellcheck disable=SC1091
source "$VENV_DIR/bin/activate"
# 3. Configure Instacart CodeArtifact (skip silently if `isc` isn't installed)
if command -v isc >/dev/null 2>&1; then
say "Configuring Instacart CodeArtifact (isc codeartifact configure)"
isc codeartifact configure
else
warn "'isc' not found; skipping CodeArtifact configure (non-Instacart users can ignore)."
fi
# 4. Install deps
say "Upgrading pip"
python -m pip install --upgrade pip >/dev/null
say "Installing requirements.txt"
python -m pip install -r requirements.txt
# 5. Seed .env
# 1. Seed .env first so users can start editing while deps install
if [ ! -f .env ]; then
if [ -f .env.example ]; then
say "Creating .env from .env.example"
@ -69,6 +29,70 @@ else
say ".env already exists (leaving as-is)"
fi
# 2. Pick Python interpreter.
# If .python-version exists and pyenv is available, resolve through pyenv
# so the user doesn't have to switch manually. Otherwise fall back to
# $PYTHON_BIN (default: python3).
PINNED_PY=""
if [ -f .python-version ]; then
PINNED_PY="$(tr -d '[:space:]' < .python-version)"
fi
if [ -n "$PINNED_PY" ] && command -v pyenv >/dev/null 2>&1; then
# Capture once: piping into `grep -q` can return SIGPIPE (141) under pipefail.
PYENV_VERSIONS="$(pyenv versions --bare)"
if ! grep -qx "$PINNED_PY" <<<"$PYENV_VERSIONS" \
&& ! grep -q "^${PINNED_PY}\." <<<"$PYENV_VERSIONS"; then
warn "pyenv: Python $PINNED_PY not installed. Run: pyenv install $PINNED_PY"
die "Install the pinned Python, then re-run ./setup.sh"
fi
PYTHON_BIN="$(pyenv which python 2>/dev/null || true)"
[ -n "$PYTHON_BIN" ] || die "pyenv could not resolve python for version $PINNED_PY"
say "Using pyenv Python $PINNED_PY ($PYTHON_BIN)"
else
PYTHON_BIN="${PYTHON_BIN:-python3}"
if ! command -v "$PYTHON_BIN" >/dev/null 2>&1; then
die "'$PYTHON_BIN' not found. Install Python ${MIN_PY_MAJOR}.${MIN_PY_MINOR}+ (or install pyenv + run: pyenv install $PINNED_PY)."
fi
if [ -n "$PINNED_PY" ]; then
warn "pyenv not installed; using system $PYTHON_BIN (.python-version pins $PINNED_PY)."
fi
fi
PY_VERSION="$("$PYTHON_BIN" -c 'import sys; print("%d.%d" % sys.version_info[:2])')"
say "Python interpreter: $PYTHON_BIN ($PY_VERSION)"
"$PYTHON_BIN" - <<PY || die "Python ${MIN_PY_MAJOR}.${MIN_PY_MINOR}+ required (found $PY_VERSION)."
import sys
sys.exit(0 if sys.version_info >= (${MIN_PY_MAJOR}, ${MIN_PY_MINOR}) else 1)
PY
# 3. Create venv
if [ ! -d "$VENV_DIR" ]; then
say "Creating virtualenv at $VENV_DIR"
"$PYTHON_BIN" -m venv "$VENV_DIR"
else
say "Reusing virtualenv at $VENV_DIR"
fi
# shellcheck disable=SC1091
source "$VENV_DIR/bin/activate"
# 4. Configure Instacart CodeArtifact (skip silently if `isc` isn't installed)
if command -v isc >/dev/null 2>&1; then
say "Configuring Instacart CodeArtifact (isc codeartifact configure)"
isc codeartifact configure
else
warn "'isc' not found; skipping CodeArtifact configure (non-Instacart users can ignore)."
fi
# 5. Install deps
say "Upgrading pip"
python -m pip install --upgrade pip >/dev/null
say "Installing requirements.txt"
python -m pip install -r requirements.txt
# 6. Quick import sanity check
say "Verifying imports"
python - <<'PY'