mirror of
https://github.com/LostRuins/koboldcpp.git
synced 2026-05-18 06:19:19 +00:00
0c3e4fccca
* fix: Propagate version tag to WebUI asset download in self-hosted CI * refactor: Apply suggestions from @CISC Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> * fix: Skip npm build when Node.js is not installed Avoid 'no such file or directory' errors on CI runners that lack Node.js. Check if npm is available via find_program before attempting npm install + npm run build. Falls back to HF Bucket download. * fix: Use + separator for ASSETS list to fix Windows build Replace fragile \; escaping with a + separator when passing the WebUI asset list via -DASSETS to the download script. On Windows, the \; escaping was not reliably preserved through the CMake build system, causing all asset filenames to be concatenated into one (e.g., 'index.html;bundle.js;bundle.css;loading.html' as a single file), which broke the HF Bucket download and subsequent xxd.cmake step. + is safe because it is not special in cmd.exe (unlike | which is a pipe operator), not special in CMake's -D argument parser, and not a valid Windows filename character. CMakeLists.txt joins assets with + and webui-download.cmake splits them back via regex. * fix: Validate HF_WEBUI_VERSION environment variable with regex Add input validation for the HF_WEBUI_VERSION env var to prevent CMake list separator or path-traversal issues in stamp filenames and download URLs. Rejects non-conforming characters early. * fix: Remove 'latest' fallback for HF_WEBUI_VERSION When needs.determine-tag.outputs.tag_name is empty, let CMake's default resolution handle it (empty -> git-based version lookup) instead of falling back to 'latest'. This ensures the sentinel stamp file is consistent with CMake's resolution logic. * fix: Demote checksum verification failure to warning instead of hard gate * fix: End line character --------- Co-authored-by: Sigbjørn Skjæret <sigbjorn.skjaeret@scala.com> |
||
|---|---|---|
| .. | ||
| ai-issues.yml | ||
| bench.yml.disabled | ||
| build-3rd-party.yml | ||
| build-and-test-snapdragon.yml | ||
| build-android.yml | ||
| build-apple.yml | ||
| build-cache.yml | ||
| build-cann.yml | ||
| build-cmake-pkg.yml | ||
| build-cross.yml | ||
| build-msys.yml | ||
| build-openvino.yml | ||
| build-riscv.yml | ||
| build-sanitize.yml | ||
| build-self-hosted.yml | ||
| build-sycl.yml | ||
| build-virtgpu.yml | ||
| build-vulkan.yml | ||
| build.yml | ||
| check-vendor.yml | ||
| close-issue.yml | ||
| code-style.yml | ||
| copilot-setup-steps.yml | ||
| docker.yml | ||
| editorconfig.yml | ||
| gguf-publish.yml | ||
| hip-quality-check.yml | ||
| labeler.yml | ||
| pre-tokenizer-hashes.yml | ||
| python-check-requirements.yml | ||
| python-lint.yml | ||
| python-type-check.yml | ||
| release.yml | ||
| server-sanitize.yml | ||
| server-self-hosted.yml | ||
| server-webui.yml | ||
| server.yml | ||
| update-ops-docs.yml | ||
| webui-build.yml | ||
| webui-publish.yml | ||
| winget.yml | ||