vrr/koboldcpp
2
0
Fork 0
mirror of https://github.com/LostRuins/koboldcpp.git synced 2026-05-07 00:41:50 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions 3

sd: fix LoRA multiplier logic to switch to at_runtime mode (#2029)

Browse source 
`0. in inputs.lora_multipliers` didn't work because the C array has
variable length.

Also fixed a few corner cases related to the default multipliers
(mainly to ensure robustness against future changes, since in most
cases the multiplier list is already sanitized by a previous
function).
This commit is contained in:
Wagner Bruna 2026-03-12 04:36:51 -03:00 • committed by GitHub
parent 318a5486ce
commit 796f7bdeff
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 18 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

22
koboldcpp.py
View file

@ -2023,19 +2023,12 @@ def sd_load_model(model_filename,vae_filename,lora_filenames,t5xxl_filename,clip
lora_filenames = [lf.encode("UTF-8") for lf in lora_filenames[:lora_filenames_max] if lf]
lora_len = len(lora_filenames)
lora_multipliers = args.sdloramult[:lora_len]
if len(lora_multipliers) < lora_len:
missing = lora_len - len(lora_multipliers)
if len(lora_multipliers) == 1:
# previous behavior: all get the same weight
lora_multipliers.extend(lora_multipliers * missing)
else:
lora_multipliers.extend([0.] * missing)
lora_multipliers = prepare_lora_multipliers([])
inputs.lora_len = lora_len
inputs.lora_filenames = (ctypes.c_char_p * lora_len)(*lora_filenames)
inputs.lora_multipliers = (ctypes.c_float * lora_len)(*lora_multipliers)
# auto if no zero-weight lora, dynamic otherwise
inputs.lora_apply_mode = 3 if 0. in inputs.lora_multipliers else 0
inputs.lora_apply_mode = 3 if 0. in lora_multipliers else 0
inputs.img_hard_limit = args.sdclamped
inputs.img_soft_limit = args.sdclampedsoft
@ -8491,20 +8484,19 @@ def mk_lora_info(imgloras, multipliers):
# the full filename as a path, but we don't know if we can expose it
used_lora_names = set()
result = []
first_multiplier = multipliers[0] if len(multipliers) > 0 else 1.
for i, lora_path in enumerate(imgloras):
multiplier = 0. if i >= len(multipliers) else multipliers[i]
multiplier = multipliers[i] if i < len(multipliers) else first_multiplier
lora_file = os.path.basename(lora_path)
lora_name, lora_ext = os.path.splitext(lora_file)
# ensure unique names
i = 1
mapped_name = lora_name
while True:
if mapped_name not in used_lora_names:
result.append((lora_path, mapped_name, mapped_name + lora_ext, multiplier))
used_lora_names.add(mapped_name)
break
while mapped_name in used_lora_names:
i += 1
mapped_name = lora_name + '_' + str(i)
used_lora_names.add(mapped_name)
result.append((lora_path, mapped_name, mapped_name + lora_ext, multiplier))
return result