vrr/koboldcpp
2
0
Fork 0
mirror of https://github.com/LostRuins/koboldcpp.git synced 2025-09-11 09:34:37 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

Fix additional settings related to inv dynatemp (#1391)

Browse source 
* update additional dynatemp settings

* Label fix

* remove min restrict

* 1 more

* update to match lite
This commit is contained in:
Reithan 2025-02-28 03:02:22 -08:00 • committed by GitHub
parent b0b067cd96
commit 02971ca323
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
4 changed files with 11 additions and 15 deletions
Download patch file Download diff file Expand all files Collapse all files

2
gpttype_adapter.cpp
View file

@ -1640,7 +1640,7 @@ const std::vector<samplers> & sampler_order, llama_grammar * grammar, float dyna
else if (nsigma > 0.0f)
{
sample_top_k(&candidates_p, top_k);
if (dynatemp_range > 0) {
if (dynatemp_range != 0) {
float dynatemp_min = temp - dynatemp_range;
float dynatemp_max = temp + dynatemp_range;
//do not allow negative values

5
kcpp_docs.embd
View file

@ -141,8 +141,9 @@
},
"dynatemp_range": {
"default": 0,
"description": "If greater than 0, uses dynamic temperature. Dynamic temperature range will be between Temp+Range and Temp-Range. If less or equal to 0 , uses static temperature.",
"minimum": 0,
"description": "If not equal to 0, uses dynamic temperature. Dynamic temperature range will be between Temp+Range and Temp-Range. If equal to 0 , uses static temperature.",
"minimum": -5,
"maximum": 5,
"type": "number"
},
"smoothing_factor": {

17
klite.embd
View file

@ -8526,13 +8526,8 @@ Current version indicated by LITEVER below.
{
let a1 = parseFloat(document.getElementById("dynatemp_min").value);
let a2 = parseFloat(document.getElementById("dynatemp_max").value);
if (a2<a1)
{
a2 = a1;
document.getElementById("dynatemp_max").value = document.getElementById("dynatemp_min").value;
}
let avg = (a1+a2)*0.5;
let diff = Math.abs(a2 - a1)*0.5;
let diff = (a2 - a1)*0.5;
document.getElementById("dynatemp_range").value = diff.toFixed(3);
document.getElementById("dynatemp_outtemp").value = avg.toFixed(3);
document.getElementById("temperature").value = avg.toFixed(3);
@ -8543,7 +8538,7 @@ Current version indicated by LITEVER below.
function confirm_dynatemp()
{
document.getElementById("dynatempcontainer").classList.add("hidden");
document.getElementById("dynatemp_overview").innerText = (document.getElementById("dynatemp_range").value>0?"ON":"OFF");
document.getElementById("dynatemp_overview").innerText = (document.getElementById("dynatemp_range").value!=0?"ON":"OFF");
}
function show_dynatemp()
{
@ -10867,7 +10862,7 @@ Current version indicated by LITEVER below.
document.getElementById("dynatemp_exponent").value = localsettings.dynatemp_exponent;
document.getElementById("smoothing_factor").value = localsettings.smoothing_factor;
document.getElementById("nsigma").value = localsettings.nsigma;
document.getElementById("dynatemp_overview").innerText = (localsettings.dynatemp_range>0?"ON":"OFF");
document.getElementById("dynatemp_overview").innerText = (localsettings.dynatemp_range!=0?"ON":"OFF");
document.getElementById("presence_penalty").value = localsettings.presence_penalty;
document.getElementById("sampler_seed").value = localsettings.sampler_seed;
document.getElementById("top_k").value = document.getElementById("top_k_slide").value = localsettings.top_k;
@ -11072,7 +11067,7 @@ Current version indicated by LITEVER below.
document.getElementById("rep_pen_slope").value = found.rep_pen_slope;
document.getElementById("sampler_order").value = found.sampler_order.toString();
document.getElementById("presetsdesc").innerText = found.description;
document.getElementById("dynatemp_overview").innerText = (document.getElementById("dynatemp_range").value>0?"ON":"OFF");
document.getElementById("dynatemp_overview").innerText = (document.getElementById("dynatemp_range").value!=0?"ON":"OFF");
}else{
document.getElementById("presetsdesc").innerText = "";
}
@ -11418,8 +11413,8 @@ Current version indicated by LITEVER below.
localsettings.rep_pen_slope = cleannum(localsettings.rep_pen_slope, 0, 20);
localsettings.top_p = cleannum(localsettings.top_p, 0.002, 1);
localsettings.min_p = cleannum(localsettings.min_p, 0.0, 1);
localsettings.dynatemp_range = cleannum(localsettings.dynatemp_range, 0.0, 5);
localsettings.dynatemp_range = (localsettings.dynatemp_range>localsettings.temperature?localsettings.temperature:localsettings.dynatemp_range);
localsettings.dynatemp_range = cleannum(localsettings.dynatemp_range, -5, 5);
localsettings.dynatemp_range = (localsettings.dynatemp_range>localsettings.temperature?localsettings.temperature:localsettings.dynatemp_range<-localsettings.temperature?-localsettings.temperature:localsettings.dynatemp_range);
localsettings.dynatemp_exponent = cleannum(localsettings.dynatemp_exponent, 0.0, 10.0);
localsettings.smoothing_factor = cleannum(localsettings.smoothing_factor, 0.0, 10.0);
localsettings.nsigma = cleannum(localsettings.nsigma, 0.0, 5.0);

2
otherarch/otherarch.h
View file

@ -47,7 +47,7 @@ struct kcpp_params {
std::vector<std::string> dry_sequence_breakers; // DRY sequence breakers
float xtc_threshold = 0;
float xtc_probability = 0;
float dynatemp_range = 0.0f; // enables DynaTemp if greater than 0. dynatemp_min = temperature - dt_range, dynatemp_max = temperature + dt_range
float dynatemp_range = 0.0f; // enables DynaTemp if neq 0. dynatemp_min = temperature - dt_range, dynatemp_max = temperature + dt_range
float dynatemp_exponent = 1.0f;
std::string model_filename = ""; // model path