mirror of
https://github.com/MoonshotAI/kimi-code.git
synced 2026-08-25 16:46:17 +00:00
c12f30951f
* feat(agent-core): feed AskUserQuestion answers back as question text and option labels
The flattened answers record the model receives was keyed by synthesized
ids (q_0 / opt_0_1), forcing a cross-message positional lookup against the
original tool call to understand what the user picked — both unreadable in
transcripts and a real model-misreads-the-choice badcase.
- toAgentCoreResponse now takes the original broker request and translates
wire ids back to question text (keys) and option labels (values);
unknown ids are kept verbatim, missing request falls back to raw ids
- wire protocol unchanged: clients still answer with option ids; the
resolve route reads the pending request before settling it
- question texts must be unique per call and option labels unique per
question, enforced in the tool execution path (AJV cannot express the
zod refine) and mirrored on the exported schemas
- web transcript card resolves both the new label form and legacy id
transcripts; TUI and ACP paths already produced the text form
* fix(agent-core): align multi-select answer join across clients and harden question schema
- Join multi-select labels with ', ' in the server translator, matching
what the TUI reverse-RPC path already emits, so the model sees one
format regardless of which client answered
- Trim segments in the web transcript resolver before label matching:
TUI-answered multi-select transcripts (', '-joined) previously lost
their highlight to a spurious leading-space Other row
- Move the question-text/legacy-q_<i> answer lookup out of the SFC into
askUserToolParse as answerFor(), per that module's testability intent
- Require non-empty question text and option labels (.min(1)) so empty
strings are rejected by AJV at the tool boundary instead of failing
deeper in the protocol layer
* fix(agent-core): resolve option ids only within the answered question
The translator's option-id lookup was a single flat map across all
questions, so a stale or malformed response pairing one question with
another question's option id (q_1 + opt_0_0) was silently translated
into a label that was never offered for that question. Scope the lookup
to the answered question's own options; cross-question and unknown ids
now both pass through verbatim, staying diagnosable.
|
||
|---|---|---|
| .. | ||
| background | ||
| cron | ||
| fixtures | ||
| planning | ||
| policies | ||
| providers | ||
| agent.test.ts | ||
| ask-user.test.ts | ||
| bash-env.test.ts | ||
| bash-windows-kill.test.ts | ||
| bash.test.ts | ||
| builtin-current.test.ts | ||
| edit.test.ts | ||
| enter-plan-mode.test.ts | ||
| exit-plan-mode-options.test.ts | ||
| exit-plan-mode.test.ts | ||
| fetch-url.test.ts | ||
| file-type.test.ts | ||
| glob.test.ts | ||
| goal.test.ts | ||
| grep.test.ts | ||
| image-compress.test.ts | ||
| image-originals.test.ts | ||
| input-schema-io.test.ts | ||
| list-directory.test.ts | ||
| path-guard.test.ts | ||
| plan-mode-hard-block.test.ts | ||
| read-file.test.ts | ||
| read-media-desc.test.ts | ||
| read-media.test.ts | ||
| read.test.ts | ||
| result-builder.test.ts | ||
| rg-locator.test.ts | ||
| shell-cancel.test.ts | ||
| shell-quoting.test.ts | ||
| skill-tool-dispatch.test.ts | ||
| skill-tool.test.ts | ||
| todo-list.test.ts | ||
| web-search.test.ts | ||
| write.test.ts | ||