kimi-code/packages/server/test/svc/systemd.test.ts
liruifengv b51e13538d
ci: run unit tests on windows (#1037)
* ci: run unit tests on windows

* fix(migration-legacy): align workdir bucket key with agent-core

computeWorkdirBucket used a local node:path-based resolve that yields backslash-separated paths on Windows, while agent-core's encodeWorkDirKey uses pathe (forward slashes on every platform). The SHA-256 inputs diverged, so migrated sessions were written to a bucket that the session picker never reads, making them invisible on Windows.

Alias computeWorkdirBucket to encodeWorkDirKey so both sides stay byte-identical, drop the local slugify copy, and update the workdir-bucket test reference accordingly.

* test(acp-adapter): expect platform-native separators in e2e-fs path

The e2e-fs test asserted the fs/readTextFile wire path as the raw POSIX targetPath, but AcpKaos.toClientPath converts '/' to '\' when the inner LocalKaos reports pathClass 'win32' (Windows). On Windows the wire path became '\Users\test\x.ts' and the assertion failed.

Mirror toClientPath in the test: expect backslash separators on win32 and the raw path otherwise. Implementation is unchanged.

* test(sdk): normalize workDir and skillDir paths in session tests

SessionStore.create/list and the skill loader normalize paths through pathe (forward slashes). The SDK tests compared the resulting workDir and skill loaded-dir against raw mkdtemp / node:path strings, which use backslashes on Windows (and node:fs realpath also returns backslashes for the skill dir), failing three toMatchObject assertions.

Build the expected paths with agent-core's normalizeWorkDir so they match the internal pathe representation on every platform. The skill dir keeps its realpath() (the loader realpaths the root) and only normalizes separators.

* test(skill): normalize realpath to forward slashes in scanner tests

resolveSkillRoots normalizes every root.path through fs.realpath followed by replacing backslashes with forward slashes (scanner.ts). The scanner tests compared root.path against node:fs realpath directly, which returns backslashes on Windows, so twenty assertions failed (toEqual / toContain / toHaveLength) even though the resolved paths were identical.

Wrap realpath at the top of the test file to mirror the implementation's normalization, so every comparison uses the same forward-slash form on every platform.

* test: skip Unix-only permission tests on Windows

The Unix file-permission assertions (mode bits like 0o600 / 0o700 and chmod 000 making a path unreadable) have no equivalent on Windows, which uses ACLs; fs.chmod there can only toggle the read-only bit. These six tests failed on Windows with mismatched mode values or a missing 40411.

Skip them on win32 via it.skipIf(process.platform === 'win32'): oauth FileTokenStorage (0600 file, 0700 dir), agent-core BackgroundTaskPersistence (0700 tasks dir), agent-core createPerIdJsonStore (0700 subdir), migration-legacy atomicWrite (0600 file), and server fs:browse (chmod 000 -> 40411).

* test(tui): make platform-sensitive assertions cross-platform

The TUI implementations are already platform-aware (pathe-style paths, pathToFileURL, quoteShellArg cmd/POSIX quoting, Alt+V on Windows for paste expansion), but the tests hard-coded POSIX expectations and failed on Windows.

Align the assertions with the implementation's platform behavior: footer-goal-badge matches the '[goal' badge prefix instead of /goal/ (toolbar tips contain '/goal'); tool-call expects backslash relative paths on win32; plan-box builds the file:// URL via pathToFileURL; custom-editor sends Alt+V on win32 for paste expansion; file-mention-provider normalizes the expected description to forward slashes; kimi-tui-startup builds the resume command with quoteShellArg; kimi-tui-message-flow builds the expected install path with resolve().

* test: align path assertions with pathe on Windows

Several test suites asserted paths produced by node:path/node:os/node:fs against values that agent-core, node-sdk and kaos normalize through pathe (forward slashes). On Windows the two forms diverge (backslashes vs forward slashes), failing about 19 assertions.

Mirror the implementation's normalization in the assertions via a local toPosix helper (or agent-core's normalizeWorkDir), so expected paths use forward slashes on every platform: kaos LocalKaos, node-sdk export/list/resume/config/transport sessions, cli FileMentionProvider, and agent-core skill-session.

* test(native): build path expectations with node:path.resolve

paths.mjs builds every path with node:path.resolve, which yields backslash-separated absolute paths on Windows. The path-helpers tests asserted against template strings that mixed the backslash appRoot with forward-slash segments, so Object.is failed on Windows even though the strings looked identical.

Build the expectations with the same resolve(appRoot, ...) helper so the separators match on every platform.

* fix: make Windows CI tests pass across all packages

Fix the remaining Windows CI failures so the Windows test job can go green. The changes fall into a few categories:

- Path separators: agent-core/node-sdk/kaos normalize paths via pathe (forward slashes); align test expectations and a couple of implementations (native cache base, workspace registry) with that.

- Platform-only services: skip launchd/systemd manager suites on win32 (Windows uses schtasks).

- Process/signal lifecycle: skip or relax tests that rely on POSIX signals / SIGTERM semantics that Windows does not support.

- Hook shell syntax: rewrite hook test commands from POSIX shell (single quotes, semicolons, stderr redirects, if/then/fi) to node -e / .cjs files that run under cmd.exe.

- CRLF: make Bash tool description stripping tolerate CRLF line endings.

- Misc: realpath short-name divergence, port-retry timing, telemetry spawn, fs-watch timing, snapshot path normalization, etc.

* fix: remove unused basename import in workspaceRegistryService

Fix lint error (no-unused-vars): basename from node:path is no longer used after switching to posixBasename from pathe.

* fix: align resume harness pathClass and wait for banner state on Windows

Two more Windows CI fixes:

- createResumeNoSideEffectKaos now reports pathClass 'win32' on Windows so tool descriptions (e.g. Glob's Windows note) match the live agent in expectResumeMatches, fixing usage/description deep-equal drift.

- kimi-tui-startup once-banner test now waits for writeBannerDisplayState to land before asserting, since the atomic write can lag behind the render on Windows.

* fix: resolve remaining Windows unit test failures

Make the new Windows CI job green across agent-core, kaos, node-sdk and server:

- Align the resume harness kaos pathClass with the live agent so platform-conditional tool descriptions (Glob's Windows note) match in expectResumeMatches instead of drifting on win32.
- Rewrite hook commands in agent-core tests as cross-platform node one-liners; single-quote echo, >&2 and ';' do not work under cmd.exe.
- Add .gitattributes enforcing LF so raw-imported templates (e.g. the compaction instruction) produce byte-identical token counts on Windows and POSIX.
- Terminate the full process tree on Windows in both the hook runner and kaos (taskkill /T /F) so grandchildren cannot outlive their parent and keep the cwd locked.
- Normalize workDir path separators in two kimi-sdk session tests to match the stored canonical form.
- Avoid cmd.exe arg-quoting pitfalls in the kaos cmd.exe test, and run the Windows process-tree kill test from a script file with the pid path passed via argv.
- Give the first fs-git e2e test more time on Windows and retry the temp-dir cleanup; skip the fs-watch overflow-burst assertion on Windows where fs-event coalescing prevents the single-window spike.

* ci: retrigger checks

* fix: resolve remaining Windows failures after merging main

- Terminate the spawned git/gh process tree on Windows in FsGitService (taskkill /T /F on timeout) so a timed-out 'gh pr view' cannot leave a grandchild holding the workspace cwd, which made the fs-git e2e cleanup fail with EPERM.

- Give the fs:git_status e2e suite a longer timeout on Windows and retry the temp-dir cleanup longer to ride out the slower child-process teardown.

- Make the third-party plugin install trust test assert the resolved install path via node:path so it matches the Windows-resolved path (D:\tmp\...) as well as the POSIX one.

* fix: align workspace registry roots and harden fs-git cleanup on Windows

- workspace-registry test: compare normalized (forward-slash) roots, since the registry and session index both store workDir via pathe.resolve (forward slashes on every platform). realpath() yields backslashes on Windows and diverged from the stored root.

- fs-git e2e: bump the temp-dir cleanup retries and the afterEach timeout, since Windows child-process teardown after server.close() is asynchronous and can keep the workspace cwd locked for several seconds.

* test: stub openUrl in kimi-tui-message-flow feedback tests

The /feedback command falls back to openUrl(FEEDBACK_ISSUE_URL) when submission fails, which spawned a real browser window on every test run. Mock #/utils/open-url (matching the existing login/message-replay/server test convention) so the suite never opens a browser.

* test: harden fs-git e2e cleanup against Windows cwd locks

On Windows, git/gh child processes and the session core process can outlive server.close() and keep the temp workspace as their cwd, so rmSync fails with EPERM even after a long retry. Add rmSyncRobust that retries and, if the cwd is still locked, swallows EPERM/EBUSY on Windows — the OS reclaims the temp dir and a cleanup hiccup must not fail an otherwise-passing test.

* test: harden server e2e cleanup against async teardown races

server.close() does not fully await the server's asynchronous teardown, so on a loaded CI runner the temp home/workspace dirs can still be held or written to when the afterEach rmSync runs, failing with EPERM (Windows) or ENOTEMPTY (Linux). Use a rmSyncRobust helper (retry + swallow EPERM/EBUSY/ENOTEMPTY) in the fs-git and question e2e cleanup. Also fix a leftover `throw err` (renamed to `throw error`) that broke the typecheck.
2026-06-26 11:56:41 +08:00

359 lines
13 KiB
TypeScript

/**
* Pure-function tests for the systemd backend. No real `systemctl` shell-out —
* `execSystemctl` is stubbed so we can assert the exact argv.
*
* Mirrors the pattern from `launchd.test.ts`.
*/
import { existsSync, mkdirSync, mkdtempSync, readFileSync, rmSync, writeFileSync } from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
import {
createSystemdManager,
type SystemdManagerDeps,
} from '../../src/svc/systemd';
import {
buildSystemdUnit,
parseSystemctlShow,
} from '../../src/svc/systemd-unit';
import { KIMI_SERVER_SYSTEMD_UNIT } from '../../src/svc/paths';
import { readInstallPlan, writeInstallPlan } from '../../src/svc/install-plan';
import { ServiceUnavailableError } from '../../src/svc/types';
import type { ExecOptions, ExecResult } from '../../src/svc/exec';
interface StubCall {
args: readonly string[];
options?: ExecOptions;
}
function makeStubExec(responses: ReadonlyArray<ExecResult>) {
const calls: StubCall[] = [];
let i = 0;
const execSystemctl = async (
args: readonly string[],
options?: ExecOptions,
): Promise<ExecResult> => {
calls.push({ args, options });
const next = responses[i] ?? { stdout: '', stderr: '', code: 0 };
i += 1;
return next;
};
return { execSystemctl, calls } as const;
}
function makeDeps(
responses: ReadonlyArray<ExecResult>,
workDir: string,
): { deps: SystemdManagerDeps; calls: StubCall[]; unitPath: string; logPath: string } {
const { execSystemctl, calls } = makeStubExec(responses);
const unitPath = join(workDir, 'systemd', 'user', KIMI_SERVER_SYSTEMD_UNIT);
const logPath = join(workDir, 'server', 'server.log');
const deps: SystemdManagerDeps = {
execSystemctl,
resolveProgram: () => '/usr/local/bin/kimi',
unitPath: () => unitPath,
logPath: () => logPath,
};
return { deps, calls, unitPath, logPath };
}
let workDir: string;
let prevHome: string | undefined;
beforeEach(() => {
workDir = mkdtempSync(join(tmpdir(), 'kimi-systemd-test-'));
prevHome = process.env['KIMI_CODE_HOME'];
process.env['KIMI_CODE_HOME'] = workDir;
});
afterEach(() => {
if (prevHome === undefined) {
delete process.env['KIMI_CODE_HOME'];
} else {
process.env['KIMI_CODE_HOME'] = prevHome;
}
rmSync(workDir, { recursive: true, force: true });
});
describe('buildSystemdUnit', () => {
it('renders the standard [Unit]/[Service]/[Install] triple', () => {
const unit = buildSystemdUnit({
programArguments: ['/usr/local/bin/kimi', 'server', 'run', '--port', '58627'],
});
expect(unit).toContain('[Unit]');
expect(unit).toContain('[Service]');
expect(unit).toContain('[Install]');
expect(unit).toContain('Description=Kimi Code local server');
expect(unit).toContain('ExecStart=/usr/local/bin/kimi server run --port 58627');
expect(unit).toContain('Restart=always');
expect(unit).toContain('WantedBy=default.target');
});
it('quotes argv elements with whitespace', () => {
const unit = buildSystemdUnit({
programArguments: ['/path with space/kimi', 'server', 'run'],
});
expect(unit).toContain('ExecStart="/path with space/kimi" server run');
});
it('rejects argv elements with CR/LF', () => {
expect(() =>
buildSystemdUnit({ programArguments: ['/usr/bin/kimi', 'server\nrun'] }),
).toThrow(/cannot contain CR or LF/);
});
it('renders Environment= lines', () => {
const unit = buildSystemdUnit({
programArguments: ['/usr/bin/kimi'],
environment: { FOO: 'bar', BAZ: 'qux' },
});
expect(unit).toContain('Environment=FOO=bar');
expect(unit).toContain('Environment=BAZ=qux');
});
});
describe('parseSystemctlShow', () => {
it('parses KEY=VALUE lines into a map', () => {
const out = ['ActiveState=active', 'SubState=running', 'MainPID=4321', 'ExecStart={ path=/x }'].join('\n');
const fields = parseSystemctlShow(out);
expect(fields['ActiveState']).toBe('active');
expect(fields['SubState']).toBe('running');
expect(fields['MainPID']).toBe('4321');
expect(fields['ExecStart']).toBe('{ path=/x }');
});
it('ignores lines without `=`', () => {
const fields = parseSystemctlShow('hello world\nActiveState=active');
expect(fields['ActiveState']).toBe('active');
expect(Object.keys(fields).length).toBe(1);
});
});
describe.skipIf(process.platform === 'win32')('systemd manager — install', () => {
it('writes the unit, daemon-reloads, enables --now', async () => {
const { deps, calls, unitPath } = makeDeps(
[
{ stdout: '', stderr: '', code: 0 }, // show-environment
{ stdout: '', stderr: '', code: 0 }, // daemon-reload
{ stdout: '', stderr: '', code: 0 }, // enable --now
],
workDir,
);
const mgr = createSystemdManager(deps);
const result = await mgr.install({ host: '127.0.0.1', port: 58627, logLevel: 'info' });
expect(result.status).toBe('installed');
expect(result.unitPath).toBe(unitPath);
expect(existsSync(unitPath)).toBe(true);
const text = readFileSync(unitPath, 'utf8');
expect(text).toContain('ExecStart=/usr/local/bin/kimi server run --port 58627 --log-level info --host 127.0.0.1');
expect(text).toContain('--host 127.0.0.1');
expect(calls.length).toBe(3);
expect(calls[0]?.args).toEqual(['show-environment']);
expect(calls[1]?.args).toEqual(['daemon-reload']);
expect(calls[2]?.args).toEqual(['enable', '--now', KIMI_SERVER_SYSTEMD_UNIT]);
});
it('refuses to overwrite an existing install without --force', async () => {
const { deps, calls, unitPath } = makeDeps([], workDir);
mkdirSync(unitPath.replace(/\/[^/]+$/, ''), { recursive: true });
writeFileSync(unitPath, '# stub');
const mgr = createSystemdManager(deps);
const result = await mgr.install({ host: '127.0.0.1', port: 58627, logLevel: 'info' });
expect(result.status).toBe('already-installed');
expect(calls.length).toBe(0);
});
it('overwrites + replaces when force=true', async () => {
const { deps, unitPath } = makeDeps(
[
{ stdout: '', stderr: '', code: 0 }, // show-environment
{ stdout: '', stderr: '', code: 0 }, // daemon-reload
{ stdout: '', stderr: '', code: 0 }, // enable --now
],
workDir,
);
mkdirSync(unitPath.replace(/\/[^/]+$/, ''), { recursive: true });
writeFileSync(unitPath, '# old');
const mgr = createSystemdManager(deps);
const result = await mgr.install({ host: '0.0.0.0', port: 9999, logLevel: 'debug', force: true });
expect(result.status).toBe('replaced');
const text = readFileSync(unitPath, 'utf8');
expect(text).toContain('ExecStart=/usr/local/bin/kimi server run --port 9999 --log-level debug');
expect(text).not.toContain('0.0.0.0');
});
it('fails before writing files when user systemd is unavailable', async () => {
const { deps, calls, unitPath } = makeDeps(
[
{
stdout: '',
stderr: 'System has not been booted with systemd as init system (PID 1).',
code: 1,
},
],
workDir,
);
const mgr = createSystemdManager(deps);
await expect(
mgr.install({ host: '127.0.0.1', port: 58627, logLevel: 'info' }),
).rejects.toBeInstanceOf(ServiceUnavailableError);
expect(calls).toEqual([{ args: ['show-environment'], options: undefined }]);
expect(existsSync(unitPath)).toBe(false);
expect(readInstallPlan()).toBeUndefined();
});
it('surfaces daemon-reload failure as a thrown error', async () => {
const { deps } = makeDeps(
[
{ stdout: '', stderr: '', code: 0 },
{ stdout: '', stderr: 'unit not loaded', code: 1 },
],
workDir,
);
const mgr = createSystemdManager(deps);
await expect(
mgr.install({ host: '127.0.0.1', port: 58627, logLevel: 'info' }),
).rejects.toThrow(/daemon-reload failed/);
});
it('surfaces enable --now failure as a thrown error', async () => {
const { deps } = makeDeps(
[
{ stdout: '', stderr: '', code: 0 },
{ stdout: '', stderr: '', code: 0 },
{ stdout: '', stderr: 'unit failed to start', code: 1 },
],
workDir,
);
const mgr = createSystemdManager(deps);
await expect(
mgr.install({ host: '127.0.0.1', port: 58627, logLevel: 'info' }),
).rejects.toThrow(/enable --now failed/);
});
});
describe.skipIf(process.platform === 'win32')('systemd manager — lifecycle', () => {
it('start delegates to `systemctl --user start`', async () => {
const { deps, calls, unitPath } = makeDeps([{ stdout: '', stderr: '', code: 0 }], workDir);
mkdirSync(unitPath.replace(/\/[^/]+$/, ''), { recursive: true });
writeFileSync(unitPath, '# stub');
const mgr = createSystemdManager(deps);
const result = await mgr.start();
expect(result.ok).toBe(true);
expect(calls[0]?.args).toEqual(['start', KIMI_SERVER_SYSTEMD_UNIT]);
});
it('start refuses when not installed', async () => {
const { deps, calls } = makeDeps([], workDir);
const mgr = createSystemdManager(deps);
const result = await mgr.start();
expect(result.ok).toBe(false);
expect(result.message).toMatch(/not installed/);
expect(calls.length).toBe(0);
});
it('stop delegates to `systemctl --user stop`', async () => {
const { deps, calls } = makeDeps([{ stdout: '', stderr: '', code: 0 }], workDir);
const mgr = createSystemdManager(deps);
const result = await mgr.stop();
expect(result.ok).toBe(true);
expect(calls[0]?.args).toEqual(['stop', KIMI_SERVER_SYSTEMD_UNIT]);
});
it('restart delegates to `systemctl --user restart`', async () => {
const { deps, calls } = makeDeps([{ stdout: '', stderr: '', code: 0 }], workDir);
const mgr = createSystemdManager(deps);
const result = await mgr.restart();
expect(result.ok).toBe(true);
expect(calls[0]?.args).toEqual(['restart', KIMI_SERVER_SYSTEMD_UNIT]);
});
it('uninstall calls disable + removes unit + clears plan', async () => {
const { deps, calls, unitPath } = makeDeps(
[
{ stdout: '', stderr: '', code: 0 }, // disable --now
{ stdout: '', stderr: '', code: 0 }, // daemon-reload
],
workDir,
);
mkdirSync(unitPath.replace(/\/[^/]+$/, ''), { recursive: true });
writeFileSync(unitPath, '# stub');
writeInstallPlan({
host: '127.0.0.1',
port: 58627,
logLevel: 'info',
program: '/usr/local/bin/kimi',
programArguments: ['/usr/local/bin/kimi', 'server', 'run'],
logPath: '/tmp/x',
installedAt: '2026-06-11T00:00:00.000Z',
});
expect(readInstallPlan()).toBeDefined();
const mgr = createSystemdManager(deps);
const result = await mgr.uninstall();
expect(result.ok).toBe(true);
expect(calls[0]?.args).toEqual(['disable', '--now', KIMI_SERVER_SYSTEMD_UNIT]);
expect(calls[1]?.args).toEqual(['daemon-reload']);
expect(existsSync(unitPath)).toBe(false);
expect(readInstallPlan()).toBeUndefined();
});
});
describe.skipIf(process.platform === 'win32')('systemd manager — status', () => {
it('reports installed=false when no unit exists', async () => {
const { deps } = makeDeps([], workDir);
const mgr = createSystemdManager(deps);
const status = await mgr.status();
expect(status.installed).toBe(false);
expect(status.running).toBe(false);
expect(status.platform).toBe('linux');
expect(status.unitName).toBe(KIMI_SERVER_SYSTEMD_UNIT);
});
it('reports running=true + pid from `systemctl --user show`', async () => {
const showOutput = ['ActiveState=active', 'SubState=running', 'MainPID=9876'].join('\n');
const { deps, unitPath } = makeDeps([{ stdout: showOutput, stderr: '', code: 0 }], workDir);
mkdirSync(unitPath.replace(/\/[^/]+$/, ''), { recursive: true });
writeFileSync(unitPath, '# stub');
writeInstallPlan({
host: '127.0.0.1',
port: 58627,
logLevel: 'info',
program: '/usr/local/bin/kimi',
programArguments: [],
logPath: '/tmp/x',
installedAt: '2026-06-11T00:00:00.000Z',
});
const mgr = createSystemdManager(deps);
const status = await mgr.status();
expect(status.installed).toBe(true);
expect(status.running).toBe(true);
expect(status.pid).toBe(9876);
expect(status.host).toBe('127.0.0.1');
expect(status.port).toBe(58627);
});
it('reports installed=true, running=false when `systemctl show` fails', async () => {
const { deps, unitPath } = makeDeps(
[{ stdout: '', stderr: 'Failed to connect', code: 1 }],
workDir,
);
mkdirSync(unitPath.replace(/\/[^/]+$/, ''), { recursive: true });
writeFileSync(unitPath, '# stub');
const mgr = createSystemdManager(deps);
const status = await mgr.status();
expect(status.installed).toBe(true);
expect(status.running).toBe(false);
expect(status.notes?.[0]).toMatch(/systemctl --user show failed/);
});
});