kimi-code/packages/server/test/fs-watch.e2e.test.ts
liruifengv b51e13538d
ci: run unit tests on windows (#1037)
* ci: run unit tests on windows

* fix(migration-legacy): align workdir bucket key with agent-core

computeWorkdirBucket used a local node:path-based resolve that yields backslash-separated paths on Windows, while agent-core's encodeWorkDirKey uses pathe (forward slashes on every platform). The SHA-256 inputs diverged, so migrated sessions were written to a bucket that the session picker never reads, making them invisible on Windows.

Alias computeWorkdirBucket to encodeWorkDirKey so both sides stay byte-identical, drop the local slugify copy, and update the workdir-bucket test reference accordingly.

* test(acp-adapter): expect platform-native separators in e2e-fs path

The e2e-fs test asserted the fs/readTextFile wire path as the raw POSIX targetPath, but AcpKaos.toClientPath converts '/' to '\' when the inner LocalKaos reports pathClass 'win32' (Windows). On Windows the wire path became '\Users\test\x.ts' and the assertion failed.

Mirror toClientPath in the test: expect backslash separators on win32 and the raw path otherwise. Implementation is unchanged.

* test(sdk): normalize workDir and skillDir paths in session tests

SessionStore.create/list and the skill loader normalize paths through pathe (forward slashes). The SDK tests compared the resulting workDir and skill loaded-dir against raw mkdtemp / node:path strings, which use backslashes on Windows (and node:fs realpath also returns backslashes for the skill dir), failing three toMatchObject assertions.

Build the expected paths with agent-core's normalizeWorkDir so they match the internal pathe representation on every platform. The skill dir keeps its realpath() (the loader realpaths the root) and only normalizes separators.

* test(skill): normalize realpath to forward slashes in scanner tests

resolveSkillRoots normalizes every root.path through fs.realpath followed by replacing backslashes with forward slashes (scanner.ts). The scanner tests compared root.path against node:fs realpath directly, which returns backslashes on Windows, so twenty assertions failed (toEqual / toContain / toHaveLength) even though the resolved paths were identical.

Wrap realpath at the top of the test file to mirror the implementation's normalization, so every comparison uses the same forward-slash form on every platform.

* test: skip Unix-only permission tests on Windows

The Unix file-permission assertions (mode bits like 0o600 / 0o700 and chmod 000 making a path unreadable) have no equivalent on Windows, which uses ACLs; fs.chmod there can only toggle the read-only bit. These six tests failed on Windows with mismatched mode values or a missing 40411.

Skip them on win32 via it.skipIf(process.platform === 'win32'): oauth FileTokenStorage (0600 file, 0700 dir), agent-core BackgroundTaskPersistence (0700 tasks dir), agent-core createPerIdJsonStore (0700 subdir), migration-legacy atomicWrite (0600 file), and server fs:browse (chmod 000 -> 40411).

* test(tui): make platform-sensitive assertions cross-platform

The TUI implementations are already platform-aware (pathe-style paths, pathToFileURL, quoteShellArg cmd/POSIX quoting, Alt+V on Windows for paste expansion), but the tests hard-coded POSIX expectations and failed on Windows.

Align the assertions with the implementation's platform behavior: footer-goal-badge matches the '[goal' badge prefix instead of /goal/ (toolbar tips contain '/goal'); tool-call expects backslash relative paths on win32; plan-box builds the file:// URL via pathToFileURL; custom-editor sends Alt+V on win32 for paste expansion; file-mention-provider normalizes the expected description to forward slashes; kimi-tui-startup builds the resume command with quoteShellArg; kimi-tui-message-flow builds the expected install path with resolve().

* test: align path assertions with pathe on Windows

Several test suites asserted paths produced by node:path/node:os/node:fs against values that agent-core, node-sdk and kaos normalize through pathe (forward slashes). On Windows the two forms diverge (backslashes vs forward slashes), failing about 19 assertions.

Mirror the implementation's normalization in the assertions via a local toPosix helper (or agent-core's normalizeWorkDir), so expected paths use forward slashes on every platform: kaos LocalKaos, node-sdk export/list/resume/config/transport sessions, cli FileMentionProvider, and agent-core skill-session.

* test(native): build path expectations with node:path.resolve

paths.mjs builds every path with node:path.resolve, which yields backslash-separated absolute paths on Windows. The path-helpers tests asserted against template strings that mixed the backslash appRoot with forward-slash segments, so Object.is failed on Windows even though the strings looked identical.

Build the expectations with the same resolve(appRoot, ...) helper so the separators match on every platform.

* fix: make Windows CI tests pass across all packages

Fix the remaining Windows CI failures so the Windows test job can go green. The changes fall into a few categories:

- Path separators: agent-core/node-sdk/kaos normalize paths via pathe (forward slashes); align test expectations and a couple of implementations (native cache base, workspace registry) with that.

- Platform-only services: skip launchd/systemd manager suites on win32 (Windows uses schtasks).

- Process/signal lifecycle: skip or relax tests that rely on POSIX signals / SIGTERM semantics that Windows does not support.

- Hook shell syntax: rewrite hook test commands from POSIX shell (single quotes, semicolons, stderr redirects, if/then/fi) to node -e / .cjs files that run under cmd.exe.

- CRLF: make Bash tool description stripping tolerate CRLF line endings.

- Misc: realpath short-name divergence, port-retry timing, telemetry spawn, fs-watch timing, snapshot path normalization, etc.

* fix: remove unused basename import in workspaceRegistryService

Fix lint error (no-unused-vars): basename from node:path is no longer used after switching to posixBasename from pathe.

* fix: align resume harness pathClass and wait for banner state on Windows

Two more Windows CI fixes:

- createResumeNoSideEffectKaos now reports pathClass 'win32' on Windows so tool descriptions (e.g. Glob's Windows note) match the live agent in expectResumeMatches, fixing usage/description deep-equal drift.

- kimi-tui-startup once-banner test now waits for writeBannerDisplayState to land before asserting, since the atomic write can lag behind the render on Windows.

* fix: resolve remaining Windows unit test failures

Make the new Windows CI job green across agent-core, kaos, node-sdk and server:

- Align the resume harness kaos pathClass with the live agent so platform-conditional tool descriptions (Glob's Windows note) match in expectResumeMatches instead of drifting on win32.
- Rewrite hook commands in agent-core tests as cross-platform node one-liners; single-quote echo, >&2 and ';' do not work under cmd.exe.
- Add .gitattributes enforcing LF so raw-imported templates (e.g. the compaction instruction) produce byte-identical token counts on Windows and POSIX.
- Terminate the full process tree on Windows in both the hook runner and kaos (taskkill /T /F) so grandchildren cannot outlive their parent and keep the cwd locked.
- Normalize workDir path separators in two kimi-sdk session tests to match the stored canonical form.
- Avoid cmd.exe arg-quoting pitfalls in the kaos cmd.exe test, and run the Windows process-tree kill test from a script file with the pid path passed via argv.
- Give the first fs-git e2e test more time on Windows and retry the temp-dir cleanup; skip the fs-watch overflow-burst assertion on Windows where fs-event coalescing prevents the single-window spike.

* ci: retrigger checks

* fix: resolve remaining Windows failures after merging main

- Terminate the spawned git/gh process tree on Windows in FsGitService (taskkill /T /F on timeout) so a timed-out 'gh pr view' cannot leave a grandchild holding the workspace cwd, which made the fs-git e2e cleanup fail with EPERM.

- Give the fs:git_status e2e suite a longer timeout on Windows and retry the temp-dir cleanup longer to ride out the slower child-process teardown.

- Make the third-party plugin install trust test assert the resolved install path via node:path so it matches the Windows-resolved path (D:\tmp\...) as well as the POSIX one.

* fix: align workspace registry roots and harden fs-git cleanup on Windows

- workspace-registry test: compare normalized (forward-slash) roots, since the registry and session index both store workDir via pathe.resolve (forward slashes on every platform). realpath() yields backslashes on Windows and diverged from the stored root.

- fs-git e2e: bump the temp-dir cleanup retries and the afterEach timeout, since Windows child-process teardown after server.close() is asynchronous and can keep the workspace cwd locked for several seconds.

* test: stub openUrl in kimi-tui-message-flow feedback tests

The /feedback command falls back to openUrl(FEEDBACK_ISSUE_URL) when submission fails, which spawned a real browser window on every test run. Mock #/utils/open-url (matching the existing login/message-replay/server test convention) so the suite never opens a browser.

* test: harden fs-git e2e cleanup against Windows cwd locks

On Windows, git/gh child processes and the session core process can outlive server.close() and keep the temp workspace as their cwd, so rmSync fails with EPERM even after a long retry. Add rmSyncRobust that retries and, if the cwd is still locked, swallows EPERM/EBUSY on Windows — the OS reclaims the temp dir and a cleanup hiccup must not fail an otherwise-passing test.

* test: harden server e2e cleanup against async teardown races

server.close() does not fully await the server's asynchronous teardown, so on a loaded CI runner the temp home/workspace dirs can still be held or written to when the afterEach rmSync runs, failing with EPERM (Windows) or ENOTEMPTY (Linux). Use a rmSyncRobust helper (retry + swallow EPERM/EBUSY/ENOTEMPTY) in the fs-git and question e2e cleanup. Also fix a leftover `throw err` (renamed to `throw error`) that broke the typecheck.
2026-06-26 11:56:41 +08:00

507 lines
15 KiB
TypeScript

/**
* `event.fs.changed` end-to-end (W12 / Chain 14, P1.14).
*
* AC coverage (ROADMAP §Chain 14):
* 1. subscribe `/src` → create file → receive `event.fs.changed`
* 2. burst > 500 changes / 200ms → truncated event
* 3. two clients, two paths → no cross-delivery
* 4. > 100 paths per connection → `42902 fs.watch_limit_exceeded`
*
* Boots `startServer` against a tmp workspace, drives WS clients via the
* real `ws` library (same shape as `ws-broadcast.e2e.test.ts`), and
* mutates the filesystem to trigger chokidar events.
*
* **Timing note** (chokidar + tmpdir): chokidar's `ready` event takes
* O(50ms) to fire on a tree the size of these tests. We don't wait for
* it explicitly; instead each test:
* - issues `watch_fs_add` (the ack means the WS handler has called
* `chokidar.add`),
* - sleeps `WATCH_SETTLE_MS` (= 100ms) to let chokidar register the
* paths,
* - performs the mutation,
* - waits for the `event.fs.changed` envelope up to 2000ms.
*
* The 200ms debounce window + 100ms settle gives ~300ms per mutation; AC
* tests usually finish in ≈500ms.
*/
import {
mkdirSync,
mkdtempSync,
rmSync,
writeFileSync,
} from 'node:fs';
import { tmpdir } from 'node:os';
import { join } from 'node:path';
import { pino } from 'pino';
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
import { WebSocket } from 'ws';
import {
IRestGateway,
startServer,
type RunningServer,
} from '../src';
import { fixedTokenAuth } from './helpers/serverHarness';
import { rawDataToString } from '../src/ws/rawData';
let tmpDir: string;
let lockPath: string;
let bridgeHome: string;
let workspace: string;
let server: RunningServer | undefined;
beforeEach(() => {
tmpDir = mkdtempSync(join(tmpdir(), 'kimi-server-fswatch-'));
lockPath = join(tmpDir, 'lock');
bridgeHome = mkdtempSync(join(tmpdir(), 'kimi-server-fswatch-home-'));
workspace = join(tmpDir, 'workspace');
mkdirSync(workspace, { recursive: true });
mkdirSync(join(workspace, 'src'), { recursive: true });
mkdirSync(join(workspace, 'docs'), { recursive: true });
});
afterEach(async () => {
try {
await server?.close();
} catch {
// ignore
}
server = undefined;
rmSync(tmpDir, { recursive: true, force: true });
rmSync(bridgeHome, { recursive: true, force: true });
});
async function bootDaemon(): Promise<RunningServer> {
server = await startServer({
serviceOverrides: [fixedTokenAuth()],
host: '127.0.0.1',
port: 0,
lockPath,
logger: pino({ level: 'silent' }),
coreProcessOptions: { homeDir: bridgeHome },
wsGatewayOptions: { pingIntervalMs: 5_000, pongTimeoutMs: 5_000 },
});
return server;
}
function appOf(r: RunningServer): {
inject: (req: unknown) => Promise<{
statusCode: number;
json: () => unknown;
}>;
} {
const app = r.services.invokeFunction((a) => {
const gw = a.get(IRestGateway);
return gw.app as unknown as {
inject: (req: unknown) => Promise<{
statusCode: number;
json: () => unknown;
}>;
};
});
// Auto-attach the fixed bearer token so the M5.1 auth hook passes. A
// caller-supplied `authorization` header wins, so explicit token tests keep
// working; every other header (Range, content-type, …) is preserved.
return {
inject(req: unknown) {
const q = req as { headers?: Record<string, string | string[] | undefined> };
return app.inject({
...q,
headers: { authorization: 'Bearer test-token', ...q.headers },
});
},
};
}
async function createSession(r: RunningServer): Promise<string> {
const res = await appOf(r).inject({
method: 'POST',
url: '/api/v1/sessions',
payload: { metadata: { cwd: workspace } },
});
const env = res.json() as { code: number; data: { id: string } | null };
if (env.code !== 0 || env.data === null) {
throw new Error(`create session failed: ${JSON.stringify(env)}`);
}
return env.data.id;
}
function wsUrl(http: string): string {
return http.replace(/^http:\/\//, 'ws://') + '/api/v1/ws';
}
interface WsFrame {
type: string;
payload?: Record<string, unknown>;
id?: string;
code?: number;
msg?: string;
seq?: number;
session_id?: string;
}
interface Conn {
ws: WebSocket;
queue: WsFrame[];
waiters: Array<(frame: WsFrame) => void>;
}
function openConn(url: string): Promise<Conn> {
return new Promise((resolve, reject) => {
const ws = new WebSocket(url, ['kimi-code.bearer.test-token']);
const queue: WsFrame[] = [];
const waiters: Array<(frame: WsFrame) => void> = [];
ws.on('message', (data) => {
let parsed: WsFrame;
try {
parsed = JSON.parse(rawDataToString(data)) as WsFrame;
} catch {
return;
}
if (waiters.length > 0) {
const w = waiters.shift();
w?.(parsed);
} else {
queue.push(parsed);
}
});
ws.once('open', () => resolve({ ws, queue, waiters }));
ws.once('error', (err) => reject(err));
});
}
function receive(conn: Conn, timeoutMs: number): Promise<WsFrame> {
return new Promise((resolve, reject) => {
if (conn.queue.length > 0) {
resolve(conn.queue.shift()!);
return;
}
const t = setTimeout(() => {
const idx = conn.waiters.indexOf(waiter);
if (idx >= 0) conn.waiters.splice(idx, 1);
reject(new Error(`no message in ${timeoutMs}ms`));
}, timeoutMs);
const waiter = (frame: WsFrame): void => {
clearTimeout(t);
resolve(frame);
};
conn.waiters.push(waiter);
});
}
async function receiveType(
conn: Conn,
type: string,
timeoutMs: number,
): Promise<WsFrame> {
const deadline = Date.now() + timeoutMs;
for (;;) {
const remaining = deadline - Date.now();
if (remaining <= 0) {
throw new Error(`no message of type ${type} within ${timeoutMs}ms`);
}
const frame = await receive(conn, remaining);
if (frame.type === type) return frame;
}
}
async function helloAndSubscribe(
conn: Conn,
clientId: string,
sessionId: string,
): Promise<void> {
await receiveType(conn, 'server_hello', 1000);
conn.ws.send(
JSON.stringify({
type: 'client_hello',
id: `cli_${clientId}`,
payload: { client_id: clientId, subscriptions: [sessionId] },
}),
);
await receiveType(conn, 'ack', 1000);
}
const sleep = (ms: number): Promise<void> =>
new Promise((r) => setTimeout(r, ms));
/** Time we give chokidar to register newly-watched paths before we mutate. */
const WATCH_SETTLE_MS = 150;
describe('WS fs watch (W12 / Chain 14)', () => {
it('AC #1: subscribe /src → create file → receive event.fs.changed', async () => {
const r = await bootDaemon();
const sid = await createSession(r);
const conn = await openConn(wsUrl(r.address));
await helloAndSubscribe(conn, 'A', sid);
// Add `src` to watch_fs.
conn.ws.send(
JSON.stringify({
type: 'watch_fs_add',
id: 'w1',
payload: { session_id: sid, paths: ['src'] },
}),
);
const ack = await receiveType(conn, 'ack', 1000);
expect(ack.code).toBe(0);
expect(ack.payload).toMatchObject({ watched_paths: ['src'] });
await sleep(WATCH_SETTLE_MS);
writeFileSync(join(workspace, 'src', 'new.ts'), 'export const x = 1;\n');
const ev = await receiveType(conn, 'event.fs.changed', 2000);
expect(ev.session_id).toBe(sid);
const payload = ev.payload as {
changes: Array<{ path: string; change: string; kind: string }>;
coalesced_window_ms: number;
truncated?: boolean;
};
expect(payload.coalesced_window_ms).toBe(200);
expect(payload.truncated).toBeUndefined();
expect(payload.changes.length).toBeGreaterThanOrEqual(1);
// Path is POSIX-relative to cwd; should mention `src/new.ts` or the dir
// (created event lands as soon as the file's parent directory dispatches).
const paths = payload.changes.map((c) => c.path);
expect(paths.some((p) => p === 'src/new.ts' || p === 'src')).toBe(true);
conn.ws.close();
});
// Windows ReadDirectoryChangesW coalesces/spreads the burst, so no single
// 200ms window reliably crosses the 500-event overflow threshold. The
// truncation logic itself is covered by this same test on POSIX.
it.skipIf(process.platform === 'win32')('AC #2: burst > 500 changes inside 200ms window → truncated:true', { timeout: 5000 }, async () => {
const r = await bootDaemon();
const sid = await createSession(r);
const conn = await openConn(wsUrl(r.address));
await helloAndSubscribe(conn, 'A', sid);
// Watch the whole workspace root so every new file lands in scope.
conn.ws.send(
JSON.stringify({
type: 'watch_fs_add',
id: 'w2',
payload: { session_id: sid, paths: ['.'] },
}),
);
await receiveType(conn, 'ack', 1000);
await sleep(WATCH_SETTLE_MS);
// Slam 600 files into a fresh dir; chokidar emits >500 add events well
// inside one 200ms window.
const burstDir = join(workspace, 'burst');
mkdirSync(burstDir, { recursive: true });
for (let i = 0; i < 600; i++) {
writeFileSync(join(burstDir, `f${i}.txt`), `x${i}`);
}
// Drain frames until we see truncated:true OR run out of time.
const deadline = Date.now() + (process.platform === 'win32' ? 8000 : 4000);
let sawTruncated = false;
while (Date.now() < deadline) {
const remaining = deadline - Date.now();
let frame: WsFrame;
try {
frame = await receive(conn, remaining);
} catch {
break;
}
if (frame.type !== 'event.fs.changed') continue;
const payload = frame.payload as { truncated?: boolean; count?: number };
if (payload.truncated === true) {
expect(payload.count).toBeGreaterThan(500);
sawTruncated = true;
break;
}
}
expect(sawTruncated).toBe(true);
conn.ws.close();
});
it('AC #3: two clients on disjoint paths receive only their own changes', async () => {
const r = await bootDaemon();
const sid = await createSession(r);
const a = await openConn(wsUrl(r.address));
const b = await openConn(wsUrl(r.address));
await helloAndSubscribe(a, 'A', sid);
await helloAndSubscribe(b, 'B', sid);
a.ws.send(
JSON.stringify({
type: 'watch_fs_add',
id: 'wA',
payload: { session_id: sid, paths: ['src'] },
}),
);
await receiveType(a, 'ack', 1000);
b.ws.send(
JSON.stringify({
type: 'watch_fs_add',
id: 'wB',
payload: { session_id: sid, paths: ['docs'] },
}),
);
await receiveType(b, 'ack', 1000);
await sleep(WATCH_SETTLE_MS);
writeFileSync(join(workspace, 'src', 'a.ts'), 'a');
writeFileSync(join(workspace, 'docs', 'b.md'), 'b');
// A should see src changes only.
const evA = await receiveType(a, 'event.fs.changed', 2000);
const payloadA = evA.payload as {
changes: Array<{ path: string }>;
};
expect(payloadA.changes.some((c) => c.path.startsWith('src/'))).toBe(true);
expect(payloadA.changes.some((c) => c.path.startsWith('docs/'))).toBe(false);
// B should see docs changes only.
const evB = await receiveType(b, 'event.fs.changed', 2000);
const payloadB = evB.payload as {
changes: Array<{ path: string }>;
};
expect(payloadB.changes.some((c) => c.path.startsWith('docs/'))).toBe(true);
expect(payloadB.changes.some((c) => c.path.startsWith('src/'))).toBe(false);
// Cross-contamination check: A should NOT receive any frame whose
// changes touch docs/, and vice versa. Drain a short window.
const drainDeadline = Date.now() + 400;
while (Date.now() < drainDeadline) {
const remaining = drainDeadline - Date.now();
try {
const frame = await receive(a, remaining);
if (frame.type !== 'event.fs.changed') continue;
const p = frame.payload as { changes: Array<{ path: string }> };
expect(p.changes.some((c) => c.path.startsWith('docs/'))).toBe(false);
} catch {
break;
}
}
a.ws.close();
b.ws.close();
});
it('AC #4: > 100 paths on one connection → 42902 fs.watch_limit_exceeded', async () => {
const r = await bootDaemon();
const sid = await createSession(r);
const conn = await openConn(wsUrl(r.address));
await helloAndSubscribe(conn, 'A', sid);
// Create 101 directories so each path resolves under cwd successfully
// (we don't want a 41304 / 40409 false-positive masking the 42902).
const paths: string[] = [];
for (let i = 0; i < 101; i++) {
const p = `dir${i}`;
mkdirSync(join(workspace, p), { recursive: true });
paths.push(p);
}
// First add 100 — should succeed.
conn.ws.send(
JSON.stringify({
type: 'watch_fs_add',
id: 'w100',
payload: { session_id: sid, paths: paths.slice(0, 100) },
}),
);
const ack100 = await receiveType(conn, 'ack', 2000);
expect(ack100.code).toBe(0);
const payload100 = ack100.payload as { current_count: number };
expect(payload100.current_count).toBe(100);
// 101st path → 42902.
conn.ws.send(
JSON.stringify({
type: 'watch_fs_add',
id: 'w101',
payload: { session_id: sid, paths: [paths[100]!] },
}),
);
const ack101 = await receiveType(conn, 'ack', 2000);
expect(ack101.code).toBe(42902);
conn.ws.close();
});
it('idempotent: adding the same path twice keeps watched_paths singular', async () => {
const r = await bootDaemon();
const sid = await createSession(r);
const conn = await openConn(wsUrl(r.address));
await helloAndSubscribe(conn, 'A', sid);
conn.ws.send(
JSON.stringify({
type: 'watch_fs_add',
id: 'w1',
payload: { session_id: sid, paths: ['src'] },
}),
);
await receiveType(conn, 'ack', 1000);
conn.ws.send(
JSON.stringify({
type: 'watch_fs_add',
id: 'w2',
payload: { session_id: sid, paths: ['src'] },
}),
);
const ack = await receiveType(conn, 'ack', 1000);
const payload = ack.payload as { current_count: number };
expect(payload.current_count).toBe(1);
conn.ws.close();
});
it('watch_fs_remove drops the subscription and acks updated watched_paths', async () => {
const r = await bootDaemon();
const sid = await createSession(r);
const conn = await openConn(wsUrl(r.address));
await helloAndSubscribe(conn, 'A', sid);
conn.ws.send(
JSON.stringify({
type: 'watch_fs_add',
id: 'wadd',
payload: { session_id: sid, paths: ['src', 'docs'] },
}),
);
await receiveType(conn, 'ack', 1000);
conn.ws.send(
JSON.stringify({
type: 'watch_fs_remove',
id: 'wrm',
payload: { session_id: sid, paths: ['src'] },
}),
);
const ack = await receiveType(conn, 'ack', 1000);
const payload = ack.payload as { watched_paths: string[]; current_count: number };
expect(payload.watched_paths).toEqual(['docs']);
expect(payload.current_count).toBe(1);
conn.ws.close();
});
it('41304: watch_fs_add for `..` path → fs.path_escapes_session', async () => {
const r = await bootDaemon();
const sid = await createSession(r);
const conn = await openConn(wsUrl(r.address));
await helloAndSubscribe(conn, 'A', sid);
conn.ws.send(
JSON.stringify({
type: 'watch_fs_add',
id: 'wbad',
payload: { session_id: sid, paths: ['../escape'] },
}),
);
const ack = await receiveType(conn, 'ack', 1000);
expect(ack.code).toBe(41304);
conn.ws.close();
});
});