mirror of
https://github.com/MoonshotAI/kimi-code.git
synced 2026-07-09 17:29:12 +00:00
* ci: run unit tests on windows * fix(migration-legacy): align workdir bucket key with agent-core computeWorkdirBucket used a local node:path-based resolve that yields backslash-separated paths on Windows, while agent-core's encodeWorkDirKey uses pathe (forward slashes on every platform). The SHA-256 inputs diverged, so migrated sessions were written to a bucket that the session picker never reads, making them invisible on Windows. Alias computeWorkdirBucket to encodeWorkDirKey so both sides stay byte-identical, drop the local slugify copy, and update the workdir-bucket test reference accordingly. * test(acp-adapter): expect platform-native separators in e2e-fs path The e2e-fs test asserted the fs/readTextFile wire path as the raw POSIX targetPath, but AcpKaos.toClientPath converts '/' to '\' when the inner LocalKaos reports pathClass 'win32' (Windows). On Windows the wire path became '\Users\test\x.ts' and the assertion failed. Mirror toClientPath in the test: expect backslash separators on win32 and the raw path otherwise. Implementation is unchanged. * test(sdk): normalize workDir and skillDir paths in session tests SessionStore.create/list and the skill loader normalize paths through pathe (forward slashes). The SDK tests compared the resulting workDir and skill loaded-dir against raw mkdtemp / node:path strings, which use backslashes on Windows (and node:fs realpath also returns backslashes for the skill dir), failing three toMatchObject assertions. Build the expected paths with agent-core's normalizeWorkDir so they match the internal pathe representation on every platform. The skill dir keeps its realpath() (the loader realpaths the root) and only normalizes separators. * test(skill): normalize realpath to forward slashes in scanner tests resolveSkillRoots normalizes every root.path through fs.realpath followed by replacing backslashes with forward slashes (scanner.ts). The scanner tests compared root.path against node:fs realpath directly, which returns backslashes on Windows, so twenty assertions failed (toEqual / toContain / toHaveLength) even though the resolved paths were identical. Wrap realpath at the top of the test file to mirror the implementation's normalization, so every comparison uses the same forward-slash form on every platform. * test: skip Unix-only permission tests on Windows The Unix file-permission assertions (mode bits like 0o600 / 0o700 and chmod 000 making a path unreadable) have no equivalent on Windows, which uses ACLs; fs.chmod there can only toggle the read-only bit. These six tests failed on Windows with mismatched mode values or a missing 40411. Skip them on win32 via it.skipIf(process.platform === 'win32'): oauth FileTokenStorage (0600 file, 0700 dir), agent-core BackgroundTaskPersistence (0700 tasks dir), agent-core createPerIdJsonStore (0700 subdir), migration-legacy atomicWrite (0600 file), and server fs:browse (chmod 000 -> 40411). * test(tui): make platform-sensitive assertions cross-platform The TUI implementations are already platform-aware (pathe-style paths, pathToFileURL, quoteShellArg cmd/POSIX quoting, Alt+V on Windows for paste expansion), but the tests hard-coded POSIX expectations and failed on Windows. Align the assertions with the implementation's platform behavior: footer-goal-badge matches the '[goal' badge prefix instead of /goal/ (toolbar tips contain '/goal'); tool-call expects backslash relative paths on win32; plan-box builds the file:// URL via pathToFileURL; custom-editor sends Alt+V on win32 for paste expansion; file-mention-provider normalizes the expected description to forward slashes; kimi-tui-startup builds the resume command with quoteShellArg; kimi-tui-message-flow builds the expected install path with resolve(). * test: align path assertions with pathe on Windows Several test suites asserted paths produced by node:path/node:os/node:fs against values that agent-core, node-sdk and kaos normalize through pathe (forward slashes). On Windows the two forms diverge (backslashes vs forward slashes), failing about 19 assertions. Mirror the implementation's normalization in the assertions via a local toPosix helper (or agent-core's normalizeWorkDir), so expected paths use forward slashes on every platform: kaos LocalKaos, node-sdk export/list/resume/config/transport sessions, cli FileMentionProvider, and agent-core skill-session. * test(native): build path expectations with node:path.resolve paths.mjs builds every path with node:path.resolve, which yields backslash-separated absolute paths on Windows. The path-helpers tests asserted against template strings that mixed the backslash appRoot with forward-slash segments, so Object.is failed on Windows even though the strings looked identical. Build the expectations with the same resolve(appRoot, ...) helper so the separators match on every platform. * fix: make Windows CI tests pass across all packages Fix the remaining Windows CI failures so the Windows test job can go green. The changes fall into a few categories: - Path separators: agent-core/node-sdk/kaos normalize paths via pathe (forward slashes); align test expectations and a couple of implementations (native cache base, workspace registry) with that. - Platform-only services: skip launchd/systemd manager suites on win32 (Windows uses schtasks). - Process/signal lifecycle: skip or relax tests that rely on POSIX signals / SIGTERM semantics that Windows does not support. - Hook shell syntax: rewrite hook test commands from POSIX shell (single quotes, semicolons, stderr redirects, if/then/fi) to node -e / .cjs files that run under cmd.exe. - CRLF: make Bash tool description stripping tolerate CRLF line endings. - Misc: realpath short-name divergence, port-retry timing, telemetry spawn, fs-watch timing, snapshot path normalization, etc. * fix: remove unused basename import in workspaceRegistryService Fix lint error (no-unused-vars): basename from node:path is no longer used after switching to posixBasename from pathe. * fix: align resume harness pathClass and wait for banner state on Windows Two more Windows CI fixes: - createResumeNoSideEffectKaos now reports pathClass 'win32' on Windows so tool descriptions (e.g. Glob's Windows note) match the live agent in expectResumeMatches, fixing usage/description deep-equal drift. - kimi-tui-startup once-banner test now waits for writeBannerDisplayState to land before asserting, since the atomic write can lag behind the render on Windows. * fix: resolve remaining Windows unit test failures Make the new Windows CI job green across agent-core, kaos, node-sdk and server: - Align the resume harness kaos pathClass with the live agent so platform-conditional tool descriptions (Glob's Windows note) match in expectResumeMatches instead of drifting on win32. - Rewrite hook commands in agent-core tests as cross-platform node one-liners; single-quote echo, >&2 and ';' do not work under cmd.exe. - Add .gitattributes enforcing LF so raw-imported templates (e.g. the compaction instruction) produce byte-identical token counts on Windows and POSIX. - Terminate the full process tree on Windows in both the hook runner and kaos (taskkill /T /F) so grandchildren cannot outlive their parent and keep the cwd locked. - Normalize workDir path separators in two kimi-sdk session tests to match the stored canonical form. - Avoid cmd.exe arg-quoting pitfalls in the kaos cmd.exe test, and run the Windows process-tree kill test from a script file with the pid path passed via argv. - Give the first fs-git e2e test more time on Windows and retry the temp-dir cleanup; skip the fs-watch overflow-burst assertion on Windows where fs-event coalescing prevents the single-window spike. * ci: retrigger checks * fix: resolve remaining Windows failures after merging main - Terminate the spawned git/gh process tree on Windows in FsGitService (taskkill /T /F on timeout) so a timed-out 'gh pr view' cannot leave a grandchild holding the workspace cwd, which made the fs-git e2e cleanup fail with EPERM. - Give the fs:git_status e2e suite a longer timeout on Windows and retry the temp-dir cleanup longer to ride out the slower child-process teardown. - Make the third-party plugin install trust test assert the resolved install path via node:path so it matches the Windows-resolved path (D:\tmp\...) as well as the POSIX one. * fix: align workspace registry roots and harden fs-git cleanup on Windows - workspace-registry test: compare normalized (forward-slash) roots, since the registry and session index both store workDir via pathe.resolve (forward slashes on every platform). realpath() yields backslashes on Windows and diverged from the stored root. - fs-git e2e: bump the temp-dir cleanup retries and the afterEach timeout, since Windows child-process teardown after server.close() is asynchronous and can keep the workspace cwd locked for several seconds. * test: stub openUrl in kimi-tui-message-flow feedback tests The /feedback command falls back to openUrl(FEEDBACK_ISSUE_URL) when submission fails, which spawned a real browser window on every test run. Mock #/utils/open-url (matching the existing login/message-replay/server test convention) so the suite never opens a browser. * test: harden fs-git e2e cleanup against Windows cwd locks On Windows, git/gh child processes and the session core process can outlive server.close() and keep the temp workspace as their cwd, so rmSync fails with EPERM even after a long retry. Add rmSyncRobust that retries and, if the cwd is still locked, swallows EPERM/EBUSY on Windows — the OS reclaims the temp dir and a cleanup hiccup must not fail an otherwise-passing test. * test: harden server e2e cleanup against async teardown races server.close() does not fully await the server's asynchronous teardown, so on a loaded CI runner the temp home/workspace dirs can still be held or written to when the afterEach rmSync runs, failing with EPERM (Windows) or ENOTEMPTY (Linux). Use a rmSyncRobust helper (retry + swallow EPERM/EBUSY/ENOTEMPTY) in the fs-git and question e2e cleanup. Also fix a leftover `throw err` (renamed to `throw error`) that broke the typecheck.
221 lines
7.6 KiB
TypeScript
221 lines
7.6 KiB
TypeScript
/**
|
|
* `/api/v1/fs:browse` + `/api/v1/fs:home` end-to-end tests.
|
|
*
|
|
* Covers:
|
|
* - GET /fs:home → { home, recent_roots }
|
|
* - GET /fs:browse?path=$tmp → lists child dirs + git probe
|
|
* - relative path → 40001
|
|
* - missing path → 40409
|
|
* - permission denied → 40411 (skipped when running as root)
|
|
*/
|
|
|
|
import { chmodSync, mkdirSync, mkdtempSync, rmSync, writeFileSync } from 'node:fs';
|
|
import os from 'node:os';
|
|
import { tmpdir } from 'node:os';
|
|
import { isAbsolute, join } from 'node:path';
|
|
|
|
import { pino } from 'pino';
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
|
|
import { IRestGateway, startServer, type RunningServer } from '../src';
|
|
import { fixedTokenAuth } from './helpers/serverHarness';
|
|
import type {
|
|
FsBrowseEntry,
|
|
FsBrowseResponse,
|
|
FsHomeResponse,
|
|
Workspace,
|
|
} from '@moonshot-ai/protocol';
|
|
|
|
let tmpDir: string;
|
|
let lockPath: string;
|
|
let bridgeHome: string;
|
|
let server: RunningServer | undefined;
|
|
|
|
beforeEach(() => {
|
|
tmpDir = mkdtempSync(join(tmpdir(), 'kimi-server-fsbrowse-test-'));
|
|
lockPath = join(tmpDir, 'lock');
|
|
bridgeHome = mkdtempSync(join(tmpdir(), 'kimi-server-fsbrowse-home-'));
|
|
});
|
|
|
|
afterEach(async () => {
|
|
try {
|
|
await server?.close();
|
|
} catch {
|
|
// ignore
|
|
}
|
|
server = undefined;
|
|
// Re-chmod anything we made unreadable so rmSync can clean it.
|
|
try {
|
|
chmodSync(join(tmpDir, 'locked'), 0o700);
|
|
} catch {
|
|
// ignore — fixture may not exist
|
|
}
|
|
rmSync(tmpDir, { recursive: true, force: true });
|
|
rmSync(bridgeHome, { recursive: true, force: true });
|
|
});
|
|
|
|
async function bootDaemon(): Promise<RunningServer> {
|
|
server = await startServer({
|
|
serviceOverrides: [fixedTokenAuth()],
|
|
host: '127.0.0.1',
|
|
port: 0,
|
|
lockPath,
|
|
logger: pino({ level: 'silent' }),
|
|
coreProcessOptions: { homeDir: bridgeHome },
|
|
});
|
|
return server;
|
|
}
|
|
|
|
function appOf(r: RunningServer): {
|
|
inject: (req: unknown) => Promise<{ statusCode: number; json: () => unknown }>;
|
|
} {
|
|
const app = r.services.invokeFunction((a) => {
|
|
const gw = a.get(IRestGateway);
|
|
return gw.app as unknown as {
|
|
inject: (req: unknown) => Promise<{ statusCode: number; json: () => unknown }>;
|
|
};
|
|
});
|
|
// Auto-attach the fixed bearer token so the M5.1 auth hook passes. A
|
|
// caller-supplied `authorization` header wins, so explicit token tests keep
|
|
// working; every other header (Range, content-type, …) is preserved.
|
|
return {
|
|
inject(req: unknown) {
|
|
const q = req as { headers?: Record<string, string | string[] | undefined> };
|
|
return app.inject({
|
|
...q,
|
|
headers: { authorization: 'Bearer test-token', ...q.headers },
|
|
});
|
|
},
|
|
};
|
|
}
|
|
|
|
function envelopeOf<T>(body: unknown): {
|
|
code: number;
|
|
msg: string;
|
|
data: T | null;
|
|
request_id: string;
|
|
details?: unknown;
|
|
} {
|
|
return body as { code: number; msg: string; data: T | null; request_id: string; details?: unknown };
|
|
}
|
|
|
|
function makeGitRepo(root: string, branch: string): void {
|
|
mkdirSync(join(root, '.git'), { recursive: true });
|
|
writeFileSync(join(root, '.git', 'HEAD'), `ref: refs/heads/${branch}\n`, 'utf8');
|
|
}
|
|
|
|
describe('GET /api/v1/fs:home', () => {
|
|
it('returns the user $HOME directory + empty recent_roots when nothing is registered', async () => {
|
|
const r = await bootDaemon();
|
|
const res = await appOf(r).inject({ method: 'GET', url: '/api/v1/fs:home' });
|
|
expect(res.statusCode).toBe(200);
|
|
const env = envelopeOf<FsHomeResponse>(res.json());
|
|
expect(env.code).toBe(0);
|
|
expect(env.data!.home).toBe(os.homedir());
|
|
expect(env.data!.recent_roots).toEqual([]);
|
|
});
|
|
|
|
it('populates recent_roots from registered workspaces (newest first)', async () => {
|
|
const r = await bootDaemon();
|
|
const a = join(tmpDir, 'first');
|
|
const b = join(tmpDir, 'second');
|
|
mkdirSync(a);
|
|
mkdirSync(b);
|
|
await appOf(r).inject({ method: 'POST', url: '/api/v1/workspaces', payload: { root: a } });
|
|
await new Promise((resolve) => setTimeout(resolve, 5));
|
|
await appOf(r).inject({ method: 'POST', url: '/api/v1/workspaces', payload: { root: b } });
|
|
|
|
const env = envelopeOf<FsHomeResponse>(
|
|
(await appOf(r).inject({ method: 'GET', url: '/api/v1/fs:home' })).json(),
|
|
);
|
|
expect(env.data!.recent_roots.length).toBe(2);
|
|
// Sourced from workspaces sorted by last_opened_at desc → newest first.
|
|
expect(env.data!.recent_roots[0]).toContain('second');
|
|
expect(env.data!.recent_roots[1]).toContain('first');
|
|
});
|
|
});
|
|
|
|
describe('GET /api/v1/fs:browse', () => {
|
|
it('lists immediate subdirectories with git probe (only dirs, not files)', async () => {
|
|
const r = await bootDaemon();
|
|
mkdirSync(join(tmpDir, 'alpha'));
|
|
mkdirSync(join(tmpDir, 'beta'));
|
|
makeGitRepo(join(tmpDir, 'beta'), 'develop');
|
|
writeFileSync(join(tmpDir, 'README.md'), 'no', 'utf8'); // file, must not be listed
|
|
mkdirSync(join(tmpDir, '.hidden'));
|
|
|
|
const res = await appOf(r).inject({
|
|
method: 'GET',
|
|
url: `/api/v1/fs:browse?path=${encodeURIComponent(tmpDir)}`,
|
|
});
|
|
expect(res.statusCode).toBe(200);
|
|
const env = envelopeOf<FsBrowseResponse>(res.json());
|
|
expect(env.code).toBe(0);
|
|
const names = env.data!.entries.map((e) => e.name);
|
|
expect(names).toContain('alpha');
|
|
expect(names).toContain('beta');
|
|
expect(names).toContain('.hidden');
|
|
expect(names).not.toContain('README.md');
|
|
// Sort: non-dot first (alpha, beta) then dot (.hidden) last.
|
|
expect(names[names.length - 1]).toBe('.hidden');
|
|
// Git probe on beta returned the branch.
|
|
const beta = env.data!.entries.find((e): e is FsBrowseEntry => e.name === 'beta')!;
|
|
expect(beta.is_git_repo).toBe(true);
|
|
expect(beta.branch).toBe('develop');
|
|
// Parent is set (not null).
|
|
expect(env.data!.parent).toBeTruthy();
|
|
});
|
|
|
|
it('returns 40001 when path is relative', async () => {
|
|
const r = await bootDaemon();
|
|
const res = await appOf(r).inject({
|
|
method: 'GET',
|
|
url: '/api/v1/fs:browse?path=relative%2Fpath',
|
|
});
|
|
expect(envelopeOf(res.json()).code).toBe(40001);
|
|
});
|
|
|
|
it('returns 40409 when path does not exist', async () => {
|
|
const r = await bootDaemon();
|
|
const res = await appOf(r).inject({
|
|
method: 'GET',
|
|
url: `/api/v1/fs:browse?path=${encodeURIComponent(join(tmpDir, 'does-not-exist'))}`,
|
|
});
|
|
expect(envelopeOf(res.json()).code).toBe(40409);
|
|
});
|
|
|
|
it.skipIf(process.platform === 'win32')('returns 40411 when path is unreadable (chmod 000)', async () => {
|
|
if (process.getuid?.() === 0) {
|
|
// Root bypasses permission checks; skip.
|
|
return;
|
|
}
|
|
const r = await bootDaemon();
|
|
const locked = join(tmpDir, 'locked');
|
|
mkdirSync(locked);
|
|
chmodSync(locked, 0o000);
|
|
try {
|
|
const res = await appOf(r).inject({
|
|
method: 'GET',
|
|
url: `/api/v1/fs:browse?path=${encodeURIComponent(locked)}`,
|
|
});
|
|
expect(envelopeOf(res.json()).code).toBe(40411);
|
|
} finally {
|
|
chmodSync(locked, 0o700);
|
|
}
|
|
});
|
|
|
|
it('defaults to $HOME when path query is omitted', async () => {
|
|
const r = await bootDaemon();
|
|
const res = await appOf(r).inject({ method: 'GET', url: '/api/v1/fs:browse' });
|
|
expect(res.statusCode).toBe(200);
|
|
const env = envelopeOf<FsBrowseResponse>(res.json());
|
|
expect(env.code).toBe(0);
|
|
// realpath of $HOME on macOS may differ from os.homedir() (e.g. /Users vs
|
|
// /System/Volumes/Data/Users), and on Windows it is a drive path. Just
|
|
// sanity-check the response has an absolute path.
|
|
expect(isAbsolute(env.data!.path)).toBe(true);
|
|
});
|
|
});
|
|
|
|
// Silence unused-Workspace import (kept for ts inference in future expansion).
|
|
void ({} as Workspace | undefined);
|