kimi-code/packages/node-sdk/test/list-sessions.test.ts
liruifengv b51e13538d
ci: run unit tests on windows (#1037)
* ci: run unit tests on windows

* fix(migration-legacy): align workdir bucket key with agent-core

computeWorkdirBucket used a local node:path-based resolve that yields backslash-separated paths on Windows, while agent-core's encodeWorkDirKey uses pathe (forward slashes on every platform). The SHA-256 inputs diverged, so migrated sessions were written to a bucket that the session picker never reads, making them invisible on Windows.

Alias computeWorkdirBucket to encodeWorkDirKey so both sides stay byte-identical, drop the local slugify copy, and update the workdir-bucket test reference accordingly.

* test(acp-adapter): expect platform-native separators in e2e-fs path

The e2e-fs test asserted the fs/readTextFile wire path as the raw POSIX targetPath, but AcpKaos.toClientPath converts '/' to '\' when the inner LocalKaos reports pathClass 'win32' (Windows). On Windows the wire path became '\Users\test\x.ts' and the assertion failed.

Mirror toClientPath in the test: expect backslash separators on win32 and the raw path otherwise. Implementation is unchanged.

* test(sdk): normalize workDir and skillDir paths in session tests

SessionStore.create/list and the skill loader normalize paths through pathe (forward slashes). The SDK tests compared the resulting workDir and skill loaded-dir against raw mkdtemp / node:path strings, which use backslashes on Windows (and node:fs realpath also returns backslashes for the skill dir), failing three toMatchObject assertions.

Build the expected paths with agent-core's normalizeWorkDir so they match the internal pathe representation on every platform. The skill dir keeps its realpath() (the loader realpaths the root) and only normalizes separators.

* test(skill): normalize realpath to forward slashes in scanner tests

resolveSkillRoots normalizes every root.path through fs.realpath followed by replacing backslashes with forward slashes (scanner.ts). The scanner tests compared root.path against node:fs realpath directly, which returns backslashes on Windows, so twenty assertions failed (toEqual / toContain / toHaveLength) even though the resolved paths were identical.

Wrap realpath at the top of the test file to mirror the implementation's normalization, so every comparison uses the same forward-slash form on every platform.

* test: skip Unix-only permission tests on Windows

The Unix file-permission assertions (mode bits like 0o600 / 0o700 and chmod 000 making a path unreadable) have no equivalent on Windows, which uses ACLs; fs.chmod there can only toggle the read-only bit. These six tests failed on Windows with mismatched mode values or a missing 40411.

Skip them on win32 via it.skipIf(process.platform === 'win32'): oauth FileTokenStorage (0600 file, 0700 dir), agent-core BackgroundTaskPersistence (0700 tasks dir), agent-core createPerIdJsonStore (0700 subdir), migration-legacy atomicWrite (0600 file), and server fs:browse (chmod 000 -> 40411).

* test(tui): make platform-sensitive assertions cross-platform

The TUI implementations are already platform-aware (pathe-style paths, pathToFileURL, quoteShellArg cmd/POSIX quoting, Alt+V on Windows for paste expansion), but the tests hard-coded POSIX expectations and failed on Windows.

Align the assertions with the implementation's platform behavior: footer-goal-badge matches the '[goal' badge prefix instead of /goal/ (toolbar tips contain '/goal'); tool-call expects backslash relative paths on win32; plan-box builds the file:// URL via pathToFileURL; custom-editor sends Alt+V on win32 for paste expansion; file-mention-provider normalizes the expected description to forward slashes; kimi-tui-startup builds the resume command with quoteShellArg; kimi-tui-message-flow builds the expected install path with resolve().

* test: align path assertions with pathe on Windows

Several test suites asserted paths produced by node:path/node:os/node:fs against values that agent-core, node-sdk and kaos normalize through pathe (forward slashes). On Windows the two forms diverge (backslashes vs forward slashes), failing about 19 assertions.

Mirror the implementation's normalization in the assertions via a local toPosix helper (or agent-core's normalizeWorkDir), so expected paths use forward slashes on every platform: kaos LocalKaos, node-sdk export/list/resume/config/transport sessions, cli FileMentionProvider, and agent-core skill-session.

* test(native): build path expectations with node:path.resolve

paths.mjs builds every path with node:path.resolve, which yields backslash-separated absolute paths on Windows. The path-helpers tests asserted against template strings that mixed the backslash appRoot with forward-slash segments, so Object.is failed on Windows even though the strings looked identical.

Build the expectations with the same resolve(appRoot, ...) helper so the separators match on every platform.

* fix: make Windows CI tests pass across all packages

Fix the remaining Windows CI failures so the Windows test job can go green. The changes fall into a few categories:

- Path separators: agent-core/node-sdk/kaos normalize paths via pathe (forward slashes); align test expectations and a couple of implementations (native cache base, workspace registry) with that.

- Platform-only services: skip launchd/systemd manager suites on win32 (Windows uses schtasks).

- Process/signal lifecycle: skip or relax tests that rely on POSIX signals / SIGTERM semantics that Windows does not support.

- Hook shell syntax: rewrite hook test commands from POSIX shell (single quotes, semicolons, stderr redirects, if/then/fi) to node -e / .cjs files that run under cmd.exe.

- CRLF: make Bash tool description stripping tolerate CRLF line endings.

- Misc: realpath short-name divergence, port-retry timing, telemetry spawn, fs-watch timing, snapshot path normalization, etc.

* fix: remove unused basename import in workspaceRegistryService

Fix lint error (no-unused-vars): basename from node:path is no longer used after switching to posixBasename from pathe.

* fix: align resume harness pathClass and wait for banner state on Windows

Two more Windows CI fixes:

- createResumeNoSideEffectKaos now reports pathClass 'win32' on Windows so tool descriptions (e.g. Glob's Windows note) match the live agent in expectResumeMatches, fixing usage/description deep-equal drift.

- kimi-tui-startup once-banner test now waits for writeBannerDisplayState to land before asserting, since the atomic write can lag behind the render on Windows.

* fix: resolve remaining Windows unit test failures

Make the new Windows CI job green across agent-core, kaos, node-sdk and server:

- Align the resume harness kaos pathClass with the live agent so platform-conditional tool descriptions (Glob's Windows note) match in expectResumeMatches instead of drifting on win32.
- Rewrite hook commands in agent-core tests as cross-platform node one-liners; single-quote echo, >&2 and ';' do not work under cmd.exe.
- Add .gitattributes enforcing LF so raw-imported templates (e.g. the compaction instruction) produce byte-identical token counts on Windows and POSIX.
- Terminate the full process tree on Windows in both the hook runner and kaos (taskkill /T /F) so grandchildren cannot outlive their parent and keep the cwd locked.
- Normalize workDir path separators in two kimi-sdk session tests to match the stored canonical form.
- Avoid cmd.exe arg-quoting pitfalls in the kaos cmd.exe test, and run the Windows process-tree kill test from a script file with the pid path passed via argv.
- Give the first fs-git e2e test more time on Windows and retry the temp-dir cleanup; skip the fs-watch overflow-burst assertion on Windows where fs-event coalescing prevents the single-window spike.

* ci: retrigger checks

* fix: resolve remaining Windows failures after merging main

- Terminate the spawned git/gh process tree on Windows in FsGitService (taskkill /T /F on timeout) so a timed-out 'gh pr view' cannot leave a grandchild holding the workspace cwd, which made the fs-git e2e cleanup fail with EPERM.

- Give the fs:git_status e2e suite a longer timeout on Windows and retry the temp-dir cleanup longer to ride out the slower child-process teardown.

- Make the third-party plugin install trust test assert the resolved install path via node:path so it matches the Windows-resolved path (D:\tmp\...) as well as the POSIX one.

* fix: align workspace registry roots and harden fs-git cleanup on Windows

- workspace-registry test: compare normalized (forward-slash) roots, since the registry and session index both store workDir via pathe.resolve (forward slashes on every platform). realpath() yields backslashes on Windows and diverged from the stored root.

- fs-git e2e: bump the temp-dir cleanup retries and the afterEach timeout, since Windows child-process teardown after server.close() is asynchronous and can keep the workspace cwd locked for several seconds.

* test: stub openUrl in kimi-tui-message-flow feedback tests

The /feedback command falls back to openUrl(FEEDBACK_ISSUE_URL) when submission fails, which spawned a real browser window on every test run. Mock #/utils/open-url (matching the existing login/message-replay/server test convention) so the suite never opens a browser.

* test: harden fs-git e2e cleanup against Windows cwd locks

On Windows, git/gh child processes and the session core process can outlive server.close() and keep the temp workspace as their cwd, so rmSync fails with EPERM even after a long retry. Add rmSyncRobust that retries and, if the cwd is still locked, swallows EPERM/EBUSY on Windows — the OS reclaims the temp dir and a cleanup hiccup must not fail an otherwise-passing test.

* test: harden server e2e cleanup against async teardown races

server.close() does not fully await the server's asynchronous teardown, so on a loaded CI runner the temp home/workspace dirs can still be held or written to when the afterEach rmSync runs, failing with EPERM (Windows) or ENOTEMPTY (Linux). Use a rmSyncRobust helper (retry + swallow EPERM/EBUSY/ENOTEMPTY) in the fs-git and question e2e cleanup. Also fix a leftover `throw err` (renamed to `throw error`) that broke the typecheck.
2026-06-26 11:56:41 +08:00

406 lines
14 KiB
TypeScript

import { existsSync } from 'node:fs';
import { mkdir, mkdtemp, readFile, rm, utimes, writeFile } from 'node:fs/promises';
import { tmpdir } from 'node:os';
import { basename, dirname, join } from 'node:path';
import { afterEach, describe, expect, it } from 'vitest';
import { createKimiHarness } from '#/index';
import type { KimiError } from '#/index';
import {
SessionStore,
encodeWorkDirKey,
normalizeWorkDir,
sessionIndexPath,
} from '../../agent-core/src/session/store';
import { TEST_IDENTITY } from './test-identity';
const tempDirs: string[] = [];
afterEach(async () => {
for (const dir of tempDirs.splice(0)) {
await rm(dir, { recursive: true, force: true });
}
});
async function makeTempDir(): Promise<string> {
const dir = await mkdtemp(join(tmpdir(), 'kimi-sdk-list-'));
tempDirs.push(dir);
return dir;
}
async function writeSessionState(
sessionDir: string,
state: Record<string, unknown>,
): Promise<string> {
const statePath = join(sessionDir, 'state.json');
await writeFile(statePath, `${JSON.stringify(state, null, 2)}\n`, 'utf-8');
return statePath;
}
describe('SessionStore.list', () => {
it('returns an empty array when the workDir bucket does not exist', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const store = new SessionStore(homeDir);
await expect(store.list({ workDir })).resolves.toEqual([]);
});
it('creates workDir-scoped session directories and a root session index', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const store = new SessionStore(homeDir);
const summary = await store.create({ id: 'ses_list_full', workDir });
expect(summary).toMatchObject({
id: 'ses_list_full',
workDir: normalizeWorkDir(workDir),
title: undefined,
});
expect(summary.sessionDir).not.toBe(join(homeDir, 'sessions', 'ses_list_full'));
expect(basename(summary.sessionDir)).toBe('ses_list_full');
const workdirKey = basename(dirname(summary.sessionDir));
expect(workdirKey).toBe(encodeWorkDirKey(workDir));
expect(workdirKey.length).toBeLessThan(70);
expect(existsSync(join(summary.sessionDir, 'state.json'))).toBe(false);
const indexRaw = await readFile(sessionIndexPath(homeDir), 'utf-8');
expect(indexRaw).toContain('"sessionId":"ses_list_full"');
expect(indexRaw).toContain(summary.sessionDir);
expect(indexRaw).toContain(`"workDir":"${normalizeWorkDir(workDir)}"`);
});
it('forks a session directory, rewrites metadata, and drops reserved goal state', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const store = new SessionStore(homeDir);
const source = await store.create({ id: 'ses_fork_source', workDir });
const sourceAgentDir = join(source.sessionDir, 'agents', 'main');
const sourceSubagentDir = join(source.sessionDir, 'agents', 'agent-1');
await mkdir(sourceAgentDir, { recursive: true });
await mkdir(sourceSubagentDir, { recursive: true });
await writeFile(join(sourceAgentDir, 'wire.jsonl'), '{"type":"context.clear"}\n', 'utf-8');
await writeFile(join(sourceSubagentDir, 'wire.jsonl'), '{"type":"context.clear"}\n', 'utf-8');
await writeFile(
join(source.sessionDir, 'upcoming-goals.json'),
`${JSON.stringify({ version: 1, goals: [{ id: 'queued-1', objective: 'source queued goal' }] })}\n`,
'utf-8',
);
await writeSessionState(source.sessionDir, {
createdAt: '2030-01-01T00:00:00.000Z',
updatedAt: '2030-01-01T00:00:00.000Z',
title: 'Source title',
isCustomTitle: true,
agents: {
main: {
homedir: sourceAgentDir,
type: 'main',
},
'agent-1': {
homedir: sourceSubagentDir,
type: 'subagent',
parentAgentId: 'main',
},
},
custom: {
source: true,
goal: {
goalId: 'source-goal',
objective: 'source objective',
status: 'active',
turnsUsed: 0,
tokensUsed: 0,
budgetLimits: {},
},
},
});
const fork = await store.fork({
sourceId: source.id,
targetId: 'ses_fork_child',
title: 'Fork title',
metadata: {
child: true,
goal: {
goalId: 'metadata-goal',
objective: 'metadata objective',
status: 'active',
turnsUsed: 0,
tokensUsed: 0,
budgetLimits: {},
},
},
});
const forkState = JSON.parse(await readFile(join(fork.sessionDir, 'state.json'), 'utf-8')) as {
title?: string;
isCustomTitle?: boolean;
forkedFrom?: string;
agents?: { main?: { homedir?: string } };
custom?: Record<string, unknown>;
};
expect(forkState.title).toBe('Fork title');
expect(forkState.isCustomTitle).toBe(true);
expect(forkState.forkedFrom).toBe(source.id);
expect(forkState.agents?.main?.homedir).toBe(
normalizeWorkDir(join(fork.sessionDir, 'agents', 'main')),
);
expect(forkState.custom).toMatchObject({ source: true, child: true });
expect(forkState.custom).not.toHaveProperty('goal');
expect(existsSync(join(fork.sessionDir, 'upcoming-goals.json'))).toBe(false);
expect(existsSync(join(source.sessionDir, 'upcoming-goals.json'))).toBe(true);
const forkWire = await readFile(join(fork.sessionDir, 'agents', 'main', 'wire.jsonl'), 'utf-8');
expect(forkWire
.trim()
.split('\n')
.map((line) => JSON.parse(line) as Record<string, unknown>)).toEqual([
{ type: 'context.clear' },
{ type: 'forked', time: expect.any(Number) },
]);
const forkSubagentWire = await readFile(
join(fork.sessionDir, 'agents', 'agent-1', 'wire.jsonl'),
'utf-8',
);
expect(forkSubagentWire
.trim()
.split('\n')
.map((line) => JSON.parse(line) as Record<string, unknown>)).toEqual([
{ type: 'context.clear' },
{ type: 'forked', time: expect.any(Number) },
]);
const sourceState = JSON.parse(
await readFile(join(source.sessionDir, 'state.json'), 'utf-8'),
) as { forkedFrom?: string };
expect(sourceState.forkedFrom).toBeUndefined();
const sessions = await store.list({ workDir });
expect(sessions.map((session) => session.id).toSorted()).toEqual([
source.id,
fork.id,
].toSorted());
});
it('returns only sessions from the requested workDir bucket', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const otherWorkDir = await makeTempDir();
const store = new SessionStore(homeDir);
await store.create({ id: 'ses_list_a', workDir });
await store.create({ id: 'ses_other_workdir', workDir: otherWorkDir });
const sessions = await store.list({ workDir });
expect(sessions.map((session) => session.id)).toEqual(['ses_list_a']);
});
it('uses the workDir bucket before the session index when sessionId is provided', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const store = new SessionStore(homeDir);
const local = await store.create({ id: 'ses_bucket_hit', workDir });
await rm(sessionIndexPath(homeDir), { force: true });
const sessions = await store.list({ workDir, sessionId: local.id });
expect(sessions.map((session) => session.id)).toEqual([local.id]);
});
it('falls back to the session index when a workDir-scoped sessionId is not in that bucket', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const otherWorkDir = await makeTempDir();
const store = new SessionStore(homeDir);
await store.create({ id: 'ses_local', workDir });
const other = await store.create({ id: 'ses_index_fallback', workDir: otherWorkDir });
const sessions = await store.list({ workDir, sessionId: other.id });
expect(sessions).toHaveLength(1);
expect(sessions[0]).toMatchObject({
id: other.id,
workDir: normalizeWorkDir(otherWorkDir),
});
});
it('lists every indexed session when no filters are provided', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const otherWorkDir = await makeTempDir();
const store = new SessionStore(homeDir);
await store.create({ id: 'ses_all_a', workDir });
await store.create({ id: 'ses_all_b', workDir: otherWorkDir });
const sessions = await store.list();
expect(sessions.map((session) => session.id).toSorted()).toEqual([
'ses_all_a',
'ses_all_b',
]);
});
it('returns an empty array when a sessionId filter is unknown', async () => {
const homeDir = await makeTempDir();
const store = new SessionStore(homeDir);
await expect(store.list({ sessionId: 'ses_missing' })).resolves.toEqual([]);
});
it('reads title from customTitle before title', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const store = new SessionStore(homeDir);
const custom = await store.create({ id: 'ses_custom_title', workDir });
await writeSessionState(custom.sessionDir, {
title: 'Base Title',
customTitle: 'Custom Title',
});
const fallback = await store.create({ id: 'ses_fallback_title', workDir });
await writeSessionState(fallback.sessionDir, {
title: 'Fallback Title',
});
const sessions = await store.list({ workDir });
expect(sessions.find((session) => session.id === custom.id)?.title).toBe('Custom Title');
expect(sessions.find((session) => session.id === fallback.id)?.title).toBe('Fallback Title');
});
it('keeps sessions visible when state.json is missing or malformed', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const store = new SessionStore(homeDir);
await store.create({ id: 'ses_no_state', workDir });
const malformed = await store.create({ id: 'ses_bad_state', workDir });
await writeFile(join(malformed.sessionDir, 'state.json'), '{bad json', 'utf-8');
const sessions = await store.list({ workDir });
expect(sessions.map((session) => session.id).toSorted()).toEqual([
'ses_bad_state',
'ses_no_state',
]);
expect(sessions.every((session) => session.title === undefined)).toBe(true);
});
it('sorts by filesystem activity descending', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const store = new SessionStore(homeDir);
const oldSession = await store.create({ id: 'ses_old', workDir });
const newSession = await store.create({ id: 'ses_new', workDir });
const oldTime = new Date('2030-04-18T12:00:00Z');
const newTime = new Date('2030-04-18T12:00:10Z');
await writeFile(join(oldSession.sessionDir, 'wire.jsonl'), '{}\n', 'utf-8');
await writeFile(join(newSession.sessionDir, 'wire.jsonl'), '{}\n', 'utf-8');
await utimes(join(oldSession.sessionDir, 'wire.jsonl'), oldTime, oldTime);
await utimes(join(newSession.sessionDir, 'wire.jsonl'), newTime, newTime);
const sessions = await store.list({ workDir });
expect(sessions.map((session) => session.id)).toEqual(['ses_new', 'ses_old']);
});
it('does not scan legacy flat session directories', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
await mkdir(join(homeDir, 'sessions', 'ses_legacy_flat'), { recursive: true });
await writeSessionState(join(homeDir, 'sessions', 'ses_legacy_flat'), {
session_id: 'ses_legacy_flat',
workspace_dir: workDir,
custom_title: 'Legacy Flat',
});
const store = new SessionStore(homeDir);
await expect(store.list({ workDir })).resolves.toEqual([]);
await expect(store.get('ses_legacy_flat')).rejects.toMatchObject({
name: 'KimiError',
code: 'session.not_found',
});
});
});
describe('KimiHarness.listSessions', () => {
it('rejects whitespace-only workDir with request.work_dir_required', async () => {
const homeDir = await makeTempDir();
const harness = createKimiHarness({
identity: TEST_IDENTITY,
homeDir,
});
try {
await expect(harness.listSessions({ workDir: ' ' })).rejects.toMatchObject({
name: 'KimiError',
code: 'request.work_dir_required',
} satisfies Partial<KimiError>);
} finally {
await harness.close();
}
});
it('lists all sessions when no payload is provided', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const otherWorkDir = await makeTempDir();
const harness = createKimiHarness({
identity: TEST_IDENTITY,
homeDir,
});
try {
await harness.createSession({ id: 'ses_harness_all_a', workDir });
await harness.createSession({ id: 'ses_harness_all_b', workDir: otherWorkDir });
const sessions = await harness.listSessions();
expect(sessions.map((session) => session.id).toSorted()).toEqual([
'ses_harness_all_a',
'ses_harness_all_b',
]);
} finally {
await harness.close();
}
});
it('resolves relative workDir inputs before filtering', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const harness = createKimiHarness({
identity: TEST_IDENTITY,
homeDir,
});
const originalCwd = process.cwd();
try {
process.chdir(workDir);
const session = await harness.createSession({ id: 'ses_relative_workdir', workDir: '.' });
const sessions = await harness.listSessions({ workDir: '.' });
expect(sessions.map((item) => item.id)).toEqual([session.id]);
} finally {
process.chdir(originalCwd);
await harness.close();
}
});
it('lists persisted sessions after the active Session has been closed', async () => {
const homeDir = await makeTempDir();
const workDir = await makeTempDir();
const harness = createKimiHarness({
identity: TEST_IDENTITY,
homeDir,
});
try {
const session = await harness.createSession({ id: 'ses_closed_but_listed', workDir });
await harness.closeSession(session.id);
const sessions = await harness.listSessions({ workDir });
expect(sessions.map((item) => item.id)).toEqual([session.id]);
} finally {
await harness.close();
}
});
});