mirror of
https://github.com/MoonshotAI/kimi-code.git
synced 2026-07-09 17:29:12 +00:00
* ci: run unit tests on windows * fix(migration-legacy): align workdir bucket key with agent-core computeWorkdirBucket used a local node:path-based resolve that yields backslash-separated paths on Windows, while agent-core's encodeWorkDirKey uses pathe (forward slashes on every platform). The SHA-256 inputs diverged, so migrated sessions were written to a bucket that the session picker never reads, making them invisible on Windows. Alias computeWorkdirBucket to encodeWorkDirKey so both sides stay byte-identical, drop the local slugify copy, and update the workdir-bucket test reference accordingly. * test(acp-adapter): expect platform-native separators in e2e-fs path The e2e-fs test asserted the fs/readTextFile wire path as the raw POSIX targetPath, but AcpKaos.toClientPath converts '/' to '\' when the inner LocalKaos reports pathClass 'win32' (Windows). On Windows the wire path became '\Users\test\x.ts' and the assertion failed. Mirror toClientPath in the test: expect backslash separators on win32 and the raw path otherwise. Implementation is unchanged. * test(sdk): normalize workDir and skillDir paths in session tests SessionStore.create/list and the skill loader normalize paths through pathe (forward slashes). The SDK tests compared the resulting workDir and skill loaded-dir against raw mkdtemp / node:path strings, which use backslashes on Windows (and node:fs realpath also returns backslashes for the skill dir), failing three toMatchObject assertions. Build the expected paths with agent-core's normalizeWorkDir so they match the internal pathe representation on every platform. The skill dir keeps its realpath() (the loader realpaths the root) and only normalizes separators. * test(skill): normalize realpath to forward slashes in scanner tests resolveSkillRoots normalizes every root.path through fs.realpath followed by replacing backslashes with forward slashes (scanner.ts). The scanner tests compared root.path against node:fs realpath directly, which returns backslashes on Windows, so twenty assertions failed (toEqual / toContain / toHaveLength) even though the resolved paths were identical. Wrap realpath at the top of the test file to mirror the implementation's normalization, so every comparison uses the same forward-slash form on every platform. * test: skip Unix-only permission tests on Windows The Unix file-permission assertions (mode bits like 0o600 / 0o700 and chmod 000 making a path unreadable) have no equivalent on Windows, which uses ACLs; fs.chmod there can only toggle the read-only bit. These six tests failed on Windows with mismatched mode values or a missing 40411. Skip them on win32 via it.skipIf(process.platform === 'win32'): oauth FileTokenStorage (0600 file, 0700 dir), agent-core BackgroundTaskPersistence (0700 tasks dir), agent-core createPerIdJsonStore (0700 subdir), migration-legacy atomicWrite (0600 file), and server fs:browse (chmod 000 -> 40411). * test(tui): make platform-sensitive assertions cross-platform The TUI implementations are already platform-aware (pathe-style paths, pathToFileURL, quoteShellArg cmd/POSIX quoting, Alt+V on Windows for paste expansion), but the tests hard-coded POSIX expectations and failed on Windows. Align the assertions with the implementation's platform behavior: footer-goal-badge matches the '[goal' badge prefix instead of /goal/ (toolbar tips contain '/goal'); tool-call expects backslash relative paths on win32; plan-box builds the file:// URL via pathToFileURL; custom-editor sends Alt+V on win32 for paste expansion; file-mention-provider normalizes the expected description to forward slashes; kimi-tui-startup builds the resume command with quoteShellArg; kimi-tui-message-flow builds the expected install path with resolve(). * test: align path assertions with pathe on Windows Several test suites asserted paths produced by node:path/node:os/node:fs against values that agent-core, node-sdk and kaos normalize through pathe (forward slashes). On Windows the two forms diverge (backslashes vs forward slashes), failing about 19 assertions. Mirror the implementation's normalization in the assertions via a local toPosix helper (or agent-core's normalizeWorkDir), so expected paths use forward slashes on every platform: kaos LocalKaos, node-sdk export/list/resume/config/transport sessions, cli FileMentionProvider, and agent-core skill-session. * test(native): build path expectations with node:path.resolve paths.mjs builds every path with node:path.resolve, which yields backslash-separated absolute paths on Windows. The path-helpers tests asserted against template strings that mixed the backslash appRoot with forward-slash segments, so Object.is failed on Windows even though the strings looked identical. Build the expectations with the same resolve(appRoot, ...) helper so the separators match on every platform. * fix: make Windows CI tests pass across all packages Fix the remaining Windows CI failures so the Windows test job can go green. The changes fall into a few categories: - Path separators: agent-core/node-sdk/kaos normalize paths via pathe (forward slashes); align test expectations and a couple of implementations (native cache base, workspace registry) with that. - Platform-only services: skip launchd/systemd manager suites on win32 (Windows uses schtasks). - Process/signal lifecycle: skip or relax tests that rely on POSIX signals / SIGTERM semantics that Windows does not support. - Hook shell syntax: rewrite hook test commands from POSIX shell (single quotes, semicolons, stderr redirects, if/then/fi) to node -e / .cjs files that run under cmd.exe. - CRLF: make Bash tool description stripping tolerate CRLF line endings. - Misc: realpath short-name divergence, port-retry timing, telemetry spawn, fs-watch timing, snapshot path normalization, etc. * fix: remove unused basename import in workspaceRegistryService Fix lint error (no-unused-vars): basename from node:path is no longer used after switching to posixBasename from pathe. * fix: align resume harness pathClass and wait for banner state on Windows Two more Windows CI fixes: - createResumeNoSideEffectKaos now reports pathClass 'win32' on Windows so tool descriptions (e.g. Glob's Windows note) match the live agent in expectResumeMatches, fixing usage/description deep-equal drift. - kimi-tui-startup once-banner test now waits for writeBannerDisplayState to land before asserting, since the atomic write can lag behind the render on Windows. * fix: resolve remaining Windows unit test failures Make the new Windows CI job green across agent-core, kaos, node-sdk and server: - Align the resume harness kaos pathClass with the live agent so platform-conditional tool descriptions (Glob's Windows note) match in expectResumeMatches instead of drifting on win32. - Rewrite hook commands in agent-core tests as cross-platform node one-liners; single-quote echo, >&2 and ';' do not work under cmd.exe. - Add .gitattributes enforcing LF so raw-imported templates (e.g. the compaction instruction) produce byte-identical token counts on Windows and POSIX. - Terminate the full process tree on Windows in both the hook runner and kaos (taskkill /T /F) so grandchildren cannot outlive their parent and keep the cwd locked. - Normalize workDir path separators in two kimi-sdk session tests to match the stored canonical form. - Avoid cmd.exe arg-quoting pitfalls in the kaos cmd.exe test, and run the Windows process-tree kill test from a script file with the pid path passed via argv. - Give the first fs-git e2e test more time on Windows and retry the temp-dir cleanup; skip the fs-watch overflow-burst assertion on Windows where fs-event coalescing prevents the single-window spike. * ci: retrigger checks * fix: resolve remaining Windows failures after merging main - Terminate the spawned git/gh process tree on Windows in FsGitService (taskkill /T /F on timeout) so a timed-out 'gh pr view' cannot leave a grandchild holding the workspace cwd, which made the fs-git e2e cleanup fail with EPERM. - Give the fs:git_status e2e suite a longer timeout on Windows and retry the temp-dir cleanup longer to ride out the slower child-process teardown. - Make the third-party plugin install trust test assert the resolved install path via node:path so it matches the Windows-resolved path (D:\tmp\...) as well as the POSIX one. * fix: align workspace registry roots and harden fs-git cleanup on Windows - workspace-registry test: compare normalized (forward-slash) roots, since the registry and session index both store workDir via pathe.resolve (forward slashes on every platform). realpath() yields backslashes on Windows and diverged from the stored root. - fs-git e2e: bump the temp-dir cleanup retries and the afterEach timeout, since Windows child-process teardown after server.close() is asynchronous and can keep the workspace cwd locked for several seconds. * test: stub openUrl in kimi-tui-message-flow feedback tests The /feedback command falls back to openUrl(FEEDBACK_ISSUE_URL) when submission fails, which spawned a real browser window on every test run. Mock #/utils/open-url (matching the existing login/message-replay/server test convention) so the suite never opens a browser. * test: harden fs-git e2e cleanup against Windows cwd locks On Windows, git/gh child processes and the session core process can outlive server.close() and keep the temp workspace as their cwd, so rmSync fails with EPERM even after a long retry. Add rmSyncRobust that retries and, if the cwd is still locked, swallows EPERM/EBUSY on Windows — the OS reclaims the temp dir and a cleanup hiccup must not fail an otherwise-passing test. * test: harden server e2e cleanup against async teardown races server.close() does not fully await the server's asynchronous teardown, so on a loaded CI runner the temp home/workspace dirs can still be held or written to when the afterEach rmSync runs, failing with EPERM (Windows) or ENOTEMPTY (Linux). Use a rmSyncRobust helper (retry + swallow EPERM/EBUSY/ENOTEMPTY) in the fs-git and question e2e cleanup. Also fix a leftover `throw err` (renamed to `throw error`) that broke the typecheck.
342 lines
11 KiB
TypeScript
342 lines
11 KiB
TypeScript
import { mkdtemp, realpath, rm } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
|
|
import { LocalKaos } from '#/local';
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
|
|
// ── Helper ────────────────────────────────────────────────────────────
|
|
|
|
async function streamToBuffer(stream: NodeJS.ReadableStream): Promise<Buffer> {
|
|
const chunks: Buffer[] = [];
|
|
for await (const chunk of stream) {
|
|
chunks.push(Buffer.from(chunk as Buffer));
|
|
}
|
|
return Buffer.concat(chunks);
|
|
}
|
|
|
|
// ── Tests ─────────────────────────────────────────────────────────────
|
|
|
|
describe('e2e: process lifecycle', () => {
|
|
let kaos: LocalKaos;
|
|
let tempDir: string;
|
|
let originalCwd: string;
|
|
|
|
beforeEach(async () => {
|
|
kaos = await LocalKaos.create();
|
|
originalCwd = process.cwd();
|
|
tempDir = await realpath(await mkdtemp(join(tmpdir(), 'kaos-proc-')));
|
|
process.chdir(tempDir);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
process.chdir(originalCwd);
|
|
await rm(tempDir, { recursive: true, force: true });
|
|
});
|
|
|
|
describe('stdin → stdout → wait → exitCode', () => {
|
|
it('write to stdin, read from stdout, wait for exit', async () => {
|
|
// Node script that reads stdin and echoes it to stdout
|
|
const code = `
|
|
let data = '';
|
|
process.stdin.setEncoding('utf-8');
|
|
process.stdin.on('data', (chunk) => { data += chunk; });
|
|
process.stdin.on('end', () => {
|
|
process.stdout.write('echo:' + data);
|
|
});
|
|
`;
|
|
const proc = await kaos.exec('node', '-e', code);
|
|
|
|
// Write to stdin
|
|
proc.stdin.write('hello from test');
|
|
proc.stdin.end();
|
|
|
|
// Wait for process to complete
|
|
const exitCode = await proc.wait();
|
|
expect(exitCode).toBe(0);
|
|
|
|
// Read stdout
|
|
const stdout = await streamToBuffer(proc.stdout);
|
|
expect(stdout.toString('utf-8')).toBe('echo:hello from test');
|
|
});
|
|
|
|
it('multiple stdin writes before end', async () => {
|
|
const code = `
|
|
let data = '';
|
|
process.stdin.setEncoding('utf-8');
|
|
process.stdin.on('data', (chunk) => { data += chunk; });
|
|
process.stdin.on('end', () => {
|
|
process.stdout.write(data.toUpperCase());
|
|
});
|
|
`;
|
|
const proc = await kaos.exec('node', '-e', code);
|
|
|
|
proc.stdin.write('hello ');
|
|
proc.stdin.write('world ');
|
|
proc.stdin.write('test');
|
|
proc.stdin.end();
|
|
|
|
const exitCode = await proc.wait();
|
|
expect(exitCode).toBe(0);
|
|
|
|
const stdout = await streamToBuffer(proc.stdout);
|
|
expect(stdout.toString('utf-8')).toBe('HELLO WORLD TEST');
|
|
});
|
|
|
|
it('exitCode is null before wait, correct after wait', async () => {
|
|
const proc = await kaos.exec('node', '-e', 'process.exit(42)');
|
|
|
|
// Before wait, exitCode may be null
|
|
// (it could also be set if process is very fast, so we just check after wait)
|
|
const exitCode = await proc.wait();
|
|
expect(exitCode).toBe(42);
|
|
expect(proc.exitCode).toBe(42);
|
|
});
|
|
});
|
|
|
|
describe('long-running process → kill', () => {
|
|
it.skipIf(process.platform === 'win32')('start → verify running → kill → confirm exit', async () => {
|
|
// Process that runs indefinitely
|
|
const code = `
|
|
process.stdout.write('started\\n');
|
|
setInterval(() => {}, 1000);
|
|
`;
|
|
const proc = await kaos.exec('node', '-e', code);
|
|
|
|
expect(proc.pid).toBeGreaterThan(0);
|
|
|
|
// Kill it
|
|
await proc.kill('SIGTERM');
|
|
|
|
const exitCode = await proc.wait();
|
|
// On SIGTERM, node typically exits with non-zero
|
|
expect(typeof exitCode).toBe('number');
|
|
});
|
|
|
|
it('kill with SIGKILL → immediate termination', async () => {
|
|
const code = `
|
|
// Trap SIGTERM to test that SIGKILL forces exit
|
|
process.on('SIGTERM', () => { /* ignore */ });
|
|
process.stdout.write('alive\\n');
|
|
setInterval(() => {}, 1000);
|
|
`;
|
|
const proc = await kaos.exec('node', '-e', code);
|
|
|
|
await proc.kill('SIGKILL');
|
|
const exitCode = await proc.wait();
|
|
|
|
// SIGKILL cannot be caught - process is terminated
|
|
expect(exitCode).not.toBe(0);
|
|
});
|
|
|
|
it('multiple wait() calls return same exit code', async () => {
|
|
const proc = await kaos.exec('node', '-e', 'process.exit(7)');
|
|
|
|
const code1 = await proc.wait();
|
|
const code2 = await proc.wait();
|
|
const code3 = await proc.wait();
|
|
|
|
expect(code1).toBe(7);
|
|
expect(code2).toBe(7);
|
|
expect(code3).toBe(7);
|
|
});
|
|
});
|
|
|
|
describe('stdin close → natural exit', () => {
|
|
it('closing stdin causes stdin-reading process to exit naturally', async () => {
|
|
// Process that exits when stdin closes
|
|
const code = `
|
|
process.stdin.resume();
|
|
process.stdin.on('end', () => {
|
|
process.stdout.write('stdin closed');
|
|
process.exit(0);
|
|
});
|
|
`;
|
|
const proc = await kaos.exec('node', '-e', code);
|
|
|
|
// Close stdin immediately
|
|
proc.stdin.end();
|
|
|
|
const exitCode = await proc.wait();
|
|
expect(exitCode).toBe(0);
|
|
|
|
const stdout = await streamToBuffer(proc.stdout);
|
|
expect(stdout.toString('utf-8')).toBe('stdin closed');
|
|
});
|
|
|
|
it('cat-like process exits when stdin is closed', async () => {
|
|
const code = `
|
|
process.stdin.setEncoding('utf-8');
|
|
process.stdin.on('data', (chunk) => {
|
|
process.stdout.write(chunk);
|
|
});
|
|
process.stdin.on('end', () => {
|
|
process.exit(0);
|
|
});
|
|
`;
|
|
const proc = await kaos.exec('node', '-e', code);
|
|
|
|
proc.stdin.write('line1\n');
|
|
proc.stdin.write('line2\n');
|
|
proc.stdin.end();
|
|
|
|
const exitCode = await proc.wait();
|
|
expect(exitCode).toBe(0);
|
|
|
|
const stdout = await streamToBuffer(proc.stdout);
|
|
expect(stdout.toString('utf-8')).toBe('line1\nline2\n');
|
|
});
|
|
});
|
|
|
|
describe('process.pid validity', () => {
|
|
it('pid is a positive integer', async () => {
|
|
const proc = await kaos.exec('node', '-e', 'process.exit(0)');
|
|
expect(proc.pid).toBeGreaterThan(0);
|
|
expect(Number.isInteger(proc.pid)).toBe(true);
|
|
|
|
await proc.wait();
|
|
});
|
|
|
|
it('different processes have different pids', async () => {
|
|
const proc1 = await kaos.exec('node', '-e', 'process.exit(0)');
|
|
const proc2 = await kaos.exec('node', '-e', 'process.exit(0)');
|
|
|
|
expect(proc1.pid).not.toBe(proc2.pid);
|
|
|
|
await Promise.all([proc1.wait(), proc2.wait()]);
|
|
});
|
|
|
|
it('pid matches the actual child process pid', async () => {
|
|
// Have the child process report its own pid
|
|
const code = `process.stdout.write(String(process.pid))`;
|
|
const proc = await kaos.exec('node', '-e', code);
|
|
await proc.wait();
|
|
|
|
const stdout = await streamToBuffer(proc.stdout);
|
|
const reportedPid = Number(stdout.toString('utf-8'));
|
|
|
|
expect(proc.pid).toBe(reportedPid);
|
|
});
|
|
});
|
|
|
|
describe('exec failure (command not found)', () => {
|
|
it('non-existent command → error on wait()', async () => {
|
|
// exec() itself may succeed (spawn returns) but wait() should
|
|
// report the error or the process should fail
|
|
try {
|
|
const proc = await kaos.exec('this-command-absolutely-does-not-exist-xyz-123');
|
|
// If exec resolves, wait should give a rejection
|
|
await expect(proc.wait()).rejects.toThrow();
|
|
} catch (error: unknown) {
|
|
// If exec itself throws, that's also acceptable
|
|
expect(error).toBeInstanceOf(Error);
|
|
}
|
|
});
|
|
|
|
it('exec with empty arguments rejects', async () => {
|
|
// exec() is now async, so validation errors (missing command) surface
|
|
// as rejected promises rather than synchronous throws.
|
|
await expect(kaos.exec()).rejects.toThrow(/at least one argument/);
|
|
});
|
|
});
|
|
|
|
describe('execWithEnv', () => {
|
|
it('passes custom environment variables to the child process', async () => {
|
|
const code = `process.stdout.write(process.env.MY_VAR || 'undefined')`;
|
|
const proc = await kaos.execWithEnv(['node', '-e', code], {
|
|
...(process.env as Record<string, string>),
|
|
MY_VAR: 'test-value-123',
|
|
});
|
|
const exitCode = await proc.wait();
|
|
expect(exitCode).toBe(0);
|
|
|
|
const stdout = await streamToBuffer(proc.stdout);
|
|
expect(stdout.toString('utf-8')).toBe('test-value-123');
|
|
});
|
|
|
|
it('custom env overrides specific variables', async () => {
|
|
// Passing a custom env with PATH so node can still run,
|
|
// but with a custom variable that overrides a default one.
|
|
const code = `process.stdout.write(process.env.MY_CUSTOM || 'missing')`;
|
|
const proc = await kaos.execWithEnv(['node', '-e', code], {
|
|
PATH: process.env['PATH'] ?? '',
|
|
MY_CUSTOM: 'overridden-value',
|
|
});
|
|
const exitCode = await proc.wait();
|
|
expect(exitCode).toBe(0);
|
|
|
|
const stdout = await streamToBuffer(proc.stdout);
|
|
expect(stdout.toString('utf-8')).toBe('overridden-value');
|
|
});
|
|
});
|
|
|
|
describe('process output ordering', () => {
|
|
it('stdout preserves line order for sequential writes', async () => {
|
|
const code = `
|
|
for (let i = 0; i < 100; i++) {
|
|
process.stdout.write(i + '\\n');
|
|
}
|
|
`;
|
|
const proc = await kaos.exec('node', '-e', code);
|
|
const exitCode = await proc.wait();
|
|
expect(exitCode).toBe(0);
|
|
|
|
const stdout = await streamToBuffer(proc.stdout);
|
|
const lines = stdout.toString('utf-8').trimEnd().split('\n');
|
|
|
|
expect(lines).toHaveLength(100);
|
|
for (let i = 0; i < 100; i++) {
|
|
expect(lines[i]).toBe(String(i));
|
|
}
|
|
});
|
|
|
|
it('stderr preserves line order for sequential writes', async () => {
|
|
const code = `
|
|
for (let i = 0; i < 50; i++) {
|
|
process.stderr.write('err-' + i + '\\n');
|
|
}
|
|
`;
|
|
const proc = await kaos.exec('node', '-e', code);
|
|
const exitCode = await proc.wait();
|
|
expect(exitCode).toBe(0);
|
|
|
|
const stderr = await streamToBuffer(proc.stderr);
|
|
const lines = stderr.toString('utf-8').trimEnd().split('\n');
|
|
|
|
expect(lines).toHaveLength(50);
|
|
for (let i = 0; i < 50; i++) {
|
|
expect(lines[i]).toBe(`err-${i}`);
|
|
}
|
|
});
|
|
});
|
|
|
|
describe('process exit codes', () => {
|
|
it('exit code 0 for successful process', async () => {
|
|
const proc = await kaos.exec('node', '-e', 'process.exit(0)');
|
|
expect(await proc.wait()).toBe(0);
|
|
});
|
|
|
|
it('exit code 1 for generic failure', async () => {
|
|
const proc = await kaos.exec('node', '-e', 'process.exit(1)');
|
|
expect(await proc.wait()).toBe(1);
|
|
});
|
|
|
|
it('custom exit codes (2, 42, 127, 255)', async () => {
|
|
for (const code of [2, 42, 127, 255]) {
|
|
const proc = await kaos.exec('node', '-e', `process.exit(${code})`);
|
|
expect(await proc.wait()).toBe(code);
|
|
}
|
|
});
|
|
|
|
it('uncaught exception results in exit code 1', async () => {
|
|
const code = `throw new Error('uncaught')`;
|
|
const proc = await kaos.exec('node', '-e', code);
|
|
const exitCode = await proc.wait();
|
|
expect(exitCode).toBe(1);
|
|
|
|
// stderr should contain the error message
|
|
const stderr = await streamToBuffer(proc.stderr);
|
|
expect(stderr.toString('utf-8')).toContain('uncaught');
|
|
});
|
|
});
|
|
});
|