mirror of
https://github.com/MoonshotAI/kimi-code.git
synced 2026-07-09 17:29:12 +00:00
* ci: run unit tests on windows * fix(migration-legacy): align workdir bucket key with agent-core computeWorkdirBucket used a local node:path-based resolve that yields backslash-separated paths on Windows, while agent-core's encodeWorkDirKey uses pathe (forward slashes on every platform). The SHA-256 inputs diverged, so migrated sessions were written to a bucket that the session picker never reads, making them invisible on Windows. Alias computeWorkdirBucket to encodeWorkDirKey so both sides stay byte-identical, drop the local slugify copy, and update the workdir-bucket test reference accordingly. * test(acp-adapter): expect platform-native separators in e2e-fs path The e2e-fs test asserted the fs/readTextFile wire path as the raw POSIX targetPath, but AcpKaos.toClientPath converts '/' to '\' when the inner LocalKaos reports pathClass 'win32' (Windows). On Windows the wire path became '\Users\test\x.ts' and the assertion failed. Mirror toClientPath in the test: expect backslash separators on win32 and the raw path otherwise. Implementation is unchanged. * test(sdk): normalize workDir and skillDir paths in session tests SessionStore.create/list and the skill loader normalize paths through pathe (forward slashes). The SDK tests compared the resulting workDir and skill loaded-dir against raw mkdtemp / node:path strings, which use backslashes on Windows (and node:fs realpath also returns backslashes for the skill dir), failing three toMatchObject assertions. Build the expected paths with agent-core's normalizeWorkDir so they match the internal pathe representation on every platform. The skill dir keeps its realpath() (the loader realpaths the root) and only normalizes separators. * test(skill): normalize realpath to forward slashes in scanner tests resolveSkillRoots normalizes every root.path through fs.realpath followed by replacing backslashes with forward slashes (scanner.ts). The scanner tests compared root.path against node:fs realpath directly, which returns backslashes on Windows, so twenty assertions failed (toEqual / toContain / toHaveLength) even though the resolved paths were identical. Wrap realpath at the top of the test file to mirror the implementation's normalization, so every comparison uses the same forward-slash form on every platform. * test: skip Unix-only permission tests on Windows The Unix file-permission assertions (mode bits like 0o600 / 0o700 and chmod 000 making a path unreadable) have no equivalent on Windows, which uses ACLs; fs.chmod there can only toggle the read-only bit. These six tests failed on Windows with mismatched mode values or a missing 40411. Skip them on win32 via it.skipIf(process.platform === 'win32'): oauth FileTokenStorage (0600 file, 0700 dir), agent-core BackgroundTaskPersistence (0700 tasks dir), agent-core createPerIdJsonStore (0700 subdir), migration-legacy atomicWrite (0600 file), and server fs:browse (chmod 000 -> 40411). * test(tui): make platform-sensitive assertions cross-platform The TUI implementations are already platform-aware (pathe-style paths, pathToFileURL, quoteShellArg cmd/POSIX quoting, Alt+V on Windows for paste expansion), but the tests hard-coded POSIX expectations and failed on Windows. Align the assertions with the implementation's platform behavior: footer-goal-badge matches the '[goal' badge prefix instead of /goal/ (toolbar tips contain '/goal'); tool-call expects backslash relative paths on win32; plan-box builds the file:// URL via pathToFileURL; custom-editor sends Alt+V on win32 for paste expansion; file-mention-provider normalizes the expected description to forward slashes; kimi-tui-startup builds the resume command with quoteShellArg; kimi-tui-message-flow builds the expected install path with resolve(). * test: align path assertions with pathe on Windows Several test suites asserted paths produced by node:path/node:os/node:fs against values that agent-core, node-sdk and kaos normalize through pathe (forward slashes). On Windows the two forms diverge (backslashes vs forward slashes), failing about 19 assertions. Mirror the implementation's normalization in the assertions via a local toPosix helper (or agent-core's normalizeWorkDir), so expected paths use forward slashes on every platform: kaos LocalKaos, node-sdk export/list/resume/config/transport sessions, cli FileMentionProvider, and agent-core skill-session. * test(native): build path expectations with node:path.resolve paths.mjs builds every path with node:path.resolve, which yields backslash-separated absolute paths on Windows. The path-helpers tests asserted against template strings that mixed the backslash appRoot with forward-slash segments, so Object.is failed on Windows even though the strings looked identical. Build the expectations with the same resolve(appRoot, ...) helper so the separators match on every platform. * fix: make Windows CI tests pass across all packages Fix the remaining Windows CI failures so the Windows test job can go green. The changes fall into a few categories: - Path separators: agent-core/node-sdk/kaos normalize paths via pathe (forward slashes); align test expectations and a couple of implementations (native cache base, workspace registry) with that. - Platform-only services: skip launchd/systemd manager suites on win32 (Windows uses schtasks). - Process/signal lifecycle: skip or relax tests that rely on POSIX signals / SIGTERM semantics that Windows does not support. - Hook shell syntax: rewrite hook test commands from POSIX shell (single quotes, semicolons, stderr redirects, if/then/fi) to node -e / .cjs files that run under cmd.exe. - CRLF: make Bash tool description stripping tolerate CRLF line endings. - Misc: realpath short-name divergence, port-retry timing, telemetry spawn, fs-watch timing, snapshot path normalization, etc. * fix: remove unused basename import in workspaceRegistryService Fix lint error (no-unused-vars): basename from node:path is no longer used after switching to posixBasename from pathe. * fix: align resume harness pathClass and wait for banner state on Windows Two more Windows CI fixes: - createResumeNoSideEffectKaos now reports pathClass 'win32' on Windows so tool descriptions (e.g. Glob's Windows note) match the live agent in expectResumeMatches, fixing usage/description deep-equal drift. - kimi-tui-startup once-banner test now waits for writeBannerDisplayState to land before asserting, since the atomic write can lag behind the render on Windows. * fix: resolve remaining Windows unit test failures Make the new Windows CI job green across agent-core, kaos, node-sdk and server: - Align the resume harness kaos pathClass with the live agent so platform-conditional tool descriptions (Glob's Windows note) match in expectResumeMatches instead of drifting on win32. - Rewrite hook commands in agent-core tests as cross-platform node one-liners; single-quote echo, >&2 and ';' do not work under cmd.exe. - Add .gitattributes enforcing LF so raw-imported templates (e.g. the compaction instruction) produce byte-identical token counts on Windows and POSIX. - Terminate the full process tree on Windows in both the hook runner and kaos (taskkill /T /F) so grandchildren cannot outlive their parent and keep the cwd locked. - Normalize workDir path separators in two kimi-sdk session tests to match the stored canonical form. - Avoid cmd.exe arg-quoting pitfalls in the kaos cmd.exe test, and run the Windows process-tree kill test from a script file with the pid path passed via argv. - Give the first fs-git e2e test more time on Windows and retry the temp-dir cleanup; skip the fs-watch overflow-burst assertion on Windows where fs-event coalescing prevents the single-window spike. * ci: retrigger checks * fix: resolve remaining Windows failures after merging main - Terminate the spawned git/gh process tree on Windows in FsGitService (taskkill /T /F on timeout) so a timed-out 'gh pr view' cannot leave a grandchild holding the workspace cwd, which made the fs-git e2e cleanup fail with EPERM. - Give the fs:git_status e2e suite a longer timeout on Windows and retry the temp-dir cleanup longer to ride out the slower child-process teardown. - Make the third-party plugin install trust test assert the resolved install path via node:path so it matches the Windows-resolved path (D:\tmp\...) as well as the POSIX one. * fix: align workspace registry roots and harden fs-git cleanup on Windows - workspace-registry test: compare normalized (forward-slash) roots, since the registry and session index both store workDir via pathe.resolve (forward slashes on every platform). realpath() yields backslashes on Windows and diverged from the stored root. - fs-git e2e: bump the temp-dir cleanup retries and the afterEach timeout, since Windows child-process teardown after server.close() is asynchronous and can keep the workspace cwd locked for several seconds. * test: stub openUrl in kimi-tui-message-flow feedback tests The /feedback command falls back to openUrl(FEEDBACK_ISSUE_URL) when submission fails, which spawned a real browser window on every test run. Mock #/utils/open-url (matching the existing login/message-replay/server test convention) so the suite never opens a browser. * test: harden fs-git e2e cleanup against Windows cwd locks On Windows, git/gh child processes and the session core process can outlive server.close() and keep the temp workspace as their cwd, so rmSync fails with EPERM even after a long retry. Add rmSyncRobust that retries and, if the cwd is still locked, swallows EPERM/EBUSY on Windows — the OS reclaims the temp dir and a cleanup hiccup must not fail an otherwise-passing test. * test: harden server e2e cleanup against async teardown races server.close() does not fully await the server's asynchronous teardown, so on a loaded CI runner the temp home/workspace dirs can still be held or written to when the afterEach rmSync runs, failing with EPERM (Windows) or ENOTEMPTY (Linux). Use a rmSyncRobust helper (retry + swallow EPERM/EBUSY/ENOTEMPTY) in the fs-git and question e2e cleanup. Also fix a leftover `throw err` (renamed to `throw error`) that broke the typecheck.
234 lines
8.2 KiB
TypeScript
234 lines
8.2 KiB
TypeScript
import { mkdtemp, realpath, rm } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'pathe';
|
|
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
|
|
import { LocalKaos } from '#/local';
|
|
|
|
// ── Tests ─────────────────────────────────────────────────────────────
|
|
|
|
describe('e2e: concurrent operations', () => {
|
|
let kaos: LocalKaos;
|
|
let tempDir: string;
|
|
let originalCwd: string;
|
|
|
|
beforeEach(async () => {
|
|
kaos = await LocalKaos.create();
|
|
originalCwd = process.cwd();
|
|
tempDir = await realpath(await mkdtemp(join(tmpdir(), 'kaos-concurrent-')));
|
|
process.chdir(tempDir);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
process.chdir(originalCwd);
|
|
await rm(tempDir, { recursive: true, force: true });
|
|
});
|
|
|
|
describe('concurrent reads and writes on different files', () => {
|
|
it('10 concurrent writeText + readText on separate files → all consistent', async () => {
|
|
const count = 10;
|
|
const promises = Array.from({ length: count }, async (_, i): Promise<void> => {
|
|
const filePath = join(tempDir, `file-${i}.txt`);
|
|
const content = `content-${i}-${'data'.repeat(100)}`;
|
|
await kaos.writeText(filePath, content);
|
|
const readBack = await kaos.readText(filePath);
|
|
expect(readBack).toBe(content);
|
|
});
|
|
|
|
await Promise.all(promises);
|
|
});
|
|
});
|
|
|
|
describe('concurrent writes to the same file', () => {
|
|
it('sequential writes to same file → last write wins', async () => {
|
|
const filePath = join(tempDir, 'shared.txt');
|
|
const writes = 20;
|
|
|
|
// Write sequentially to guarantee ordering
|
|
for (let i = 0; i < writes; i++) {
|
|
await kaos.writeText(filePath, `version-${i}`);
|
|
}
|
|
|
|
// The file should have the last written content
|
|
const content = await kaos.readText(filePath);
|
|
expect(content).toBe(`version-${writes - 1}`);
|
|
});
|
|
|
|
it('concurrent appends to same file → all data present', async () => {
|
|
const filePath = join(tempDir, 'append-target.txt');
|
|
await kaos.writeText(filePath, '');
|
|
|
|
const count = 20;
|
|
const promises: Promise<number>[] = [];
|
|
|
|
for (let i = 0; i < count; i++) {
|
|
promises.push(kaos.writeText(filePath, `line-${i}\n`, { mode: 'a' }));
|
|
}
|
|
|
|
await Promise.all(promises);
|
|
|
|
const content = await kaos.readText(filePath);
|
|
const lines = content.trimEnd().split('\n');
|
|
|
|
// All lines should be present (order may vary due to concurrency)
|
|
expect(lines).toHaveLength(count);
|
|
const lineSet = new Set(lines);
|
|
for (let i = 0; i < count; i++) {
|
|
expect(lineSet.has(`line-${i}`)).toBe(true);
|
|
}
|
|
});
|
|
});
|
|
|
|
describe('concurrent exec of multiple subprocesses', () => {
|
|
it('5 concurrent node processes → all complete independently', async () => {
|
|
const count = 5;
|
|
const promises = Array.from(
|
|
{ length: count },
|
|
async (_, i): Promise<{ index: number; exitCode: number; stdout: string }> => {
|
|
const code = `process.stdout.write('proc-${i}');`;
|
|
const proc = await kaos.exec('node', '-e', code);
|
|
const exitCode = await proc.wait();
|
|
|
|
const chunks: Buffer[] = [];
|
|
for await (const chunk of proc.stdout) {
|
|
chunks.push(Buffer.from(chunk as Buffer));
|
|
}
|
|
const stdout = Buffer.concat(chunks).toString('utf-8');
|
|
|
|
return { index: i, exitCode, stdout };
|
|
},
|
|
);
|
|
|
|
const results = await Promise.all(promises);
|
|
|
|
for (const result of results) {
|
|
expect(result.exitCode).toBe(0);
|
|
expect(result.stdout).toBe(`proc-${result.index}`);
|
|
}
|
|
});
|
|
|
|
it('concurrent processes with different exit codes', async () => {
|
|
const exitCodes = [0, 1, 2, 42, 0];
|
|
const promises = exitCodes.map(async (code) => {
|
|
const proc = await kaos.exec('node', '-e', `process.exit(${code})`);
|
|
return proc.wait();
|
|
});
|
|
|
|
const results = await Promise.all(promises);
|
|
expect(results).toEqual(exitCodes);
|
|
});
|
|
});
|
|
|
|
describe('concurrent iterdir + file creation', () => {
|
|
it('iterdir does not crash when files are being created concurrently', async () => {
|
|
// Pre-create some files
|
|
for (let i = 0; i < 5; i++) {
|
|
await kaos.writeText(join(tempDir, `existing-${i}.txt`), `data-${i}`);
|
|
}
|
|
|
|
// Start iterdir and file creation concurrently
|
|
const iterdirPromise = (async (): Promise<string[]> => {
|
|
const entries: string[] = [];
|
|
for await (const entry of kaos.iterdir(tempDir)) {
|
|
entries.push(entry);
|
|
}
|
|
return entries;
|
|
})();
|
|
|
|
const creationPromise = (async (): Promise<void> => {
|
|
for (let i = 0; i < 5; i++) {
|
|
await kaos.writeText(join(tempDir, `new-${i}.txt`), `new-data-${i}`);
|
|
}
|
|
})();
|
|
|
|
const [entries] = await Promise.all([iterdirPromise, creationPromise]);
|
|
|
|
// iterdir should return at least the pre-existing files
|
|
// (new files may or may not be included depending on timing)
|
|
expect(entries.length).toBeGreaterThanOrEqual(5);
|
|
});
|
|
});
|
|
|
|
describe('concurrent glob operations', () => {
|
|
it('multiple concurrent globs return correct results', async () => {
|
|
// Create files with different extensions
|
|
await kaos.writeText(join(tempDir, 'a.ts'), 'ts');
|
|
await kaos.writeText(join(tempDir, 'b.ts'), 'ts');
|
|
await kaos.writeText(join(tempDir, 'c.js'), 'js');
|
|
await kaos.writeText(join(tempDir, 'd.js'), 'js');
|
|
await kaos.writeText(join(tempDir, 'e.json'), 'json');
|
|
|
|
const [tsFiles, jsFiles, jsonFiles] = await Promise.all([
|
|
collectGlob(kaos, tempDir, '*.ts'),
|
|
collectGlob(kaos, tempDir, '*.js'),
|
|
collectGlob(kaos, tempDir, '*.json'),
|
|
]);
|
|
|
|
expect(tsFiles.toSorted()).toEqual([join(tempDir, 'a.ts'), join(tempDir, 'b.ts')].toSorted());
|
|
expect(jsFiles.toSorted()).toEqual([join(tempDir, 'c.js'), join(tempDir, 'd.js')].toSorted());
|
|
expect(jsonFiles).toEqual([join(tempDir, 'e.json')]);
|
|
});
|
|
|
|
it('10 concurrent glob(*.txt) on same directory → consistent results', async () => {
|
|
// Use a flat glob pattern to avoid ** duplication behavior
|
|
await kaos.writeText(join(tempDir, 'a.txt'), 'a');
|
|
await kaos.writeText(join(tempDir, 'b.txt'), 'b');
|
|
await kaos.writeText(join(tempDir, 'c.txt'), 'c');
|
|
|
|
const expected = [
|
|
join(tempDir, 'a.txt'),
|
|
join(tempDir, 'b.txt'),
|
|
join(tempDir, 'c.txt'),
|
|
].toSorted();
|
|
|
|
const promises: Promise<string[]>[] = [];
|
|
for (let i = 0; i < 10; i++) {
|
|
promises.push(collectGlob(kaos, tempDir, '*.txt'));
|
|
}
|
|
|
|
const results = await Promise.all(promises);
|
|
|
|
for (const result of results) {
|
|
expect(result.toSorted()).toEqual(expected);
|
|
}
|
|
});
|
|
});
|
|
|
|
describe('concurrent mixed operations', () => {
|
|
it('read + write + stat + iterdir concurrently on same directory', async () => {
|
|
const filePath = join(tempDir, 'mixed.txt');
|
|
await kaos.writeText(filePath, 'initial');
|
|
|
|
const [readResult, _writeResult, statResult, entries] = await Promise.all([
|
|
kaos.readText(filePath),
|
|
kaos.writeText(join(tempDir, 'another.txt'), 'other'),
|
|
kaos.stat(filePath),
|
|
collectIterdir(kaos, tempDir),
|
|
]);
|
|
|
|
// readResult might be 'initial' (read before write) or a valid string
|
|
expect(typeof readResult).toBe('string');
|
|
expect(statResult.stSize).toBeGreaterThan(0);
|
|
expect(entries.length).toBeGreaterThanOrEqual(1);
|
|
});
|
|
});
|
|
});
|
|
|
|
// ── Helper functions ──────────────────────────────────────────────────
|
|
|
|
async function collectGlob(kaos: LocalKaos, path: string, pattern: string): Promise<string[]> {
|
|
const results: string[] = [];
|
|
for await (const entry of kaos.glob(path, pattern)) {
|
|
results.push(entry);
|
|
}
|
|
return results;
|
|
}
|
|
|
|
async function collectIterdir(kaos: LocalKaos, path: string): Promise<string[]> {
|
|
const results: string[] = [];
|
|
for await (const entry of kaos.iterdir(path)) {
|
|
results.push(entry);
|
|
}
|
|
return results;
|
|
}
|