mirror of
https://github.com/MoonshotAI/kimi-code.git
synced 2026-07-09 17:29:12 +00:00
* ci: run unit tests on windows * fix(migration-legacy): align workdir bucket key with agent-core computeWorkdirBucket used a local node:path-based resolve that yields backslash-separated paths on Windows, while agent-core's encodeWorkDirKey uses pathe (forward slashes on every platform). The SHA-256 inputs diverged, so migrated sessions were written to a bucket that the session picker never reads, making them invisible on Windows. Alias computeWorkdirBucket to encodeWorkDirKey so both sides stay byte-identical, drop the local slugify copy, and update the workdir-bucket test reference accordingly. * test(acp-adapter): expect platform-native separators in e2e-fs path The e2e-fs test asserted the fs/readTextFile wire path as the raw POSIX targetPath, but AcpKaos.toClientPath converts '/' to '\' when the inner LocalKaos reports pathClass 'win32' (Windows). On Windows the wire path became '\Users\test\x.ts' and the assertion failed. Mirror toClientPath in the test: expect backslash separators on win32 and the raw path otherwise. Implementation is unchanged. * test(sdk): normalize workDir and skillDir paths in session tests SessionStore.create/list and the skill loader normalize paths through pathe (forward slashes). The SDK tests compared the resulting workDir and skill loaded-dir against raw mkdtemp / node:path strings, which use backslashes on Windows (and node:fs realpath also returns backslashes for the skill dir), failing three toMatchObject assertions. Build the expected paths with agent-core's normalizeWorkDir so they match the internal pathe representation on every platform. The skill dir keeps its realpath() (the loader realpaths the root) and only normalizes separators. * test(skill): normalize realpath to forward slashes in scanner tests resolveSkillRoots normalizes every root.path through fs.realpath followed by replacing backslashes with forward slashes (scanner.ts). The scanner tests compared root.path against node:fs realpath directly, which returns backslashes on Windows, so twenty assertions failed (toEqual / toContain / toHaveLength) even though the resolved paths were identical. Wrap realpath at the top of the test file to mirror the implementation's normalization, so every comparison uses the same forward-slash form on every platform. * test: skip Unix-only permission tests on Windows The Unix file-permission assertions (mode bits like 0o600 / 0o700 and chmod 000 making a path unreadable) have no equivalent on Windows, which uses ACLs; fs.chmod there can only toggle the read-only bit. These six tests failed on Windows with mismatched mode values or a missing 40411. Skip them on win32 via it.skipIf(process.platform === 'win32'): oauth FileTokenStorage (0600 file, 0700 dir), agent-core BackgroundTaskPersistence (0700 tasks dir), agent-core createPerIdJsonStore (0700 subdir), migration-legacy atomicWrite (0600 file), and server fs:browse (chmod 000 -> 40411). * test(tui): make platform-sensitive assertions cross-platform The TUI implementations are already platform-aware (pathe-style paths, pathToFileURL, quoteShellArg cmd/POSIX quoting, Alt+V on Windows for paste expansion), but the tests hard-coded POSIX expectations and failed on Windows. Align the assertions with the implementation's platform behavior: footer-goal-badge matches the '[goal' badge prefix instead of /goal/ (toolbar tips contain '/goal'); tool-call expects backslash relative paths on win32; plan-box builds the file:// URL via pathToFileURL; custom-editor sends Alt+V on win32 for paste expansion; file-mention-provider normalizes the expected description to forward slashes; kimi-tui-startup builds the resume command with quoteShellArg; kimi-tui-message-flow builds the expected install path with resolve(). * test: align path assertions with pathe on Windows Several test suites asserted paths produced by node:path/node:os/node:fs against values that agent-core, node-sdk and kaos normalize through pathe (forward slashes). On Windows the two forms diverge (backslashes vs forward slashes), failing about 19 assertions. Mirror the implementation's normalization in the assertions via a local toPosix helper (or agent-core's normalizeWorkDir), so expected paths use forward slashes on every platform: kaos LocalKaos, node-sdk export/list/resume/config/transport sessions, cli FileMentionProvider, and agent-core skill-session. * test(native): build path expectations with node:path.resolve paths.mjs builds every path with node:path.resolve, which yields backslash-separated absolute paths on Windows. The path-helpers tests asserted against template strings that mixed the backslash appRoot with forward-slash segments, so Object.is failed on Windows even though the strings looked identical. Build the expectations with the same resolve(appRoot, ...) helper so the separators match on every platform. * fix: make Windows CI tests pass across all packages Fix the remaining Windows CI failures so the Windows test job can go green. The changes fall into a few categories: - Path separators: agent-core/node-sdk/kaos normalize paths via pathe (forward slashes); align test expectations and a couple of implementations (native cache base, workspace registry) with that. - Platform-only services: skip launchd/systemd manager suites on win32 (Windows uses schtasks). - Process/signal lifecycle: skip or relax tests that rely on POSIX signals / SIGTERM semantics that Windows does not support. - Hook shell syntax: rewrite hook test commands from POSIX shell (single quotes, semicolons, stderr redirects, if/then/fi) to node -e / .cjs files that run under cmd.exe. - CRLF: make Bash tool description stripping tolerate CRLF line endings. - Misc: realpath short-name divergence, port-retry timing, telemetry spawn, fs-watch timing, snapshot path normalization, etc. * fix: remove unused basename import in workspaceRegistryService Fix lint error (no-unused-vars): basename from node:path is no longer used after switching to posixBasename from pathe. * fix: align resume harness pathClass and wait for banner state on Windows Two more Windows CI fixes: - createResumeNoSideEffectKaos now reports pathClass 'win32' on Windows so tool descriptions (e.g. Glob's Windows note) match the live agent in expectResumeMatches, fixing usage/description deep-equal drift. - kimi-tui-startup once-banner test now waits for writeBannerDisplayState to land before asserting, since the atomic write can lag behind the render on Windows. * fix: resolve remaining Windows unit test failures Make the new Windows CI job green across agent-core, kaos, node-sdk and server: - Align the resume harness kaos pathClass with the live agent so platform-conditional tool descriptions (Glob's Windows note) match in expectResumeMatches instead of drifting on win32. - Rewrite hook commands in agent-core tests as cross-platform node one-liners; single-quote echo, >&2 and ';' do not work under cmd.exe. - Add .gitattributes enforcing LF so raw-imported templates (e.g. the compaction instruction) produce byte-identical token counts on Windows and POSIX. - Terminate the full process tree on Windows in both the hook runner and kaos (taskkill /T /F) so grandchildren cannot outlive their parent and keep the cwd locked. - Normalize workDir path separators in two kimi-sdk session tests to match the stored canonical form. - Avoid cmd.exe arg-quoting pitfalls in the kaos cmd.exe test, and run the Windows process-tree kill test from a script file with the pid path passed via argv. - Give the first fs-git e2e test more time on Windows and retry the temp-dir cleanup; skip the fs-watch overflow-burst assertion on Windows where fs-event coalescing prevents the single-window spike. * ci: retrigger checks * fix: resolve remaining Windows failures after merging main - Terminate the spawned git/gh process tree on Windows in FsGitService (taskkill /T /F on timeout) so a timed-out 'gh pr view' cannot leave a grandchild holding the workspace cwd, which made the fs-git e2e cleanup fail with EPERM. - Give the fs:git_status e2e suite a longer timeout on Windows and retry the temp-dir cleanup longer to ride out the slower child-process teardown. - Make the third-party plugin install trust test assert the resolved install path via node:path so it matches the Windows-resolved path (D:\tmp\...) as well as the POSIX one. * fix: align workspace registry roots and harden fs-git cleanup on Windows - workspace-registry test: compare normalized (forward-slash) roots, since the registry and session index both store workDir via pathe.resolve (forward slashes on every platform). realpath() yields backslashes on Windows and diverged from the stored root. - fs-git e2e: bump the temp-dir cleanup retries and the afterEach timeout, since Windows child-process teardown after server.close() is asynchronous and can keep the workspace cwd locked for several seconds. * test: stub openUrl in kimi-tui-message-flow feedback tests The /feedback command falls back to openUrl(FEEDBACK_ISSUE_URL) when submission fails, which spawned a real browser window on every test run. Mock #/utils/open-url (matching the existing login/message-replay/server test convention) so the suite never opens a browser. * test: harden fs-git e2e cleanup against Windows cwd locks On Windows, git/gh child processes and the session core process can outlive server.close() and keep the temp workspace as their cwd, so rmSync fails with EPERM even after a long retry. Add rmSyncRobust that retries and, if the cwd is still locked, swallows EPERM/EBUSY on Windows — the OS reclaims the temp dir and a cleanup hiccup must not fail an otherwise-passing test. * test: harden server e2e cleanup against async teardown races server.close() does not fully await the server's asynchronous teardown, so on a loaded CI runner the temp home/workspace dirs can still be held or written to when the afterEach rmSync runs, failing with EPERM (Windows) or ENOTEMPTY (Linux). Use a rmSyncRobust helper (retry + swallow EPERM/EBUSY/ENOTEMPTY) in the fs-git and question e2e cleanup. Also fix a leftover `throw err` (renamed to `throw error`) that broke the typecheck.
162 lines
5.7 KiB
TypeScript
162 lines
5.7 KiB
TypeScript
/**
|
|
* Background task persistence tests.
|
|
*/
|
|
|
|
import { mkdir, rm, stat, writeFile } from 'node:fs/promises';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'pathe';
|
|
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
|
|
import {
|
|
BackgroundTaskPersistence,
|
|
type BackgroundTaskInfo,
|
|
} from '../../../src/agent/background';
|
|
|
|
let sessionDir: string;
|
|
let persistence: BackgroundTaskPersistence;
|
|
|
|
function sample(overrides: Partial<Extract<BackgroundTaskInfo, { kind: 'process' }>> = {}): Extract<BackgroundTaskInfo, { kind: 'process' }> {
|
|
return {
|
|
taskId: 'bash-11111111',
|
|
kind: 'process',
|
|
command: 'npm install',
|
|
description: 'install deps',
|
|
pid: 12345,
|
|
startedAt: 1_700_000_000,
|
|
endedAt: null,
|
|
exitCode: null,
|
|
status: 'running',
|
|
detached: true,
|
|
...overrides,
|
|
};
|
|
}
|
|
|
|
beforeEach(async () => {
|
|
sessionDir = join(
|
|
tmpdir(),
|
|
`kimi-bg-persist-${Date.now()}-${Math.random().toString(36).slice(2)}`,
|
|
);
|
|
await mkdir(sessionDir, { recursive: true });
|
|
persistence = new BackgroundTaskPersistence(sessionDir);
|
|
});
|
|
|
|
afterEach(async () => {
|
|
await rm(sessionDir, { recursive: true, force: true });
|
|
});
|
|
|
|
describe('BackgroundTaskPersistence', () => {
|
|
it('round-trips a task via write/read', async () => {
|
|
await persistence.writeTask(sample());
|
|
const loaded = await persistence.readTask('bash-11111111');
|
|
expect(loaded).toEqual(sample());
|
|
});
|
|
|
|
it('returns undefined when task file is missing', async () => {
|
|
expect(await persistence.readTask('bash-missing0')).toBeUndefined();
|
|
});
|
|
|
|
it('overwrites on subsequent write', async () => {
|
|
await persistence.writeTask(sample({ status: 'running' }));
|
|
await persistence.writeTask(
|
|
sample({ status: 'completed', exitCode: 0, endedAt: 1_700_000_100 }),
|
|
);
|
|
const task = await persistence.readTask('bash-11111111');
|
|
expect(task).toMatchObject({
|
|
status: 'completed',
|
|
kind: 'process',
|
|
exitCode: 0,
|
|
endedAt: 1_700_000_100,
|
|
});
|
|
});
|
|
|
|
it('listTasks enumerates all persisted entries', async () => {
|
|
await persistence.writeTask(sample({ taskId: 'bash-11111111' }));
|
|
await persistence.writeTask(sample({ taskId: 'bash-22222222', command: 'pnpm test' }));
|
|
const all = await persistence.listTasks();
|
|
expect(all).toHaveLength(2);
|
|
expect(all.map((task) => task.taskId).toSorted()).toEqual([
|
|
'bash-11111111',
|
|
'bash-22222222',
|
|
]);
|
|
});
|
|
|
|
it('listTasks returns empty when tasks dir does not exist', async () => {
|
|
expect(await persistence.listTasks()).toEqual([]);
|
|
});
|
|
|
|
it('listTasks skips corrupt files', async () => {
|
|
await persistence.writeTask(sample());
|
|
await writeFile(join(sessionDir, 'tasks', 'bash-baaaaaaa.json'), '{not json', 'utf-8');
|
|
const all = await persistence.listTasks();
|
|
expect(all.map((task) => task.taskId)).toEqual(['bash-11111111']);
|
|
});
|
|
|
|
it.skipIf(process.platform === 'win32')('writeTask creates tasks dir with mode 0700', async () => {
|
|
await persistence.writeTask(sample());
|
|
const st = await stat(join(sessionDir, 'tasks'));
|
|
// eslint-disable-next-line no-bitwise
|
|
expect(st.mode & 0o777).toBe(0o700);
|
|
});
|
|
|
|
it('rejects path-traversal task ids', async () => {
|
|
await expect(
|
|
persistence.writeTask(sample({ taskId: '../../etc/passwd' })),
|
|
).rejects.toThrow(/Invalid task id/);
|
|
await expect(persistence.readTask('../etc/passwd')).rejects.toThrow(/Invalid task id/);
|
|
expect(() => persistence.taskOutputFile('../etc/passwd')).toThrow(/Invalid task id/);
|
|
});
|
|
|
|
it('listTasks silently skips non-validating task id files', async () => {
|
|
await persistence.writeTask(sample());
|
|
await writeFile(
|
|
join(sessionDir, 'tasks', 'BAD-ID!!!.json'),
|
|
JSON.stringify(sample({ taskId: 'BAD-ID!!!' })),
|
|
'utf-8',
|
|
);
|
|
const all = await persistence.listTasks();
|
|
expect(all.map((task) => task.taskId)).toEqual(['bash-11111111']);
|
|
});
|
|
|
|
it('listTasks skips unrecognized records', async () => {
|
|
await persistence.writeTask(sample());
|
|
await writeFile(
|
|
join(sessionDir, 'tasks', 'bash-cccccccc.json'),
|
|
JSON.stringify({ oops: 1 }),
|
|
'utf-8',
|
|
);
|
|
const all = await persistence.listTasks();
|
|
expect(all.map((task) => task.taskId)).toEqual(['bash-11111111']);
|
|
});
|
|
|
|
it('readTask for an unknown task does not create a directory', async () => {
|
|
const { readdir } = await import('node:fs/promises');
|
|
expect(await persistence.readTask('bash-noexis00')).toBeUndefined();
|
|
const top = await readdir(sessionDir);
|
|
expect(top.includes('tasks')).toBe(false);
|
|
});
|
|
|
|
describe('readTaskOutputBytes / taskOutputSizeBytes', () => {
|
|
it('taskOutputSizeBytes reports the full byte size of output.log', async () => {
|
|
await persistence.appendTaskOutput('bash-size0000', 'abcdefghij');
|
|
expect(await persistence.taskOutputSizeBytes('bash-size0000')).toBe(10);
|
|
});
|
|
|
|
it('taskOutputSizeBytes returns 0 when output.log is absent', async () => {
|
|
expect(await persistence.taskOutputSizeBytes('bash-none0000')).toBe(0);
|
|
});
|
|
|
|
it('readTaskOutputBytes returns the exact byte window for offset + maxBytes', async () => {
|
|
await persistence.appendTaskOutput('bash-page0000', 'abcdefghijklmnopqrstuvwxyz');
|
|
|
|
expect(await persistence.readTaskOutputBytes('bash-page0000', 5, 10)).toBe('fghijklmno');
|
|
expect(await persistence.readTaskOutputBytes('bash-page0000', 0, 3)).toBe('abc');
|
|
expect(await persistence.readTaskOutputBytes('bash-page0000', 20, 100)).toBe('uvwxyz');
|
|
expect(await persistence.readTaskOutputBytes('bash-page0000', 26, 10)).toBe('');
|
|
});
|
|
|
|
it('readTaskOutputBytes returns empty string when output.log is absent', async () => {
|
|
expect(await persistence.readTaskOutputBytes('bash-none0001', 0, 100)).toBe('');
|
|
});
|
|
});
|
|
});
|