mirror of
https://github.com/MoonshotAI/kimi-code.git
synced 2026-07-09 17:29:12 +00:00
* test(server): add API surface snapshot guardrail
Boot startServer on port 0 and snapshot the documented v1 route table derived from /openapi.json paths, plus the reachability of doc/meta endpoints (/healthz, /openapi.json, /asyncapi.json, /). Gives later auth/--host phases an intentional diff when routes change. M0 makes no production behavior change.
* test(server): add e2e server harness with token support
Add test/helpers/serverHarness.ts: boot() wraps startServer with an isolated lock + home dir and returns a handle (server, address, baseUrl, wsUrl, token, close) plus authedFetch/authedWs that carry Authorization: Bearer <token> (and the kimi-code.bearer.<token> WS subprotocol). serviceOverrides is the generic DI seam later phases use to inject a fixed-token auth service; IAuthTokenService is not referenced yet. closeAll() tears down every booted server and socket. M0 makes no production behavior change; typecheck-only gate.
* feat(server): add privateFiles 0600 atomic write/read utility
* feat(server): add per-start tokenStore
* feat(server): add env-based bcrypt password hash utility
* feat(server): add IAuthTokenService DI seam
* feat(server): add global onRequest auth hook with bypass + redaction
* fix(server): stop reflecting Host header in /asyncapi.json
* feat(server): add WS bearer subprotocol constant and parser
* feat(server): enforce bearer token auth on WS upgrade
* feat(server): add Host header allowlist middleware
* feat(server): add Origin/CORS middleware
* feat(server): wire Host/Origin checks into HTTP and WS
* feat(server): wire token auth, Host/Origin, and WS auth into start.ts
* fix(server): create lock file with 0600 permissions
* fix(server): suppress debug routes on non-loopback binds
* feat(kimi-code): read server token and send Authorization on CLI calls
* feat(kimi-code): inject server token into /web URL fragment
* feat(server): add bindClassify for loopback/lan/public classification
* feat(kimi-code): register --host flag and pass it through the daemon
* feat(server): require password and TLS opt-out on non-loopback binds
* feat(server): rate-limit repeated auth failures on non-loopback binds
* feat(server): disable shutdown and terminals on public binds by default
* feat(server): add security response headers on non-loopback binds
* test(server): cover LAN/public host-exposure hardening end to end
* docs(server): add deployment security and threat-model guide
* changeset: minor kimi-code for server auth and host exposure
* feat(kimi-web): add server bearer-token auth support
* fix: repair CI for server auth and host exposure
- Replace native @node-rs/bcrypt with pure-JS bcryptjs so the ESM CLI
bundle and the SEA native bundle both build without native-addon
require issues (node-rs/bcrypt broke the ESM smoke and the SEA
check-bundle allowlist).
- Remove dead cleanup references (stopSpinner, authLogoBlinkTimer) in
apps/kimi-web App.vue that failed vue-tsc.
- Fix lint: drop empty spread fallbacks in the e2e auth-header merge,
void the intentionally-async WS upgrade listener, add missing
assertions to satisfy jest/expect-expect, and convert a ternary
statement to if/else.
- Send the bearer token in the snapshot perf/smoke tests so they pass
under the new global auth hook.
- Refresh the pnpmDeps hash in flake.nix for the updated lockfile.
* feat(server): persist bearer token and add rotate-token command
- persist the server bearer token in <home>/server.token (0600) and reuse it across restarts instead of per-start server-<pid>.token
- add `kimi server rotate-token` to regenerate the token; the token store reloads on mtime/inode change so rotation applies without restart
- print the token and Vite-style Local/Network URLs in the startup banner
- allow non-loopback binds with bearer-token-only auth (password now optional) and update SECURITY.md
- surface daemon boot failures immediately with the exit reason and log tail instead of waiting for the spawn timeout
* feat(server): print full token URLs and re-print links after rotate
- Drop the ready-panel border so token URLs print in full for copying; keep the Kimi sprite beside the title.
- Re-print Local/Network access links after `server rotate-token` (host/port from the lock).
- Extract shared access-URL helpers into access-urls.ts.
- Unify link and token colors between the banner and rotate-token.
* feat(server): dim URL #token= fragment and de-highlight token
- Render the `#token=…` fragment in a dim gray so the host/port stands out in the banner and rotate-token links.
- De-highlight the standalone token; set it off with surrounding whitespace instead of color.
- Add splitTokenFragment helper.
* refactor(cli): polish server ready banner and rotate-token output
- move version onto the ready banner title line; drop the separate
Ready:/Version: rows and the startup-time metric
- reorder rotate-token output so the new token sits between the
invalidation note and the access links
- update server CLI tests for the new layout
* feat(server): warn on reuse and refine ready banner
- Warn when `server run` reuses an already-running daemon (its options are not applied) and show the running server's actual URLs.
- Show a `Network: off use --host 0.0.0.0 to enable` hint on loopback binds.
- Move the version onto the title line and drop the startup-time metric.
* fix(web): relabel auth dialog to token and cover full page
- Relabel the server auth dialog from "password" to "token"; the server accepts the bearer token, with the password only as a fallback.
- Make the auth dialog overlay fully opaque so it covers the whole page instead of revealing the login page underneath.
* fix: resolve CI failures on web auth PR
- Replace chalk.yellow named color with chalk.hex(darkColors.warning)
in the server reuse notice to satisfy the chalk named color guard.
- Update pnpmDeps hash in flake.nix to match the regenerated
pnpm-lock.yaml so the Nix build succeeds.
- Retry rmSync in ws-broadcast e2e teardown to ride out EBUSY /
ENOTEMPTY races while the server flushes files after close().
* test(server): update API surface snapshot for warnings route
The feat/web-auth branch adds GET /api/v1/sessions/{session_id}/warnings
(packages/server/src/routes/sessions.ts), so the API surface guardrail
snapshot needs to record the new documented v1 route.
363 lines
11 KiB
TypeScript
363 lines
11 KiB
TypeScript
/**
|
|
* `/api/v1/sessions/{sid}/fs:list` + `/api/v1/sessions/{sid}/fs:read` end-to-end
|
|
* tests (W10.1 / Chain 9 / P1.9).
|
|
*
|
|
* AC coverage (ROADMAP §Chain 9):
|
|
* 1. list in cwd → entries
|
|
* 2. read normal file
|
|
* 3. path contains `..` / absolute → 41304
|
|
* 4. read 6 MB file under 10 MB cap → ok
|
|
* read > 10 MB file → 41302
|
|
* 5. read binary file (containing null bytes) → 40907 (utf-8) /
|
|
* base64 fallback (auto)
|
|
* 6. .gitignore: node_modules is filtered out by default
|
|
* 7. session unknown → 40401
|
|
* 8. unsupported action (fs:bogus) → 40001
|
|
*/
|
|
|
|
import {
|
|
mkdirSync,
|
|
mkdtempSync,
|
|
rmSync,
|
|
writeFileSync,
|
|
} from 'node:fs';
|
|
import { tmpdir } from 'node:os';
|
|
import { join } from 'node:path';
|
|
|
|
import { pino } from 'pino';
|
|
import { afterEach, beforeEach, describe, expect, it } from 'vitest';
|
|
|
|
import { IRestGateway, startServer, type RunningServer } from '../src';
|
|
import { fixedTokenAuth } from './helpers/serverHarness';
|
|
|
|
let tmpDir: string;
|
|
let lockPath: string;
|
|
let bridgeHome: string;
|
|
let workspace: string;
|
|
let server: RunningServer | undefined;
|
|
|
|
beforeEach(() => {
|
|
tmpDir = mkdtempSync(join(tmpdir(), 'kimi-server-fs-test-'));
|
|
lockPath = join(tmpDir, 'lock');
|
|
bridgeHome = mkdtempSync(join(tmpdir(), 'kimi-server-fs-home-'));
|
|
workspace = join(tmpDir, 'workspace');
|
|
mkdirSync(workspace, { recursive: true });
|
|
});
|
|
|
|
afterEach(async () => {
|
|
try {
|
|
await server?.close();
|
|
} catch {
|
|
// ignore
|
|
}
|
|
server = undefined;
|
|
rmSync(tmpDir, { recursive: true, force: true });
|
|
rmSync(bridgeHome, { recursive: true, force: true });
|
|
});
|
|
|
|
async function bootDaemon(): Promise<RunningServer> {
|
|
server = await startServer({
|
|
serviceOverrides: [fixedTokenAuth()],
|
|
host: '127.0.0.1',
|
|
port: 0,
|
|
lockPath,
|
|
logger: pino({ level: 'silent' }),
|
|
coreProcessOptions: { homeDir: bridgeHome },
|
|
});
|
|
return server;
|
|
}
|
|
|
|
function appOf(r: RunningServer): {
|
|
inject: (req: unknown) => Promise<{
|
|
statusCode: number;
|
|
json: () => unknown;
|
|
}>;
|
|
} {
|
|
const app = r.services.invokeFunction((a) => {
|
|
const gw = a.get(IRestGateway);
|
|
return gw.app as unknown as {
|
|
inject: (req: unknown) => Promise<{
|
|
statusCode: number;
|
|
json: () => unknown;
|
|
}>;
|
|
};
|
|
});
|
|
// Auto-attach the fixed bearer token so the M5.1 auth hook passes. A
|
|
// caller-supplied `authorization` header wins, so explicit token tests keep
|
|
// working; every other header (Range, content-type, …) is preserved.
|
|
return {
|
|
inject(req: unknown) {
|
|
const q = req as { headers?: Record<string, string | string[] | undefined> };
|
|
return app.inject({
|
|
...q,
|
|
headers: { authorization: 'Bearer test-token', ...q.headers },
|
|
});
|
|
},
|
|
};
|
|
}
|
|
|
|
function envelopeOf<T>(body: unknown): {
|
|
code: number;
|
|
msg: string;
|
|
data: T | null;
|
|
request_id: string;
|
|
details?: unknown;
|
|
} {
|
|
return body as {
|
|
code: number;
|
|
msg: string;
|
|
data: T | null;
|
|
request_id: string;
|
|
details?: unknown;
|
|
};
|
|
}
|
|
|
|
async function createSession(r: RunningServer): Promise<string> {
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: '/api/v1/sessions',
|
|
payload: { metadata: { cwd: workspace } },
|
|
});
|
|
const env = envelopeOf<{ id: string }>(res.json());
|
|
if (env.code !== 0 || env.data === null) {
|
|
throw new Error(`create session failed: ${JSON.stringify(env)}`);
|
|
}
|
|
return env.data.id;
|
|
}
|
|
|
|
describe('POST /api/v1/sessions/{sid}/fs:list (W10.1)', () => {
|
|
it('lists direct children of cwd', async () => {
|
|
writeFileSync(join(workspace, 'hello.txt'), 'hi');
|
|
mkdirSync(join(workspace, 'src'));
|
|
writeFileSync(join(workspace, 'src', 'index.ts'), 'export {}');
|
|
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:list`,
|
|
payload: { path: '.' },
|
|
});
|
|
const env = envelopeOf<{
|
|
items: { name: string; kind: string }[];
|
|
truncated: boolean;
|
|
}>(res.json());
|
|
expect(env.code).toBe(0);
|
|
expect(env.data).not.toBeNull();
|
|
const names = env.data!.items.map((i) => i.name).sort();
|
|
expect(names).toEqual(['hello.txt', 'src']);
|
|
expect(env.data!.truncated).toBe(false);
|
|
});
|
|
|
|
it('rejects absolute path with 41304', async () => {
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:list`,
|
|
payload: { path: '/etc' },
|
|
});
|
|
const env = envelopeOf<unknown>(res.json());
|
|
expect(env.code).toBe(41304);
|
|
});
|
|
|
|
it('rejects ".." escape with 41304', async () => {
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:list`,
|
|
payload: { path: '../..' },
|
|
});
|
|
const env = envelopeOf<unknown>(res.json());
|
|
expect(env.code).toBe(41304);
|
|
});
|
|
|
|
it('filters .gitignore-listed paths by default (node_modules)', async () => {
|
|
writeFileSync(join(workspace, '.gitignore'), 'node_modules\n');
|
|
mkdirSync(join(workspace, 'node_modules'));
|
|
writeFileSync(join(workspace, 'node_modules', 'pkg.js'), 'x');
|
|
writeFileSync(join(workspace, 'visible.txt'), 'v');
|
|
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:list`,
|
|
payload: { path: '.' },
|
|
});
|
|
const env = envelopeOf<{ items: { name: string }[] }>(res.json());
|
|
const names = env.data!.items.map((i) => i.name);
|
|
expect(names).toContain('visible.txt');
|
|
expect(names).not.toContain('node_modules');
|
|
});
|
|
|
|
it('honors follow_gitignore=false to include gitignored entries', async () => {
|
|
writeFileSync(join(workspace, '.gitignore'), 'node_modules\n');
|
|
mkdirSync(join(workspace, 'node_modules'));
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:list`,
|
|
payload: { path: '.', follow_gitignore: false },
|
|
});
|
|
const env = envelopeOf<{ items: { name: string }[] }>(res.json());
|
|
const names = env.data!.items.map((i) => i.name);
|
|
expect(names).toContain('node_modules');
|
|
});
|
|
|
|
it('returns 40401 for unknown session', async () => {
|
|
const r = await bootDaemon();
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: '/api/v1/sessions/does-not-exist/fs:list',
|
|
payload: { path: '.' },
|
|
});
|
|
const env = envelopeOf<unknown>(res.json());
|
|
expect(env.code).toBe(40401);
|
|
});
|
|
|
|
it('returns 40001 for unsupported action fs:bogus', async () => {
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:bogus`,
|
|
payload: {},
|
|
});
|
|
const env = envelopeOf<unknown>(res.json());
|
|
expect(env.code).toBe(40001);
|
|
});
|
|
});
|
|
|
|
describe('POST /api/v1/sessions/{sid}/fs:read (W10.1)', () => {
|
|
it('reads a normal utf-8 text file', async () => {
|
|
writeFileSync(join(workspace, 'hello.txt'), 'hello world');
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:read`,
|
|
payload: { path: 'hello.txt' },
|
|
});
|
|
const env = envelopeOf<{
|
|
content: string;
|
|
encoding: 'utf-8' | 'base64';
|
|
is_binary: boolean;
|
|
size: number;
|
|
mime: string;
|
|
}>(res.json());
|
|
expect(env.code).toBe(0);
|
|
expect(env.data).not.toBeNull();
|
|
expect(env.data!.content).toBe('hello world');
|
|
expect(env.data!.encoding).toBe('utf-8');
|
|
expect(env.data!.is_binary).toBe(false);
|
|
expect(env.data!.size).toBe(11);
|
|
});
|
|
|
|
it('rejects absolute path with 41304', async () => {
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:read`,
|
|
payload: { path: '/etc/passwd' },
|
|
});
|
|
const env = envelopeOf<unknown>(res.json());
|
|
expect(env.code).toBe(41304);
|
|
});
|
|
|
|
it('returns 40409 for a missing file', async () => {
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:read`,
|
|
payload: { path: 'no-such-file.txt' },
|
|
});
|
|
const env = envelopeOf<unknown>(res.json());
|
|
expect(env.code).toBe(40409);
|
|
});
|
|
|
|
it('returns 40906 when path is a directory', async () => {
|
|
mkdirSync(join(workspace, 'a-dir'));
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:read`,
|
|
payload: { path: 'a-dir' },
|
|
});
|
|
const env = envelopeOf<unknown>(res.json());
|
|
expect(env.code).toBe(40906);
|
|
});
|
|
|
|
it('returns 41302 when file size > 10 MB', async () => {
|
|
// 10 MB + 1 byte: exactly trips the > 10 MB check.
|
|
const huge = Buffer.alloc(10 * 1024 * 1024 + 1, 0x41);
|
|
writeFileSync(join(workspace, 'huge.txt'), huge);
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:read`,
|
|
payload: { path: 'huge.txt' },
|
|
});
|
|
const env = envelopeOf<unknown>(res.json());
|
|
expect(env.code).toBe(41302);
|
|
});
|
|
|
|
it('returns 40907 for binary file when encoding is utf-8', async () => {
|
|
// 32 bytes of \x00 \x01 \x02 ... — null byte trips the heuristic.
|
|
const bin = Buffer.from([
|
|
0, 1, 2, 3, 4, 5, 6, 7, 8, 9, 10, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20,
|
|
21, 22, 23, 24, 25, 26, 27, 28, 29, 30, 31,
|
|
]);
|
|
writeFileSync(join(workspace, 'bin'), bin);
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:read`,
|
|
payload: { path: 'bin', encoding: 'utf-8' },
|
|
});
|
|
const env = envelopeOf<unknown>(res.json());
|
|
expect(env.code).toBe(40907);
|
|
});
|
|
|
|
it('falls back to base64 for binary file when encoding is auto', async () => {
|
|
const bin = Buffer.from([0, 1, 2, 3, 0xfe, 0xff]);
|
|
writeFileSync(join(workspace, 'bin'), bin);
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:read`,
|
|
payload: { path: 'bin' },
|
|
});
|
|
const env = envelopeOf<{
|
|
content: string;
|
|
encoding: 'utf-8' | 'base64';
|
|
is_binary: boolean;
|
|
}>(res.json());
|
|
expect(env.code).toBe(0);
|
|
expect(env.data!.encoding).toBe('base64');
|
|
expect(env.data!.is_binary).toBe(true);
|
|
// base64 round-trips back to the original bytes.
|
|
expect(Buffer.from(env.data!.content, 'base64').equals(bin)).toBe(true);
|
|
});
|
|
|
|
it('rejects 11 MB length request via Zod (>10 MB cap)', async () => {
|
|
writeFileSync(join(workspace, 'small.txt'), 'x');
|
|
const r = await bootDaemon();
|
|
const sid = await createSession(r);
|
|
const res = await appOf(r).inject({
|
|
method: 'POST',
|
|
url: `/api/v1/sessions/${sid}/fs:read`,
|
|
payload: { path: 'small.txt', length: 11 * 1024 * 1024 },
|
|
});
|
|
const env = envelopeOf<unknown>(res.json());
|
|
expect(env.code).toBe(40001);
|
|
});
|
|
});
|