kimi-code/packages/acp-adapter/test/config-options.test.ts
liruifengv 108299be3c
refactor!: overhaul thinking config and effort resolution (#1132)
* feat: support multi-level thinking effort switching

- kimi provider: emit thinking.effort in the new wire format; keep reasoning_effort mirrored during the transition
- model catalog: thread support_efforts / default_effort from oauth through to /models
- config schema: add supportEfforts / defaultEffort on model aliases
- TUI: multi-segment thinking control in /model, new /effort command, footer effort display
- switch status uses displayName and distinguishes model vs effort-only changes

* docs: add thinking effort design plans

- thinking-effort-switching.md: implemented multi-level effort switching
- thinking-model-overhaul.md: follow-up refactor plan for the thinking state model

* docs: collapse thinking overhaul plan into a single PR

* refactor!: overhaul thinking config and effort resolution

Replace default_thinking and thinking.mode with a single [thinking] enabled/effort table. ThinkingEffort is now an open string ('off' | 'on' | model-declared effort); effort levels come from each model's support_efforts instead of a fixed enum.

Centralize default and always_thinking clamp logic in resolveThinkingEffort/defaultThinkingEffortFor, and honor an explicitly configured effort when an always_thinking model is forced back on.

TUI keeps a single thinkingEffort field instead of the boolean + level pair; 'on' is normalized to the model default at the UI boundary.

BREAKING CHANGE: default_thinking and thinking.mode are removed from config; migrate to [thinking] enabled/effort.

* refactor: rename residual thinking level wording to effort

Rename comments, error messages, parameter names, the SetThinkingPayload wire field (level -> effort), and TUI local variables so the thinking effort naming is consistent throughout. No behavior change.

* refactor: rename remaining camelCase thinking level identifiers to effort

Rename liveLevel/prevLevel/levelChanged/commitLevel/effectiveLevel to liveEffort/prevEffort/effortChanged/commitEffort/effectiveEffort in the TUI model picker and config commands.

* refactor: eliminate remaining thinking level wording in comments and tests

Rename levelLabel -> effortLabel, EffortSelectorOptions.levels -> efforts, and 'effort level(s)' / 'default level' / 'requested level' wording in comments, error messages, slash-command description, and test titles to effort. Also restore the withThinking(effort) parameter rename in the Kimi provider that was accidentally reverted.

* fix: address codex review feedback on thinking effort handling

- OpenAI thinkingEffortToReasoningEffort and Anthropic clampEffort now normalize 'on' / unrecognized efforts instead of throwing, so boolean non-Kimi models no longer crash on session start.

- ACP resolveCurrentThinkingEnabled treats a non-empty thinking.effort as enabled, matching agent-core's resolveThinkingEffort.

- REST promptThinkingSchema accepts any non-empty effort string so model-declared efforts are not rejected at the API boundary.

* test: align kimi e2e expectations with supportEfforts-gated reasoning_effort

The kimi provider now sends reasoning_effort only when the model declares support_efforts; boolean models (no support_efforts) send only thinking.type. Update the kimi e2e tests to drop the stale reasoning_effort expectation for the boolean test model.

* test: cover [thinking] effort parsing in config.test

Add effort = "high" to the documented [thinking] table in the config parse test and assert config.thinking.effort is resolved, so the new [thinking] effort field has direct parse coverage.

* docs: add thinking test coverage gap analysis

Capture the explore agent's test coverage review for the thinking overhaul PR, including P1/P2 gaps and the two open design questions, for follow-up test additions.

* feat(oauth): parse nested think_efforts from /models response

The /models endpoint now returns effort levels under a nested think_efforts object ({ support, valid_efforts, default_effort }). Parse it preferentially in both managed-kimi-code and open-platform model parsing, falling back to the legacy flat support_efforts / default_effort fields for older servers.

* refactor(oauth): only read nested think_efforts; gate on support=true

Drop the legacy flat support_efforts / default_effort fallback. The think_efforts object is now the single source, and its support flag gates the whole object — when support is not true, valid_efforts and default_effort are ignored entirely.

* chore: remove unused parseStringArray import in open-platform

* docs: finalize thinking effort release notes

Downgrade the changeset to minor with an English summary, drop the version-specific 'added in 1.0.0' info block, and present the deprecated config fields as a table (field / deprecated in 0.21.0 / description).

* refactor: drop temporary refresh toggles and kimi reasoning_effort mirror

Remove the always-true REFRESH_MODELS_ON_PICKER_OPEN / REFRESH_PROVIDER_MODELS_ON_STARTUP toggles and their stale re-enable TODOs, and stop sending reasoning_effort from the kimi provider (thinking.effort is the only wire field now).

* fix(tui): avoid persisting "on" as thinking effort

* fix: preserve persisted thinking effort across login and provider setup

* fix(tui): show actual thinking effort in /status and footer

* test(tui): align message-flow expectations with effort persistence and /status display

* fix(vis): rename thinkingLevel to thinkingEffort in config.update analysis
2026-06-30 22:34:13 +08:00

219 lines
9.2 KiB
TypeScript

import { describe, expect, it, vi } from 'vitest';
import type { KimiHarness } from '@moonshot-ai/kimi-code-sdk';
import {
buildModelOption,
buildModeOption,
buildSessionConfigOptions,
buildThinkingOption,
} from '../src/config-options';
import type { AcpModelEntry } from '../src/model-catalog';
function makeHarnessWithModels(
entries: ReadonlyArray<{ id: string; model?: string; displayName?: string; capabilities?: readonly string[] }>,
): { harness: KimiHarness; getConfig: ReturnType<typeof vi.fn> } {
// Mirror the `listAvailableModels` derivation: `id` is the config map
// key, `model` defaults to id, `displayName` to model. The test fixtures
// below pick names that exercise the three thinkingSupported triggers
// (name regex, capabilities array, toggleable allow-list).
const models: Record<string, { model: string; displayName?: string; capabilities?: readonly string[] }> = {};
for (const entry of entries) {
models[entry.id] = {
model: entry.model ?? entry.id,
...(entry.displayName !== undefined ? { displayName: entry.displayName } : {}),
...(entry.capabilities !== undefined ? { capabilities: entry.capabilities } : {}),
};
}
const getConfig = vi.fn(async () => ({ models }));
return { harness: { getConfig } as unknown as KimiHarness, getConfig };
}
describe('buildModelOption', () => {
it('emits exactly one option per catalog row (Phase 15: no inlined `,thinking` variant rows)', () => {
const models: readonly AcpModelEntry[] = [
{ id: 'alpha', name: 'Alpha', thinkingSupported: true, defaultThinkingEffort: 'on' },
{ id: 'beta', name: 'Beta', thinkingSupported: false, defaultThinkingEffort: 'on' },
];
const option = buildModelOption(models, 'alpha');
expect(option.id).toBe('model');
expect(option.category).toBe('model');
expect(option.name).toBe('Model');
if (option.type !== 'select') {
throw new Error('expected a SessionConfigSelect option');
}
expect(option.currentValue).toBe('alpha');
expect(option.options).toHaveLength(2);
const projected = option.options.map((entry) =>
'value' in entry ? { value: entry.value, name: entry.name } : null,
);
expect(projected).toEqual([
{ value: 'alpha', name: 'Alpha' },
{ value: 'beta', name: 'Beta' },
]);
});
it('treats `currentValue` as the bare base model id — Phase 15 keeps the snapshot suffix-free', () => {
const models: readonly AcpModelEntry[] = [
{ id: 'kimi-v2', name: 'Kimi v2', thinkingSupported: true, defaultThinkingEffort: 'on' },
];
const option = buildModelOption(models, 'kimi-v2');
if (option.type !== 'select') {
throw new Error('expected a SessionConfigSelect option');
}
expect(option.currentValue).toBe('kimi-v2');
expect(option.options.map((o) => ('value' in o ? o.value : ''))).toEqual(['kimi-v2']);
});
it('handles an empty catalog without emitting any options', () => {
const option = buildModelOption([], '');
if (option.type !== 'select') {
throw new Error('expected a SessionConfigSelect option');
}
expect(option.options).toHaveLength(0);
expect(option.currentValue).toBe('');
});
});
describe('buildThinkingOption', () => {
it('produces a `type:"select"` `category:"thought_level"` option with `off`/`on` entries carrying the toggle value', () => {
const on = buildThinkingOption(true);
expect(on.type).toBe('select');
expect(on.id).toBe('thinking');
expect(on.category).toBe('thought_level');
expect(on.name).toBe('Thinking');
if (on.type !== 'select') throw new Error('expected SessionConfigSelect');
expect(on.currentValue).toBe('on');
expect(on.options.map((o) => ('value' in o ? o.value : ''))).toEqual(['off', 'on']);
expect(on.options.map((o) => ('name' in o ? o.name : ''))).toEqual(['Thinking Off', 'Thinking On']);
const off = buildThinkingOption(false);
if (off.type !== 'select') throw new Error('expected SessionConfigSelect');
expect(off.currentValue).toBe('off');
});
it('collapses to a single locked "on" entry for always-thinking models', () => {
const locked = buildThinkingOption(true, true);
if (locked.type !== 'select') throw new Error('expected SessionConfigSelect');
expect(locked.currentValue).toBe('on');
expect(locked.options.map((o) => ('value' in o ? o.value : ''))).toEqual(['on']);
expect(locked.options.map((o) => ('name' in o ? o.name : ''))).toEqual(['Thinking On']);
});
});
describe('buildModeOption', () => {
it('returns the locked 4-mode taxonomy in order (default → plan → auto → yolo) with description carried through', () => {
const option = buildModeOption('plan');
expect(option.id).toBe('mode');
expect(option.category).toBe('mode');
expect(option.name).toBe('Mode');
if (option.type !== 'select') {
throw new Error('expected a SessionConfigSelect option');
}
expect(option.currentValue).toBe('plan');
expect(option.options).toHaveLength(4);
const ids = option.options.map((o) => ('value' in o ? o.value : ''));
expect(ids).toEqual(['default', 'plan', 'auto', 'yolo']);
for (const entry of option.options) {
if ('value' in entry) {
expect(typeof entry.name).toBe('string');
expect(entry.name.length).toBeGreaterThan(0);
expect(typeof entry.description).toBe('string');
expect((entry.description ?? '').length).toBeGreaterThan(0);
}
}
});
});
describe('buildSessionConfigOptions', () => {
it('composes [model, thinking, mode] when current model supports thinking and calls getConfig exactly once', async () => {
// `kimi-for-coding` is on the toggleable allow-list so its derived
// thinkingSupported is true even without explicit capabilities.
const { harness, getConfig } = makeHarnessWithModels([
{ id: 'kimi-coder', model: 'kimi-for-coding', displayName: 'Kimi Coder' },
]);
const result = await buildSessionConfigOptions(harness, 'kimi-coder', false, 'default');
expect(getConfig).toHaveBeenCalledTimes(1);
expect(result).toHaveLength(3);
expect(result.map((o) => o.id)).toEqual(['model', 'thinking', 'mode']);
if (result[0]!.type === 'select') {
expect(result[0]!.currentValue).toBe('kimi-coder');
}
if (result[1]!.type === 'select' && result[1]!.id === 'thinking') {
expect(result[1]!.currentValue).toBe('off');
expect(result[1]!.category).toBe('thought_level');
} else {
throw new Error('expected thinking select at index 1');
}
if (result[2]!.type === 'select') {
expect(result[2]!.currentValue).toBe('default');
}
});
it('omits the thinking toggle when current model is non-thinking-supported', async () => {
const { harness } = makeHarnessWithModels([
{ id: 'kimi-coder', model: 'kimi-for-coding', displayName: 'Kimi Coder' },
{ id: 'kimi-plain', model: 'qwen-2.5-coder', displayName: 'Kimi Plain' },
]);
const result = await buildSessionConfigOptions(harness, 'kimi-plain', false, 'default');
expect(result.map((o) => o.id)).toEqual(['model', 'mode']);
});
it('reflects the thinking toggle currentValue from the explicit argument', async () => {
const { harness } = makeHarnessWithModels([
{ id: 'kimi-coder', model: 'kimi-for-coding', displayName: 'Kimi Coder' },
]);
const result = await buildSessionConfigOptions(harness, 'kimi-coder', true, 'default');
const toggle = result.find((o) => o.id === 'thinking');
if (!toggle || toggle.type !== 'select') throw new Error('expected thinking select toggle');
expect(toggle.currentValue).toBe('on');
});
it('locks the thinking toggle to on for always-thinking models even when the session state says off', async () => {
const { harness } = makeHarnessWithModels([
{
id: 'kimi-deep',
model: 'kimi-deep-coder',
displayName: 'Kimi Deep',
capabilities: ['thinking', 'always_thinking'],
},
]);
const result = await buildSessionConfigOptions(harness, 'kimi-deep', false, 'default');
const toggle = result.find((o) => o.id === 'thinking');
if (!toggle || toggle.type !== 'select') throw new Error('expected thinking select toggle');
expect(toggle.currentValue).toBe('on');
expect(toggle.options.map((o) => ('value' in o ? o.value : ''))).toEqual(['on']);
});
it('omits the thinking toggle when the current base model id is not in the catalog (defensive)', async () => {
const { harness } = makeHarnessWithModels([
{ id: 'kimi-coder', model: 'kimi-for-coding', displayName: 'Kimi Coder' },
]);
const result = await buildSessionConfigOptions(harness, 'unknown-model', true, 'default');
expect(result.map((o) => o.id)).toEqual(['model', 'mode']);
});
it('handles missing getConfig (partial-stub harness) by suppressing the toggle and shipping an empty model picker', async () => {
const harness = {} as unknown as KimiHarness;
const result = await buildSessionConfigOptions(harness, '', false, 'default');
expect(result.map((o) => o.id)).toEqual(['model', 'mode']);
const modelOpt = result.find((o) => o.id === 'model');
if (!modelOpt || modelOpt.type !== 'select') throw new Error('expected select');
expect(modelOpt.options).toHaveLength(0);
});
});